8e6e7976d2
fix: psalm
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-02 10:19:25 +07:00
388f2973b9
fix: psalm
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-02 10:08:08 +07:00
dfcf3132dd
chore(db): Make the query more simpler to read
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-02 09:57:48 +07:00
deeccd12a3
chore: fix typo in `SameSiteCookieMiddleware`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-31 00:34:45 +07:00
92f3f7e2d2
chore: Remove unused `CsrfTokenManager` from `CSPMiddleware`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-31 00:34:41 +07:00
c3fa25a16e
fix: Run migration sql as statement so that the primary db node is used
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-30 15:45:50 +07:00
95006d2b8e
Revert "fix(TaskProcessing): Use OCP\Server::get instead of copying methods"
...
This reverts commit d624c8da8f
2024-08-30 10:07:01 +07:00
1e896a7307
fix(TextProcessing): Don't run taskProcessing if task type is not available
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
de117d4654
fix(SpeechToTextManager): Throw TaskProcessing Task failed
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
7be3a18f13
fix(TaskProcessing): Use OCP\Server::get instead of copying methods
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
04edeb510d
feat(speech-to-text): SpeechToTextManager::transcribeFile calls TaskProcessingManager::runTask
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
5ab0866341
feat(textprocessing): TextProcessingManager::runTask calls TaskProcessingManager::runTask
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
bfb5835750
Merge pull request #47546 from nextcloud/fix/files-view-error-messages
...
fix: Adjust filename validation messages
2024-08-29 23:28:50 +07:00
edaa4d1432
fix(DB): do not assume sharding is always enabled
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-08-29 19:55:10 +07:00
381e922085
fix(DB): set sharding parameters only when intended
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-08-29 19:12:44 +07:00
1f46be7d69
fix(Image): Do not send empty Content-Type header
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +07:00
b778f3de0a
fix(\OC\Image): Use new IAppConfig and type safe methods
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +07:00
c67e54287a
fix(OC\Image): Fix all psalm spotted issues in the file
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +07:00
e8c671fa8b
fix: Remove all references to OC_Image
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +07:00
47d2cb7479
fix: Move \OC_Image to \OC\Image with the other internal classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +07:00
6d04ad829b
Merge pull request #47581 from nextcloud/fix/audit-new-node
...
fix: Do not fail to get internal path on NonExistingFile
2024-08-29 15:43:21 +07:00
fef4295ef7
Merge pull request #47567 from nextcloud/jtr/fix-opcache-restricted-env
...
fix(config): Avoid error messages for restricted opcache API
2024-08-29 08:46:41 +07:00
61108882b9
fix: Do not fail to get internal path on NonExistingFile/NonExistingFolder
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-29 12:43:44 +07:00
d404998157
Merge pull request #47515 from nextcloud/bugfix/noid/fix-migration-sorting
...
fix(migration): Correctly sort migrations by version number
2024-08-28 20:46:24 +07:00
17f011f7c5
fix: Also validate parent path in `verifyPath`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 17:22:20 +07:00
08836696e2
fix: Allow read-only filename validation to allow reading files
...
Needed to read files with the "Windows compatibility" feature.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 17:22:20 +07:00
030c209d22
fix: Renaming does not need update but delete permissions
...
Renaming is basically copy + delete (a move), so no need to update permissions.
Especially if the node is in a invalid directory the node should be moveable but not editable.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 17:22:20 +07:00
3e434bcebf
fix(config): Avoid error messages for restricted opcache API
...
Make changes recently added via #44230 match #8188 to avoid failures in restricted hosting environments.
Fixes #47562
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-08-28 08:20:25 +07:00
2574cbfa61
chore: Apply php:cs recommendations
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-28 10:44:18 +07:00
9d0248545d
fix: mark systemconfig value as not being tainted because they are implicitly trusted
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:27:14 +07:00
b21a399d1a
fix: implement sharding compatible cleanup for various bits
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:27:14 +07:00
cc091b150e
fix: fix share cleanup for deleted groups with sharding
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:20 +07:00
2eaeeeeafe
fix: run mimetype repair query across all shards
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:19 +07:00
390f6a78b4
fix: hint storage id in more places
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:19 +07:00
fc05a67f19
fix: only allow pre-defined shards
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:19 +07:00
62f8b6517f
feat: implement distributing partitioned queries over multiple shards
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:19 +07:00
f5b3486744
feat: add option to automatically partition queries by specific tables
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:18:53 +07:00
c58bdbf378
fix: delay calculating global cache prefix untill a cache is created
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:18:52 +07:00
114db0558c
fix: don't make ICacheFactory depend on database
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:18:52 +07:00
c09ec95255
feat: track expected output columns in query builder
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:18:52 +07:00
81c6c24cd5
fix: Adjust filename validation messages
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-27 23:12:24 +07:00
e68f77ea6c
Merge pull request #47521 from nextcloud/fix/noid/loosing-systemconfig-on-setup
...
fix(logger): ignore session logging during setup
2024-08-27 18:10:16 +07:00
558877c842
Merge pull request #47522 from nextcloud/enh/noid/taskprocessing-runtask
...
[TaskProcessing] Add manager::runTask method
2024-08-27 17:53:20 +07:00
46c853146b
fix(migration): Correctly sort migrations by version number
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-08-27 16:25:10 +07:00
11822def85
Merge pull request #47509 from nextcloud/fix/exif-orientation-type
...
fix: gracefully handle unexpected exif orientation types
2024-08-27 15:59:14 +07:00
9100b8757e
fix(setup): ignore long session login during installation
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-08-27 12:29:42 +07:00
396b8f52f1
fix(taskprocessing): fix condition to reschedule SynchronousBackgroundJob
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-27 14:59:20 +07:00
c1ed256d50
feat(taskprocessing): add IManager::runTask method to run task synchronously
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-27 13:11:51 +07:00
829642c9e5
Merge pull request #47508 from nextcloud/fix/router/attribute-routes-all-apps
2024-08-27 12:48:50 +07:00
12b44844e1
fix(Router): Load attribute routes of all apps when not app is specified
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-08-27 10:42:47 +07:00
bdcfe5b8a9
fix(db): Increase log level for very slow transactions
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-08-27 10:12:14 +07:00
cd928ed4ed
fix: gracefully handle unexpected exif orientation types
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-08-27 09:32:04 +07:00
6d2253e692
Merge pull request #46013 from nextcloud/obj-store-move-from-storage-preserve-fileid
...
fix: write object to the correct urn when moving from another storage to object store
2024-08-26 13:47:27 +07:00
36f272d03b
Merge pull request #47435 from phreaker0/fix-mail-template-class-call
...
fix(mailer): Call to custom mail_template_class
2024-08-26 08:58:00 +07:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +07:00
4a3ade5d43
Merge pull request #46021 from nextcloud/middleware-delay-admin
...
perf: delay getting (sub)admin status for user in the security middleware untill we need it
2024-08-23 17:38:01 +07:00
8b60df1600
perf: delay getting (sub)admin status for user in the security middleware untill we need it
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-23 15:26:40 +07:00
bd740ac0b0
fix: write object to the correct urn when moving from another storage to object store
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-23 15:22:16 +07:00
658d2f7ea1
feat: expose escapeLikeParameter trough query builder
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-23 15:12:10 +07:00
ae787c5ef2
fix call to custom mail_template_class
...
Signed-off-by: Christoph Klaffl <christoph@phreaker.eu>
2024-08-22 19:39:23 +07:00
ebfbe99652
fix(files): Create non-existent parents of mountpoints
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-08-22 12:04:31 +07:00
c3ad469750
Merge pull request #47259 from nextcloud/memcache-ncad
...
feat: add negative compare-and-delete to imemcache
2024-08-21 17:19:04 +07:00
1992a6d72b
Merge pull request #47371 from nextcloud/fix/disable-auto-zoom-ios
...
fix: Disable auto-zoom on iOS
2024-08-21 14:32:16 +07:00
d5140fe034
Merge pull request #47372 from nextcloud/fix/filename-validator
...
fix: `FilenameValidator::isForbidden` should only check forbidden files
2024-08-21 13:07:33 +07:00
c82b17d0a3
fix: Support Safari mobile
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-21 13:01:23 +07:00
ec00367f30
fix: Disable auto-zoom on iOS
...
When using iOS and focussing an input element the view should not be zoomed.
So if we set a maximum scale iOS will not auto-zoom but still allow users to zoom.
But we can not do this by default as this will disable user zoom on Chrome.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-21 13:01:18 +07:00
dbbe2bbcb7
fix(theming): Make getImage() call save against missing non-SVG version
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-08-21 10:30:25 +07:00
b9cc7bcec7
fix: `FilenameValidator::isForbidden` should only check forbidden files
...
And not forbidden basenames as this is used for different purposes.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-21 04:16:14 +07:00
20dbb6c7e8
feat: add negative compare-and-delete to imemcache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-20 19:34:28 +07:00
3756152cb1
fix: use mountpoint from storage to find the encryption keys
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-20 13:32:03 +07:00
1071201052
feat: store the mountpoint of storages in the mount options
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-20 13:31:35 +07:00
c2e1c9f8dc
fix: Prevent crash when refreshing metadata for files without an owner
...
This crash was mostly happening when using external storages and for example the command "occ memories:migrate-google-takeout"
Signed-off-by: Vincent FarZz <farcry69@live.fr>
2024-08-18 20:03:32 +07:00
2ec68b1eb9
refactor(Log): Use new in initializer instead of constructor body
...
PHP 8.1 allows us to now move the `new` into the initializer,
this makes the code a bit nicer (and 3 lines shorter).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-17 18:38:28 +07:00
a92171260f
fix: check for correct storage class when checking for link parent
...
fixes #39123
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-16 13:13:31 +07:00
13a72d0f0e
Merge pull request #38750 from whlsxl/postgres-install-error
2024-08-16 12:58:58 +07:00
67c52d202c
fix: use `$this->tryCreateDbUser` condition
2024-08-16 10:59:15 +07:00
f490a4e8c0
fix: postgresql GRANT user's permission after createDatabase, ensure database exist when GRANT
2024-08-16 10:57:11 +07:00
d35c4eb911
Merge branch 'master' into jr-readdir-false-false
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-08-16 10:53:50 +07:00
9189bc290b
feat(webauthn): Add user verification to webauthn challenges
...
Require user verification if all tokens are registered
with UV flag, else discourage it
Signed-off-by: S1m <git@sgougeon.fr>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-08-15 11:03:10 +07:00
7641e768b3
Merge pull request #45435 from nextcloud/feat/dav/upcoming-events-api
...
feat(dav): Add an API for upcoming events
2024-08-14 06:54:43 +07:00
370a9d77ea
feat(dav): Add an API for upcoming events
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-08-13 20:03:31 +07:00
3e409fd342
Merge pull request #43573 from nextcloud/HolgerHees-fix-csp-nonce-handling
...
Fix for ignored `CSP_NONCE` in ContentSecurity Header
2024-08-13 17:53:30 +07:00
5100e3152d
feat(auth): Clean-up unused auth tokens and wipe tokens
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-08-13 12:39:11 +07:00
142b6e313f
Merge pull request #47180 from nextcloud/fix/apply-group-limit-on-remove-from-group
...
Apply group limit on remove from group
2024-08-13 12:20:48 +07:00
2916e5df7e
feat: Provide CSP nonce as `<meta>` element
...
This way we use the CSP nonce for dynamically loaded scripts.
Important to notice: The CSP nonce must NOT be injected in `content` as
this can lead to value exfiltration using e.g. side-channel attacts (CSS selectors).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-13 10:32:44 +07:00
86f01a3358
fix: Make sure CSP nonce is not double base64 encoded
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-13 09:52:33 +07:00
73397cd759
fix: Use `CSP_NONCE` env variable in ContentSecurity Header
...
We should use 'cspNonceManager' for requesting the NONCE value, because it is doing the same as before, except that it honors a CPS_NONCE environment variable if available.
Signed-off-by: Holger Hees <holger.hees@gmail.com>
2024-08-13 09:52:08 +07:00
e23325f047
fix: Remove shares only if there are no more common groups between users
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-12 15:20:21 +07:00
5559beb28c
fix(files_sharing): Delete user shares if needed when user is removed from a group
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-12 14:41:19 +07:00
dbab2a825d
fix(taskprocessing): select preferred provider when running sync task, fix task type values according to preferred provider
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-12 13:11:41 +07:00
2156a927a3
fix: lint
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-08-09 22:47:32 +07:00
c6be80a75d
fix(jobs): Swicth to executeStatement() while deleting rows
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-08-09 22:38:33 +07:00
0563757ea4
fix(SetupCheck): Properly check public access to data directory
...
When checking for public (web) access to the data directory the status is not enough
as you might have a webserver that forwards to e.g. a login page.
So instead check that the content of the file matches.
For this the `.ncdata` file (renamed from `.ocdata`¹) has minimal text content
to allow checking.
¹The file was renamed from the legacy `.ocdata`, there is a repair step to remove the old one.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 22:08:42 +07:00
609fa7d5db
Merge pull request #47044 from nextcloud/fix/accept-several-mounts-in-encryption
...
fix(encryption): Fix mountpoint check to accept if several are found
2024-08-07 20:58:19 +07:00
495f454b6f
Merge pull request #46395 from nextcloud/apcu-default-ttl
...
fix: set default TTL for APCu cache as per docs
2024-08-07 20:16:02 +07:00
cae0a8218d
chore: remove Redis::DEFAULT_TTL constant now that it's defined in the interface
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-07 19:41:44 +07:00
b19652a2ad
chore: cleanup acpu inc and dec
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-07 19:41:43 +07:00
cd9cc01b77
fix: set default TTL for APCu cache as per docs
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-07 19:41:41 +07:00
3ffcfb1dab
Merge pull request #47069 from nextcloud/fix/noid/display-message-on-no-migration-attributes
...
fix(migration-preview): display a message if no attributes set
2024-08-07 11:48:20 +07:00
2b38d6ae7e
fix(session): Log when session_* calls are slow
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-08-07 09:02:10 +07:00
6ad6fa6425
fix(migration-preview): display a message if no attributes set
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-08-06 22:23:12 +07:00
8a5bc4778b
Merge pull request #38364 from joshtrichards/jr-preview-libgd-webp-animation-bypass
2024-08-06 17:56:14 +07:00
2d8676fa5d
Merge pull request #47065 from nextcloud/fix/group-oc
2024-08-06 17:52:01 +07:00
42650f6773
Merge pull request #46967 from nextcloud/fix/share-not-found
2024-08-06 17:45:44 +07:00
e6457aa9c4
Merge pull request #46985 from nextcloud/feat/email-share-format
2024-08-06 17:40:47 +07:00
db28aa8cd1
fix(files_sharing): show proper share not found error message
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-06 16:25:10 +07:00
4776b6600a
fix: Ensure database connection is setup when getting group details
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-06 13:41:04 +07:00
c221090c86
fix: unify bundle naming
...
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-08-06 11:14:07 +07:00
eecc9f328b
Merge pull request #46953 from nextcloud/cleanup-old-mount-repair
...
chore: delete repair step for 8y old oc_mounts issue
2024-08-06 09:42:20 +07:00
28a34e7351
fix(emails): adjust mail button to new design
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-06 09:42:19 +07:00
9ef2e142c4
Merge pull request #46931 from nextcloud/connection-builder-additional-params
...
fix: fix passing additional db connection parameters in factory
2024-08-05 17:41:04 +07:00
277c2cf5d1
fix(encryption): Fix mountpoint check to accept if several are found
...
There is no strong requirement to have only one mount for a given
storage id. Also the error in this case would be misleading.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-05 17:34:25 +07:00
eb4fb994cf
fix: ensure array returned from getMountsForFileId is continious
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-02 17:22:33 +07:00
9af6184af6
chore: delete repair step for 8y old oc_mounts issue
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-02 17:21:54 +07:00
572361f498
fix(files): Fix incorrect keys by reindexing
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-08-01 09:14:44 +07:00
abd7514c5e
Merge pull request #46864 from nextcloud/fix/dont-persist-blurhash-preview-2
...
fix: don't persist previews used during blurhash generation - take 2
2024-08-01 16:17:10 +07:00
014fcb0131
Merge pull request #45950 from nextcloud/chore/remove-depreacted-search
...
chore: Remove deprecated legacy search backend
2024-08-01 13:56:09 +07:00
a6d421e767
chore: Remove deprecated legacy search backend
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-01 12:33:18 +07:00
80231e60aa
fix(activity): regroup Files and spltit sharing activity
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-01 11:03:24 +07:00
c4227ef448
Merge pull request #46912 from nextcloud/fix/taskprocessing-speech-to-text-legacy
...
More fixes for task processing
2024-08-01 09:04:15 +07:00
5d98b647d6
Merge pull request #46872 from nextcloud/fix/taskprocessing/dont-break-with-provider-errors
...
fix(TaskProcessing): Don't break if provider methods throw
2024-08-01 09:02:26 +07:00
5654799cb4
fix: fix passing additional db connection parameters in factory
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-31 18:53:42 +07:00
5e4200853f
fix(TaskProcessing): Legacy Speech To Text support needs UserId
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-31 12:43:05 +07:00
cef675358b
Merge pull request #46099 from nextcloud/fix/properly-add-accept-share-interface
...
fix: Add `acceptShare` as an interface
2024-07-30 18:35:16 +07:00
18c0bcb2da
Merge pull request #46476 from nextcloud/enh/noid/migration-attributes
...
Migration Attributes
2024-07-30 15:54:56 +07:00
3d136e4466
fix: Add `acceptShare` as an interface
...
It was commented out because at that time no other share provider
supported the `acceptShare` method. Today it is the same no other provider
supports it, but we should make it discoverable by adding it to the public API
as an additional interface.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-30 15:25:51 +07:00
1205379f5a
fix(TaskProcessing): Don't break if provider methods throw
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-30 13:25:39 +07:00
710a69b4b5
feat(log): Allow to combine log.conditions to only log (app&user)
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-30 13:18:09 +07:00
21f558b12b
Merge pull request #46379 from nextcloud/fix/folder-search-owner
...
fix: `OCP\Files\Node\Folder::search` was not setting the owner
2024-07-30 13:04:15 +07:00
08c785ff46
fix: don't persist previews used during blurhash generation
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-07-30 09:09:26 +07:00
ad490c963b
feat(migration-attributes): tests
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-07-29 12:44:52 +07:00
7c1ee524be
fix(migration-attributes): privatizing AttributeException
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-07-29 12:44:52 +07:00
79e6014879
feat(upgrade): release metadata
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-07-29 12:44:52 +07:00
dd08f93202
chore: fix some comments
...
Signed-off-by: withbest <seekseat@outlook.com>
2024-07-29 14:43:27 +07:00
181aecad4c
fix: Release directory iterator and thereby its potential directory lock prior to deleting a directory, to avoid e.g. "Text file busy" error with VirtualBox shared folder storage
...
Signed-off-by: Dennis Verspuij <6680484+dennisverspuij@users.noreply.github.com>
2024-07-27 16:37:16 +07:00
0ae83d6183
Merge pull request #46760 from nextcloud/fix/appframework/csrf-custom-header
2024-07-27 16:27:52 +07:00
813264c15d
Merge pull request #46508 from nextcloud/ernolf/enh/imaginary-pdf-handling
...
feat(preview): introducing new class ImaginaryPDF
2024-07-25 23:17:58 +07:00
4f2a29adf9
Merge pull request #46672 from nextcloud/fix/preview-invalid-id
...
Avoid using partial file info as valid one
2024-07-25 19:37:30 +07:00
9d1705259c
fix(AppFramework): Allow requests with OCS-APIRequest header to pass CSRF checks
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-25 17:31:49 +07:00
a8bdd4f99b
feat(preview): move previews for imaginary pdf to own class ImaginaryPDF
...
Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-07-25 17:01:01 +07:00
3d7d0b6088
Merge pull request #46383 from nextcloud/feat/template-fields
...
feat: Template field workflow
2024-07-25 14:19:49 +07:00
9a3a27f856
fix(taskprocessing): add missing translate default task type
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-07-25 12:09:47 +07:00
efe03ee690
feat: Add support for filling fields to backend components
...
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-25 11:11:40 +07:00
05ed5aa230
fix: Emit new `BeforeGetTemplates` event
...
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2024-07-25 11:11:38 +07:00
46c518f712
fix: Don't validate input again upon running a task
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-25 10:27:45 +07:00
aaa8af4b49
fix: Make sure provider provides enum values
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-25 10:23:53 +07:00
6363437ccb
fix(taskprocessing): Update lib/private/TaskProcessing/Manager.php
...
Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-25 10:10:32 +07:00
060fb26686
fix(taskprocessing): run cs:fix
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-07-25 10:10:32 +07:00
799ee8fd51
feat(TaskProcessing): Implement enums and default values
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-25 10:10:31 +07:00
65941811b3
Merge pull request #44788 from nextcloud/db-error-logging
...
feat: add additional logging for database errors
2024-07-25 09:09:57 +07:00
57ed738af2
Merge pull request #46644 from nextcloud/cast-bigint
...
fix: cast to bigint on postgresql
2024-07-24 20:39:04 +07:00
7fbb981877
feat: add additional logging for database errors
...
including the stack trace of the current database transaction
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-24 15:35:07 +07:00
52fe7b1a12
Merge pull request #46694 from nextcloud/fix/file-info-name
...
fix: FileInfo from `View` should have the correct name of a mountpoint
2024-07-24 15:22:11 +07:00
7266a9ef33
Merge pull request #46418 from nextcloud/artonge/feat/user_admin_delegation
...
feat(users): Add users and group management to admin delegation
2024-07-24 11:15:54 +07:00
fc0b694d37
feat: mail provider backend
...
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-23 16:20:36 +07:00
c004f5376f
fix(taskprocessing): build autoloader files and fix psalm issue
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-07-23 17:12:38 +07:00
df11aa9efc
feat(taskprocessing): add appId filter to taskprocessing occ commands
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-07-23 17:12:38 +07:00
c120a64ba2
feat(taskprocessing): add occ commands to list tasks and compute stats
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-07-23 17:12:38 +07:00
df086a8c20
feat(taskprocessing): add start, stop and schedule time to tasks
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-07-23 17:12:38 +07:00
5ea972922b
fix: explicitly filter for storageid in preview cleanup job
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-23 14:41:15 +07:00
16c184e2cb
fix: cast to bigint on postgresql
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-23 14:41:13 +07:00
b37fb43a32
feat: let users configure their first day of week
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-07-22 22:35:46 +07:00
2b0bc8b310
fix: Do not return partial file info if we have a cache entry
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-22 22:32:34 +07:00
12796c3ae7
fix: FileInfo from `View` should have the correct name of a mountpoint
...
If a mountpoint is returned from a `View` the name must match the view scoped name
and not the global name.
For example group folders have a name like `1` or `2` (the ID),
but the name of the FileInfo returned fro mthe View should be the mount point name,
like `First groupfolder` or similar.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-22 22:01:12 +07:00
dff8815449
feat(users): Add support for admin delegation for users and groups management
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-22 17:17:35 +07:00
32f5739bc6
feat: add config flag to toggle persistent redis connections
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-22 14:25:20 +07:00
fffc784769
feat(taskprocessing): add support for webhooks (http or AppAPI) in the task processing API
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-07-22 11:34:29 +07:00
9ed2d3e495
Merge pull request #46571 from nextcloud/chore/migrate-to-filenamevalidator
...
refactor: Migrate some legacy and core functions to `IFilenameValidator`
2024-07-22 10:40:50 +07:00
c2a571e435
Merge pull request #46473 from nextcloud/feat/restrict_admin_to_ips
...
feat(security): restrict admin actions to IP ranges
2024-07-22 10:10:42 +07:00
800dffec31
Merge pull request #46640 from nextcloud/fix/noid/google-scope
...
fix(Token): take over scope in token refresh with login by cookie
2024-07-22 08:49:53 +07:00
9716b0d735
refactor: Migrate some legacy and core functions to `IFilenameValidator`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-19 19:41:46 +07:00
7395211c1a
Merge pull request #46605 from nextcloud/bugfix/noid/test-more-oracle-versions
...
fix(deps): Deprecate functionality deprecated by doctrine and test on more oracle versions
2024-07-19 16:40:49 +07:00
f1d97a3188
feat(Security): add Factory for IP addresses and ranges
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +07:00
047479ccf9
feat(security): Add public API to allow validating IP Ranges and checking for "in range"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +07:00
202e5b1e95
feat(security): restrict admin actions to IP ranges
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +07:00
99182aac37
fix(Token): take over scope in token refresh with login by cookie
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-07-19 15:53:46 +07:00
b656edc47c
fix(db): Fix md5 for oracle >= 20
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 14:13:56 +07:00
18844cb1b6
Merge pull request #46608 from nextcloud/error-log-textprocessing
...
fix(TextProcessing): use error instead of info for exception logging
2024-07-19 13:59:47 +07:00
a3c3eab09c
Merge pull request #46368 from nextcloud/fix/task-processing
...
TaskProcessing follow-up
2024-07-19 12:38:30 +07:00
e1e4ee4d67
fix(db): Manually track if `where()` is called when not empty to avoid recursion
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:16 +07:00
eeb6ddb176
fix(db): Deprecate `IExpressionBuilder::or()` and `IExpressionBuilder::and()` without parameters
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:16 +07:00
e45465781f
fix(db): Deprecate `getState()` as per upstream
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:15 +07:00
829f2b9bc7
fix(db): Promote the use of `getDatabaseProvider` to reduce the impage of removed upstream platforms
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:14 +07:00
bd383627a7
fix(db): Deprecate using table alias for DELETE and UPDATE
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:13 +07:00
c84580d53a
fix(db): `Doctrine\DBAL\Connection::executeUpdate()` is deprecated
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:12 +07:00
11e84b8968
fix(db): Fix internal calls to doctrine's `fetch()` methods
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:12 +07:00
a4c1d7291f
fix(db): Use `createSchemaManager()` method as `getSchemaManager()` is deprecated
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:11 +07:00
f92352eda4
fix(db): Deprecate `getQueryPart()` and `resetQueryPart()` methods that will be removed with Doctrine/DBAL 4
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:10 +07:00
64ca4b832d
Merge pull request #46583 from nextcloud/filecache-sharding-compat
...
Make filecache queries compatible with sharding
2024-07-19 09:49:45 +07:00
40f820470a
chore: use "app_api" session key, "app_api_system" is deprecated
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-07-18 17:16:57 +07:00
d473b516ad
fix(TextProcessing): use error instead of info for exception logging
...
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
2024-07-18 17:53:52 +07:00
b7af6ec200
feat: allow for ExApps to call Admin endpoints marked with specific attr
...
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
2024-07-18 15:11:39 +07:00
e5dcdfb9e0
feat(Security): Warn about using annotations instead of attributes
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-18 11:25:32 +07:00
c5b687271b
fix: make batch propagator work with sharding restrictions
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-17 19:16:07 +07:00
0931492ff0
fix: make usermountcache compatible with sharding
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-17 19:16:05 +07:00
718ef5dea5
Merge pull request #46510 from nextcloud/feat/info-xml-backends
...
feat: hide caldav server settings if no app uses the caldav backend
2024-07-17 18:57:08 +07:00
ad88fd07e3
fix: make joining on tags in search queries work with sharding
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-17 15:46:39 +07:00
80f8c7949e
fix: always set storage id in Cache::get
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-17 15:46:31 +07:00
5ff7bde3fb
fix: add set storage id for more cache queries
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-17 15:46:21 +07:00
183726a299
feat(settings/admin/ai): fix provider list not being declared
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-07-17 15:24:19 +07:00
9dca5ae0e0
feat(settings/admin/ai): Add Task Processing API settings
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 15:24:19 +07:00
969cc52851
fix(TaskProcessing): Run cs:fix
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 13:55:55 +07:00
ba33e6220c
fix(TaskProcessing): Use getScalarType instead of relying on magic integers
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 13:55:55 +07:00
fb34b13439
fix(TaskProcessingA/Manager): Catch new error
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 13:55:55 +07:00
2fed2fc433
fix(TaskProcessingA/Manager): Use time() along with rand int for file names
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 13:55:55 +07:00
ee7502ab1c
fix(TaskProcessing\Manager#setTaskResult): Replace files contents with ID instead of File object
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 13:55:55 +07:00
c1f2c76f44
fix: do not overwrite the output if NodeID exists
...
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 13:55:55 +07:00
3937cccd4b
fix(TaskProcessing\Manager#setTaskResult): Replace files contents with ID instead of File object
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 13:55:55 +07:00
5c457c64e8
fix: Validate output properly
...
Differentiate between output with file IDs and output with File data
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 13:55:55 +07:00
4ac7f8275b
feat(TaskProcessing): Allow setting task results for file slots
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 13:55:55 +07:00
1671bf3ef2
feat(Reference): Add public API endpoints to get references
...
Calling the public API endpoints will check for matching registered
reference providers that implement `IPublicReferenceProvider` and call
their respective functions. If no matching provider is found, the
default `LinkReferenceProvider` will be used to provide open graph data.
The frontend reference widget components will call these endpoints from
unauthorized sessions, e.g. in public shares.
If present, the sharing token of the origin URL is passed to
`resolveReferencePublic()` as additional information for the reference
provider to determine the access scope. This allows the respective
reference providers to determine whether the origin share has access to
the linked resource.
`getCacheKeyPublic` also gets the sharing token so it can scope the cached
entry to it.
Contributes to #45978
Signed-off-by: Jonas <jonas@freesources.org>
2024-07-17 12:56:41 +07:00
b06ce832d8
Merge pull request #46555 from nextcloud/emptyArrayAppStoreFail
...
fix(appstore): Return an empty array in case of fail
2024-07-17 12:33:33 +07:00
05888991d7
Merge pull request #46419 from nextcloud/bugfix/noid/limit-logo-size-for-outlook
...
fix(mail): Fix big logos in mail templates for Outlook
2024-07-17 11:54:47 +07:00
693a81bfa3
fix(mail): Fix big logos in mail templates for Outlook
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-17 09:24:55 +07:00
d237fd0e78
Merge pull request #46342 from nextcloud/fix-getimagesize
2024-07-16 21:47:35 +07:00
8665a9ba16
chore: add warning in case of failure
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-16 18:13:25 +07:00
1b41e8f566
Merge pull request #46538 from nextcloud/fix/use-filename-validator
...
refactor: Migrate filename validation from `Storage` and `Util` to `FilenameValidator`
2024-07-16 17:42:40 +07:00
decae5a45a
Merge pull request #46547 from nextcloud/query-builder-connection
...
feat: allow running QueryBuilder queries on different connections
2024-07-16 17:38:28 +07:00
f4ede27cdb
refactor: Remove deprecated `Util` function for filename validation to `FilenameValidator`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-16 12:49:10 +07:00
69341e4306
refactor: Migrate filename validation logic from `Storage` to `FilenameValidator`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-16 12:49:09 +07:00
bcfe566acc
Merge pull request #46543 from nextcloud/fix/htaccess
...
fix(htaccess): Serve images as static assets
2024-07-16 11:52:12 +07:00
b010474c78
fix(appstore): Return an empty array in case of fail
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-16 11:42:35 +07:00
e42bceac9f
feat: hide caldav server settings if no app uses the caldav backend
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-07-16 09:18:33 +07:00
c0e1503ce1
fix(previews): Stop returning true when getimagesize() fails
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-07-15 21:06:49 +07:00
9de6190ec4
feat: allow running QueryBuilder queries on different connections
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-15 22:41:04 +07:00
bdbeabafa7
feat: Add `forbidden_filename_basenames` config option
...
This allows to configure forbidden filenames (the full filename like `.htaccess`)
and also forbidden basenames like `com0` where `com0`, `com0.txt` and `com0.tar.gz` will match.
We need this as only using basenames was too restrictive and will cause problems on some systems when updating.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-15 19:39:18 +07:00
52e243f4d8
fix(htaccess): Serve images as static assets
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-15 18:06:13 +07:00
f94b0c3f55
Merge pull request #46397 from nextcloud/extended-query-builder-base
...
feat: add base class for extending the query builder
2024-07-15 14:53:22 +07:00
7206b2dc41
Merge pull request #46396 from nextcloud/inspectable-composite-expression
...
feat: allow inspecting the parts of the composite expression builder
2024-07-15 14:53:07 +07:00
fcff64afc7
Merge pull request #46475 from nextcloud/redisReqVer4
...
fix(redis): Require version >=4 for unlink
2024-07-15 09:54:42 +07:00
9b84831c8d
fix(files_sharing): adjust IAttributes API and files_versions
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +07:00
967b3848e0
fix(files_sharing): phpunit & openapi fixes
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +07:00
30f9ef414e
fix: psalm, cs, autoloader and lint
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +07:00
75ca4944c9
feat(files_sharing): allow mixed values in share attributes and allow storing email arrays
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +07:00
c253112cf7
chore(files_sharing): refactor mail handling
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +07:00
d388370c3b
feat(files_sharing): implement IShareProviderWithNotification and refactor sendMailNotification
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +07:00
4c61a94f4f
fix(redis): Require version >=4 for unlink
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-12 19:53:49 +07:00
c82d382a20
feat: add base class for extending the query builder
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-12 17:01:39 +07:00
d81d59e9c3
feat: allow inspecting the parts of the composite expression builder
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-12 17:01:36 +07:00
6983310ec0
docs: correct return type for findAppInDirectories
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-07-11 23:13:08 +07:00
50af0805f0
Merge pull request #46448 from nextcloud/bugfix/noid/fix-missing-dashboard-widget-icon
...
fix(dashboard): Unify widget icon colors and document it's behaviour
2024-07-11 17:27:55 +07:00
cf935e33ae
fix: `OCP\Files\Node\Folder::search` was not setting the owner
...
The owner was not set on the file info causing e.g. webdav searches to never return the known owner.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-11 15:46:44 +07:00
37d331233c
fix(dashboard): Document expected icon behaviour
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-07-11 13:14:03 +07:00
a229723b8c
feat: Add new forbidden filename options to Capabilities
...
Allow clients to access the new filename validation options
and make frontend name validation possible.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-11 13:31:54 +07:00
95af299cf5
Merge pull request #46398 from nextcloud/fix/46165/token-race
...
fix(Session): avoid race conditions on clustered setups
2024-07-11 09:24:24 +07:00
b50182b0d6
Merge pull request #46371 from nextcloud/feat/filename-validator
...
feat: Add `IFilenameValidator` to have one consistent place for filename validation
2024-07-10 15:40:26 +07:00
6a783d9b08
fix(Session): avoid race conditions on clustered setups
...
- re-stablishes old behaviour with cache to return null instead of throwing
an InvalidTokenException when the token is cached as non-existing
- token invalidation and re-generation are bundled in a DB transaction now
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-07-10 13:28:33 +07:00
e31f474fec
Merge pull request #46320 from nextcloud/perf/php-session-cache-limiter
...
perf: Set session.cache_limiter at runtime to avoid clients caching static assets served by PHP
2024-07-10 11:52:52 +07:00
a96b5940dd
chore: Make active apps initial state consistent with OCS API
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-10 01:35:24 +07:00
ddb9ef8287
Merge pull request #46004 from nextcloud/perf/noid/log-slow-capabilities
...
perf(capabilities): Log capabilities providers that are slow
2024-07-09 20:32:55 +07:00
3a97dbf248
Merge pull request #46123 from nextcloud/feat/user-password-hash
...
feat: Allow getting/setting the password hash of a user
2024-07-09 08:00:01 +07:00
46f1efac41
feat: Add `IFilenameValidator` to have one consistent place for filename validation
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-09 15:04:34 +07:00
6b523e8b09
Merge pull request #46317 from nextcloud/s3InsertTimeout
...
fix(s3): Don't wait indefinitely for S3 to return
2024-07-09 09:49:39 +07:00
c390ae94ff
feat: Validate password hash
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-08 16:31:42 +07:00
dba00560d2
perf: Return cached password hash
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-08 16:30:52 +07:00
34d97d45cf
feat: Allow getting/setting the password hash of a user
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-08 16:30:52 +07:00
a330f4c9d5
feat: Implement IPasswordHashBackend in database user backend
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-08 16:30:52 +07:00
34a9e48827
fix: switch from explode to substr (faster)
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-07-08 16:41:58 +07:00
62192ca57a
fix(config): Add missing handling for envCache in getKeys()
...
NC_ env variable overrides were not appearing in
the output of `occ config:list system` nor `occ
config:system:get xxx`. This was creating nearly
impossible to diagnose configuration/ behavior
disprepancies.
- Refactored readData() so that we aren't saving
the entire environment in the envCache anymore
(only those prefixed "NC_") and so that we save
NC_ provided config values under their real
key.
- Refactored getValue() to accommodate readData()
refactor
- Fixed getKeys() to properly return
envCache keys too
Environment provided config variables now appear
in `occ config:list system` as expected.
Environment provided config variables now appear
when queried via `occ config:system:get KEY`
envCache is now free of non-NC stuff.
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-07-08 16:41:58 +07:00
38bee2c014
perf: Set session.cache_limiter at runtime to avoid clients caching static assets served by PHP
...
By default there is a Pragma: no-cache header set due to the default
value `no-cache` of session.cache-limiter, which will cause Chrome and
iOS to not cache even with a different Cache-Control header set on the
response.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-08 22:30:27 +07:00
4eba967d63
fix: getLastLoggedInUsers moved from AllConfig/IConfig to IUserManager/Manager
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
357786f36a
fix: return type doc block added as per psalm
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
53e3644ffb
fix: return type doc block added as per psalm
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
0df1a29cf0
fix: return type doc block added as per psalm
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
3dee8a213d
fix: second join and where conditions added only when search param is available
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
0e6040289f
fix: query refactored to support both the search by email and sort by login
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
ae95e46787
fix: limit and fixLimit removed. negative limit handled in controller. removed getUsersSortedByLastLogin from Manager and instead used the config in controller
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
ceedfb4616
fix: removed default limit of 25. if null is given all users are fetched or if limit is given limit number of users are fetched
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
cfafbc8415
fix: removed references to old disabled users code. refactored query as per getDisplayNames function. limit and offset added to query. default limit set to 25.
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
afa51365ff
fix: removed the params related to sortMode and order since it sorts by lastLogin
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
5b249df686
fix: doc blocks added
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
695bd042d7
fix: search and searchDisplayNames reverted to how it was initially as sort and order are not required here
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
dc6e8c9c0a
fix: search and searchDisplayNames reverted to how it was initially as sort and order are not required here
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
4cb85f7c9e
fix: rebased the branch with master and resolved conflicts
...
fix: added a new endpoint users/recent and getting users based on last login info in the same. Reverted old code that was breaking LDAP
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
76c875a588
fix: change orderBy and sort to sortMode and sortOrder. default it to uid asc. enable email search by changing query
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
33b38c6573
fix: cs fix and psalm ci related changes
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
c8c68c3510
fix: sort the user getDisplayNames based on lastLogin. Default sort order is lastLogin DESC
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
87a8013ee3
feat: cs fix run on the changed files and default order by last_login desc. Also last_login sort logic changed
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
0ee676cd51
feat: add ability to sort users by last_login, uid or displayName. one of these needs to be passed as orderBy and sort can be ASC or DESC
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
c84e76a749
fix(s3): Don't wait indefinitely for S3 to return
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: lint
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: use AwsException
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: Throw on connection failure
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: Wrap all in try catch block
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: use RequestTimeout error message
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
log: use OCP Server class
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: Handle connect timeout only
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: Handle errors more generically
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-05 16:24:32 +07:00
415edcac9b
chore: More explicit splitHash typing
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-04 17:05:45 +07:00
d9bf6c432e
feat: Add method to validate an IHasher hash
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-04 17:05:45 +07:00
7e663301ff
Merge pull request #45353 from nextcloud/feat/excalidraw-file-support
...
feat: support excalidraw file
2024-07-04 17:27:38 +07:00
8b3055ce59
Merge pull request #46276 from nextcloud/3rdparty/patch-mp3info
...
chore(mp3info): apply upstream patch for invalid array access
2024-07-04 14:25:18 +07:00
bd7b09a709
Merge pull request #46251 from nextcloud/feat/taskprocessing-more-tasktypes
...
feat(TaskProcessing): Add more task types
2024-07-04 14:02:02 +07:00
03d71e859c
Merge pull request #46286 from nextcloud/fix/tp/sync-bg-job-status
...
fix(TaskProcessing): Set task status to running when processing via ISynchronousProvider
2024-07-04 12:53:54 +07:00
9a2f026bd6
feat: support excalidraw file
...
Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
2024-07-04 11:09:21 +07:00
37454eb200
feat: log file id and path when extracting the mp3 cover fails
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-07-04 10:55:31 +07:00
8cb0f1a3ae
Merge pull request #46174 from nextcloud/fix/integrity-check
...
fix(IntegrityCheck): Ensure the check is run if no results are available
2024-07-04 10:39:38 +07:00
d9cf6e61c8
feat(TaskProcessing): Add more task types
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-04 10:10:23 +07:00
1b2c8d5030
fix(TaskProcessing): Set task status to running when processing via ISynchronousProvider
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-04 10:02:36 +07:00
993424fc95
Merge pull request #46273 from nextcloud/fix/make-ooo-replacement-nullable
...
Fix: Make out of office replacement nullable
2024-07-03 15:03:24 +07:00
85a3b27cf9
Fix: Make out of office replacement nullable
...
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-07-03 12:31:53 +07:00
8fc498fb82
fix(IntegrityCheck): Ensure the check is run if no results are available
...
If there are no cached results the current implementation was also returning an empty array,
but this was the same as when there was a successful run.
So to distinguish this we return `null` if there are *no* results.
In this case we need to rerun the integrity checker.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-03 11:37:49 +07:00
5f7b33fbea
Merge pull request #46194 from nextcloud/schema-export-cmnd
...
feat: add commands for exporting current and expected database schema
2024-07-02 16:44:55 +07:00
4f01486da0
feat: add commands for exporting current and expected database schema
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-02 13:45:12 +07:00
92acbb0d39
Merge pull request #45766 from nextcloud/feat/ooo-replacement
...
Feat: Allow users to select another user as their out-of-office replacement
2024-07-01 23:25:43 +07:00
55f3e53695
Merge pull request #46169 from nextcloud/enh/support-profiler-in-occ
...
Support profiler in occ commands
2024-07-01 22:45:31 +07:00
f5ff8136ac
feat(TaskProcessingApi): Add endpoint for getting the next task
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-01 17:11:12 +07:00
a9774741e8
Feat: Allow users to select another user as their out-of-office replacement
...
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-07-01 15:10:16 +07:00
Git'Fellow
Ferdinand Thiessen
Julius Härtl
Marcel Klehr
Julien Veyssier
Andy Scherzinger
Arthur Schiwon
Côme Chilliet
Josh
Louis Chemineau
Robin Appelman
Maxence Lange
Joas Schilling
Daniel
Kate
provokateurin
Christoph Wurst
Richard Steinmetz
Joas Schilling
Christoph Klaffl
Vincent FarZz
John Molakvoæ
Hailong Wang
S1m
Christoph Wurst
Côme Chilliet
Holger Hees
skjnldsv
Jérôme Herbinet
Stephan Orbaugh
Christopher Ng
withbest
Dennis Verspuij
ernolf
Elizabeth Danzberger
SebastianKrupinski
Benjamin Gaussorgues
Andrey Borysenko
Anupam Kumar
Alexander Piskun
Jonas
Pytal
yemkareems
Hoang Pham
Hamza
Hamza Mahjoubi