Commit Graph

15098 Commits (b0197c5dfcb0dac94de43bfbfa89a2889fc1e30b)

Author SHA1 Message Date
Daniel Kesselberg 6be00432b7
chore: always execute parse_url in preventLocalAddress
This change should make it easier to spot wrong uses of the HTTP client on development setups where allow_local_remote_servers is usually true.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-10-01 18:00:47 +07:00
Kate 26762172f5
Merge pull request #48454 from nextcloud/fix/storage/get-directory-content-return-type 2024-10-01 16:22:16 +07:00
Arthur Schiwon 7f7a3cd45f
Merge pull request #48484 from nextcloud/fwdport/48445/master
fix(Auth): ignore missing token when trying to set password-unconfirm…
2024-10-01 15:47:11 +07:00
Robin Appelman 1bf27e74dd
Merge pull request #48235 from nextcloud/readd-object-store-phpunit
test: re-add object store primary storage phpunit tests
2024-10-01 15:11:10 +07:00
Arthur Schiwon 12d39e818d
fix(Auth): ignore missing token when trying to set password-unconfirmable
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-10-01 12:24:20 +07:00
Daniel Kesselberg fbaa4cc5e0 fix: catch NotPermittedException in Folder.nodeExists
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-30 19:00:36 +07:00
Daniel Kesselberg 3db20c8b00 docs: Folder.get throws a NotPermittedException exception
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-30 19:00:36 +07:00
provokateurin e1998b6b6c
fix(Storage): Fix getDirectoryContent() return type
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-30 16:49:27 +07:00
Daniel be87dec2d9
Merge pull request #48439 from nextcloud/fix/background-image
fix(theming): Use `AppConfig` for setting background image
2024-09-30 12:42:29 +07:00
Côme Chilliet 6ef05bafeb
fix: Fix test of IConstructableStorage implentation by storage classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-30 11:21:42 +07:00
Ferdinand Thiessen 60083b1b5f
fix(theming): Use `AppConfig` for setting background image
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 22:44:03 +07:00
Ferdinand Thiessen eb69e89fa5
chore: Drop unused legacy `OC_Files`
It is replaced with the Sabre `ZipFolderPlugin` and apps should use the `OCP\AppFramework\Http\StreamResponse`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 13:18:40 +07:00
Ferdinand Thiessen 2f66bd5b75
fix: Allow `Streamer` to specify type in constructor instead of magin UA handling
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 13:18:29 +07:00
ernolf b4ea146d10 feat(share): make sharelink token length configurable
- ensure unique share token with dynamic length adjustment

Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
2024-09-28 08:06:24 +07:00
Josh ce51cecb44
fix(config): Suppress error at install time
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-09-27 17:28:14 +07:00
Robin Appelman 3e12e1e789
fix: rework move into object store to better preserve fileids
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-27 14:46:08 +07:00
Robin Appelman 888d06dff9
fix: preserve fileid when moving from objectstore to non-objectstore
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-27 14:45:42 +07:00
Robin Appelman da21acfb3f
fix: ensure source folder is removed from cache when moving to objectstore
otherwise this causes confusion down the line as it's contents will be moved to the new cache

Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-27 14:45:42 +07:00
Joas Schilling 234c44a77e
fix(l10n): Fix list of RTL languages
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-27 12:50:30 +07:00
Ferdinand Thiessen d57a2dd465
fix: Skip users that still exist in backend
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-26 20:48:45 +07:00
Ferdinand Thiessen 16833aff86
fix: Make user removal more resilient
Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.

There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.

The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-26 20:48:37 +07:00
provokateurin 7cdccd058f
fix(Storage): Fix IStorage return types
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 18:13:03 +07:00
provokateurin 35dfc639b3
fix(QueryBuilder): Restrict identifier length to 30 characters due to Oracle limitations
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 08:57:06 +07:00
Côme Chilliet 280f6df66c
Merge pull request #32018 from nextcloud/cleanup/event/trashbin
Port files trashbin events to IEventDispatcher/IEventListener
2024-09-24 17:15:39 +07:00
Richard Steinmetz 19ad13571c
fix: gracefully parse non-standard trusted certificates
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-09-24 12:36:09 +07:00
Joas Schilling 12ed773b58
Merge pull request #47349 from nextcloud/feat/31420/bidi-backend-support
Add bidirectional text support - Backend
2024-09-24 11:27:42 +07:00
Carl Schwan 77821f8f3e
feat(trashbin): Port files trashbin events to IEventDispatcher/IEventListener
oc_hooks is deprecated and will at some point be removed

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-23 18:13:21 +07:00
Joas Schilling 7ddad46137
Merge pull request #48268 from nextcloud/debt/noid/ignore-docker-image-lock-file
fix: skip the integrity check for nextcloud-init-sync.lock
2024-09-23 17:48:40 +07:00
Joas Schilling 82566c5479
fix(rtl): Make clear that the direction is based on language
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-23 17:00:07 +07:00
Joas Schilling ae06ab5860
fix(rtl): Fix list of RTL languages
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-23 16:59:49 +07:00
ali ghorbani 2b7efd66b6
feat(rtl): Set layout direction based on language
Signed-off-by: ali ghorbani <ghorbani.ali.developer@gmail.com>
2024-09-23 16:59:20 +07:00
Joas Schilling 643e216a25
Merge pull request #48274 from nextcloud/feat/noid/priority-notifications
feat(prioritynotifications): Allow some apps to mark notifications as priority
2024-09-23 16:10:25 +07:00
Côme Chilliet 40b404c566
Merge pull request #48111 from nextcloud/fix/move-storage-constructor-to-specific-interface
fix: Move storage constructor to specific interface
2024-09-23 15:57:38 +07:00
Louis Chemineau 22d5d29c01 fix(users): Don't crash if disabled user is missing in the database
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-23 10:40:38 +07:00
Côme Chilliet 94b0a0e863 fix: Move storage constructor to specific interface
That allows Wrappers to use DI and not care about the constructor

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-23 09:46:44 +07:00
Joas Schilling 5193579e4f
feat(prioritynotifications): Allow some apps to mark notifications as priority
They will be still send as push during DND.
Apps are currently limited to:
- twofactor_nextcloud_notification to help with login
- spreed which will only set it for pushes in manually picked conversations

Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-23 09:02:48 +07:00
Daniel Kesselberg 6e870c0206
fix: skip the integrity check for nextcloud-init-sync.lock
nextcloud-init-sync.lock is used by nextcloud/docker to prevent running the initialization script on multiple containers at the same time.

Ref: https://github.com/nextcloud/docker/issues/2299.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-22 17:48:43 +07:00
Ferdinand Thiessen 59059f6605
Merge pull request #48246 from nextcloud/bug/noid/profile-clear-not-working
fix(profiler): clear command does not work
2024-09-21 12:52:47 +07:00
Andy Scherzinger 3009da3722
Merge pull request #43968 from exi/custom-binary-search-paths
feat: make search path for BinaryFinder customizable.
2024-09-20 19:14:17 +07:00
Git'Fellow 2ba3f7ed5c
Merge pull request #47782 from nextcloud/reworkShareExceptions
fix(l10n): Rephrasing some exceptions to be translated
2024-09-20 18:53:40 +07:00
Git'Fellow dcbe8da2a6 fix(l10n): Rephrasing some exceptions to be translated
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

fix: Fix tests

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-20 18:35:11 +07:00
Daniel Kesselberg 4ae10aa7f9
fix(profiler): clear command does not work
- The loop is supposed to delete the files first and then the directories.
- getPathInfo returns a SplFileInfo object for the parent (the folder in our case).
- A non-empty directory cannot be deleted.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-20 18:14:33 +07:00
Reno Reckling ef7e857881
feat: make search path for BinaryFinder customizable.
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.

Also added tests.

This fixes issue #43922

Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Reno Reckling <e-github@wthack.de>
2024-09-20 17:00:06 +07:00
Julius Knorr 606241caeb
chore(legacy): Introduce public version ct plass and drop version methods from OC_Util
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-20 14:53:34 +07:00
Ferdinand Thiessen a8f46af20f
chore: Add proper deprecation dates where missing
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-20 00:46:03 +07:00
Julius Härtl 232c22fcd1 fix(federation): Do not overwrite certificate bundle
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-09-20 00:13:00 +07:00
Ferdinand Thiessen 2a59f4fc95
Merge pull request #48220 from nextcloud/chore/remove-travis
chore: Remove old travis related stuff
2024-09-19 23:26:39 +07:00
Ferdinand Thiessen 7ae7f7fd12
chore: Remove old travis related stuff
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 20:16:29 +07:00
Robin Appelman 47d281865e perf: reuse cache info we already have when moving to object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 19:06:06 +07:00
provokateurin 9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +07:00
Ferdinand Thiessen 5cce140701
chore: Remove deprecated `ILogger` logging functions
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:37:06 +07:00
Ferdinand Thiessen f1dfd6ba71
refactor(OC_Template): Remove deprecated ILogger
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:21 +07:00
Ferdinand Thiessen 74923d174b
refactor(OC_Files): Remove deprecated ILogger
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:21 +07:00
Ferdinand Thiessen 8b79283c6b
refactor(OC_Util): Remove deprecated ILogger
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:21 +07:00
Ferdinand Thiessen 0d31976690
refactor(OC_Hook): Remove deprecated ILogger
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:21 +07:00
Ferdinand Thiessen 69abd8851b
refactor(OC_App): Remove ILogger usage
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:21 +07:00
Ferdinand Thiessen 7ae62cfe47
refactor(ProviderFactory): Remove usage of ILogger and use non-deprecated stuff
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:20 +07:00
Ferdinand Thiessen 44c7248749
refactor(Collaboration): Use non-deprecated methods
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:20 +07:00
Ferdinand Thiessen fe05882628
chore!: Remove `OC\AppFramework\Logger`
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:32:25 +07:00
John Molakvoæ df2711d23e
Merge pull request #48163 from nextcloud/feat/nfo
feat: add nfo file support
2024-09-19 00:22:16 +07:00
Joas Schilling 342927b140
Merge pull request #48182 from nextcloud/oracle-share-reminder
fix: fix share reminder job for oracle
2024-09-18 20:24:07 +07:00
Robin Appelman b45f2420fe fix: fix share reminder job for oracle
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 19:24:44 +07:00
Côme Chilliet 989d708bd8
Merge pull request #48137 from nextcloud/enh/add-rich-object-formatter
feat: Add OCP interface to format richtext into string
2024-09-18 18:59:56 +07:00
Robin Appelman 3c0c81bb94 fix: ensure parent folder exists when writing a file to object storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 14:11:27 +07:00
Robin Appelman 75cf17e4c4 fix: verify that parent exists in cache when inserting
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 14:11:27 +07:00
Robin Appelman e0fb25f846 fix: fix object store id for test object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 13:54:55 +07:00
Robin Appelman 60f6347c97 fix: cleanup objectstore file_put_content
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 13:54:55 +07:00
Robin Appelman 3e94ee391f fix: create intermediate directories for objectstore moveFromStorage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 13:54:55 +07:00
Robin Appelman 879fcc4253 fix: get source file before moving the cache item in objectstore moveFromStorage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 13:54:55 +07:00
John Molakvoæ (skjnldsv) 397910cd1d
feat: add nfo file support
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-18 11:51:10 +07:00
John Molakvoæ 6bcab26174
Merge pull request #44013 from nextcloud/fieat/profile-pronounces
feat: add pronouns to account profile
2024-09-18 01:25:07 +07:00
John Molakvoæ (skjnldsv) b24e02e5df
fix(core): profile design and pronouns support
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-18 00:15:19 +07:00
John Molakvoæ eb374a74c7
Merge pull request #45020 from Noodlesalat/fix-lastlogin-update-token-login 2024-09-17 23:54:37 +07:00
John Molakvoæ (skjnldsv) 26abc86eca
feat: add profile pronouns
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-17 22:20:36 +07:00
provokateurin c2fb7a72da
fix(psalm): Fix @throws annotations
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 17:18:30 +07:00
Stephan Orbaugh f25acfb799
Merge pull request #47986 from cfiehe/fix_move_on_same_bucket
perf(ObjectStoreStorage): Improve (slow) move on same object bucket
2024-09-17 16:35:19 +07:00
Ferdinand Thiessen f5b73d2c77
fix: Remove legacy settings forms
`OC_App::getForms` was always returning an empty array,
because there were no setter for `adminForms` or `personalForms` anymore.
So removed all that legacy settings forms logic.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-17 14:54:39 +07:00
Côme Chilliet 117c7ee654
fix: Fix Event and Notification creation with the new required parameter
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 14:37:55 +07:00
John Molakvoæ fe9981fad7
Merge pull request #48129 from nextcloud/feat/zst 2024-09-17 14:31:06 +07:00
Côme Chilliet 295eee6712
fix: Add missing alias for IRichTextFormatter
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 14:23:44 +07:00
John Molakvoæ (skjnldsv) 67fb4da40f
chore: update RepairMimeTypes migration
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-17 14:14:01 +07:00
Côme Chilliet 70a886ce83
feat: Add OCP interface to format richtext into string
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 13:57:33 +07:00
Kate 4e64a6eb48
Merge pull request #48080 from nextcloud/fix/storage/method-docs-inheritance 2024-09-17 11:16:20 +07:00
John Molakvoæ 57a5baa88f
Merge pull request #48094 from nextcloud/fix/storage/get-owner-false 2024-09-17 10:44:31 +07:00
John Molakvoæ 6f78730573
Merge pull request #48114 from nextcloud/fix/AppStore--remove-unneeded-warning 2024-09-17 10:26:31 +07:00
provokateurin d2d1e3284d
fix(Storage): Fix method docs inheritance
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 10:20:38 +07:00
provokateurin dc13f9cc1e
fix(Files): Handle getOwner() returning false
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 10:10:50 +07:00
provokateurin 8ca6fcace7
fix(Storage): Document getOwner() can return false
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 10:10:50 +07:00
Côme Chilliet c256518ab3
Merge pull request #48110 from nextcloud/chore/remove-deprecated-aliases
chore: Remove deprecated aliases from dependency injection
2024-09-17 09:39:27 +07:00
Ferdinand Thiessen c2443ad1f2
chore: Replace DI alias with real class
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-17 02:27:31 +07:00
Grigorii K. Shartsev 70ed4aec39 fix(appstoreFetcher): get app list from custom app store
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-09-17 01:29:25 +07:00
Grigorii K. Shartsev ce679c3da4 fix(appstoreFetcher): remove unneeded warning
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
2024-09-17 01:24:49 +07:00
Côme Chilliet 0759b481e6
chore: Remove deprecated aliases from dependency injection
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 21:11:09 +07:00
Côme Chilliet b9fb1db0f8
Merge pull request #48009 from nextcloud/fix/remove-references-to-deprected-storage-interface
fix: Remove OCP\Files\Storage interface deprecated since version 9
2024-09-16 20:50:38 +07:00
Robin Appelman ede0c26b78
Merge pull request #46480 from nextcloud/fix/mailer-binaryfinder-fallback
fix(Mailer): Fix sendmail binary fallback
2024-09-16 18:18:14 +07:00
Côme Chilliet e7ac9bb2d8
chore: Check storage is an instance of the correct class instead of psalm-suppress
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:39 +07:00
Côme Chilliet ed0ac284e3
chore: Remove deprecated Storage::search method instead of moving it to IStorage
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:38 +07:00
Côme Chilliet 5d01e0a73c
chore: psalm-suppress legacy code weirdness
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:38 +07:00
Côme Chilliet 492e6997d8
chore: Fix psalm issues, put back private versions of getter in private Storage interface
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:38 +07:00
Côme Chilliet 22822d5e9b
fix: Fix other uses of removed Storage interface
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:36 +07:00