Commit Graph

260 Commits (b0197c5dfcb0dac94de43bfbfa89a2889fc1e30b)

Author SHA1 Message Date
Côme Chilliet 0c346849f3
Migrate missing PHP modules check to new API and improve it
Test all modules listed as required in our documentation

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 15:58:45 +07:00
Côme Chilliet 6bc3e008c7
Fix tests for setup checks
Had to remove tests for migrated checks, we should add tests for each
 SetupCheck class later on.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 11:44:02 +07:00
Valdnet be6c889414 Correct typos and add quotation marks
Corrects typos and unifies spelling for "occ" commands.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-10-11 01:51:39 +07:00
Côme Chilliet 0a9371f99f
Migrate applications away from deprecated ILogger
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-21 11:57:21 +07:00
Anna Larch 7f11ee8c4a fix(CardDAV): only run upgrade sync if 1000 users or less
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-26 17:21:50 +07:00
Joas Schilling bed3ffb312
feat(admin): Show an error when the admin is throttled
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:40:24 +07:00
Joas Schilling ab70bbd3ff
fix(db)!: Remove private legacy event because we can not keep it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:35 +07:00
Julius Härtl 925bcebcb6
feat: Add public event for missing indices
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-07-14 13:11:22 +07:00
Daniel Kesselberg 5a23b429dd
feat: remove check for OpenSSL 1.0.1d and 1.0.2b
OpenSSL 1.0.1d: 2013-02-05
OpenSSL 1.0.2b: 2015-06-11

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-04 18:44:47 +07:00
Simon L e2ab9bf4af address review and fix tests
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-18 11:33:53 +07:00
Simon L 80645a591a add an admin check for db file locking
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-17 12:51:33 +07:00
jld3103 d9f8522003
Fix types for reading and writing config values
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-05 09:08:56 +07:00
julia.kirschenheuter 0cfbe54a5a Create headings for settings pages
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-03-07 17:51:19 +07:00
Côme Chilliet dde5c46a3e
Migrate to Symfony Mailer
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-02 10:30:06 +07:00
Joas Schilling 348454cb91
Merge pull request #35876 from bennet0496/patch-mail-header
Adding option to set Auto-Submitted email header
2023-01-04 09:34:14 +07:00
Bennet Becker 5a1cc8de9b
update usages of AutoSubmittedValue to AutoSubmitted::VALUE_
Signed-off-by: Bennet Becker <dev@bennet.cc>
2023-01-03 15:28:43 +07:00
Côme Chilliet b843d09810
Fix typing errors in settings tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-02 15:13:00 +07:00
Bennet Becker eec1ebb848
Updating unit test for NewUserMailHelper, to test for autosumbitted
header

Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
2022-12-23 19:27:09 +07:00
Vincent Petry f9ea078e27
Add unit test for case insensitive email saving
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-12-16 17:47:42 +07:00
Carl Schwan f244406ebd Update composer autoloader
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 13:35:17 +07:00
Carl Schwan e35bcc9381 Fix tests
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 10:06:19 +07:00
Côme Chilliet 68363f6944
Fix some more problems with tests under PHP 8.2
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 16:02:24 +07:00
Côme Chilliet 72f4b34ad5
Fix tests depending on a trailing whitespace
Many editors remove trailing whitespaces, so avoid depending on them for
 tests success.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 10:31:58 +07:00
Côme Chilliet c79a6b3f62
Fix errors from PHP 8.2 testing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 17:08:21 +07:00
Christopher Ng 98bc98ac98 Add profile config migration
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-01 15:27:37 +07:00
Simon L 9dbcf0560f
Merge pull request #33200 from nextcloud/enh/noid/64bit
add a setup check for 64 bit
2022-07-13 20:19:40 +07:00
Carl Schwan 4e0574e184 Port encryption admin settings to vue
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-13 14:58:55 +07:00
szaimen cf9b1082ed add a setup check for 64 bit
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-07-13 09:33:33 +07:00
Louis Chemineau 347ca20f4e Rename setting name to reduce its length
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-06-27 11:04:17 +07:00
Côme Chilliet c0c54b20d9
Remove deprecated at() matcher from settings tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-07 10:05:18 +07:00
Pytal e647b9fa49
Merge pull request #32443 from nextcloud/port/background-job-admin 2022-05-20 09:58:13 +07:00
Carl Schwan e8e0f97c9a Port BackgroundJob admin settings to vue
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 15:00:54 +07:00
Carl Schwan 9d5a542a4e Improve two factor admin settings
- Port more of it to vue
- Use new nextcloud vue components for the setting section
- Add a bit of spacing between the elements

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 13:27:55 +07:00
Louis Chemineau 80fa3c7319 Add setting to ignore email during search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-03 17:50:29 +07:00
Vincent Petry 78c8e57896
Fix migrators according to exceptions
Fixed syntax errors.
Removed if condition for copyToFolder since it's void now.
Change signature of setMigratorVersions to also be void.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-13 16:52:40 +07:00
Louis Chemineau 37f1c8640e Add settings to ignore second display name in search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-04-12 17:27:59 +07:00
Vincent Petry 4626bfbc83
Merge pull request #31927 from nextcloud/feat/dont_match_userid_tests
Tweak tests to include shareapi_restrict_user_enumeration_full_match_userid
2022-04-12 09:43:02 +07:00
Pytal 209a2a6a4b
Merge pull request #31866 from nextcloud/test-avatar-migration 2022-04-11 10:45:40 +07:00
Côme Chilliet eed6330b92 Adapt AccountMigratorTest to id change
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-04-11 13:59:27 +07:00
Louis Chemineau a1ff0f368d Tweak tests to include shareapi_restrict_user_enumeration_full_match_userid
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-04-11 12:51:19 +07:00
Christopher Ng 8e7372df44 Add comment explaining avatar basename
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-08 18:03:33 +07:00
Christopher Ng 6e62c3ddc5 Remove unnecessary array_diff
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-08 18:02:49 +07:00
Christopher Ng 32fc848fcf Test avatar migration
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-07 00:44:06 +07:00
Christopher Ng 3fb420115d Improve strictness of account file regex
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-07 00:24:48 +07:00
Pytal 9644b7e505
Merge pull request #31852 from nextcloud/test-account-migrator 2022-04-06 11:42:08 +07:00
Christopher Ng 8aa9ea7402 Test migration of account information
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-06 02:11:13 +07:00
Carl Schwan a29251e02d Allow to disable password policy enforcement for selected groups
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-04-05 17:04:17 +07:00
Christopher Ng 108abd77ed Add profile default setting for admin
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 02:55:12 +07:00
Christopher Ng 1fc0b4320c Add global profile toggle config
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 02:55:12 +07:00
szaimen 351357047a fix drone tests on master
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-03-11 20:45:26 +07:00
szaimen 3c8f8bc70a fix tests
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-03-07 18:07:45 +07:00
MichaIng 5ac91f1cb8 Add Nextcloud docs link to OPcache recommends
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list.

Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend.

Signed-off-by: MichaIng <micha@dietpi.com>
2022-03-03 23:00:07 +07:00
Arthur Schiwon b28aa52b28
Setup warning for invalid LDAP user or group UUIDs.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-10 10:15:01 +07:00
szaimen fa1ee8f0c7 fix tests
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-02-03 20:41:12 +07:00
Carl Schwan 7619dceff4
Fix tests with email templates
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-18 20:56:50 +07:00
MichaIng 82c1beaacb Enhance and complement OPcache setup checks
The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage.

With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used.

The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded.

A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks.

OPcache usage based checks are skipped when Nextcloud is not permitted to use the API.

Signed-off-by: MichaIng <micha@dietpi.com>
2021-12-19 23:38:21 +07:00
Côme Chilliet dc8b79c4d2
Fix OCA\Settings\Tests\Settings\Admin\SharingTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-16 09:43:30 +07:00
Joas Schilling c6ae53096c
More test fixing
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 22:17:19 +07:00
Joas Schilling e8f7a08e52
ArgumentCountError: Too few arguments to function OCA\Settings\Controller\CheckSetupController::__construct()
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +07:00
Joas Schilling 24935666e8
PHPUnit\Framework\MockObject\DuplicateMethodException: Cannot stub or mock using a method list that contains duplicates:
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +07:00
Joas Schilling 19d070850b
Make sure trusted_proxies is an array
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +07:00
Julien Veyssier facb50ebcc
fix appstoreenabled check in Fetcher so it's coherent with AppSettingsController
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-10-18 12:39:43 +07:00
Carl Schwan 6958d8005a
Add admin privilege delegation for admin settings
This makes it possible for selected groups to access some settings
pages.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-09-29 21:43:31 +07:00
szaimen d253d52007
Merge pull request #28837 from nextcloud/show-warning-if-sharing-app-disabled
Show warning on the share settings when the File Shares app is disabled
2021-09-20 12:11:42 +07:00
Stefan ea4b7bac7a Issue 16719: CheckSetupController.php: now injecting reference to ITempManager, rather than obtaining using it manually
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +07:00
Thomas Citharel b3c7927260
Show warning on the share settings when the File Shares app is disabled
Closes #3706

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2021-09-15 16:33:03 +07:00
Arthur Schiwon 27865d03c0
use specific email getter where necessary
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +07:00
J0WI 3b656446af Introduce ISecureRandom::CHAR_ALPHANUMERIC
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-07-08 15:11:31 +07:00
szaimen a5bcfbe058 fix NewUserMailHelperTest
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-06-22 17:12:34 +07:00
szaimen 2cb85546fe fix NewUserMailHelperTest
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-06-22 17:01:23 +07:00
John Molakvoæ (skjnldsv) 215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
John Molakvoæ (skjnldsv) b228e8a361
Fix translation phpunit test
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-02 18:00:45 +07:00
Arthur Schiwon 847ed37afc
do not use private AccountManager in UsersController
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-25 14:35:38 +07:00
Robin Appelman b1dca57a1c
load share settings from the share manager in more places
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:28 +07:00
Daniel Calviño Sánchez 67dd087ce4 Fix deleting properties of user settings when not given explicitly
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +07:00
Daniel Calviño Sánchez a7431817b9 Respect additional user settings not covered by the controller
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.

Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).

This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +07:00
Daniel Calviño Sánchez c5e3d2e5c2 Add more unit tests for setting user settings
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +07:00
Daniel Calviño Sánchez 190ffd75b7 Change default test data to values less similar to empty values
Right now it makes no difference, but this should make future tests
clearer, specially in case of failure.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +07:00
Daniel Calviño Sánchez ef5d538448 Extract default test data to a helper getter
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +07:00
Daniel Calviño Sánchez 8cae515daa Use constants from interface rather than class
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +07:00
Vincent Petry af61486aea
Separate settings for remote share expiration
Added separate settings for default and enforced expiration date for
remote shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +07:00
Vincent Petry 5d14fd4396
Make extra user profile fields always editable
The fields for phone number, address, website and twitter are now
editable regardless whether federated sharing and the lookup server
are enabled or not.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +07:00
Vincent Petry 278a73789e
Map old account scope properties to new names
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +07:00
Joas Schilling 07095fd122
Also clear the knownUser when changing via the settings endpoint
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 19:37:10 +07:00
Joas Schilling 5b53b6f977
Add a setting to restrict returning a full match unless in phonebook or same group
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:25:57 +07:00
Joas Schilling b71268e38b
Add a config setting to restrict autocompletion to phonebook matches
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:55 +07:00
Roeland Jago Douma bc961baa40 Move some settings over to the IInitialState
The old one has been deprecated. Part one of many.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 21:11:56 +07:00
Roeland Jago Douma 38f761f25f Move away some ILoggers
Makes psalm happier

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 10:47:25 +07:00
Roeland Jago Douma 7d8e9baa77
Revert "use the configured forwarded headers for the setup check" 2021-02-13 18:03:32 +07:00
Robin Appelman 01118a2218
use the configured forwarded headers for the setup check
instead of always checking against the same header

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-12 14:22:27 +07:00
Morris Jobke bffa61fc32
Add setup check to verify that the used DB version is still supported in the next major release
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-08 13:38:32 +07:00
Julius Härtl 068e3b2c1e
Set the user language when adding the footer
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-07 15:31:55 +07:00
Christoph Wurst d89a75be0b
Update all license headers for Nextcloud 21
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +07:00
Joas Schilling 46b073d7ce
Add a config for default region of phone numbers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +07:00
Joas Schilling 9e04e6f99a
Also translate the phone number when coming in via the accounts manager API directly
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +07:00
Joas Schilling da9462b482
Make code strict
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +07:00
medcloud 87ec4a0da3 Fix #23357
Signed-off-by: medcloud <42641918+medcloud@users.noreply.github.com>
2020-11-18 22:29:02 +07:00
Joas Schilling d5df033ede
Create primary keys on all tables and add a command to create the afterwards
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:36:27 +07:00
Morris Jobke 1c496a5a35
Add a background job that checks for potential user imported SSL certificates and shows a warning in the admin settings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 10:06:33 +07:00
nhirokinet 830348dbee
Add SVG support check to setup check
Signed-off-by: nhirokinet <nhirokinet@nhiroki.net>
2020-11-02 11:29:08 +07:00
Roeland Jago Douma 0dbb99a81b
Merge pull request #23161 from nextcloud/enh/noid/setup-checks2
Remove setup check for php mail
2020-10-08 22:40:37 +07:00
Christoph Wurst d9015a8c94
Format code to a single space around binary operators
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +07:00
Daniel Kesselberg 9c8e8007f9
Remove setup check for php mail
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-10-03 21:58:55 +07:00
Arthur Schiwon f959828616
emit typed event for user management
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-08 22:50:05 +07:00
Christoph Wurst 1f7f93a695
Update license headers for Nextcloud 20 (again)
There are still lots of outdated headers, so time for another round of
updates.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-07 14:37:44 +07:00
Roeland Jago Douma 16e1d1cb12
Merge pull request #22136 from nextcloud/design/reasons-to-use-nextcloud
Add 'Reasons to use Nextcloud in your organization' call to action in settings
2020-09-07 08:49:05 +07:00
Jan C. Borchardt 4c48d6bf18
Add 'Reasons to use Nextcloud in your organization' call to action in settings
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2020-09-07 08:30:01 +07:00
John Molakvoæ 593d64d935
Merge pull request #17456 from brad2014/feature/brad2014/12391-improve-imip-mail-message-take-2 2020-09-04 19:53:02 +07:00
Brad Rubenstein 442af8c5d5 Minor cleanup: php-cs-fixer, tests, interface consistency
IMipPlugin.php Removed blank lines to make php-cs-fixer happy.
Minor cleanup:  bugs found by Psalm static checker
IEMailTemplate: The public interface to addBodyListItem also needs to include the new plainIndent parameter.
IMipPlugin: Fixes an undefined variable for events that do not have DTEND.  Also use explicit string conversion for parameters and properties in several places.

The new email template adds an additional blank line before "button" links in plain text, so the tests were fixed to include that additional blank line.

Signed-off-by: Brad Rubenstein <brad@wbr.tech>
2020-09-02 17:54:36 +07:00
Christoph Wurst 2a054e6c04
Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +07:00
Morris Jobke 9e483ea949
Fix unit tests
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 16:35:38 +07:00
Morris Jobke 603d7dab5e
Add setup check that links to the migration documentation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 15:45:45 +07:00
Morris Jobke 234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-12 13:55:19 +07:00
Daniel Kesselberg 89c6a2bc1f
Add setup checks for php default charset and output buffering.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-26 00:54:16 +07:00
Simon Spannagel d5b1297b55 Adjust tests to new e-mail layout
Signed-off-by: Simon Spannagel <simonspa@kth.se>
2020-07-23 20:22:48 +07:00
Roeland Jago Douma fa9dfd83c9
Fix AppFramework services
* We can't just register an alias as the services need the appId to be
  injected. if we just register an alias this blows up since the main
  container doesn't have the appId.
* Moved the Authtokens over to show the PoC works

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-14 16:01:14 +07:00
Joas Schilling 6e46df26a8
Unify settings middleware with others
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 20:18:38 +07:00
Joas Schilling 817eff6cbf
Remove old unit tests as well
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-06 11:11:11 +07:00
Joas Schilling 7dcb1cdb42
Remove controller and routes which have no UI component anyway
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-04 10:41:08 +07:00
Jan-Christoph Borchardt e981669e89
Fix notification mail tests
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
2020-05-01 03:00:42 +07:00
Christoph Wurst cb057829f7
Update license headers for 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +07:00
Roeland Jago Douma 2fc35d10e4
Added trailing space
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-18 10:26:35 +07:00
John Molakvoæ 36f9ad32f2
Merge pull request #20447 from liamjack/fix/13287/welcome_email
Increase max-height on button in welcome email template
2020-04-17 09:42:49 +07:00
Roeland Jago Douma bb4dedb015
Provide the proper language to the mailer
Else we can't properly translate the footer in the recipients e-mail
language.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-16 09:04:13 +07:00
Liam JACK 301335e9e1
Fix #13287 - Increase max-height on button in welcome email template
Signed-off-by: Liam JACK <liamjack@users.noreply.github.com>
2020-04-12 13:07:16 +07:00
Christoph Wurst caff1023ea
Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +07:00
Christoph Wurst f4c09f299d
Make sure there is exactly one newline after imports
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:14:31 +07:00
Christoph Wurst 44577e4345
Remove trailing and in between spaces
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +07:00
Christoph Wurst afbd9c4e6e
Unify function spacing to PSR2 recommendation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +07:00
Christoph Wurst 41b5e5923a
Use exactly one empty line after the namespace declaration
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +07:00
Christoph Wurst 2fbad1ed72
Fix (array) indent style to always use one tab
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +07:00
Joas Schilling bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id
Add optional comments reference_id
2020-04-02 11:34:21 +07:00
Christoph Wurst 1a9330cd69
Update the license headers for Nextcloud 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +07:00
Joas Schilling 720dc4e93d
Add optional column oc_comments.reference_id
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-31 10:51:15 +07:00
Christoph Wurst 463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
Remove unused imports
2020-03-27 17:14:08 +07:00
Christoph Wurst b80ebc9674
Use the short array syntax, everywhere
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +07:00
Christoph Wurst 2ee65f177e
Use the shorter phpunit syntax for mocked return values
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:21:27 +07:00
Christoph Wurst 74936c49ea
Remove unused imports
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +07:00
Roeland Jago Douma 3b26bfe879
Merge pull request #20127 from nextcloud/bugfix/noid/check-user-on-remote-wipe
Check the user on remote wipe
2020-03-24 20:26:52 +07:00
Roeland Jago Douma b0ea022a3e
Add basic reverseproxy misconfig detection to setupchecks
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-03-23 10:37:08 +07:00
Julius Härtl 47271e56ee Fix tests due to config adjustments
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-20 10:46:13 +07:00
Joas Schilling dc7913efcd
Fix recursive calls in logging via server methods
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-18 18:59:49 +07:00
Joas Schilling 9935c71ec3
Check the user on remote wipe
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-16 09:29:28 +07:00
Julius Härtl dbd63222c8
Add system config flag to manually set that a subscription is available
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-10 14:31:27 +07:00
Joas Schilling f464f2313f
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-10 10:14:02 +07:00
Daniel Kesselberg 29fede5fe5
Update test to pass l10n instead of factory
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-02-03 10:31:23 +07:00
Roeland Jago Douma bfaf3fff33
Move Admin Settings also to info.xml
More cleanup of the Settings apps. Makes the manager cleaner and a
proper manager.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-31 16:55:17 +07:00
Roeland Jago Douma c9253cce6c
Move personal settings to proper registration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-30 22:06:28 +07:00
Roeland Jago Douma dc1979903e
Move password settings
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-30 14:03:28 +07:00
Roeland Jago Douma 391a368557
Move the personal 2FA settings to its own app
Small isolated classes are easier to understand and to maintain!
Another step in the cleaning up of the settings. So that adding new
stuff later is easier.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-29 20:37:47 +07:00