0ebd44abb6
Migrate tests of forwarded for headers check
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 11:36:42 +07:00
0107c7ea24
Migrate Forwarded For Headers check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-20 11:36:42 +07:00
fe8b5d47ae
Migrate Bruteforce Throttle check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-13 16:26:59 +07:00
7495236034
Migrate memory_limit check to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-13 15:55:46 +07:00
00d3856b92
Revert "Migrate code integrity to SetupCheck API"
...
This reverts commit aa2d315d95d37b48752d0e92d0ce79913be1d4f1.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:04 +07:00
0fd5ed9854
Migrate 32bit check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +07:00
ac3da13b38
Migrate Freetype check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +07:00
086d3ceecc
Migrate code integrity to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +07:00
147b29fca2
Migrate Randomness secure check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:03 +07:00
ddd13a90d8
Migrate memcache check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:25:02 +07:00
6911dc30e6
Migrated both file locking checks to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +07:00
f9770b8ef2
Remove duplicate fileinfo PHP module check
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +07:00
3c75075eba
Migrate database transaction level check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:03 +07:00
5957a2bf6b
Migrate email test to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +07:00
506f3961ec
Remove duplicated ReadOnlyConfig setup check
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +07:00
dec52f6979
Migrate getenv test to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-11-07 12:14:02 +07:00
d551a0d886
Adapt CheckSetupControllerTest to the migration to a setup check
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-24 15:36:09 +07:00
0c346849f3
Migrate missing PHP modules check to new API and improve it
...
Test all modules listed as required in our documentation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 15:58:45 +07:00
6bc3e008c7
Fix tests for setup checks
...
Had to remove tests for migrated checks, we should add tests for each
SetupCheck class later on.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-19 11:44:02 +07:00
be6c889414
Correct typos and add quotation marks
...
Corrects typos and unifies spelling for "occ" commands.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-10-11 01:51:39 +07:00
0a9371f99f
Migrate applications away from deprecated ILogger
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-21 11:57:21 +07:00
7f11ee8c4a
fix(CardDAV): only run upgrade sync if 1000 users or less
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-26 17:21:50 +07:00
bed3ffb312
feat(admin): Show an error when the admin is throttled
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:40:24 +07:00
ab70bbd3ff
fix(db)!: Remove private legacy event because we can not keep it
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:35 +07:00
925bcebcb6
feat: Add public event for missing indices
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-07-14 13:11:22 +07:00
5a23b429dd
feat: remove check for OpenSSL 1.0.1d and 1.0.2b
...
OpenSSL 1.0.1d: 2013-02-05
OpenSSL 1.0.2b: 2015-06-11
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-04 18:44:47 +07:00
e2ab9bf4af
address review and fix tests
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-18 11:33:53 +07:00
80645a591a
add an admin check for db file locking
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-17 12:51:33 +07:00
0cfbe54a5a
Create headings for settings pages
...
Signed-off-by: julia.kirschenheuter <julia.kirschenheuter@nextcloud.com>
2023-03-07 17:51:19 +07:00
dde5c46a3e
Migrate to Symfony Mailer
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-02 10:30:06 +07:00
b843d09810
Fix typing errors in settings tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-02 15:13:00 +07:00
f9ea078e27
Add unit test for case insensitive email saving
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-12-16 17:47:42 +07:00
e35bcc9381
Fix tests
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 10:06:19 +07:00
68363f6944
Fix some more problems with tests under PHP 8.2
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 16:02:24 +07:00
cf9b1082ed
add a setup check for 64 bit
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-07-13 09:33:33 +07:00
c0c54b20d9
Remove deprecated at() matcher from settings tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-07 10:05:18 +07:00
351357047a
fix drone tests on master
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-03-11 20:45:26 +07:00
3c8f8bc70a
fix tests
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-03-07 18:07:45 +07:00
5ac91f1cb8
Add Nextcloud docs link to OPcache recommends
...
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list.
Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend.
Signed-off-by: MichaIng <micha@dietpi.com>
2022-03-03 23:00:07 +07:00
b28aa52b28
Setup warning for invalid LDAP user or group UUIDs.
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-10 10:15:01 +07:00
fa1ee8f0c7
fix tests
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-02-03 20:41:12 +07:00
82c1beaacb
Enhance and complement OPcache setup checks
...
The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage.
With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used.
The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded.
A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks.
OPcache usage based checks are skipped when Nextcloud is not permitted to use the API.
Signed-off-by: MichaIng <micha@dietpi.com>
2021-12-19 23:38:21 +07:00
c6ae53096c
More test fixing
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 22:17:19 +07:00
e8f7a08e52
ArgumentCountError: Too few arguments to function OCA\Settings\Controller\CheckSetupController::__construct()
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +07:00
24935666e8
PHPUnit\Framework\MockObject\DuplicateMethodException: Cannot stub or mock using a method list that contains duplicates:
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +07:00
19d070850b
Make sure trusted_proxies is an array
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +07:00
facb50ebcc
fix appstoreenabled check in Fetcher so it's coherent with AppSettingsController
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-10-18 12:39:43 +07:00
6958d8005a
Add admin privilege delegation for admin settings
...
This makes it possible for selected groups to access some settings
pages.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-09-29 21:43:31 +07:00
ea4b7bac7a
Issue 16719: CheckSetupController.php: now injecting reference to ITempManager, rather than obtaining using it manually
...
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +07:00
27865d03c0
use specific email getter where necessary
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +07:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
b228e8a361
Fix translation phpunit test
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-02 18:00:45 +07:00
847ed37afc
do not use private AccountManager in UsersController
...
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-25 14:35:38 +07:00
67dd087ce4
Fix deleting properties of user settings when not given explicitly
...
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +07:00
a7431817b9
Respect additional user settings not covered by the controller
...
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.
Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).
This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +07:00
c5e3d2e5c2
Add more unit tests for setting user settings
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +07:00
190ffd75b7
Change default test data to values less similar to empty values
...
Right now it makes no difference, but this should make future tests
clearer, specially in case of failure.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +07:00
ef5d538448
Extract default test data to a helper getter
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +07:00
8cae515daa
Use constants from interface rather than class
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +07:00
5d14fd4396
Make extra user profile fields always editable
...
The fields for phone number, address, website and twitter are now
editable regardless whether federated sharing and the lookup server
are enabled or not.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +07:00
278a73789e
Map old account scope properties to new names
...
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +07:00
07095fd122
Also clear the knownUser when changing via the settings endpoint
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 19:37:10 +07:00
38f761f25f
Move away some ILoggers
...
Makes psalm happier
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 10:47:25 +07:00
7d8e9baa77
Revert "use the configured forwarded headers for the setup check"
2021-02-13 18:03:32 +07:00
01118a2218
use the configured forwarded headers for the setup check
...
instead of always checking against the same header
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-12 14:22:27 +07:00
bffa61fc32
Add setup check to verify that the used DB version is still supported in the next major release
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-08 13:38:32 +07:00
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +07:00
46b073d7ce
Add a config for default region of phone numbers
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +07:00
9e04e6f99a
Also translate the phone number when coming in via the accounts manager API directly
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +07:00
da9462b482
Make code strict
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +07:00
d5df033ede
Create primary keys on all tables and add a command to create the afterwards
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:36:27 +07:00
1c496a5a35
Add a background job that checks for potential user imported SSL certificates and shows a warning in the admin settings
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 10:06:33 +07:00
830348dbee
Add SVG support check to setup check
...
Signed-off-by: nhirokinet <nhirokinet@nhiroki.net>
2020-11-02 11:29:08 +07:00
0dbb99a81b
Merge pull request #23161 from nextcloud/enh/noid/setup-checks2
...
Remove setup check for php mail
2020-10-08 22:40:37 +07:00
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +07:00
9c8e8007f9
Remove setup check for php mail
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-10-03 21:58:55 +07:00
f959828616
emit typed event for user management
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-08 22:50:05 +07:00
1f7f93a695
Update license headers for Nextcloud 20 (again)
...
There are still lots of outdated headers, so time for another round of
updates.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-07 14:37:44 +07:00
4c48d6bf18
Add 'Reasons to use Nextcloud in your organization' call to action in settings
...
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2020-09-07 08:30:01 +07:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +07:00
9e483ea949
Fix unit tests
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 16:35:38 +07:00
603d7dab5e
Add setup check that links to the migration documentation
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 15:45:45 +07:00
234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-12 13:55:19 +07:00
89c6a2bc1f
Add setup checks for php default charset and output buffering.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-26 00:54:16 +07:00
7dcb1cdb42
Remove controller and routes which have no UI component anyway
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-04 10:41:08 +07:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +07:00
44577e4345
Remove trailing and in between spaces
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +07:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +07:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +07:00
bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id
...
Add optional comments reference_id
2020-04-02 11:34:21 +07:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +07:00
720dc4e93d
Add optional column oc_comments.reference_id
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-31 10:51:15 +07:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +07:00
2ee65f177e
Use the shorter phpunit syntax for mocked return values
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:21:27 +07:00
3b26bfe879
Merge pull request #20127 from nextcloud/bugfix/noid/check-user-on-remote-wipe
...
Check the user on remote wipe
2020-03-24 20:26:52 +07:00
b0ea022a3e
Add basic reverseproxy misconfig detection to setupchecks
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-03-23 10:37:08 +07:00
9935c71ec3
Check the user on remote wipe
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-16 09:29:28 +07:00
dbd63222c8
Add system config flag to manually set that a subscription is available
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-10 14:31:27 +07:00
c9253cce6c
Move personal settings to proper registration
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-30 22:06:28 +07:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +07:00
Côme Chilliet
Valdnet
Anna Larch
Joas Schilling
Julius Härtl
Daniel Kesselberg
Simon L
julia.kirschenheuter
Vincent Petry
Carl Schwan
MichaIng
Arthur Schiwon
Julien Veyssier
Stefan
John Molakvoæ (skjnldsv)
Daniel Calviño Sánchez
Roeland Jago Douma
Roeland Jago Douma
Robin Appelman
Morris Jobke
Christoph Wurst
nhirokinet
Jan C. Borchardt
Joas Schilling