Vincent Petry
cd21caf846
Merge pull request #34067 from nextcloud/timm2k-patch-1
...
Convert file_metadata.id from int(11) to bigint(20)
2022-09-15 14:03:30 +07:00
Vincent Petry
da01494a37
Add accessibility entry in user menu
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-09-14 15:05:35 +07:00
timm2k
0c407b58db
Update CheckSetupController.php
...
file_metadata.id needs to be bigint(20).
Signed-off-by: timm2k <timm2k@gmx.de>
2022-09-14 10:10:12 +07:00
Joas Schilling
7d6d65600e
Fix twofactor provider icons in dark mode
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-09-13 17:50:25 +07:00
Carl Schwan
ff49fa4415
Merge pull request #29881 from nextcloud/fix/setting/accessibility-title
...
Improve accessibility of the title of the settings
2022-09-06 16:56:14 +07:00
Simon L
6132b6a4ae
Merge pull request #33790 from nextcloud/Valdnet-patch-2
...
l10n: Spelling unification
2022-09-02 17:01:52 +07:00
Valdnet
d9399e1246
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
l10n: Change to administration
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
l10n: Spelling unification
Spelling unification in Transifex.
Match the menu name to the header name of the settings page.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-09-02 12:42:07 +07:00
Carl Schwan
2397ea7219
Merge branch 'master' into fix/setting/accessibility-title
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-09-02 12:05:51 +07:00
Christopher Ng
f44d2586b1
Remake profile picture saving with Vue
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-02 02:22:57 +07:00
Christopher Ng
98bc98ac98
Add profile config migration
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-09-01 15:27:37 +07:00
Carl Schwan
9689f734e8
Merge pull request #33429 from nextcloud/port-password-vue
...
Port password settings to vue
2022-08-31 20:47:25 +07:00
Carl Schwan
60c42914d8
Port password settings to vue
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-31 17:42:36 +07:00
szaimen
955b6bb82e
add a way to open the admin settings overview directly
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-08-30 15:46:09 +07:00
Christopher Ng
d7821f8474
Remake phone number property saving with Vue
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-08-26 23:49:27 +07:00
Christopher Ng
e2efbab13f
Remake website property saving with Vue
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-08-26 18:50:28 +07:00
Christopher Ng
dd7cb9784f
Remake location property saving with Vue
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-08-25 23:52:33 +07:00
Christopher Ng
09f6eb5e58
Remake Twitter handle saving with Vue
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-08-25 18:19:10 +07:00
Christopher Ng
c5c70daa66
Modularize shared account property components
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-08-25 18:08:39 +07:00
Arthur Schiwon
1a781ccf56
Fix opening Help page throws Exception
...
- Commit 458c2fa297 provoked the error,
because the "core" "app" was not found. Previously, false was
returned, but now an AppPathNotFoundException
- IUrlGenerator::linkTo() accepts an empty app argument however, moving
the "core" portion to the path solves it and avoids apps lookup
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-08-24 18:55:34 +07:00
Joas Schilling
7e11778190
Use user name cache in activity providers
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-19 10:48:32 +07:00
Christopher Ng
34308087d6
Consolidate account property getters
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-07-21 01:14:23 +07:00
Simon L
9dbcf0560f
Merge pull request #33200 from nextcloud/enh/noid/64bit
...
add a setup check for 64 bit
2022-07-13 20:19:40 +07:00
Carl Schwan
4e0574e184
Port encryption admin settings to vue
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-13 14:58:55 +07:00
szaimen
cf9b1082ed
add a setup check for 64 bit
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-07-13 09:33:33 +07:00
Carl Schwan
f99a06c89a
Don't allow setting password bigger than 469 characters
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-05 11:47:25 +07:00
Louis Chemineau
347ca20f4e
Rename setting name to reduce its length
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-06-27 11:04:17 +07:00
szaimen
f8bebb62ca
do not display the buffer_size info if the size is already set to a certain threshold
...
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
2022-06-17 22:15:28 +07:00
Valdnet
dfe7243338
l10n: Delete apostrophe
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-06-07 16:41:38 +07:00
Valdnet
1bc6fb2c58
l10n: Change to a capital letter
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-06-03 09:34:15 +07:00
Christopher Ng
57c66bf7cb
Use Image class from public API
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-06-02 00:37:36 +07:00
Christopher Ng
f2850a6c06
Skip avatar on failure
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-05-30 17:49:05 +07:00
Christopher Ng
432bc9a585
Update method name
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-05-30 17:49:05 +07:00
Côme Chilliet
6da413f7af
Move new IMigrator method to a specific interface ISizeEstimationMigrator
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-30 07:36:13 +07:00
Côme Chilliet
09917b8583
Implement getExportEstimatedSize in migrators
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-05-30 07:36:13 +07:00
Pytal
e647b9fa49
Merge pull request #32443 from nextcloud/port/background-job-admin
2022-05-20 09:58:13 +07:00
Carl Schwan
697b83bf50
Merge pull request #32501 from nextcloud/cleanup/admin-delegation-setting
...
Cleanup admin delegation setting page
2022-05-20 18:55:18 +07:00
Carl Schwan
e8e0f97c9a
Port BackgroundJob admin settings to vue
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 15:00:54 +07:00
Carl Schwan
9d5a542a4e
Improve two factor admin settings
...
- Port more of it to vue
- Use new nextcloud vue components for the setting section
- Add a bit of spacing between the elements
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 13:27:55 +07:00
Carl Schwan
4f4d777767
Cleanup admin delegation setting page
...
- Simplify code a bit
- Add link to doc
- Use Nextcloud vue component a bit more
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-19 18:15:41 +07:00
Carl Schwan
046d5451b1
Improve accessibility of the title of the settings
...
Before every setting page had the same title and this is causing issues
for screenreaders since they can't differenciate the title of page. Now
a new variable is available for apps to declare the page subtitle.
This new variable is implemented for the settings app and while at it I
added a bit more type hinting to the stuff I touched :)
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-16 22:47:37 +07:00
szaimen
c6f3fe99f4
adjust wording for database checks
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-05-16 19:22:23 +07:00
blizzz
0284c0f717
Merge pull request #32276 from nextcloud/fix/ldap_error_handling
...
Do not dispatch postSetPassword when setPassword fails
2022-05-05 20:19:28 +07:00
Louis Chemineau
8a2cf5bb68
Do not dispatch postSetPassword when setPassword fails
...
Also Improve error message when setPassword fails
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-05 17:21:23 +07:00
Louis Chemineau
80fa3c7319
Add setting to ignore email during search
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-05-03 17:50:29 +07:00
rakekniven
d2830612d0
l10n: Improve grammar
...
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-04-27 08:19:19 +07:00
Christopher Ng
0924271abe
Catch avatar export separately for better failure tracing
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-13 17:02:25 +07:00
Côme Chilliet
0fd72f4355
Adapt existing migrators to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-04-13 16:52:40 +07:00
Louis Chemineau
37f1c8640e
Add settings to ignore second display name in search
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-04-12 17:27:59 +07:00
Côme Chilliet
dda51d49d7
Use Migrators id instead of class names
...
This will help with UI and means migrators can move in namespaces
without changing export format.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-04-11 13:59:27 +07:00
Vincent Petry
cde260577e
Merge pull request #31857 from nextcloud/feat/dont_match_userid
...
Add settings to not match userID during full match
2022-04-11 10:27:59 +07:00
Christopher Ng
087b75217e
Extend account migrator
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-04-08 19:31:22 +07:00
Louis Chemineau
0e06ee68c0
Add settings to not match userID during full match
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-04-06 15:41:41 +07:00
Vincent Petry
b8b4d247b4
Merge pull request #31194 from nextcloud/feat/allow-to-exclude-groups-from-password-enforcement
...
Allow to disable password policy enforcement for selected groups
2022-04-06 10:13:23 +07:00
Carl Schwan
a29251e02d
Allow to disable password policy enforcement for selected groups
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-04-05 17:04:17 +07:00
Vincent Petry
4511bd4bf6
Merge pull request #30950 from nextcloud/enh/opcache-recommends-translation
...
Add OPcache recommendations to Transifex
2022-03-24 17:56:09 +07:00
Joas Schilling
a0c7798c7d
Limit the length of app password names
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-23 10:47:56 +07:00
MichaIng
31606c9861
Add OPcache recommendations to Transifex
...
Fixes: https://github.com/nextcloud/server/issues/30941
Signed-off-by: MichaIng <micha@dietpi.com>
2022-03-22 10:42:51 +07:00
Christopher Ng
85123f9d36
Move data into settings folder
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-22 03:22:10 +07:00
Christopher Ng
ad31cfe72d
Use account method to set all properties
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 04:51:26 +07:00
Christopher Ng
bf79b97718
Use streams
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 04:51:26 +07:00
Christopher Ng
e5a205fec1
Transfer to settings app and register
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 04:51:26 +07:00
Christopher Ng
108abd77ed
Add profile default setting for admin
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 02:55:12 +07:00
Christopher Ng
1fc0b4320c
Add global profile toggle config
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-18 02:55:12 +07:00
Joas Schilling
a6882deebc
Differenciate the activity depending on admin vs user action
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 15:26:47 +07:00
Simon L
3a0b934f84
Merge pull request #31430 from nextcloud/enh/31429/improve-overwrite-cli-url-check
...
Validate `overwrite.cli.url` to be a url in setup check
2022-03-10 12:40:59 +07:00
szaimen
4191a178dd
improve overwrite cli url setup check
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-03-09 22:26:00 +07:00
John Molakvoæ
23e8ae15aa
Merge pull request #31470 from nextcloud/enh/13099/allow-disable-imagick-warning
2022-03-08 08:53:12 +07:00
szaimen
7dca146b58
allow to disable the imagick warning
...
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
2022-03-07 17:35:12 +07:00
Julien Veyssier
d5574cf189
allow adding protocol to domains in 'connectivity_check_domains' config
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-03-07 14:13:11 +07:00
MichaIng
3980322621
Merge pull request #31267 from nextcloud/enh/docs-link-for-opcache-recommends
...
Add Nextcloud docs link to OPcache recommends
2022-03-04 01:24:10 +07:00
MichaIng
5ac91f1cb8
Add Nextcloud docs link to OPcache recommends
...
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list.
Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend.
Signed-off-by: MichaIng <micha@dietpi.com>
2022-03-03 23:00:07 +07:00
Mickey Knox
f63eb4261f
Fix permittedPath comparison
...
Signed-off-by: Mickey Knox <mickey@netfreaks.org>
2022-03-02 22:38:11 +07:00
Carl Schwan
7c8a901b84
Cleanup admin settings js files
...
* Move admin.js to webpack, so that this use the bundled jquery files
instead of the deprecated window.$ Also fixing formatting
* Remove log.js that seems to be from a time where logreader was bundled
with server and I couldn't find an usage of it anymore
* Fix recent regression in rebuild navigation function (now not depending on
jquery anymore and bundled by webpack).
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-17 17:52:03 +07:00
Vincent Petry
713840ccc0
Merge pull request #31032 from nextcloud/instanceName
...
Don't use plain URL on the email subject
2022-02-10 18:07:50 +07:00
Arthur Schiwon
b28aa52b28
Setup warning for invalid LDAP user or group UUIDs.
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-10 10:15:01 +07:00
acsfer
e48726704d
Don't use plain URL on the subject
...
Many servers classify emails with plain URLs on subject as spam, or can event reject/discard it completely. Don't use it and display Instance Name instead.
`550 5.2.0 GIuMngdpZqS9h Mail rejected. OFR_506 [506]`
2022-02-06 13:38:52 +07:00
szaimen
84cf39f582
show if the mail server settings are not set or verified
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-02-03 20:16:35 +07:00
Carl Schwan
89d109a4d9
Merge pull request #30508 from nextcloud/fix/psaml-bin
...
Fix psalm not running
2022-01-13 09:51:04 +07:00
Carl Schwan
aeecb72e96
Fix a few psalm issues and moved back to psalm/phar 4.18
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-12 20:03:06 +07:00
MichaIng
79cdb565dc
Avoid zero division in setup checks
...
Fixes: https://github.com/nextcloud/server/issues/30532
Signed-off-by: MichaIng <micha@dietpi.com>
2022-01-11 10:26:57 +07:00
MichaIng
82c1beaacb
Enhance and complement OPcache setup checks
...
The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage.
With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used.
The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded.
A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks.
OPcache usage based checks are skipped when Nextcloud is not permitted to use the API.
Signed-off-by: MichaIng <micha@dietpi.com>
2021-12-19 23:38:21 +07:00
Joas Schilling
19d070850b
Make sure trusted_proxies is an array
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +07:00
Christopher Ng
50a6612c1f
Refine profile backend for frontend visibility requirements
...
- Provide metadata
- Dynamic displayId
- Add appId
- Filter out unused parameter config properties from the existing profile config
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-11-04 00:17:29 +07:00
Vitor Mattos
6f7ca3432c
show warning on personal settings page
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2021-10-23 00:54:51 +07:00
Vitor Mattos
e55ceb2bb1
Show warning on admin settings page
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2021-10-23 00:54:50 +07:00
John Molakvoæ
b2c32b7e6c
Merge pull request #27731 from ZitronePlus/master
2021-10-22 12:04:07 +07:00
John Molakvoæ
c98039c1df
Merge pull request #26725 from nextcloud/fix-federated-scope-not-shown-when-public-addressbook-upload-is-disabled
2021-10-22 11:52:56 +07:00
Julien Veyssier
0bef570fe9
Merge pull request #29256 from nextcloud/fix/noid/harmonize-appstoreenabled-check
...
Fix appstoreenabled check
2021-10-21 12:42:14 +07:00
Pytal
f7b3d521f8
Merge pull request #28751 from nextcloud/feat/28139/profile-page
2021-10-18 23:03:58 +07:00
Christopher Ng
309354852f
Profile backend
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-10-19 04:59:35 +07:00
Christoph Wurst
f432dd2e2e
Add scheduling availability settings
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-18 20:21:51 +07:00
Julien Veyssier
facb50ebcc
fix appstoreenabled check in Fetcher so it's coherent with AppSettingsController
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-10-18 12:39:43 +07:00
Christoph Wurst
4b8f8c5203
Deprecate PHP7.3 for Nextcloud 23
...
* 7.3 reaches EOL shortly after the release of 23.0.0
* Nextcloud 24 will require PHP7.4
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-18 09:15:54 +07:00
Bjoern Schiessle
664bd5802f
add 'supported'-label to all supported apps, also if they are not downloaded yet
...
Signed-off-by: Bjoern Schiessle <bjoern@schiessle.org>
2021-10-06 22:17:50 +07:00
Joas Schilling
0dae8805c2
Improve icon and section title of "Admin privileges"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2021-10-06 19:13:16 +07:00
Carl Schwan
6958d8005a
Add admin privilege delegation for admin settings
...
This makes it possible for selected groups to access some settings
pages.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-09-29 21:43:31 +07:00
szaimen
d253d52007
Merge pull request #28837 from nextcloud/show-warning-if-sharing-app-disabled
...
Show warning on the share settings when the File Shares app is disabled
2021-09-20 12:11:42 +07:00
szaimen
3eb1d23720
Merge pull request #28838 from stefan-schilling/enh/16719-integrity-check-temp-dir
...
Issue 16719: CheckSetupController.php now checks configured temporary directory for existence and if it's writable
2021-09-17 18:19:22 +07:00
Stefan
eb46011680
Issue 16719: CheckSetupController.php: now injecting reference to ITempManager, rather than obtaining using it manually
...
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +07:00
Stefan
8758b36ebb
Issue 16719: CheckSetupController.php now checks configured temporary directory for existence and if it's writable
...
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +07:00
Thomas Citharel
b3c7927260
Show warning on the share settings when the File Shares app is disabled
...
Closes #3706
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2021-09-15 16:33:03 +07:00
Arthur Schiwon
d93e2548f0
only offer to set locally verified mails as primary
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-15 15:38:49 +07:00
Arthur Schiwon
fe5e672654
let user choose notification email in user settings
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-15 15:38:40 +07:00
Arthur Schiwon
27865d03c0
use specific email getter where necessary
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +07:00
Christoph Wurst
506b411dfc
Merge pull request #28332 from nextcloud/work/carl/argon2i2
...
Only recommand for php-sodium on >= PHP 7.4
2021-08-31 08:59:27 +07:00
Christopher Ng
cc5815dcd0
Provide initial state
...
- camelCase language strings
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-08-27 05:06:12 +07:00
Christopher Ng
d4d59493a2
Provide initial state
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-08-23 21:29:47 +07:00
Daniel Calviño Sánchez
1e19b1cc99
Hide "federated" scope when Federation app is disabled
...
If the Federation app is disabled it is not possible to synchronize the
users from a different server.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-08-18 19:56:10 +07:00
Julius Härtl
f49a751283
Do not retain VerifyUserData job when lookup server is not available
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-08-17 11:39:24 +07:00
Carl Schwan
07ccccecad
Only recommand for php-sodium on >= PHP 7.4
...
This is because php-sodium will solve the missing PASSWORD_ARGON2I
constant problem only on >= php 7.4, previously argon2 wasn't part of
the standard extension and was disabled on Centos/RHEL.
So installing php-sodium on php 7.2 for example wouldn't hide the
message. Tested on Fedora with php 7.4, Centos 7 with php 7.2,
Centos 8 with php 7.2 and openSUSE with php 7.4.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-08-06 14:22:09 +07:00
Christoph Wurst
43e41ca532
Merge pull request #28259 from nextcloud/work/carl/sodium-check
...
Check that php was compiled with argon2 support or that the php-sodium extensions is installed
2021-07-30 17:34:10 +07:00
Carl Schwan
8e51a5feda
Check that php was compiled with argon2 support or that the php-sodium
...
extensions is installed
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-07-30 15:11:55 +07:00
Julien Veyssier
416d10f76c
refs #21045 add app config to disable unlimited quota and to set max quota
...
avoid unlimited quota as default_quota fallback value if unlimited quota is not allowed
avoid getting/setting/displaying unlimited default quota if not allowed
implement tests for unlimited quota restrictions
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-07-29 19:31:36 +07:00
Marco Ambrosini
a4d1c55624
Allow to disable group change notification
...
Signed-off-by: Marco Ambrosini <marcoambrosini@pm.me>
2021-07-28 12:23:47 +07:00
Joas Schilling
f86f594a3a
Merge pull request #27860 from J0WI/alphanumeric-rnd
...
Introduce ISecureRandom::CHAR_ALPHANUMERIC
2021-07-16 12:46:20 +07:00
Christopher Ng
74aa115125
Refine unsupported federation scope checks
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-07-16 05:46:04 +07:00
Christopher Ng
ef41d5977a
Provide initial state
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-07-15 10:16:06 +07:00
J0WI
3b656446af
Introduce ISecureRandom::CHAR_ALPHANUMERIC
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-07-08 15:11:31 +07:00
Gary Kim
b78f3a57d1
Migrate HintException to OCP
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 +07:00
ZitronePlus
1d0a40a4a6
Fix for #26526
...
fix for sql query
replaced double quotes with single quotes.
Query should now also work for dbs with sql_mode including "ANSI" and "ANSI_QUOTES"
2021-06-30 14:52:48 +07:00
Lukas Reschke
25ab4059c6
Add security.txt
...
Ref https://securitytxt.org
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-23 13:58:47 +07:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
Valdnet
9c6b01abeb
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-06-02 17:49:32 +07:00
Arthur Schiwon
847ed37afc
do not use private AccountManager in UsersController
...
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-25 14:35:38 +07:00
Morris Jobke
f1dbabd910
Merge pull request #26727 from nextcloud/group-exclude-link-share
...
Add option to exclude groups from creating link shares
2021-05-21 15:35:39 +07:00
Roeland Jago Douma
4a2775a442
Harden apptoken check
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-17 16:05:45 +07:00
blizzz
b8b2e796bf
Merge pull request #26959 from nextcloud/techdebt/noid/verifiyuserdata-iaccountmanager
...
VerifyUserData shall use IAccountManager, not private API
2021-05-12 23:35:39 +07:00
Arthur Schiwon
9977027321
VerifyUserData shall use IAccountManager, not private API
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 22:57:20 +07:00
Arthur Schiwon
a49588bbe5
PersonalInfo settings to use public AccoutManager API
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 22:55:34 +07:00
Robin Appelman
0e6321957d
allow excluding groups from creating link shares
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:31 +07:00
Joas Schilling
aa651fd629
Merge pull request #26259 from nextcloud/feature/noid/validate-website-to-be-valid
...
Validate the website field input to be a valid URL
2021-04-26 13:56:01 +07:00
Daniel Calviño Sánchez
67dd087ce4
Fix deleting properties of user settings when not given explicitly
...
The controller can receive an optional subset of the properties of the
user settings; values not given are set to "null" by default. However,
those null values overwrote the previously existing values, so in
practice any value not given was deleted from the user settings. Now
only non null values overwrite the previous values.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +07:00
Daniel Calviño Sánchez
ac0c18327e
Fix TypeError when "email" is not given in the controller request
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +07:00
Daniel Calviño Sánchez
a7431817b9
Respect additional user settings not covered by the controller
...
"AccountManager::updateUser()" wipes previous user data with whichever
user data is given (except for some adjustments, like resetting the
verified status when needed). As the controller overrode the properties
those properties would lose some of their attributes even if they are
not affected by the changes made by the controller. Now the controller
only modifies the attributes set ("value" and "scope") to prevent that.
Note that with this change the controller no longer removes the
"verified" status, but this is not a problem because, as mentioned,
"AccountManager::updateUser()" resets them when needed (for example,
when the value of the website property changes).
This change is a previous step to fix overwritting properties with null
values, and it will prevent the controller from making unexpected
changes if more attributes are added in the future.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:41 +07:00
Daniel Calviño Sánchez
8cae515daa
Use constants from interface rather than class
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:40 +07:00
Joas Schilling
d80cc76ee7
Validate the website field input to be a valid URL
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 16:34:13 +07:00
Morris Jobke
3e7f7e5f9b
Merge pull request #26474 from nextcloud/caugner-patch-mariadb-in-mysql-support-warning
...
Mention MariaDB in MySQL support warning
2021-04-21 16:26:37 +07:00
Vincent Petry
af61486aea
Separate settings for remote share expiration
...
Added separate settings for default and enforced expiration date for
remote shares.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +07:00
Claas Augner
17963ea089
Mention MariaDB in MySQL support warning
2021-04-09 12:31:16 +07:00
Roeland Jago Douma
bd2e6309b5
Merge pull request #25605 from nextcloud/trusted-proxy-warning-localhost
...
dont show trusted proxy warning when the proxy and remote are both localhost
2021-04-01 13:27:26 +07:00
Vincent Petry
5d14fd4396
Make extra user profile fields always editable
...
The fields for phone number, address, website and twitter are now
editable regardless whether federated sharing and the lookup server
are enabled or not.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +07:00
Vincent Petry
278a73789e
Map old account scope properties to new names
...
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +07:00
Joas Schilling
61ed57b757
Rename some parameters and methods to make the API more clear
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 20:30:29 +07:00
Joas Schilling
07095fd122
Also clear the knownUser when changing via the settings endpoint
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 19:37:10 +07:00
Joas Schilling
5b53b6f977
Add a setting to restrict returning a full match unless in phonebook or same group
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:25:57 +07:00
Joas Schilling
b71268e38b
Add a config setting to restrict autocompletion to phonebook matches
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-10 17:19:55 +07:00
Roeland Jago Douma
e44be839bb
Fix some types in the Settings Personal pages
...
* Fix types
* Typed the code
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 11:05:41 +07:00
Joas Schilling
f92d21e80e
Merge pull request #25870 from nextcloud/techdept/settings/move_group_activity_events
...
Move group activities to events
2021-03-05 13:05:06 +07:00
Roeland Jago Douma
f492a6aac3
Move group activities to events
...
Use the fancy events.
Nicer code
Nicely isolated code
win-win
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-03 11:33:33 +07:00
Roeland Jago Douma
bc961baa40
Move some settings over to the IInitialState
...
The old one has been deprecated. Part one of many.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 21:11:56 +07:00
Roeland Jago Douma
2afa1c5739
Merge pull request #25862 from nextcloud/techdept/psalm/some_loggers
...
Move away some ILoggers
2021-03-02 15:01:44 +07:00
Lukas Reschke
41dc18342f
Merge pull request #25854 from nextcloud/techdept/psalm/checksetupcontroller
...
Fix lying docblocks
2021-03-02 13:33:21 +07:00
Roeland Jago Douma
38f761f25f
Move away some ILoggers
...
Makes psalm happier
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 10:47:25 +07:00
Christoph Wurst
7be2ce82e7
Merge pull request #25544 from nextcloud/refactor/app-password-created-event
...
Move app_password_created to a typed event
2021-03-02 08:18:59 +07:00
Roeland Jago Douma
3d0dff0d2b
Fix lying docblocks
...
* typed the return
* removed unneeded temp variable
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 16:48:04 +07:00
dependabot-preview[bot]
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
...
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard ) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases )
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +07:00
Roeland Jago Douma
bd8b1786c5
Some psalm fixes in the settings app
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-15 10:00:35 +07:00
Roeland Jago Douma
7d8e9baa77
Revert "use the configured forwarded headers for the setup check"
2021-02-13 18:03:32 +07:00
Robin Appelman
01118a2218
use the configured forwarded headers for the setup check
...
instead of always checking against the same header
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-12 14:22:27 +07:00
Robin Appelman
cc0cc68c8d
dont show trusted proxy warning when the proxy and remote are both localhost
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-12 13:32:51 +07:00
Christoph Wurst
f8808e260d
Move app_password_created to a typed event
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-09 18:49:35 +07:00
Christoph Wurst
378f116a63
Do not show 2FA settings if the user has no providers available
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-22 13:55:22 +07:00
Christoph Wurst
c1d4f8161b
Migrate internal classes to the OCP db col types
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 14:09:13 +07:00
Vincent Petry
eeac11a687
Fix casing of MySQLPlatform class name
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-01-12 09:39:59 +07:00
Roeland Jago Douma
6c8f2dc7bc
Merge pull request #25016 from nextcloud/enh/noid/add-check-for-unsupported-db
...
Add setup check to verify that the used DB version is still supported…
2021-01-11 14:21:42 +07:00
Morris Jobke
24d436cb60
Remove unneeded casts that were found by Psalm
...
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521 )
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-11 13:14:41 +07:00
Morris Jobke
bffa61fc32
Add setup check to verify that the used DB version is still supported in the next major release
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-08 13:38:32 +07:00
Christoph Wurst
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +07:00
Julius Härtl
068e3b2c1e
Set the user language when adding the footer
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-07 15:31:55 +07:00
Julius Härtl
abfb72378f
Hide client link in welcome mail if an empty customclient_desktop config is set
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-01-07 10:45:54 +07:00
Christoph Wurst
90d0732828
Fix updating user settings
...
The requests dispatched from the personal settings page don't always
send all the possible params but just a subset. Hence requests currently
fail on master e.g. when you update your email. This makes the arguments
optional again.
Regression of da9462b482
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-05 12:59:50 +07:00
Christoph Wurst
9ce3ea3368
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-30 14:07:05 +07:00
Roeland Jago Douma
adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net
...
Unify links to php.net
2020-12-22 09:53:31 +07:00
Christoph Wurst
f37e150d1c
Merge pull request #24702 from nextcloud/enhancement/well-known-handler-api
...
Add well known handlers API
2020-12-18 13:34:04 +07:00
Christoph Wurst
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +07:00
Christoph Wurst
6995223b1e
Add well known handlers API
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 13:13:05 +07:00
Joas Schilling
96253c7c1b
Add missing parent::__construct() calls to Jobs
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-14 16:35:12 +07:00
Julius Härtl
a0444bc69c
Merge pull request #24247 from nextcloud/bugfix/noid/ocm-providerId-string
2020-12-09 17:25:59 +07:00
Julius Härtl
8f6c2ec357
Move columns to bigint
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-08 16:05:53 +07:00
Joas Schilling
f648635758
Make the throwing optional, so background tasks don't break
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +07:00
Joas Schilling
46b073d7ce
Add a config for default region of phone numbers
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +07:00
Joas Schilling
9e04e6f99a
Also translate the phone number when coming in via the accounts manager API directly
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +07:00
Joas Schilling
efe79f2937
Validate and standardize the phone number on saving
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +07:00
Joas Schilling
c2913f18d2
Also return the phone number and twitter handle on the API
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +07:00
Joas Schilling
da9462b482
Make code strict
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:37 +07:00
Morris Jobke
fe79a1ad3e
Harden setup check for TLS version if host is not reachable
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-12-02 13:17:05 +07:00
Roeland Jago Douma
6166e1a157
Use proper OCP\BackgroundJobs\Job
...
And typehunt the IJobList
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-11-25 15:03:06 +07:00
Vincent Petry
2143f2bb82
Set up FS before querying storage info in settings
...
The personal info section of the personal settings is querying the
storage quota information. For this it requires the FS to be setup which
is not always guaranteed.
This fixes an issue where refreshing the settings page would cause it to
fail after Redis caches are full. It is likely that when Redis cache is
populated, some code path is initializing the FS, so it works so far.
But when the cache is populated, that code path is skipped so the FS is
not guaranteed to be setup...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2020-11-13 17:06:37 +07:00
Joas Schilling
d5df033ede
Create primary keys on all tables and add a command to create the afterwards
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:36:27 +07:00
Morris Jobke
a223f603f9
Simplify the check if admin can change password based on encryption status
...
Found by Psalm:
```
/home/runner/work/server/server/apps/settings/lib/Controller/UsersController.php:324:8:error - RedundantCondition: Type true for $isEncryptionModuleLoaded is never falsy
```
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-05 22:20:34 +07:00
Morris Jobke
9435ec2b4e
Remove unneeded service - found by Psalm
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 10:06:33 +07:00
Morris Jobke
1c496a5a35
Add a background job that checks for potential user imported SSL certificates and shows a warning in the admin settings
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 10:06:33 +07:00
nhirokinet
830348dbee
Add SVG support check to setup check
...
Signed-off-by: nhirokinet <nhirokinet@nhiroki.net>
2020-11-02 11:29:08 +07:00
Morris Jobke
e2e7c2d014
Document settings BeforeTemplateRenderedEvent
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-29 11:15:31 +07:00
Morris Jobke
b8ed997238
Remove ISection in favor of IIconSection
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-10-28 23:05:00 +07:00
Roeland Jago Douma
28d82394f1
Merge pull request #23720 from nextcloud/lowercase-email
...
save email as lower case
2020-10-27 20:14:43 +07:00
Robin Appelman
cbd6e65678
save email as lower case
...
email addresses are case insensitive
Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-10-27 14:56:52 +07:00
timm2k
60efad45cf
Update CheckSetupController.php
2020-10-26 09:42:01 +07:00
Roeland Jago Douma
0dbb99a81b
Merge pull request #23161 from nextcloud/enh/noid/setup-checks2
...
Remove setup check for php mail
2020-10-08 22:40:37 +07:00
Christoph Wurst
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +07:00
Daniel Kesselberg
9c8e8007f9
Remove setup check for php mail
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-10-03 21:58:55 +07:00
J0WI
68ce17e59b
Unify links to php.net
...
Update all links to https://www.php.net/
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2020-09-17 17:40:04 +07:00
Roeland Jago Douma
05edd1e5d6
Merge pull request #22890 from nextcloud/techdebt/18680/help-static-code-analysis-understand-code
...
Help static code analysis to understand code
2020-09-17 08:51:20 +07:00
Daniel Kesselberg
096fe20611
Help static code analysis to understand code.
...
It adds proper type hints to private namespace to allow private namespace methods.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-09-16 16:37:17 +07:00
Morris Jobke
d3680e682a
Remove not needed semicolon and PHPDoc hint
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-16 16:18:43 +07:00
Arthur Schiwon
f959828616
emit typed event for user management
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-09-08 22:50:05 +07:00
Morris Jobke
0e6344f543
Merge pull request #22650 from nextcloud/fix/noid/fix-psalm-warning
...
Only load viewer in settings if the viewer app is enabled
2020-09-07 20:41:49 +07:00
Morris Jobke
ce1e873a0a
Only load viewer in settings if the viewer app is enabled
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-09-07 20:25:57 +07:00
Christoph Wurst
1f7f93a695
Update license headers for Nextcloud 20 (again)
...
There are still lots of outdated headers, so time for another round of
updates.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-07 14:37:44 +07:00
Jan C. Borchardt
4c48d6bf18
Add 'Reasons to use Nextcloud in your organization' call to action in settings
...
Signed-off-by: Jan C. Borchardt <hey@jancborchardt.net>
2020-09-07 08:30:01 +07:00
Julius Härtl
7a1748e6f0
Show changelog in apps management
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-09-03 19:16:13 +07:00
Christoph Wurst
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +07:00
Joas Schilling
b09620651c
Don't use deprecated getIniWrapper() anymore
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-20 16:35:38 +07:00
Morris Jobke
da584462d1
Merge pull request #22018 from nextcloud/bugfix/noid/harden-key-generation
...
Harden SSE key generation
2020-08-19 20:42:34 +07:00
Morris Jobke
603d7dab5e
Add setup check that links to the migration documentation
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 15:45:45 +07:00
Morris Jobke
d7f66c36ac
Fix "misplaced variables" warning of Psalm in PHPDoc statements
...
Ref #21787
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-17 17:46:57 +07:00
Julius Härtl
36cfdd320b
Harden key generation
...
There might be cases where multiple requests trigger the key generation
at the same time and the instance ends up with a non-fitting
public/private key pair. Therefore the whole key generation should be
locked. Other than that this makes sure that user key generation return
values are properly validated.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-14 07:58:40 +07:00
Morris Jobke
93ba8faabc
Fix name of app config option to properly reflect what it does
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-13 13:34:31 +07:00
Morris Jobke
53fab3fe5f
Add app config option to disable "Email was changed by admin" email
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-12 12:27:43 +07:00
blizzz
326a04d12c
Merge pull request #22004 from nextcloud/enh/noid/setup-checks-php
...
Add setup checks for php default charset and output buffering.
2020-08-07 20:55:04 +07:00
Morris Jobke
2aa6256f38
Merge pull request #22102 from nextcloud/feature/noid/app-navigation-via-unified-search
...
App navigation via unified search
2020-08-05 22:53:03 +07:00
John Molakvoæ (skjnldsv)
d2c0569b49
Fix search providers order and IDs
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-05 17:57:17 +07:00
Joas Schilling
99fbaa9cba
Very top of the tops
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-05 17:51:18 +07:00
Joas Schilling
5be04942e7
Hide navigation links which dont lead anywhere (looking at you user status)
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-05 17:50:20 +07:00
Joas Schilling
fcdd702040
App navigation via unified search
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-05 16:42:36 +07:00
Joas Schilling
ea8f68bea6
Hand in the route and the parameters of the request
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-08-05 12:52:16 +07:00
John Molakvoæ (skjnldsv)
d98f7c1bd8
Make apps handle the order logic
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-05 11:37:45 +07:00
John Molakvoæ (skjnldsv)
71b62c4203
Show mime icon, bump bundles, make the SearchResultEntry class non-abstract, Fix header search icon, various fixes
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-08-04 21:36:22 +07:00
Joas Schilling
5d41a3f9a2
Add settings sections to unified search
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-03 17:03:06 +07:00
Daniel Kesselberg
89c6a2bc1f
Add setup checks for php default charset and output buffering.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-26 00:54:16 +07:00
Morris Jobke
7870ca0663
Use the proper IAppContainer and IServerContainer type hints to know which code runs with which container
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-21 20:44:05 +07:00
Christoph Wurst
91e7f12088
Adjust apps' code to use the ContainerInterface
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-21 20:43:18 +07:00
Christoph Wurst
090a54adab
Migrate settigns to the PSR container
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-16 15:55:04 +07:00
Morris Jobke
2ad95feab6
Merge pull request #21816 from nextcloud/techdebt/noid/federatedfilesharing-to-ibootstrap
...
Use IBootstrap for the app federatedfilesharing
2020-07-14 20:44:05 +07:00
Morris Jobke
7e281a07bb
Use IBootstrap for the app federatedfilesharing
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-07-14 16:34:43 +07:00
Roeland Jago Douma
fa9dfd83c9
Fix AppFramework services
...
* We can't just register an alias as the services need the appId to be
injected. if we just register an alias this blows up since the main
container doesn't have the appId.
* Moved the Authtokens over to show the PoC works
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-07-14 16:01:14 +07:00
Morris Jobke
54d36c047b
Merge pull request #21741 from nextcloud/debt/noid/url-generator-does-not-implement-i-user-session
...
Fix type for $urlGenerator
2020-07-08 09:06:56 +07:00
Daniel Kesselberg
ba0ef74c06
Fix type for $urlGenerator
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-08 09:06:29 +07:00
Roeland Jago Douma
4d8b4ef3cc
Merge pull request #21533 from nextcloud/techdebt/noid/dedicated-method-to-get-a-users-language
...
Techdebt/noid/dedicated method to get a users language
2020-07-04 08:56:13 +07:00
Joas Schilling
db8267db26
Use the new method everywhere
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-07-03 10:59:43 +07:00
Daniel Kesselberg
87dd760a89
Replace TYPE with TYPES
...
As TYPE::* is deprecated.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-30 23:46:22 +07:00
Joas Schilling
6e46df26a8
Unify settings middleware with others
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-23 20:18:38 +07:00
Christoph Wurst
c5d2958ac7
Migrate Settings to new bootstrap mechanism
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-06-17 09:22:22 +07:00
Roeland Jago Douma
ce7a15e804
Merge pull request #21274 from nextcloud/bug/21268/paswordless-for-everyone
...
Enable passwordless for everyone not only admins.
2020-06-07 15:04:47 +07:00
Roeland Jago Douma
8325ab4bf0
Merge pull request #21224 from nextcloud/techdebt/noid/remove-unreachable-controller-and-route
...
Remove controller and routes which have no UI component anyway
2020-06-07 10:42:19 +07:00
Daniel Kesselberg
761a7bf6a2
Enable passwordless for everyone not only admins.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-06-06 21:34:49 +07:00
Thomas Citharel
d1b43d4fc2
Use \OC::$CLI instead of PHP_SAPI
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-06-04 11:31:09 +07:00
Joas Schilling
7dcb1cdb42
Remove controller and routes which have no UI component anyway
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-04 10:41:08 +07:00
Arthur Schiwon
653162a709
use the loginname to verify the old password in user password changes
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-05-26 16:53:25 +07:00
GretaD
fce716b905
Fix languages empty array
...
Signed-off-by: GretaD <gretadoci@gmail.com>
2020-05-08 10:03:58 +07:00
Christoph Wurst
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +07:00
Roeland Jago Douma
19171d77e2
Merge pull request #19191 from laurisb/patch-1
...
Improve Opcache detection
2020-04-15 11:03:05 +07:00
Roeland Jago Douma
a307d82e1d
Merge pull request #20427 from nextcloud/bug/noid/fix-password-reset-activity
...
Fix password reset saying Admin changed my password when reset from login page
2020-04-13 13:15:49 +07:00
Roeland Jago Douma
1cc793888f
Merge pull request #20421 from nextcloud/fix/20393/recommendend_webauthn_mods
...
Show setup check for recommended php modules
2020-04-12 15:56:10 +07:00
Thomas Citharel
18e8af4bb8
Fix password reset saying Admin changed my password when reset from
...
login page
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2020-04-10 18:05:43 +07:00
Christoph Wurst
28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +07:00
Christoph Wurst
a7c8d26d31
Add visibility to all properties and move static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:48:31 +07:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +07:00
Roeland Jago Douma
75836f004d
Show setup check for recommended php modules
...
Fixes #20393
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-04-10 13:25:12 +07:00
Christoph Wurst
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 10:35:09 +07:00
Christoph Wurst
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +07:00
Christoph Wurst
2a529e453a
Use a blank line after the opening tag
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:50:14 +07:00
Christoph Wurst
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +07:00
Christoph Wurst
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +07:00
Christoph Wurst
85e369cddb
Fix multiline comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-08 22:24:54 +07:00
Joas Schilling
bc6a5ef5c4
Merge pull request #19890 from nextcloud/enh/comments-reference-id
...
Add optional comments reference_id
2020-04-02 11:34:21 +07:00
Roeland Jago Douma
19ca921676
Merge pull request #20241 from nextcloud/fix/license-headers-19
...
Update the license headers for Nextcloud 19
2020-04-01 12:44:21 +07:00
Roeland Jago Douma
53db05a1f6
Start with webauthn
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-03-31 22:17:07 +07:00
Christoph Wurst
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +07:00
Joas Schilling
720dc4e93d
Add optional column oc_comments.reference_id
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-31 10:51:15 +07:00
Christoph Wurst
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +07:00
Christoph Wurst
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +07:00
Christoph Wurst
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +07:00
Roeland Jago Douma
3b26bfe879
Merge pull request #20127 from nextcloud/bugfix/noid/check-user-on-remote-wipe
...
Check the user on remote wipe
2020-03-24 20:26:52 +07:00
Roeland Jago Douma
b0ea022a3e
Add basic reverseproxy misconfig detection to setupchecks
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-03-23 10:37:08 +07:00
Julius Härtl
381decca49
Add setting to restrict user enumeration to groups
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-20 10:43:55 +07:00
Daniel Kesselberg
73643fe70b
Make sure app_install_overwrite is an array
...
otherwise in_array will complain.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-03-16 22:33:47 +07:00
Joas Schilling
9935c71ec3
Check the user on remote wipe
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-16 09:29:28 +07:00
Roeland Jago Douma
c8a360cd7a
Merge pull request #19580 from nextcloud/debt/noid/outdated-check
...
Update check for outdated php version.
2020-03-10 20:10:54 +07:00
Julius Härtl
f65e36a70c
Hide development notice when subscription is valid
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-03-06 13:08:23 +07:00
Christoph Wurst
d47daefe38
Revive the "send email to new users" toggle for the user form
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-02-28 14:01:03 +07:00
Daniel Kesselberg
f228d73b38
Update check for outdated php version.
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-02-24 20:14:13 +07:00
Daniel Kesselberg
8e8e912015
Make sure quota_preset is using numerical indexes
...
If one set quota_present to "default, none, 1 GB, 5 GB, 10 GB" the old implementation will remove default and none but keep the array indexes. Later json_encode will recognize a array with 2 as first index as object and hence quotaPreset.reduce will fail.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-02-22 20:06:16 +07:00
Joas Schilling
f464f2313f
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-10 10:14:02 +07:00
Joas Schilling
bf74c4f21b
Warn admins about delayed cron executions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-08 10:21:54 +07:00
Roeland Jago Douma
af8ad96285
Use the l10n from settings
...
Fixes #19261
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-02-03 09:44:59 +07:00
Roeland Jago Douma
bfaf3fff33
Move Admin Settings also to info.xml
...
More cleanup of the Settings apps. Makes the manager cleaner and a
proper manager.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-31 16:55:17 +07:00
Roeland Jago Douma
b68cb1fc0c
Use activity registration for the settings
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-31 15:12:32 +07:00
Roeland Jago Douma
c9253cce6c
Move personal settings to proper registration
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-30 22:06:28 +07:00
Roeland Jago Douma
dc1979903e
Move password settings
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-30 14:03:28 +07:00
Roeland Jago Douma
391a368557
Move the personal 2FA settings to its own app
...
Small isolated classes are easier to understand and to maintain!
Another step in the cleaning up of the settings. So that adding new
stuff later is easier.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-29 20:37:47 +07:00
Roeland Jago Douma
53817f5fc2
Merge pull request #19185 from nextcloud/enh/move_token_logic_to_token_settings
...
Move can create token logic
2020-01-29 20:13:23 +07:00
Roeland Jago Douma
34426a481f
Move can create token logic
...
It makes sense to have this in the actual authtoken settings. As well.
This is where it is used.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-29 15:57:59 +07:00
Lauris Binde
8413a4ec92
Improve Opcache detection
...
Improve Opcache detection by checking if extension is loaded, as opcache_get_status() is commonly disabled on shared hosting servers
2020-01-29 10:44:14 +07:00
Roeland Jago Douma
03df1b4c51
Move admin sections to settings app
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-28 12:38:11 +07:00
Roeland Jago Douma
d8e9cefcfe
Move the Personal sections to the settings app
...
There is no need to have weird magic in the manager. This should be
properly registered in the right way. The settings code is messy
anyways. This is a start to make it a tad more clean.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-01-28 08:45:07 +07:00
Arthur Schiwon
faf18b5f02
apps can have polyamorous relationships with bundles
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2020-01-24 12:50:06 +07:00
Christoph Wurst
6127c288e8
Fix license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-01-13 14:23:49 +07:00
Christoph Wurst
1b46621cd3
Update license headers for 18
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-20 09:23:25 +07:00
Roeland Jago Douma
7f2b3eabe1
Merge pull request #18429 from nextcloud/locale-fallback
...
add a fallback locale for personal settings page
2019-12-17 12:31:17 +07:00
Robin Appelman
db0bb8ae69
add a fallback locale for personal settings page
...
otherwise if the locale is set to an invalid or no longer existing locale
the rendering of the setting page will throw an exception
Signed-off-by: Robin Appelman <robin@icewind.nl>
2019-12-16 15:27:08 +07:00
Joas Schilling
3eee359d7f
Allow to force enable apps via CLI
...
Co-authored-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-13 13:06:12 +07:00
Sascha Wiswedel
fb0b94f0c5
clarified default permission setting string
...
The permission is actually about re-sharing, not about sharing after all
Signed-off-by: Sascha Wiswedel <sascha.wiswedel@nextcloud.com>
2019-12-12 14:41:28 +07:00
Roeland Jago Douma
6ddb789f0d
Merge pull request #18299 from nextcloud/bugfix/noid/filecache_bigint_mounts
...
Convert various columns in oc_mounts to bigint
2019-12-09 21:37:58 +07:00
Daniel Kesselberg
8f403b66d1
Fix Argument 3 passed to OCA\Encryption\Recovery::__construct() must be an instance of OCA\Encryption\KeyManager
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2019-12-09 14:29:22 +07:00
Georg Ehrke
699f3a6817
Convert various columns in oc_mounts to bigint
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
2019-12-09 14:13:18 +07:00
Christoph Wurst
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +07:00
Roeland Jago Douma
96eedc5eb2
My first stupid attempt at expanding the admin interface
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 14:33:13 +07:00
Roeland Jago Douma
c7d5b8fc49
Merge pull request #18079 from nextcloud/fixes/phpcs
...
Some php-cs fixes
2019-11-25 14:07:00 +07:00
Roeland Jago Douma
68748d4f85
Some php-cs fixes
...
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +07:00
Arthur Schiwon
bb1ce203bc
make help available to ordinary users again
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-11-21 12:52:37 +07:00
Roeland Jago Douma
decdb6b40f
Convert more columns to bigint
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-20 19:31:17 +07:00
Arthur Schiwon
0a1937208f
Fixes a 500 without userid
...
plus cleanup of unused use statements
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-11-16 01:10:19 +07:00
John Molakvoæ
13960b69da
Merge pull request #17509 from nextcloud/fix/application-singleton
...
Fix Application instances created multiple times
2019-11-04 18:18:32 +07:00
blizzz
75ecae28e6
Merge pull request #17450 from nextcloud/fix/17368/odd-group-numbers
...
hide strange Everyone and Disabled group numbers with LDAP
2019-10-21 11:53:44 +07:00
Arthur Schiwon
b41e3f8f08
hide strange Everyone and Disabled group numbers with LDAP, fixes 17368
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2019-10-21 10:09:21 +07:00
Julius Härtl
a307bb285e
Move help to controller
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2019-10-17 11:05:54 +07:00
Christoph Wurst
543190f8b3
Do not create Application instances directly
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-10-11 08:33:09 +07:00
Sergej Nikolaev
9aa992e60b
fix updating and deleting authtokens
...
Signed-off-by: Sergej Nikolaev <kinolaev@gmail.com>
2019-10-05 10:28:47 +07:00
Christoph Wurst
de6940352a
Move settings to an app
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2019-09-28 09:39:28 +07:00