73d94353d1
fix(cron): Keep job class limitation when searching for the next job
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-19 08:44:33 +07:00
a80d7ce11d
Merge pull request #50864 from nextcloud/fix/fix-psalm-taint-errors-2
...
fix: Fix psalm taint false-positives by small refactorings
2025-02-18 13:59:30 +07:00
2e50a39265
fix(files): properly forward open params from short urls
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-18 10:53:23 +07:00
e757b649b7
fix: Fix psalm taint false-positives by small refactorings
...
Mostly make it clear that we trust admin input or that we correctly
escape strings.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 18:08:23 +07:00
c1c59f9a6c
chore: Add missing star in phpdoc comment
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:23 +07:00
640dbd0b5e
fix: Fix false-positive psalm taint errors when outputting plain text
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:23 +07:00
7c907223d2
fix: Fix psalm taint false-positive by escaping trusted input
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:22 +07:00
fa108d5b54
fix: Correctly tag json encoding in BaseResponse to fix false-positive
...
…in psalm taint analysis
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:22 +07:00
aac79bad9b
fix: Move config.php taint trust upstream directly in OC\Config class
...
This solves some false-positive psalm taint errors
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:20 +07:00
85fbd3eb0a
fix: Work around psalm taint false-positive by not using var_export
...
var_export is listed as a taint sink because it may output stuff
depending on the parameters. It was not the case here, but we can
simply json_encode the result by passing it as context to the logger
method rather than using var_export.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:24:08 +07:00
fec865cc29
chore: Correctly flag json encoding methods as escaping html and quotes
...
Especially with JSON_HEX_TAG it’s perfectly fine to echo JSON, and we
only use it in JSON output anyway.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:24:07 +07:00
579a337750
fix: Fix psalm taint error in L10N factory
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:24:07 +07:00
885175772b
fix(repair): PHP8.3 deprecation warning
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-02-14 11:55:19 +07:00
b003af2364
Merge pull request #50794 from nextcloud/fix/fix-appmanager-cleanappid
...
fix: Only keep allowed characters in appid, and flag the method as escaping
2025-02-13 17:23:44 +07:00
6e7c97ea1f
fix: Also remove digits at the start and underscore on both ends of appid
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2025-02-13 16:22:21 +07:00
c71bc0696f
Merge pull request #50781 from nextcloud/perf/improve-incomplete-scan
...
perf(files): faster query to fetch incomplete directories
2025-02-13 15:21:25 +07:00
8f57a50767
fix: Only keep allowed characters in appid, and flag the method as escaping
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 14:21:36 +07:00
f758f565d4
fix: Replace getInstalledApps calls with getEnabledApps
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:20 +07:00
a3685551f7
fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUser
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:19 +07:00
cffd2c8d09
chore: Improve naming of methods and properties in AppManager
...
Remove all references to installed apps where it’s about enabled apps
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:19 +07:00
fb917c495b
fix(ocp): Deprecate getInstalledApps and replace with clearer method name
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:19 +07:00
d2864f7d84
fix(ocp): Deprecate isInstalled and add isEnabledForAnyone instead
...
The method name was really confusing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:18 +07:00
9bdee76535
perf(files): faster query to fetch incomplete directories
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-02-13 10:11:02 +07:00
90a1aea574
Merge pull request #50498 from nextcloud/bug/48678/restore-dav-error-response-2
...
Don't rethrow a type error
2025-02-11 17:28:44 +07:00
9e1ae74a1c
fix: make locked exception path relative to the view
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-11 14:38:27 +07:00
2786ca579a
fix: don't use cached root info from shared cache if the watcher has detected an update
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-06 19:41:43 +07:00
f9c03f7606
Merge pull request #49955 from nextcloud/occ-upgrade-reminder
...
fix: when already upgrading, don't instruct to run `occ upgrade`
2025-02-06 16:32:42 +07:00
93c72f5675
Merge pull request #50660 from nextcloud/fix/mime-int
...
fix: make sure we process mime extensions as string
2025-02-06 16:13:27 +07:00
1e30936b78
fix: psalm and OCP @since declarations
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2025-02-06 15:21:18 +07:00
729cdf6818
fix(FediverseAction): Ensure valid fediverse links are generated
...
Harden also for existing values of the profile.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 11:58:24 +07:00
fbef47a5d7
fix(AccountManager): Sanitize social media handles
...
Ensure to only accept valid X and fediverse handles.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 11:58:24 +07:00
724811adf8
fix: when already upgrading, don't instruct to run `occ upgrade`
...
Fixes #36289
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-02-05 22:57:40 +07:00
754a047404
fix(oauth2): adjust db schemas when migrating from owncloud
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-02-05 21:56:02 +07:00
6baafd82b6
fix: make sure we process mime extensions as string
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-05 12:35:41 +07:00
319a4d2df8
fix(TaskProcessing\Manager): Always use distributed cache and use PHP serialize
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-02-04 13:04:43 +07:00
f127ab10da
fix: lib/private/TaskProcessing/Manager.php
...
Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-02-04 13:03:59 +07:00
49a52126ab
fix(TaskProcessing\Manager): Always use distributed cache and use PHP serialize
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-02-04 12:54:13 +07:00
8be4ad75b3
Merge pull request #50069 from michielbdejong/fix-36340
...
Fix OCM implementation has wrong parameter names
2025-02-03 10:45:46 +07:00
16921d7ee1
Merge pull request #50530 from nextcloud/fix/convert-type
2025-01-30 11:43:40 +07:00
b6c7c28585
fix: Exclude non accepted shares when computing access list
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-30 09:57:14 +07:00
cf5d55edb7
fix(ConvertType): Read dbtype in createConnectionParams and remove safeguard
...
Signed-off-by: Nils Wenninghoff <nils@ungemein.cool>
2025-01-30 09:24:58 +07:00
995dfd1a57
Merge branch 'master' into fix-36340
2025-01-29 20:47:08 +07:00
dacb1d94d0
fix: copy sharedBy[DisplayName] to sender[DisplayName], fixes #36340
...
Signed-off-by: Michiel de Jong <michiel@pondersource.com>
2025-01-29 20:43:10 +07:00
3f45bc5ed3
Merge pull request #50514 from nextcloud/feat/s3/sse-c
...
feat(S3): add SSE-C support in S3 External Storage
2025-01-29 18:32:49 +07:00
f1c025dfd3
fix(s3): treat empty sse_c_key as not set
...
Co-authored-by: Christian Becker <christian@dabecka.de>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-28 22:59:59 +07:00
0741f6fb80
Merge pull request #50494 from nextcloud/fix/low-res-for-blurhash
...
fix(performance): use low resolution for blurhash
2025-01-28 22:58:30 +07:00
b48ee2e924
fix: Harden files scanner for invalid null access
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 20:08:46 +07:00
0a0f56282a
fix(sharing): Move permission validation to share manager
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 16:40:50 +07:00
faaed68c04
fix(performance): use low resolution for blurhash
...
Improve blurhash performance by using a low res image.
The results are hard to destinguish visualy.
It is a **blur** hash after all.
Signed-off-by: Max <max@nextcloud.com>
2025-01-28 15:19:38 +07:00
c483a84e9b
Merge pull request #49645 from nextcloud/fix/noid/clean-config-code
...
fix(config): drop value details
2025-01-27 16:54:20 +07:00
Joas Schilling
Joas Schilling
skjnldsv
Côme Chilliet
Git'Fellow
Côme Chilliet
Benjamin Gaussorgues
Daniel
Robin Appelman
Louis
John Molakvoæ
Ferdinand Thiessen
Josh
Richard Steinmetz
Marcel Klehr
Kate
Nils Wenninghoff
Michiel de Jong
Andy Scherzinger
max-nextcloud
Maxence Lange