9a7ee321fa
fix(users): improve recently active search
...
- Remove DISTINCT clause to fix PgSQL
- Join user table only if necessary
- Don't show people who never connected in active list
- Add test
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 10:17:03 +07:00
8842fcb003
test: add test for nested jail cross-storage move
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-29 15:02:49 +07:00
07d020b4d5
fix: crypto added manually as expected
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 18:42:47 +07:00
051cc83854
fix: crypto type made not nullable and tests run using ICrypto
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 12:29:20 +07:00
b7e4138886
fix: encrypt and store password, decrypt and retrieve the same
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 12:29:20 +07:00
57069e35c7
test(settings): Correctly only return bool for Symfony Input::hasParameterOption calls
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-21 11:28:55 +07:00
decc236f98
fix(message): Fix logic of Mail test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-21 11:28:54 +07:00
c71097640a
test: Fix mock creation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-21 11:28:53 +07:00
498c3dc566
fix(comments): Add test for email mention
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-18 06:21:01 +07:00
761f7e1f70
Merge pull request #48703 from nextcloud/backport/48673/stable30
...
[stable30] fix(share): Return empty string if no label is set
2024-10-17 18:25:16 +07:00
dfe8f642cd
fix(share): Return empty string if no label is set
...
* Resolves: https://github.com/nextcloud/server/issues/48629
While the database supports NULL, the typing has always said it only returns *string*.
So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-14 17:11:16 +07:00
d10330b217
fix(UserTrait): Fix backend initialization
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-08 21:02:30 +07:00
7dd85e15b9
fix: Make user removal more resilient
...
Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.
There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.
The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-08 21:02:07 +07:00
8290de3b93
Merge pull request #48077 from nextcloud/backport/47852/stable30
2024-10-02 10:43:41 +07:00
6949e21c09
Merge pull request #48317 from nextcloud/backport/48307/stable30
2024-09-30 10:24:20 +07:00
c4ffd84439
fix: gracefully parse non-standard trusted certificates
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-09-30 09:11:42 +07:00
8cf91a32d8
fix(tests): Fix test selection and run unit tests of DAV and user_status
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-25 08:39:14 +07:00
9a34a6c4c4
fix(users): Don't crash if disabled user is missing in the database
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-23 18:06:38 +07:00
ae7241f6c8
Merge pull request #48221 from nextcloud/backport/30/fix_move_on_same_bucket
2024-09-20 10:06:14 +07:00
656e32c6c1
fix(tests): Fix most obvious errors in ObjectStore tests
...
Some are still failing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-19 18:54:26 +07:00
82be489f53
perf(ObjectStoreStorage): Improve (slow) move on same object bucket
...
This commit fixes the issue #47856 . When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.
The behavior improves a lot with https://github.com/nextcloud/server/pull/46013 . However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
2024-09-19 18:53:36 +07:00
61da345203
fix(tests): Fix Folder tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-19 14:24:22 +07:00
b44ac8238d
fix(tests): Remove deprecated tests for ServerTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-19 14:24:22 +07:00
8b8508c8b1
test: put parent items into cache in tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 13:59:08 +07:00
e82ab7816f
test: fix incorrect ltrim usage in test
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-19 13:59:08 +07:00
e4f5d39464
Merge pull request #48088 from nextcloud/backport/48008/stable30
2024-09-17 12:53:41 +07:00
a7b4808b32
fix(config): add envCache tests for getKeys()
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-09-16 15:06:03 +07:00
b7b5b50050
fix(Entity): Fix magic setter call for custom strong typed setters
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-16 13:52:27 +07:00
914e8f9ce2
fix: misc code fixes around db sharding
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-16 12:19:20 +07:00
90a6b82579
Merge pull request #47940 from nextcloud/backport/47933/stable30
...
[stable30] fix(config): Throw PreconditionException always when it didn't match
2024-09-15 21:29:14 +07:00
fa355386f7
Merge pull request #47796 from nextcloud/backport/47756/stable30
...
[stable30] fix(files): Check if target path is a descendant of the shared folder
2024-09-15 21:25:30 +07:00
66a6b442b5
fix(config): Throw PreconditionException always when it didn't match
...
Previously even when the precondition did not match, the call "passed"
when the after value was the expected one. This however can lead to
race conditions, duplicate code excutions and other things.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-13 11:40:13 +07:00
80eec3f0ef
fix: Add whiteboard to education and public sector bundle
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-12 09:08:22 +07:00
2bb8c023c2
fix(files): Check if the target path is a descendant of the shared folder path
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: fix tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: add tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: tests
2024-09-06 02:00:43 +07:00
b9aaa9f2e0
fix(files): Create non-existent parents of mountpoints
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-04 18:04:13 +07:00
6ea52ed218
fix: Adjust filename validation messages
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-30 14:48:23 +07:00
77464a4a0d
fix(TaskProcessing): Fix namespace of TaskProcessingTest.php
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 14:06:15 +07:00
d2ec025fa4
fix(taskprocessing): fix tests
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 14:06:15 +07:00
656412daa4
test(phpunit): skip sharding tests on 32bit
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-08-29 20:19:33 +07:00
183fcef39b
fix: Renaming does not need update but delete permissions
...
Renaming is basically copy + delete (a move), so no need to update permissions.
Especially if the node is in a invalid directory the node should be moveable but not editable.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 20:23:50 +07:00
140b36fcea
fix: Backport to 30
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-28 14:54:14 +07:00
e5a8f996bd
chore: Apply php:cs recommendations
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
[skip ci]
2024-08-28 14:54:14 +07:00
b2645590ce
fix: implement sharding compatible cleanup for various bits
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 14:54:14 +07:00
1b6d76aa1b
test: fix share provider tests for sharding
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 14:54:14 +07:00
22f76fca59
test: run sharding tests in ci
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 14:54:14 +07:00
ecf1cc2c3c
test: mark share test cleanup as running across all shards
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 14:54:14 +07:00
82d7eaf80a
feat: implement distributing partitioned queries over multiple shards
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 14:54:14 +07:00
4ec53e723e
feat: add option to automatically partition queries by specific tables
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 14:54:14 +07:00
8f57d46a0b
fix: delay calculating global cache prefix untill a cache is created
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 14:54:14 +07:00
3e35e62f6b
feat: add negative compare-and-delete to imemcache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-23 11:37:57 +07:00
Benjamin Gaussorgues
Robin Appelman
yemkareems
Joas Schilling
Ferdinand Thiessen
provokateurin
Kate
Richard Steinmetz
Louis Chemineau
Côme Chilliet
Christoph Fiehe
Josh Richards
Andy Scherzinger
Julius Knorr
Git'Fellow
Marcel Klehr
Julien Veyssier
Arthur Schiwon