0cd1eeb509
fix(sharding): typo in addOrderBy
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 11:43:38 +07:00
9a7ee321fa
fix(users): improve recently active search
...
- Remove DISTINCT clause to fix PgSQL
- Join user table only if necessary
- Don't show people who never connected in active list
- Add test
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 10:17:03 +07:00
198c2d3d68
fix: Skip users that still exist in backend
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-08 21:02:20 +07:00
7dd85e15b9
fix: Make user removal more resilient
...
Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.
There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.
The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-08 21:02:07 +07:00
9a34a6c4c4
fix(users): Don't crash if disabled user is missing in the database
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-23 18:06:38 +07:00
0563757ea4
fix(SetupCheck): Properly check public access to data directory
...
When checking for public (web) access to the data directory the status is not enough
as you might have a webserver that forwards to e.g. a login page.
So instead check that the content of the file matches.
For this the `.ncdata` file (renamed from `.ocdata`¹) has minimal text content
to allow checking.
¹The file was renamed from the legacy `.ocdata`, there is a repair step to remove the old one.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 22:08:42 +07:00
6a783d9b08
fix(Session): avoid race conditions on clustered setups
...
- re-stablishes old behaviour with cache to return null instead of throwing
an InvalidTokenException when the token is cached as non-existing
- token invalidation and re-generation are bundled in a DB transaction now
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-07-10 13:28:33 +07:00
3a97dbf248
Merge pull request #46123 from nextcloud/feat/user-password-hash
...
feat: Allow getting/setting the password hash of a user
2024-07-09 08:00:01 +07:00
c390ae94ff
feat: Validate password hash
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-08 16:31:42 +07:00
dba00560d2
perf: Return cached password hash
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-08 16:30:52 +07:00
34d97d45cf
feat: Allow getting/setting the password hash of a user
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-08 16:30:52 +07:00
a330f4c9d5
feat: Implement IPasswordHashBackend in database user backend
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-08 16:30:52 +07:00
4eba967d63
fix: getLastLoggedInUsers moved from AllConfig/IConfig to IUserManager/Manager
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
ae95e46787
fix: limit and fixLimit removed. negative limit handled in controller. removed getUsersSortedByLastLogin from Manager and instead used the config in controller
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
ceedfb4616
fix: removed default limit of 25. if null is given all users are fetched or if limit is given limit number of users are fetched
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
cfafbc8415
fix: removed references to old disabled users code. refactored query as per getDisplayNames function. limit and offset added to query. default limit set to 25.
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
afa51365ff
fix: removed the params related to sortMode and order since it sorts by lastLogin
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
5b249df686
fix: doc blocks added
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
695bd042d7
fix: search and searchDisplayNames reverted to how it was initially as sort and order are not required here
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
dc6e8c9c0a
fix: search and searchDisplayNames reverted to how it was initially as sort and order are not required here
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
4cb85f7c9e
fix: rebased the branch with master and resolved conflicts
...
fix: added a new endpoint users/recent and getting users based on last login info in the same. Reverted old code that was breaking LDAP
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
76c875a588
fix: change orderBy and sort to sortMode and sortOrder. default it to uid asc. enable email search by changing query
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
33b38c6573
fix: cs fix and psalm ci related changes
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
c8c68c3510
fix: sort the user getDisplayNames based on lastLogin. Default sort order is lastLogin DESC
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
87a8013ee3
feat: cs fix run on the changed files and default order by last_login desc. Also last_login sort logic changed
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
0ee676cd51
feat: add ability to sort users by last_login, uid or displayName. one of these needs to be passed as orderBy and sort can be ASC or DESC
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-07-08 15:42:55 +07:00
85a3b27cf9
Fix: Make out of office replacement nullable
...
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-07-03 12:31:53 +07:00
a9774741e8
Feat: Allow users to select another user as their out-of-office replacement
...
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-07-01 15:10:16 +07:00
95dc7729fb
Merge pull request #40147 from summersab/refactor/OC-Server-getNotificationManager
2024-05-31 19:09:38 +07:00
84789222b1
chore: php lint fix import
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-05-30 18:38:02 +07:00
65ad1d0abe
Merge branch 'master' into refactor/OC-Server-getNotificationManager
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-05-30 14:33:12 +07:00
cc7e6e5e4c
Merge branch 'master' into refactor/OC-Server-getCsrfTokenManager
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-05-30 14:29:21 +07:00
fca38e12c8
Merge pull request #45411 from nextcloud/fix/auth/selective-token-activity-update
...
fix(auth): Update authtoken activity selectively
2024-05-29 12:05:45 +07:00
dae7c159f7
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-24 13:11:22 +07:00
8044edf309
fix: Also search in email field for disabled users
...
To match what is done for Database backend for enabled users
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-05-23 09:09:20 +07:00
6d56f3557d
feat: Add back searching in disabled user list
...
When disabled users where moved to their own endpoint we overlooked
search, so adding it back.
The search is done case-insensitive in uid and display name.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-05-23 09:08:31 +07:00
bcc02a3c71
fix(auth): Update authtoken activity selectively
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-05-21 07:55:01 +07:00
7278198e6b
fix: delete user credentials stored in storages_credentials when user gets deleted
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-05-16 16:48:47 +07:00
4509a17cdd
fix(User\Manager): Avoid future collisions with updater/audit logs
...
Avoid future collisions for not yet created updater and audit log files (at least using default names).
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-05-06 09:20:38 +07:00
672923f0a6
fix: Fix newly spotted psalm issues, add exhaustive typed magic properties for LDAP classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 09:23:58 +07:00
21ee7f59bd
fix(session): Do not update authtoken last_check for passwordless
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-04-26 16:05:18 +07:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
e330efe5a0
fix: Implement option to temporarily set the user session
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-19 13:48:23 +07:00
eb61f6b065
Merge pull request #40117 from summersab/refactor/OC-Server-getCommentsManager
2024-03-15 17:03:54 +07:00
f5e3fea285
Merge pull request #40138 from summersab/refactor/OC-Server-getHasher
2024-03-15 15:08:32 +07:00
6910832170
Refactor `OC\Server::getCommentsManager`
...
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2024-03-15 13:14:06 +07:00
0047789580
Refactor `OC\Server::getTwoFactorAuthManager`
...
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2024-03-15 13:12:51 +07:00
f9ce6bfdff
Refactor `OC\Server::getHasher`
...
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2024-03-15 13:04:27 +07:00
3fb1674251
Merge pull request #43461 from nextcloud/fix/get-rid-of-getlogger
...
chore: Migrate away from OC::$server->getLogger
2024-02-14 10:47:22 +07:00
524ed97d62
fix: replace `Account name` by `Login`
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:08:10 +07:00
Benjamin Gaussorgues
Ferdinand Thiessen
Louis Chemineau
Arthur Schiwon
Pytal
Christopher Ng
yemkareems
Hamza Mahjoubi
John Molakvoæ
Daniel
Andy Scherzinger
Côme Chilliet
Christoph Wurst
Josh
Julius Härtl
Andrew Summers
F. E Noel Nfebe
John Molakvoæ