a4e2a7bb7b
fix(appsmanagement): Fix exception on generating preview url for screenshots
...
Some installed apps meant for older server versions might unexpectedly
offer up screenshot values in a non-string format (e.g. health). Avoid
an exception by checking first if the first app screenshot is indeed a
string and otherwise we take the value of the parameter
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-11-01 14:48:33 +07:00
824aa30057
fix: add missing import after backport
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-30 20:36:59 +07:00
cac5be5341
fix(ci): psalm, suppress undefined for viewApps
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-30 20:36:57 +07:00
c53f5c43b4
WIP: address review comments, small fixes
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-30 20:36:56 +07:00
fb4150ec86
fix(ci): suppress UndefinedClass for AppAPI related classes since it's bundled
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-30 20:36:56 +07:00
3a51374ff3
feat(app_api): add initial state data for AppAPI UI part
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
# Conflicts:
# apps/settings/lib/Controller/AppSettingsController.php
# Conflicts:
# apps/settings/lib/Controller/AppSettingsController.php
2024-10-30 20:36:50 +07:00
51d8dc76c5
fix(users): use correct active user count
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 09:09:44 +07:00
1c474fc30e
Merge pull request #48624 from nextcloud/backport/48619/stable30
2024-10-30 09:45:20 +07:00
7bd791f327
Merge pull request #48571 from nextcloud/backport/48532/stable30
2024-10-29 10:26:18 +07:00
7b2a614ca5
Merge pull request #48866 from nextcloud/backport/48853/stable30
...
[stable30] fix(app-store): Ensure the `groups` property is always an array
2024-10-23 19:08:38 +07:00
2198fe16c9
fix(app-store): Also proxy images of locally installed apps
...
Before this only app store apps got their screenshots proxied,
but this will cause locally installed apps to not be correctly shown on the app-store.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 15:19:24 +07:00
35a1d4b224
fix(app-store): Ensure the `groups` property is always an array
...
If the value was a string, like a single group, then `json_decode` will also yield only a string.
So in this case we ensure the property is always an array with that value.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 15:05:23 +07:00
2023f3cce3
fix(appstore): Hide last modified information for shipped apps
...
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-10-18 12:02:07 +07:00
f582aba86e
fix: Fix empty sections appearing in search results
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-10-09 08:59:46 +07:00
6c73ba339a
fix: do not reduce count for subadmins if they are members of group
...
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-10-04 18:22:16 +07:00
962a971643
fix: correctly count disabled users for subadmins
...
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-09-30 10:10:22 +07:00
dbe88caec5
fix: Ensure app discover section is returned as list
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-24 11:37:41 +07:00
77321bc6cf
Merge pull request #47944 from nextcloud/backport/47883/stable30
...
[stable30] fix(setup-checks): Ensure URL with webroot works
2024-09-19 00:19:19 +07:00
9371d93249
fix(a11y): Add OTF font loading check
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-16 09:26:59 +07:00
71d870d1bd
refactor(settings): `CheckServerResponseTrait` always expect absolute path
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-15 21:40:27 +07:00
27300ac6ce
fix(setup-checks): Ensure URL with webroot works
...
We basically mock the way `URLGenerator::getAbsoluteURL` works,
so we must make sure that the URL might already contain the webroot.
Because `baseURL` and `cliURL` also contain the webroot we need to remove
the webroot from the URL first.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-15 21:40:27 +07:00
6830b250b4
fix(setupchecks): Test overwrite.cli url first, then generated one, and
...
trusted domains as last fallback.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 15:54:56 +07:00
ed8759eab8
fix: add option to remove the webroot for setup checks and don't check trusted_domains.
...
1) The checks for well-known urls should always run against the root domain and therefore the option to remove the webroot.
2) For trusted domains, the available protocol is unknown, and thus some guesswork would be needed to make that work. I've decided for now to not consider them anymore to reduce false-positives.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-05 15:54:56 +07:00
93cc5297ef
fix(settings): Fix sharing exclude groups from password requirement option not working
...
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2024-09-03 15:22:09 +07:00
3c02c442af
fix(security): Update expiration date in security.txt
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-08-14 10:43:32 +07:00
4673e1a391
Merge pull request #46816 from nextcloud/refactor/settings/security-attributes
2024-08-14 09:38:08 +07:00
0563757ea4
fix(SetupCheck): Properly check public access to data directory
...
When checking for public (web) access to the data directory the status is not enough
as you might have a webserver that forwards to e.g. a login page.
So instead check that the content of the file matches.
For this the `.ncdata` file (renamed from `.ocdata`¹) has minimal text content
to allow checking.
¹The file was renamed from the legacy `.ocdata`, there is a repair step to remove the old one.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 22:08:42 +07:00
4488714148
Merge pull request #46353 from nextcloud/skipOPcacheCLI
...
fix(setupchecks): Skip checking for OPcache settings if running checks from CLI
2024-08-01 20:02:25 +07:00
cf4326539e
fix(AdminSettings/AI): show pref list of only the enabled translation providers
...
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
2024-08-01 13:36:37 +07:00
f012c996ee
refactor(settings): Replace security annotations with respective attributes
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-27 22:49:43 +07:00
2ddfbf3e79
Merge pull request #45092 from nextcloud/fix/user-provider-search-shown
2024-07-24 16:38:13 +07:00
7266a9ef33
Merge pull request #46418 from nextcloud/artonge/feat/user_admin_delegation
...
feat(users): Add users and group management to admin delegation
2024-07-24 11:15:54 +07:00
b37fb43a32
feat: let users configure their first day of week
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-07-22 22:35:46 +07:00
3574d7eec8
feat(users): Enable features for delegated user admins
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-22 19:58:44 +07:00
dff8815449
feat(users): Add support for admin delegation for users and groups management
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-22 17:17:35 +07:00
047479ccf9
feat(security): Add public API to allow validating IP Ranges and checking for "in range"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +07:00
202e5b1e95
feat(security): restrict admin actions to IP ranges
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +07:00
7cb67c67c7
Merge pull request #46509 from nextcloud/feat/settings/taskprocessing
...
feat(settings/admin/ai): Add Task Processing API settings
2024-07-17 18:24:11 +07:00
9dca5ae0e0
feat(settings/admin/ai): Add Task Processing API settings
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 15:24:19 +07:00
2201bce7d3
fix(caldav): lower scheduling table size warning
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-07-17 11:20:49 +07:00
e8cacc50a2
chore(settings): Rename user groups
...
- "Active accounts" -> "All accounts"
- "Recent accounts" -> "Recently active"
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-11 11:19:09 +07:00
51e9651436
chore(l10n): Translate group names
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-11 11:19:09 +07:00
07319a118b
feat: Add Recent accounts section
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-11 11:19:09 +07:00
fa84f52c3f
fix: typo
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 15:11:35 +07:00
372c9d2ee6
fix: check both CLI and value
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 15:09:29 +07:00
39f052407a
fix(setupchecks): Skip checking for OPcache if running from CLI
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 10:43:20 +07:00
8fc498fb82
fix(IntegrityCheck): Ensure the check is run if no results are available
...
If there are no cached results the current implementation was also returning an empty array,
but this was the same as when there was a successful run.
So to distinguish this we return `null` if there are *no* results.
In this case we need to rerun the integrity checker.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-03 11:37:49 +07:00
682faad0b3
Merge pull request #46009 from nextcloud/refactor/ajax-cron
...
refactor(cron): Use `IAppConfig` for cron settings and migrate ajax cron away from jQuery
2024-06-29 16:29:34 +07:00
02983f3317
Merge pull request #46190 from nextcloud/bug/45047/skip-check-when-disk-free-space-disabled
...
fix(setupchecks): skip check when disk_free_space is disabled
2024-06-29 15:59:17 +07:00
14778811b4
refactor: Use `IAppConfig` for setting cron type
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-28 18:00:39 +07:00
Claudio Cambra
Andrey Borysenko
Benjamin Gaussorgues
Kate
Ferdinand Thiessen
Marcel Müller
Christopher Ng
Maksim Sukharev
Joas Schilling
Côme Chilliet
Daniel Kesselberg
provokateurin
Git'Fellow
Anupam Kumar
Louis
Richard Steinmetz
Marcel Klehr
Anna Larch