1ef465f804
Merge pull request #56251 from nextcloud/carl/template-manager-cleanup
...
refactor(template-manager): Modernize template manager API
2025-12-04 17:26:53 +07:00
6bccaf778a
fix(sharing): Allow public share access for everyone
...
When a logged-in user accesses a public share link in the same browser,
the system was incorrectly checking if that user's groups were excluded
from creating link shares. This caused share not found errors for users
in excluded groups, even though public shares should be accessible to anyone
with the link.
The group exclusion setting (`shareapi_allow_links_exclude_groups`) is
intended to restrict share creation, not share access. Public shares
are meant to be anonymous and accessible regardless of the viewer identity
or group membership.
We now check the exclusion for the share creator and not the viewer.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-12-02 09:45:18 +07:00
0c3a872908
feat(CertificateManager): Add option to specify the default certificates bundle path
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-12-01 10:47:23 +07:00
7a4167fe28
fix(oracle): Don't run tests against unsupported Oracle version anymore
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-11-27 14:39:51 +07:00
73c6b17fae
fix(View): Normalize path in `getAbsolutePath`
...
This allow to match files more consistently in HookConnector::getNodeForPath
Signed-off-by: Louis Chmn <louis@chmn.me>
2025-11-25 19:30:53 +07:00
fac380fb88
Merge pull request #55476 from nextcloud/fix/l10n/generic-language-no-user
...
fix(l10n): do not consider user language when getting the generic one
2025-11-25 10:42:56 +07:00
40246d9a19
fix(sharing): Add isTrustedServer flag to lookup results
...
When `show_federated_shares_to_trusted_servers_as_internal` is enabled,
lookup server results were being filtered out because they lacked the
`isTrustedServer` flag. This adds the flag to lookup results by:
- Injecting TrustedServers service into LookupPlugin
- Adding `server` and `isTrustedServer` fields to each lookup result
- Updating tests to reflect new structure
This ensures lookup results from trusted servers appear in internal
sharing while non-trusted servers are correctly filtered out.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-11-24 23:32:40 +07:00
9522dde7a2
feat: Add Folder::getOrCreateFolder api
...
Allow to remove some boilerplate and also this new function is type
safe.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-11-24 11:10:52 +07:00
38fd84aa6a
refactor(template-manager): Modernize template manager API
...
And correct openapi types for the size.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-11-24 10:00:47 +07:00
f9abfe0473
fix(tests): Use testing application for testing ajax endpoints, not user_ldap
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Louis Chmn <louis@chmn.me>
2025-11-21 14:23:58 +07:00
6f0537b4e9
Merge pull request #56494 from nextcloud/carl/result-improv
...
Improve IResult
2025-11-20 15:38:17 +07:00
8e04afc2b1
Merge pull request #56451 from nextcloud/feat/noid/update-user-keys
...
feat: Add option to update the public key of a user
2025-11-19 13:42:30 +07:00
234f183f8e
feat: Add option to update the public key of a user
...
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2025-11-19 10:51:43 +07:00
2b61abd9ad
refactor(db-adapter): Add tests about fetch methods
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-11-18 17:45:57 +07:00
4d47fdaa85
chore: Run rector with new rules for fetch
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-11-18 17:45:57 +07:00
503a65ddd0
refactor: Run rector
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-11-18 17:45:54 +07:00
75a8b9aff5
fix(db): Skip test on Oracle 11g
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-11-18 16:10:12 +07:00
4676b12a32
fix(db): Fix comparing JSON data in MySQL and MariaDB
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-11-18 11:58:32 +07:00
fb8caecbb0
fix(db): Fix JSON handling in WHERE statements for postgres
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-11-18 11:58:31 +07:00
4e83d20837
feat(login): Add rememberme checkbox
...
Only present if allowed by configuration.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-11-13 13:25:59 +07:00
32c149e8ea
Merge pull request #56255 from nextcloud/availability-same-request
...
make failed availability check apply in the same request
2025-11-12 18:45:01 +07:00
0ce4b4b371
Merge pull request #52012 from nextcloud/fix-user-collaborators-returned-when-searching-for-mail-collaborators
...
Fix user collaborators returned when searching for mail collaborators
2025-11-12 11:04:07 +07:00
2b9083ab29
feat(rate-limit): Allow overwriting the rate limit
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-11-12 08:59:40 +07:00
ccc0c3c25f
fix(l10n): do not consider user language when getting the generic one
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-11-10 19:50:19 +07:00
c40fcba5a4
fix: Fix user collaborators returned when searching for mail collaborators
...
The MailPlugin collaborator returned results for both user and mail
collaborators, but it was registered only for mail collaborators. While
it might make sense to move the user results to the UserPlugin instead
that change would be more complex and riskier, so for now the MailPlugin
is now registered for both user and mail collaborators and the results
are limited only to the registered type.
As the plugins are registered only with their class and then resolved
when needed using dependency injection it is not possible (as far as I
know) to provide an explicit parameter in the constructor to
differentiate whether the MailPlugin should return user or mail
collaborators. To overcome this two subclasses are introduced,
MailByMailPlugin and UserByMailPlugin, which just hardcode in their
constructor the collaborator type that their parent MailPlugin must use,
and those subclasses are the ones registered instead of the MailPlugin
(which still contains all the logic).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-11-11 01:20:17 +07:00
2c841b2337
test: Rename data providers to match the name of their tests
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-11-11 00:54:39 +07:00
74fd144003
test: Replace magic value with named constant of share type
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-11-11 00:54:39 +07:00
a0e8d943f1
test: Rename parameters to show that they are expected values
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-11-11 00:54:38 +07:00
45f2683a73
test: Fix parameter documentation
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-11-11 00:54:38 +07:00
d14cf6a8be
Merge pull request #56280 from nextcloud/chore/noid/version-in-crawler-agent
...
Add server version to default crawler user agent
2025-11-07 15:42:53 +07:00
b91034b3cf
chore: Add server version to default crawler user agent
...
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2025-11-07 11:20:56 +07:00
f4b4cb5493
Revert "feat(group): Sanitize group names and ids on creation"
2025-11-07 10:37:50 +07:00
2970232790
fix: make failed availability check apply in the same request
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-11-06 20:08:44 +07:00
cddd666213
Merge pull request #56222 from nextcloud/artonge/feat/sanitize_groupname
...
feat(group): Sanitize group names and ids on creation
2025-11-06 15:24:10 +07:00
989011766e
feat(group): Sanitize group names and ids on creation
...
It does not make sense to allow group name with weird white space sequence going forward.
Same for group ids, in which we do not really want white space.
Signed-off-by: Louis Chmn <louis@chmn.me>
2025-11-05 18:31:38 +07:00
6336eac6a5
chore: setting test metadata in annotations is deprecated (use attributes)
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-11-05 15:42:40 +07:00
b2ffff385a
chore(tests): cleanup previews in teardown
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-11-05 15:42:40 +07:00
1eeed0a170
refactor(tests): teardown is now always called - also when skipped
...
* ref: https://github.com/sebastianbergmann/phpunit/issues/6394
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-11-05 15:42:34 +07:00
f1e82b10e6
refactor(tests): `getMockForAbstractClass` is deprecated
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-11-05 15:42:34 +07:00
b2e767d98c
refactor(tests): `returnValue` is deprecated
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-11-05 15:42:34 +07:00
b7488550f7
refactor(tests): `getMockForTrait` is deprecated
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-11-05 15:42:34 +07:00
be6b39f280
refactor(tests): special name `method` is deprecated in PHPUnit
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-11-05 15:42:34 +07:00
e3b34891b0
chore: migrate to PHPUnit 11
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-11-05 15:42:33 +07:00
635a6ac9da
Merge pull request #56095 from nextcloud/feat/add-serverid
2025-11-04 16:00:32 +07:00
34f1ae62a1
fix(jobs): Limit command jobs to known cases
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-11-04 11:10:40 +07:00
1f74ed9239
feat(config): add serverid configuration and use it for Snowflakes
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-11-03 14:25:09 +07:00
83dd9d313a
feat(snowflakeids): add File Sequence Generator
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-11-03 11:45:13 +07:00
700f4db967
Merge pull request #56063 from nextcloud/tests/taskprocessing
...
test(TaskProcessing): use proper types
2025-10-31 15:04:49 +07:00
8207afb7db
fix: Use UserFacingProcessingException properly in tests
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-10-30 10:40:11 +07:00
d04d575ed3
Merge branch 'master' into feat/taskprocessing/user-facing-error-message
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-10-30 10:13:39 +07:00
Andy Scherzinger
nfebe
provokateurin
Joas Schilling
Louis Chmn
Sebastian Krupinski
Carl Schwan
Côme Chilliet
Tobias Kaminsky
Marcel Müller
Daniel Calviño Sánchez
Richard Steinmetz
Joas Schilling
Arthur Schiwon
Robin Appelman
Ferdinand Thiessen
Benjamin Gaussorgues
Marcel Klehr