Commit Graph

63 Commits (987af4193d58baa956dfd4c6d561d1b1be462f1d)

Author SHA1 Message Date
provokateurin 987af4193d
fix(files): Always transfer incoming shares when doing ownership transfer to prevent broken reshares
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-01 13:08:13 +07:00
provokateurin 918473d7f2
fix(files): Limit transferring incoming shares to the selected path
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-01 13:05:25 +07:00
grnd-alt cdad92d2bb feat: improve occ file:transfer-ownership logging
Signed-off-by: grnd-alt <github@belakkaf.net>
2025-03-20 00:56:11 +07:00
Daniel f9354dab23
Merge pull request #49761 from nextcloud/transfer-share-skip-notfound
fix: skip transfering shares that we can't find
2025-01-16 17:58:06 +07:00
Robin Appelman 757076af29
fix: explicitly ignore nested mounts when transfering ownership
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-06 14:45:35 +07:00
Robin Appelman c00724bac8 fix: skip transfering shares that we can't find
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-03 15:21:17 +07:00
provokateurin 715e7143f0
fix(files_sharing,files): Do not validate shares before adjusting the owner
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +07:00
Côme Chilliet 901496276b
Merge pull request #47425 from nextcloud/fix/avoid-invalid-share-on-transfer-ownership
fix: promote re-shares when deleting the parent share
2024-11-04 10:09:58 +07:00
provokateurin 381077028a
refactor(apps): Use constructor property promotion when possible
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +07:00
Christopher Ng 7ba52eae35 refactor: Inject IRootFolder
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-10-16 15:28:12 +07:00
Christopher Ng 53f0b3789e fix: Fix "Unknown path" error when source user `files` folder has not been initialized
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-10-16 15:26:33 +07:00
Côme Chilliet 1580c8612b
chore(apps): Apply new rector configuration to autouse classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 10:40:25 +07:00
Côme Chilliet 7a48f8d929 fix: Transfer incomming shares first, do not delete non-migratable ones
Canceling the previous add of deletion of invalid shares in
 transferownership because in some cases it deletes valid reshares, if
 incoming shares are not transfered on purpose.
Inverting the order of transfer between incoming and outgoing so that
 reshare can be migrated when incoming shares are transfered.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-14 11:58:47 +07:00
Luka Trovic 42181c2f49 fix: delete re-shares when deleting the parent share
Note: Removed part about fix command from original PR

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-14 11:58:47 +07:00
Côme Chilliet bcf670e6b5
feat(transfer-ownership): Improve verbose output of command
Makes debbuging way easier

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-07 15:35:47 +07:00
Côme Chilliet 0555900134 fix(transfer-ownership): Improve comments according to code review
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 14:44:50 +07:00
Côme Chilliet d92bf388b1 feat(transfer-ownership): Correctly react to encrypted files
For E2EE encrypted files, we abort the transfer.
For SSE encrypted files, we abort only if not using master key.
Also fixed the check for when the path to a single file is used.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 14:44:50 +07:00
Daniel Kesselberg af6de04e9e
style: update codestyle for coding-standard 1.2.3
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +07:00
Ferdinand Thiessen 4bd9bc7b06
feat(files): Use receiving users language for the ownership transfer target folder
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-29 20:19:58 +07:00
Andy Scherzinger 5b7dcc1427
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-29 08:58:16 +07:00
Côme Chilliet 4c27e88b40
fix(files): Fix ownership transfer encrypted files detection
Discovered by psalm update

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 09:23:59 +07:00
Ferdinand Thiessen 38f4451a23
fix(files): Also restore shares after ownership transfer for object storage
When a file is moved between different storages then the file id is not (always) preserved.
This means the file id has to be adjusted for all shares.

So in case the file id does not exist anymore we try to find the new file id based on the
target path of the transfer and the path suffix of the share.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-04-18 13:51:47 +07:00
John Molakvoæ 816ddaf8b3
Merge pull request #39215 from shdehnavi/replace_substr_calls_in_files_app 2024-02-23 19:45:56 +07:00
Joas Schilling aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +07:00
Hamid Dehnavi df0a396b4c Refactor "substr" calls to improve code readability
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-09-27 20:36:23 +07:00
Julius Härtl b62e29051e
fix: Always create user directory when transfering files to new users
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-06 20:51:56 +07:00
Michiel de Jong c0e84cb512 Add SHARE_TYPE_SCIENCEMESH
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
2023-03-08 16:46:55 +07:00
Vincent Petry 62d47100ec
Merge pull request #30953 from nextcloud/feat/init-storage-when-transferring-ownership
Init user's file system if not existing on ownership transfer
2022-02-10 18:13:43 +07:00
Vincent Petry 7858fee5b5
Fix path handling when transferring incoming shares
When transferring incoming shares from a guest user without specifying a
path, the $path is empty.
The fix properly handles that situation to avoid looking for shares in a
path with doubled slashes which failed to find shares to transfer.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-02-10 09:50:21 +07:00
Carl Schwan 02da4ce1b0 Init user's file system if not existing on ownership transfer
This makes it a bit easier to transfer ownership when the new user
hasn't already logged in. This still doesn't support encrypted
storages because the keys are not generated yet.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-01 13:26:41 +07:00
Vincent Petry fa23a9f720
Do not transfer shares for deleted users
Whenever a user was deleted but is still recipient of share entries,
delete these entries upon transfer.

Usually such entries would disappear after running cleanup background
jobs.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-10-04 11:04:04 +07:00
Immanuel Pasanec 1f42657bb9
Added support for transfering incoming file shares.
- new option --transfer-incoming-shares=1 | 0
- new config.php option 'transfer-incoming-shares' => true | false

The command line option overrules the config.php option.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-08-27 17:55:58 +07:00
Christoph Wurst ffcf27c757
Log exception message during failed ownership transfer share restore
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-08-24 09:22:30 +07:00
John Molakvoæ (skjnldsv) 215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
Christoph Wurst e68c4a4ed3
Only perform login check during ownership transfer for encryption
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-19 11:25:56 +07:00
Christoph Wurst d89a75be0b
Update all license headers for Nextcloud 21
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +07:00
Julius Härtl f3150f29a7
Introduce deck share type to ShareAPIController
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-12-09 13:20:24 +07:00
Joas Schilling f0b46ea605
Merge pull request #22648 from nextcloud/bugfix/noid/transfer-all-shares
Transfer shares if no path provided
2020-09-09 13:32:43 +07:00
Julius Härtl aa04a26c68
Transfer shares if no path provided
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-09-07 17:35:29 +07:00
Christoph Wurst 1f7f93a695
Update license headers for Nextcloud 20 (again)
There are still lots of outdated headers, so time for another round of
updates.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-09-07 14:37:44 +07:00
Julius Härtl ac2999a26a
Transfer shares of the transferred root node
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-31 14:23:34 +07:00
Christoph Wurst 2a054e6c04
Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +07:00
Morris Jobke 420a3762cb
Merge pull request #21797 from rawtaz/patch-1
Include e-mail shares when transferring ownership
2020-08-20 16:08:51 +07:00
Morris Jobke 4e297d7a97
Use constant instead of magic number
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-11 08:14:03 +07:00
Julius Härtl cb2f5a829e
Do not exit if available space cannot be determined on file transfer
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2020-08-11 08:14:03 +07:00
rawtaz 97d82e2a64
Include circle shares when transferring ownership 2020-07-15 13:51:04 +07:00
rawtaz 6184604771
Include e-mail shares when transferring ownership
E-mail shares weren't included in the processing of shares when using the `occ files:transfer-ownership` command, so they'd be lost (not visible in either the former or the new account). This commit fixes that.
2020-07-11 16:51:40 +07:00
Joas Schilling 89ed2c37bf
Update share type constant usage
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-24 16:49:16 +07:00
Christoph Wurst cb057829f7
Update license headers for 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +07:00
Christoph Wurst caff1023ea
Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +07:00