Commit Graph

20307 Commits (984a212c6e5afa17484036f6b1f88ab6b0e1012a)

Author SHA1 Message Date
Robin Appelman a887553ddb
return default bundle when there is an error getting the bundle
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-14 18:34:09 +07:00
Robin Appelman 194a21f374
use the nextcloud certificate bundle for s3
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-14 18:09:48 +07:00
Robin Appelman 74f64fa3eb
don't error if we can't load the ExceptionSerializer for early exceptions
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-14 17:12:53 +07:00
Côme Chilliet 1973b2fb75
Fix autoloader and phpdoc for new class
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-14 14:34:15 +07:00
Côme Chilliet b63d22b6ea
Improve wording of pathExists description
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-14 14:34:15 +07:00
Côme Chilliet b4b9e8adf7
Add getOriginalUid in IImportSource to simplify code when importing under another uid
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-14 14:34:14 +07:00
Côme Chilliet 5534f70c5d
Add pathExists method to IImportSource to test if a path exists in the archive
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-14 14:34:14 +07:00
Côme Chilliet d8b2d32a5e
Move UserMigrationException to OCP and add @throws documentation
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-14 14:33:57 +07:00
Carl Schwan 371fa1c49a
Merge pull request #31542 from nextcloud/psalm-userCounts
Fix psalm issue about userCounts
2022-03-14 11:27:43 +07:00
Nextcloud bot 4e96db8608
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-03-14 02:27:10 +07:00
Joas Schilling db1c2a5375
Merge pull request #31511 from nextcloud/bugfix/noid/allow-installing-unstable-versions
Allow installing unstable app versions based on channel and with `--allow-unstable` just like on updates
2022-03-11 14:26:30 +07:00
Carl Schwan 8d7380a15d Fix psalm issue about userCounts
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-03-11 14:17:29 +07:00
Julius Härtl 27f3aa5890
Only log events when enabled in debug mode
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-03-11 12:26:07 +07:00
Pytal eeec6142ca
Merge pull request #30963 from nextcloud/feat/calendar-migration 2022-03-10 11:34:11 +07:00
Joas Schilling a9ba631e4d
Also allow pre-releases and nightlies when installing from git
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 16:10:25 +07:00
Joas Schilling 4f9c8b08ca
Similar to the fetch() method respect the channel in the get()
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 16:10:25 +07:00
Vincent Petry 430bd6b1e2
Merge pull request #31494 from nextcloud/fix/fix-group-metadata-typing
Fix group metadata typing
2022-03-10 14:33:54 +07:00
Joas Schilling b35253a4c3
Enforce primary keys as they are required to be performant in MySQL clusters
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-10 10:24:05 +07:00
Julius Härtl bd03dd37be
Allow to set a strict-dynamic CSP through the API
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-03-09 15:10:27 +07:00
Côme Chilliet d5544923a9
Strong type OC\Group\MetaData
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-08 16:44:22 +07:00
John Molakvoæ ec4280eda0
Merge pull request #31493 from nextcloud/bugfix/noid/app-script-main 2022-03-08 16:29:13 +07:00
Robin Appelman e8872f01ae
Merge pull request #31431 from nextcloud/fs-setup-manager
Unify/cleanup filesystem setup
2022-03-08 14:50:25 +07:00
Côme Chilliet 3ecba9fd17
Fix typing of OC\Group\MetaData::sorting
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-08 15:49:29 +07:00
Julius Härtl e8cf1a8759
Avoid double-loading dist/core-main.js when apps have scripts named main
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-03-08 15:37:53 +07:00
Pytal 232af474a8
Merge pull request #31418 from nextcloud/enh/simple-file-extension 2022-03-07 11:38:23 +07:00
Christopher Ng 26e3bdfce3 Note DI only usage in PHPDoc
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-07 18:14:51 +07:00
Côme Chilliet eb60b650aa
Add missing @since in InMemoryFile to please CI
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-03-07 10:46:05 +07:00
MichaIng 89e2eac825
Merge pull request #31447 from nextcloud/doc/manager-interface
Clarify that some interface are not meant to be implemented
2022-03-06 01:40:04 +07:00
Carl Schwan 5a17415dd8 Add a few more non-extendable interface
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-03-05 14:35:34 +07:00
Robin Appelman 917c74e214
type fixes
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:16 +07:00
Robin Appelman 07a7dcb824
move user mountpoint setup to setupmanager
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:12 +07:00
Robin Appelman d81713e5c1
simplify setup of circular SetupManager<->Manager
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:09 +07:00
Robin Appelman 6c1d051ecd
add template annotations to CappedMemoryCache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:06 +07:00
Robin Appelman 22875bf367
move logic to decide what to setup to setupmanager
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:03 +07:00
Robin Appelman 1c468129af
adjust tests to new fs setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:29:59 +07:00
Robin Appelman 5c0fe93498
move teardown logic to SetupManager
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:29:50 +07:00
Robin Appelman 15ff65c12f
start moving filesystem setup logic to it's own place
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:29:47 +07:00
Robin Appelman 7630d7a934
more type hints for ICachedMountInfo and IMountManager
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:28:11 +07:00
Carl Schwan 831aebf4f6 Clarify that some interface are not meant to be implemented
This make sure that apps don't implement this interfaces and gives us
more liberty to add new methods to them (as long as it is compatible
from an usage point of view)

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: Vincent Petry <vincent@nextcloud.com>
2022-03-04 16:02:35 +07:00
John Molakvoæ 69a6efba47
Merge pull request #31449 from nextcloud/bugfix/noid/even-more-censor 2022-03-04 15:05:24 +07:00
Robin Appelman 8b22a463e9
Merge pull request #31266 from nextcloud/root-setup-mountprovider
move root mount setup to mountproviders
2022-03-04 13:44:05 +07:00
John Molakvoæ 821a0dc875
Merge pull request #31387 from nextcloud/fix/common-main-core-script-order 2022-03-04 14:37:41 +07:00
Julien Veyssier a295529576
censor app config values for all integration apps
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-03-04 13:06:37 +07:00
John Molakvoæ 58d516b509
Make sure common and main core scripts are loaded first
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-03-04 10:22:56 +07:00
Christopher Ng 0571391b10 Extend simple file with extension getter
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-04 06:11:53 +07:00
Christopher Ng 31a9be0482 Fix avatar file return type
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-03 15:48:00 +07:00
John Molakvoæ 6261d6731a
Merge pull request #31398 from nextcloud/techdebt/noid/also-use-hashed-column-on-delete 2022-03-02 12:08:10 +07:00
Julius Härtl 2ff0c972c9
Merge pull request #31124 from nextcloud/enh/diagnostics-logging
Diagnostics event logging to log
2022-03-02 12:00:44 +07:00
Joas Schilling 18bafefb00
Merge pull request #31218 from nextcloud/techdebt/noid/use-cache-also-for-userbackend-getpassword
Use the cache also for UserBackend::getPassword
2022-03-02 11:41:32 +07:00
Joas Schilling abcf45e336
Also use hashed/indexed column on delete
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-02 09:23:16 +07:00
Christopher Ng 0cbb6d7ba9 Various minor updates
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-02 02:15:05 +07:00
Christopher Ng 4eff359441 Calendar export and import
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-03-02 01:59:15 +07:00
Joas Schilling 1e27aed4dc
Censor more configs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-03-01 21:08:16 +07:00
Côme Chilliet 3ade269d1b
Merge pull request #31333 from nextcloud/fix/fix-archive-typing
Improve typing in OC\Archive classes
2022-03-01 14:20:03 +07:00
Côme Chilliet ce87b44224
Merge pull request #31380 from nextcloud/fix/opendocument-preview-avoid-errors
Ignore errors when searching for bundled preview
2022-03-01 14:10:47 +07:00
Côme Chilliet 13c11208d4
Ignore errors when searching for bundled preview
When an odt file is xml and not zip, it would throw a ValueError.
It will now just ignore this file and return null for the preview.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-28 15:43:07 +07:00
Joas Schilling b90e657ac7
Delay loading user preferences until we need them
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-28 13:49:12 +07:00
Anna c203bc71ad
Merge pull request #31377 from nextcloud/fix/specify-nullable-string
Specify string as nullable for credentials password
2022-02-28 12:03:36 +07:00
Côme Chilliet 5c4cba17f7
Merge pull request #30889 from nextcloud/fix/fix-occ-listeners
Fix listeners declaration in case of occ usage
2022-02-28 11:52:03 +07:00
Julius Härtl 83717a7800
Add event logging for db and redis connection
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-02-28 11:24:41 +07:00
Julius Härtl eede608c0e
Add event logging to app loading
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-02-28 11:24:41 +07:00
Julius Härtl 0f33453610
Diagnostics event logging to Nextcloud log
Signed-off-by: Julius Härtl <jus@bitgrid.net>

Add config samples

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-02-28 11:24:40 +07:00
Anna Larch f68028e85e Specify string as nullable for credentials password
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-02-28 11:08:48 +07:00
Côme Chilliet 63d7e7c798
Build OC\Core\Application when running occ or cron to register listeners correctly
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-28 10:31:52 +07:00
Côme Chilliet 19f68b3011
Merge pull request #31339 from nextcloud/fix/preview-code-cleaning
Fix typing in OC\Preview
2022-02-28 10:26:23 +07:00
Christoph Wurst c1000fe344
Merge pull request #31304 from nextcloud/feature/dry_run_for_add_indices
Add --dry-run option for add-missing-* cmd
2022-02-28 09:59:40 +07:00
Joas Schilling 88f4e972c5
Don't set up full filesystem to check for certificates
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-26 00:40:12 +07:00
Joas Schilling 86de1d569f
Only setupFS when we have to copy the skeleton
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-25 15:55:06 +07:00
Robin Appelman b0ce876f41
return dummy availability if storage is not found in cache
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-25 15:25:13 +07:00
Robin Appelman 215fa17d04
catch storage not available when deleting avatar
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-25 15:14:32 +07:00
Joas Schilling 67452b94ca
Update autoloader
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-25 10:38:12 +07:00
Christopher Ng 321e1cdce3 Extend ImportSource interface to list files of a folder
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-02-24 16:53:50 +07:00
Robin Appelman 8b7c8447a0
move root mount setup to mountproviders
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-24 17:21:42 +07:00
Côme Chilliet 77644cb674
Move to strong typing in OC\Archive
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-24 17:04:09 +07:00
Louis Chemineau 405c5eb813 Add --dry-run option for db:add-missing-* cmd
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-02-24 16:42:08 +07:00
Côme Chilliet 0daec4b27e
Fix tmp file cleaning for bundled previews
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-24 14:55:57 +07:00
Côme Chilliet d43dbfa0f2
Fix typing in OC\Preview\Movie
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-24 14:55:48 +07:00
Côme Chilliet ebe731f014
Fix typing in OC\Preview
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-24 14:42:55 +07:00
Côme Chilliet 153eca8ef0
Fix unused import in OC\Archive\ZIP
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-24 12:34:32 +07:00
Côme Chilliet c9100e3d44
Fix more typing in OC\Archive classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-24 12:25:04 +07:00
Côme Chilliet 7b1a044131
Improve typing in OC\Archive classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-24 12:03:36 +07:00
Nextcloud bot 6da8a6d62a
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-24 02:26:36 +07:00
Robin Appelman cfb7923e08
store mountprovider for each mount in the mounts table
this enabled more fine grained filesystem setup

Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-23 18:02:33 +07:00
Simon L 692da9236b
Merge pull request #31328 from nextcloud/bugfix/noid/mark-split-database-configs-as-sensitive
Mark split database configs as sensitive
2022-02-23 17:34:20 +07:00
Joas Schilling bf4acd5452
Merge pull request #31106 from nextcloud/techdebt/noid/improve-user-status-update-handling
Improve user status revert performance
2022-02-23 11:17:16 +07:00
Joas Schilling 1c138d3ae2
Allow to prefix the Query log with the request id
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-23 11:01:58 +07:00
Joas Schilling 07a9f34385
Extract request id handling to dedicated class so it can be injected manually
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-23 11:01:58 +07:00
Joas Schilling 6302ff0f96
Mark split database configs as sensitive
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-23 10:31:17 +07:00
Nextcloud bot 98fd66b137
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-23 02:27:42 +07:00
Christoph Wurst ef4c18a266
Deprecate our old, internal background job base classes
The OCP ones should be used instead. This makes it more visible in our
IDEs that the base class of background job should be replaced.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-02-22 11:31:54 +07:00
Côme Chilliet 5b565a4726
Merge pull request #31173 from nextcloud/enhancement/user_migration-version-handling
Add version handling to IMigrator
2022-02-22 09:02:34 +07:00
Nextcloud bot 67f192e906
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-22 02:29:25 +07:00
Côme Chilliet 07940f9d05
Please drone checkers
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-21 18:20:27 +07:00
Côme Chilliet 09cf851979
Update autoload
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-21 16:24:36 +07:00
Joas Schilling 87115d8b1c
Merge pull request #31217 from nextcloud/bugfix/noid/also-cache-non-existing-entry
Also cache non-existing to reuse it
2022-02-21 11:50:40 +07:00
Louis d721339262
Merge pull request #31195 from nextcloud/wrap_exception
Wrap S3 multipart upload exception
2022-02-21 11:27:55 +07:00
Julius Härtl ee711ed66c
Merge pull request #30367 from nextcloud/fix/minor-api-doc-fix
Fix some issues with the API documentation
2022-02-18 10:44:50 +07:00
Joas Schilling 25caf4a42c
Update cache when setting the password
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-18 09:47:18 +07:00
Côme Chilliet 885b7904a2
Avoid passing both $importSource and $version while version comes from source
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-17 18:09:14 +07:00
Carl Schwan ac4978e715
Merge pull request #31141 from nextcloud/fix/better-cache-policy
Improve caching policy use immutable when loading versionned assets
2022-02-17 16:58:35 +07:00
Côme Chilliet 67fb1b92d6
Improve version handling for user_migration
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-17 11:31:03 +07:00
Côme Chilliet b06a622a60
Add version handling to IMigrator
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-02-17 11:30:55 +07:00
Carl Schwan 8af4054237 Fix some issues with the API documentation
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-17 11:09:06 +07:00
Christoph Wurst cb252c5591
Add Transactional trait for atomic DB operations
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-02-17 09:58:41 +07:00
Joas Schilling 23ef02fbe2
Use the cache also for UserBackend::getPassword
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-16 18:00:47 +07:00
Joas Schilling 397b9098e8
Also cache non-existing to reuse it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-16 16:51:22 +07:00
Louis Chemineau bc2c02f451 Wrap S3 multipart upload exception
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-02-16 14:56:14 +07:00
Carl Schwan 7dddbd0c35 Improve caching policy
* Cache css with version in url. This makes most js and css requests to
  be cached by the browser

* Force caching previews, the etag is in the url so that if the propfind
  gives a new etag, we will refresh it otherwise it's no use to try to
  fetch the new etag and do tons of DB queries

Tested with firefox and 'debug' => false (important so that the js/css
urls are generated with ?v= parameter)

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-02-16 11:35:57 +07:00
Nextcloud bot 393d581c3a
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-16 02:27:42 +07:00
Louis Chemineau 0b768c17d2 Wrap S3 multipart upload exception
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-02-15 17:35:12 +07:00
Joas Schilling deec4f31db
Allow to revert the user status of multiple users in 3 queries instead of 3*n
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-15 16:06:33 +07:00
Christopher Ng 21f9e85e1a Extend export destination interface
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-02-11 23:34:25 +07:00
Christopher Ng e3244361ba Allow registration of migrators
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-02-11 23:34:25 +07:00
Vincent Petry fbbbc2ec34
Merge pull request #30959 from nextcloud/redis-pconnect
use persistent connections when connecting to redis
2022-02-11 16:18:37 +07:00
Vincent Petry 787716613f
Merge pull request #31035 from paierlep/fix/occ_scan_no_files_error
Removes misleading error message in occ files:scan for new users.
2022-02-10 18:07:21 +07:00
Robin Appelman de260001f1
handle setupFS with null user
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:36 +07:00
Robin Appelman b799fd40e9
dont mark fs as setup when no user is active
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:31 +07:00
Robin Appelman 2673775f6e
fix fs cache test user setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:28 +07:00
Robin Appelman 1ab58eff0f
pass user object during fs init
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:24 +07:00
Robin Appelman 0217949715
only setup part of the filesystem for appdata requests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-09 16:01:21 +07:00
Christoph Wurst cd7a217c29
Merge pull request #31007 from nextcloud/enhancement/bootstrap-calendar-resource-room-backend-registration
Move calendar resource/room backend registration to IBootstrap
2022-02-09 10:25:03 +07:00
Joas Schilling c58f8d6025
Merge pull request #30945 from nextcloud/techdebt/noid/background-job-time-windows
Background job time windows
2022-02-08 14:46:20 +07:00
Vincent Petry a7925a6c47
Merge pull request #30973 from nextcloud/techdebt/noid/allow-spliting-activities-to-another-database
Allow specify a config prefix for another database connection
2022-02-07 15:16:32 +07:00
Joas Schilling b8e0a3dbdd
Use the new option to signaling insensitivity
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-07 13:54:54 +07:00
Joas Schilling b765f79368
Allow apps to specify if their background job can be delayed
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-07 13:54:54 +07:00
Christoph Wurst 9a656e5b35
Move calendar resource/room backend registration to IBootstrap
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-02-07 12:51:42 +07:00
Christian Paier 9476ce70ed Removes misleading error message in occ files:scan for new users.
Previously the occ files:scan command printed an error message for any
new users without any files/folders in the data directory.
With this change only users with any file/folder is scanned.

This fixes #25433.

Signed-off-by: Christian Paier <hallo+git@cpaier.com>
2022-02-05 23:54:56 +07:00
Nextcloud bot 9c2db7f4e4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-05 02:26:33 +07:00
Simon L 88ded737ce
Merge pull request #30984 from UmbrellaCodr/ffmpeg-preview
reduce 'Movie preview generation failed Output' log errors
2022-02-04 15:40:51 +07:00
Joas Schilling 82f602e857
Merge pull request #30354 from nextcloud/enhancement/talk-api
Add a Talk API for OCP
2022-02-04 09:54:13 +07:00
Joas Schilling 2f2538a57a
Merge pull request #30888 from nextcloud/comments-interface
Update ICommentsManager with reaction methods
2022-02-04 09:38:04 +07:00
Christoph Wurst 2c356d0852
Add a Talk API for OCP
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-02-04 08:53:18 +07:00
UmbrellaCodr a0d7e27789
reduce 'Movie preview generation failed Output' log errors
for movies under 5 seconds

Signed-off-by: UmbrellaCodr <umbrella@biohazard.cc>

Update lib/private/Preview/Movie.php

Co-authored-by: Simon L. <szaimen@e.mail.de>
2022-02-03 17:52:37 +07:00
Simon L 68b2463107
Merge pull request #30990 from nextcloud/enh/noid/fulltextsearch-collection
FullTextSearch/IIndex: +getCollection(): string;
2022-02-04 00:18:17 +07:00
Joas Schilling 76541170bb
Allow specify a config prefix for another database connection
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-03 17:16:03 +07:00
Vitor Mattos 8ec7c5c8ae
Update ICommentsManager with reaction methods
Fix psalm errors
Reorder methods and remove return null
Use best pattern on docblock

Goals: update https://github.com/ChristophWurst/nextcloud_composer/ with reaction methods.
The script
https://github.com/ChristophWurst/nextcloud_composer/blob/master/build.sh
only get lib/public classes

Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-02-03 12:52:18 +07:00
Maxence Lange 144e83520b +getCollection(): string;
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2022-02-03 10:35:06 +07:00
Claus-Justus Heine a355410b88
Use the unjailed-path in OC_Helper::getStorageInfo() for files located in SharedStorage.
The current implementation already switches the storage-backend to
$storage->getSourceStorage(). However, it then calls
$rootInfo->getInternalPath() which returns the internal path relative to
the storage where the share is mounted. This is wrong, we need also to
unjail the path. Compare, e.g., with
OCA\Files_Sharing\SharedStorage::file_get/put_contents() for the
"logic".

Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
2022-02-03 10:05:49 +07:00
Nextcloud bot e167d7f44c
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-02-03 02:26:58 +07:00
Joas Schilling 5e5c31ea84
Merge pull request #30235 from nextcloud/bugfix/noid/primary-key-for-ratelimit-table
Add primary key for ratelimit table
2022-02-02 10:03:26 +07:00
Robin Appelman 698a713904
use persistent connections when connecting to redis
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-01 18:14:59 +07:00
Robin Appelman c712987878
send request id in response header
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-01 14:24:01 +07:00
Côme Chilliet d635d58d19
Merge pull request #29286 from nextcloud/enhancement/drop-php-7-3
Drop PHP7.3
2022-02-01 10:50:28 +07:00
Claus-Justus Heine a234217bb7
Allow sub-admins to access delegated settings.
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
2022-01-31 14:08:49 +07:00
Joas Schilling b59df35426
Make the DB query simpler (as we just deleted all other entries)
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-28 16:55:17 +07:00
Joas Schilling fcb3e9a071
Add a primary key to ratelimit_entries table
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-28 16:55:16 +07:00
Joas Schilling e8c66d0f89
Merge pull request #30794 from nextcloud/techdebt/noid/allow-to-get-comments-with-verb
Allow to get comments with a given set of verbs
2022-01-28 16:41:42 +07:00
John Molakvoæ 73e3d06781
Merge pull request #30855 from nextcloud/psalm/theming 2022-01-27 20:04:02 +07:00
Vincent Petry 363bf208a0
Merge pull request #30876 from nextcloud/docs/deprecate_addScript
Add deprecation notice to script & addScript func
2022-01-27 17:34:13 +07:00
Carl Schwan f778cbe7b9
Fix registerEventListener issues
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-27 11:12:45 +07:00
Louis 34f425c150
Merge pull request #30858 from nextcloud/fix/ajax-list-dir-content-on-file
Return 404 when AJAX tries to list dir content but file given
2022-01-27 11:08:23 +07:00
Louis Chemineau 04c9de7312 Add deprecation notice to script & addScript func
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-27 11:04:30 +07:00
Simon L d23de2653e
Merge pull request #30832 from nextcloud/untrusted_domains_warning
Makes untrusted domain error a warning.
2022-01-26 18:28:17 +07:00
Joas Schilling fe6ceba03a
Merge pull request #30822 from nextcloud/bugfix/29287/remove-create-function-calls
Remove createPluralFunction which is replaced by Symfony\Translations…
2022-01-26 16:31:21 +07:00
MichaIng ba1338e680 Return 404 when AJAX tries to list dir content but file given
Due to a code mistake, the expected 404 return when AJAX tries to list a directory content with a non-directory file path given, does not happen. It instead fails with another exception.

This commit restores the original intention to return 404 in the first place when passing a non-directory path with the "dir" parameter.

Signed-off-by: MichaIng <micha@dietpi.com>
2022-01-26 16:11:50 +07:00
Carl Schwan e3a12b3482
Fix psalm issues in theming app
After this change, we are down to only one psalm warning for this app
and related to the Application.php. This also make composer
psam:update-baseline not silently ignore new errors.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-26 14:26:58 +07:00
Christoph Wurst 4259391162
Drop PHP7.3
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-01-25 17:25:08 +07:00
Côme Chilliet 5cca86ce19
Remove redundant if clause
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-25 16:53:35 +07:00
Côme Chilliet 35dcda36a3
Fix OC\Files\Storage\DAV::hasUpdated when cache is not set
Fixes the test OCA\Files_External\Tests\Storage\WebdavTest::testStat on
 PHP>=7.4

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-25 16:53:19 +07:00
Pierre Ozoux e6d9ef2e38 Makes untrusted domain error a warning.
It sends a 400 to the client, so I could even argue that it should be an error.

But currently as an admin, I'm quiet surprised that I get a 400 in the UI, and nothing in the log with the default level.

I saw this commit that explains the reason why info. But I disagree.

Feel free to close the PR if you don't agree with it.

Signed-off-by: Pierre Ozoux <pierre@ozoux.net>
2022-01-25 10:33:31 +07:00
John Molakvoæ 272f4cd6df
Merge pull request #30763 from nextcloud/feature/noid/allow-to-log-audit-to-syslog 2022-01-25 10:25:13 +07:00
Côme Chilliet ddae16d480
Add specific psalm-return for getAllUserValues
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>

Co-authored-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-24 11:16:44 +07:00
Côme Chilliet a6eb7dc676
Fix signatures and null $userId corner case
Configuration values are sometimes queried when there is no user in
 session, so $userId is null and we just want to return the default

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-24 11:16:44 +07:00
Côme Chilliet d630af4ca8
Add a new method getAllUserValues($userId) to IConfig
The method was already there in AllConfig but private

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-24 11:16:37 +07:00
Joas Schilling f03468342e
Remove createPluralFunction which is replaced by Symfony\Translations lib
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-24 09:27:01 +07:00
Nextcloud bot 6e47104bb6
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-24 02:26:40 +07:00
Nextcloud bot 9f489422b4
[tx-robot] updated from transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2022-01-22 02:26:35 +07:00
Joas Schilling fccb98c8b6
Merge pull request #30379 from nextcloud/feature/add-comments-reactions
Add comments reactions
2022-01-21 15:08:12 +07:00
Joas Schilling d2833a6552
Fix typo in deprecated
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 14:34:45 +07:00
Joas Schilling 1ceba64863
Allow to get comments with a given set of verbs
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 13:42:04 +07:00
Vitor Mattos ab630f2cab
Fix conflict
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:41 +07:00
Vitor Mattos b9f74584a1
Fix check after change from string to mb_string
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:41 +07:00
Joas Schilling c9f2f00777
Fix CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:40 +07:00
Joas Schilling ecb98f772e
Throw if trying to save reaction without support
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:40 +07:00
Joas Schilling e0b89cd576
Only check mb_strlen()
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:40 +07:00
Joas Schilling d850dc0220
Remove order from groupConcat as it is not working everywhere
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:39 +07:00
Joas Schilling 189f9f96ce
Limit the summary and sort it afterwards
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-21 08:39:39 +07:00
Vitor Mattos f071b4dfbb
Fix groupConcat and ordering on Oracle
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:39 +07:00
Vitor Mattos f7cd995612
Order the reaction summary, improvements on validations
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:39 +07:00
Vitor Mattos 1ce894a50c
Disable reactions if database don't support utf8mb4
Fix column size

Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:39:37 +07:00
Vitor Mattos b845042a67
Update composer autoload and change string to constant
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:07 +07:00
Vitor Mattos 898e87fe1a
Rename vars and move logic to method
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:07 +07:00
Vitor Mattos afe5b6dd8a
Prevent query error when use subquery
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:06 +07:00
Vitor Mattos a7c0868a4c
Prevent violate constraint
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:06 +07:00
Vitor Mattos 1dda03e1b5
Rename vars
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:05 +07:00
Vitor Mattos 9efbc9c1d5
Add comments reactions
Signed-off-by: Vitor Mattos <vitor@php.rio>
2022-01-21 08:37:04 +07:00
Julien Veyssier 7f7980f35c
Merge pull request #30770 from nextcloud/enh/logo-link-target-config
Allow changing the top-left logo link target in config.php
2022-01-20 18:02:37 +07:00
Côme Chilliet ff809410f8
Merge pull request #30769 from nextcloud/fix/memcached_clear
Always call flush() as getAllKeys() is broken
2022-01-20 16:30:26 +07:00
Julien Veyssier c0b6b78674
allow changing the top-left logo link target in system config
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-01-20 15:11:16 +07:00
Joas Schilling de9fe8fcc1
Merge pull request #30471 from nextcloud/enh/cast-char-mysql
Explicitly cast char in the query builder
2022-01-20 14:32:56 +07:00
Côme Chilliet 36d7c73e69
Always call flush() as getAllKeys() is broken
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-01-20 11:20:18 +07:00
Louis 3e262c7e3a
Merge pull request #30745 from nextcloud/fix/dont_use_deprecated_methods
Use less deprecated methods in base.php
2022-01-19 18:04:19 +07:00
Joas Schilling 4c41abd816
Allow to get custom loggers for syslog, errorlog and systemdlog too
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-19 16:15:14 +07:00
Joas Schilling 677b25b0d3
Merge pull request #30731 from nextcloud/bugfix/noid/help-debugging-bruteforce-attempts
Log bruteforce throttle and blocking
2022-01-19 12:38:23 +07:00
Louis Chemineau b46ff973e0 Use less deprecated methods in base.php
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-19 11:07:12 +07:00
John Molakvoæ eb3cf6c5ec
Merge pull request #30129 from nextcloud/mdb10.6-pipeline 2022-01-19 09:25:46 +07:00
Vincent Petry d6716ccb21
Merge pull request #30733 from nextcloud/bugfix/noid/fix-update-button
Load core before the update script
2022-01-18 16:28:49 +07:00
Joas Schilling c8bfd8a559
Load core before the update script
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-18 14:55:13 +07:00
Julius Härtl 99b2cf8339
Add hashed attribute column for indexed job existence check
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-01-18 14:01:24 +07:00
Joas Schilling c6d000f87f
Log bruteforce throttle and blocking
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-18 10:10:19 +07:00