Marcel Klehr
a8b27c9126
TranscriptionJob: Add owner argument to simplify filesystem setup
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-19 11:26:04 +07:00
Marcel Klehr
eb996cbbb0
TranscriptionJob: Ensure filesystem is setup before trying to retrieve file
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-18 16:24:06 +07:00
Jérôme Herbinet
c343569b3f
To be consistent with the list of users
...
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
2023-04-18 15:47:26 +07:00
Marcel Klehr
9649f91892
Update lib/private/SpeechToText/SpeechToTextManager.php
...
Co-authored-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-18 15:24:14 +07:00
Simon L
8508865eaf
Merge pull request #37772 from nextcloud/enh/30986/follow-up
...
Prevent the OpenDocument preview generator from trying to open empty files
2023-04-18 12:18:14 +07:00
Simon L
8fe22ebf60
Merge pull request #36617 from nextcloud/update/psr-container
...
chore: Update PSR container to 2.0.2
2023-04-18 11:40:12 +07:00
Simon L
5f879a705b
Merge pull request #37316 from nextcloud/fix/security/strict-cookie-check-status-codes
...
fix(security)!: Use consistent HTTP status for strict cookie checks
2023-04-18 11:39:18 +07:00
Joas Schilling
bef4cf0ad1
Fix missing import
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-18 10:01:00 +07:00
Simon L
855e7a2efb
Merge pull request #36774 from nextcloud/bugfix/noid/sabre-nodes
...
fix: always use proper path on node api when calling the view
2023-04-18 04:11:44 +07:00
Simon L
45a0fe490c
Merge pull request #37534 from Rsplwe/master
...
Adjust the value of the "max-parts" parameter of the object storage 'ListPart' interface to 1000
2023-04-18 00:16:38 +07:00
Simon L
0a763820bc
Merge pull request #37676 from nextcloud/fix/auth/atomic-password-db-statements
...
fix(auth): Run token bulk update statements in atomic transaction
2023-04-17 23:48:24 +07:00
Julius Härtl
160bd75d0a
fix: Use proper path when creating node instances
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-17 23:46:52 +07:00
Simon L
85c9e75f33
Merge pull request #32314 from nextcloud/object-mkdir-logging
...
additional logging when mkdir fails for object storage
2023-04-17 23:42:08 +07:00
Simon L
5cda8f0f45
Merge pull request #35129 from Glandos/previewperf2
...
[Performance] Reuse preview directory listing
2023-04-17 20:22:39 +07:00
Simon L
d87cc208bb
Merge pull request #31286 from rotdrop/bugfix/dont-start-session-when-session-is-already-open
...
Don't call session_start() when PHP session is still or already open.
2023-04-17 20:14:53 +07:00
Ferdinand Thiessen
dc9d8c42bb
fix: Adjust console formatter code to match with Symfony type hints
...
Symfony has added type hints on the `OutputFormatterInterface`,
so we must adjust our type hints to match with Symfony.
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-04-17 18:35:10 +07:00
Christoph Wurst
a06898a2d0
fix(security)!: Use consistent HTTP status for strict cookie checks
...
Before: 503/412
Now: 412 + json body explaining the error
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-04-17 16:06:37 +07:00
Simon L
800f40b71c
fix php-lint
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-17 17:18:09 +07:00
Marcel Klehr
3f57725a7c
SpeechToTextManager#transcribeFile: Try next provider if one fails
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-17 16:59:46 +07:00
Glandos
e542e60dbc
try to make linters happy
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:14 +07:00
Glandos
3440387f0f
gather code from small and max preview
...
use directory listing in both functions to gain 25% speed on run where
every preview already exist.
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
Glandos
24c121347a
Revert 0e49b40
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
Glandos
06a7e90383
improve parameter doc
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
Glandos
4954bead1d
Ensure max preview image is not null
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
Glandos
b6c65fee2a
php-cs-fix
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
Glandos
9b4d5146d5
List preview directory only once
...
getCachedPreview used to call `getFile`, and this calls `getDirectoryListing` (or underlying function that list directory) to find the file. This was done for every preview spec.
Now, this is done only once at the beginning of the loop, and the array is just iterated when needed to find the correct entry.
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
Claus-Justus Heine
45ec432492
Don't call session_start() when PHP session is still or already open.
...
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
2023-04-17 16:23:02 +07:00
Claus-Justus Heine
456679c6fb
Update lib/private/Preview/Bundled.php
...
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2023-04-17 16:19:02 +07:00
Claus-Justus Heine
b3d8363327
Prevent the OpenDocument preview generator from trying to open empty files.
...
Rationale: does not make sense, and triggers a deprecation error in
\ZipArchive.
Signed-off-by: Claus-Justus Heine <himself@claus-justus-heine.de>
2023-04-17 16:19:02 +07:00
Marcel Klehr
6e9f260348
Update lib/private/SpeechToText/SpeechToTextManager.php
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-17 15:49:50 +07:00
Thomas Citharel
036cd47bf4
Put Mimeloader insertion and read in the same transaction
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-04-17 13:32:02 +07:00
Marcel Klehr
3779cc3d88
SpeechToTextManager: Deduplicate transcription jobs
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-17 14:57:19 +07:00
Marcel Klehr
71523b9816
AbstractTranscriptionEvent: Add File param
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-17 14:57:19 +07:00
Varun Patil
39e805fffa
redis: use atomic operations everywhere
...
This removes a lot of acrobatics in the code and does each operation
atomically using a lua script. This also reduces several round trips
to the server, and the scripts are compiled and cached server-side.
Notably, since all operations work only on a single key (except clear,
which is broken anyway and shouldn't be used), they will continue to
function and be atomic for Redis cluster.
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-04-16 14:38:56 +07:00
Julius Härtl
eecd4601ac
Merge pull request #37429 from nextcloud/object-store-rmdir
...
improve objectstore rmdir handling
2023-04-13 18:45:12 +07:00
Marcel Klehr
ad66180c34
Update lib/private/SpeechToText/SpeechToTextManager.php
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-13 15:17:17 +07:00
Marcel Klehr
865ebfaf72
Add missing strict_types + author + copyright
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-13 12:15:18 +07:00
Marcel Klehr
a8d3fff648
Split TranscriptionFinishedEvent into Successful and Failed events
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-13 12:12:07 +07:00
Marcel Klehr
176f1af26a
ISpeechToTextManager: Take File as input, drop $context
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-13 11:57:23 +07:00
Marcel Klehr
ef7ce88cee
ISpeechToTextProvider#transcribeFile: Pass \OCP\Files\File instead of path
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-12 16:52:11 +07:00
Christoph Wurst
5eb768ac5e
fix(auth): Run token statements in atomic transaction
...
All or nothing
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-04-12 15:55:42 +07:00
Maxence Lange
fc29b0d1b7
app type extended_authentication
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-04-12 09:34:49 +07:00
Arthur Schiwon
ec1acb92c7
Merge pull request #37617 from nextcloud/notify-self-test-error
...
handle not being able to write file for notify self-test
2023-04-11 19:43:41 +07:00
Marcel Klehr
a9b5d1f9da
chore(coding style): Run cs:fix
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-11 15:04:30 +07:00
Marcel Klehr
317521b607
feat(SpeechToText): Add SpeechToText provider API
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-11 14:59:57 +07:00
jld3103
b153340b62
Add type hints for mappers
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-07 09:49:42 +07:00
Jan Messer
647c65a640
[BUGFIX] throw exception instead of error if unable to create file handler (only exceptions are catch)
...
Signed-off-by: Jan Messer <jan@mtec-studios.ch>
2023-04-06 23:03:49 +07:00
Jan Messer
7a443863fe
[BUGFIX] check return value and improve error handling
...
With S3 primary storage there was a problem with getting the CA bundle from the storage without having the CA bundle for the connection which causes that the CertificateManager was throwing an Error.
This commit improves the handling in CertificateManager and log unexpected behaviors.
Signed-off-by: Jan Messer <jan@mtec-studios.ch>
2023-04-06 23:03:33 +07:00
Vincent Petry
9f05eff3ef
Merge pull request #34607 from nextcloud/encryption-size-not-found
...
fix encryption wrapper filesize for non existing files
2023-04-06 18:04:44 +07:00
Robin Appelman
570b64aafc
handle not being able to write file for notify self-test
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-06 11:52:22 +07:00
Robin Appelman
03e965a513
Merge pull request #22943 from nextcloud/scanner-no-access-handling
...
improve handling of files we can't access in the scanner
2023-04-05 21:36:21 +07:00
Côme Chilliet
e63a6f5cdb
Merge pull request #27538 from nextcloud/scanner-home-not-writable-better-errors
...
better error messages if the users home is not writable during scanning
2023-04-05 17:53:42 +07:00
Côme Chilliet
8d5165e8dc
Adapt tests to config value typing
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 17:42:14 +07:00
Robin Appelman
63fc83de26
Merge pull request #33292 from nextcloud/no-profiler
...
don't hard error when trying to load profiles with no profiler registered
2023-04-05 15:57:50 +07:00
Robin Appelman
c6be96d04f
additional logging when mkdir fails for object storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-05 14:52:19 +07:00
Robin Appelman
b1f352c614
improve handling of files we can't access in the scanner
...
instead of erroring, remove the items from the cache.
this situation can be triggered if a user has access to a file but looses it afterwards
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-05 14:44:55 +07:00
Robin Appelman
54f61352f0
better error messages if the users home is not writable during scanning
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-05 13:21:30 +07:00
Côme Chilliet
426c0341ff
Use typed version of IConfig::getSystemValue as much as possible
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 12:50:08 +07:00
Côme Chilliet
8f550398c4
Merge pull request #36836 from nextcloud/fix/view-type-cleanup
...
Tidy up typing in OC\Files\View
2023-04-05 10:14:55 +07:00
Côme Chilliet
6633b4ced6
Remove unecessary fully qualified namespaces from phpdoc
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 09:13:39 +07:00
jld3103
d9f8522003
Fix types for reading and writing config values
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-05 09:08:56 +07:00
Robin Appelman
43b61d26e8
don't hard error when trying to load profiles with no profiler registered
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-04 17:24:29 +07:00
Robin Appelman
9d3c8b7e70
Merge pull request #36360 from nextcloud/new-share-existing-node
...
also set the node when re-using existing share on share create
2023-04-04 17:11:24 +07:00
Robin Appelman
5267a74027
fix type hints
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-04 17:05:45 +07:00
Robin Appelman
8c9197d65e
fix unencrypted folder size when no children with unencrypted size set are left
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-04 16:48:11 +07:00
Robin Appelman
649bed5154
fix unencrypted_size for files when scanning
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-04 16:48:11 +07:00
Robin Appelman
63fb33538c
fix unencrypted_size for folders when scanning the filesystem with encryption enabled
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-04 16:48:10 +07:00
Robin Appelman
15a6920b07
fix encryption wrapper filesize for non existing files
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-04 16:21:17 +07:00
Joas Schilling
131f481a67
fix(initial-state): Log an error when initial-state can not be JSON encoded
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-04 10:54:12 +07:00
Louis
7ab44b2d28
Merge pull request #37146 from nextcloud/artonge/feat/migrate_metadata_to_value
...
Migrate metadata JSON column to new value TEXT column
2023-04-04 10:23:54 +07:00
Robin Appelman
d63fa2d991
improve objectstore rmdir handling
...
remove folder entries as they are cleared instead of in one go afterwards
otherwise they stick around if some of the child entries can't be removed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-03 18:28:29 +07:00
Robin Appelman
3473fa3187
also set the node when re-using existing share on share create
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-03 16:40:47 +07:00
Robin Appelman
5024f295dc
Merge pull request #36097 from nextcloud/path-prefix-optimize
...
extend path-prefix optimizer to remove all cases of path_hash= when encountering a path prefix filter
2023-04-03 16:39:49 +07:00
Rsplwe
5c6f35832c
Update lib/private/Files/ObjectStore/S3.php
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Rsplwe <i@rsplwe.com>
2023-04-03 21:59:59 +07:00
Côme Chilliet
dbc0d6a1c2
Merge pull request #37543 from nextcloud/fix/inherited-parameter-names
...
Fix inherited parameter names
2023-04-03 15:08:45 +07:00
Joas Schilling
c5339fa336
Merge pull request #37542 from nextcloud/bugfix/noid/allow-to-opt-out-of-ratelimit-for-testing
...
feat(security): Allow to opt-out of ratelimit protection, e.g. for te…
2023-04-03 14:19:41 +07:00
Louis Chemineau
1a6709cf43
Migrate metadata as JSON to value as STRING
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-03 14:06:28 +07:00
Arthur Schiwon
84c76a89ec
Merge pull request #37520 from nextcloud/fix/noid/fix-dbal-exception-handling
...
fix DBAL exception handling in setValues
2023-04-03 11:30:14 +07:00
Côme Chilliet
5ad045619c
View needs to return an instance of OC\Files\FileInfo explicitely
...
Applications are calling methods from the class which are not from the
public interface, and which cannot be added easily to public interface
because Node interface extends FileInfo.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:35 +07:00
Côme Chilliet
0b3dad895f
More type cleanup in View and FileInfo
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:35 +07:00
Côme Chilliet
ea05544213
Fix return type of methods returning false on error
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:34 +07:00
Côme Chilliet
f974281ac9
Improve typing for fopen/toTmpFile
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:34 +07:00
Côme Chilliet
4393b96542
Remove unused method getLocalFolder
...
It’s not used and not in any OCP interface/class.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:34 +07:00
Côme Chilliet
966a3e6963
Tidy up typing in OC\Files\View
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:33 +07:00
Julius Härtl
671d2726fa
Merge pull request #36652 from nextcloud/perf/autoloading/theming-authoritative-autoloader
...
perf(autoloading): Add authoritative autoloader for theming
2023-04-03 10:38:00 +07:00
Joas Schilling
454281af03
feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-03 09:06:45 +07:00
jld3103
dcf6ebebab
Fix inherited parameter names
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-03 08:29:33 +07:00
Robin Appelman
c9e4e30523
clear encrypted flag when moving away from encrypted storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-01 15:36:37 +07:00
Rsplwe
d85e623916
s3: get remaining truncation part
...
Signed-off-by: Rsplwe <i@rsplwe.com>
2023-04-01 22:56:15 +07:00
Rsplwe
ccac296821
Adjust the value of 'maxparts' to 1000
...
Signed-off-by: Rsplwe <i@rsplwe.com>
2023-04-01 21:20:52 +07:00
Côme Chilliet
8104d9f5d8
Remove useless coalescing operator on non-null return value
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-01 14:20:26 +07:00
Côme Chilliet
da618c457a
Fix quota typing for 32bits after forward port from 25
...
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-04-01 14:20:25 +07:00
Côme Chilliet
3f84d41226
Silence a warning from psalm with explanation
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-01 14:20:25 +07:00
Côme Chilliet
1740311283
Adapt types of subclasses
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-01 14:20:24 +07:00
Côme Chilliet
ed863fb47c
Make it clear that file sizes may be float on 32bits
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-01 14:20:24 +07:00
Vincent Petry
c6b683342e
Remove quota value type for 32-bit systems
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2023-04-01 14:20:20 +07:00
Arthur Schiwon
997c2a2a79
fix DBAL exception handling in setValues
...
This seems to be a left over after abstracting DBAL. Nowadays,
IQueryBuilder::executeStatement() only throws a \OCP\DB\Exception, where
previously original DBAL exceptions where thrown. These are now wrapped,
the orignal classes are now mapped to a reason.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-03-31 17:01:17 +07:00
Julien Veyssier
636c2415cc
Merge pull request #37452 from nextcloud/fix/missing-interface-methods
...
Add missing interface methods
2023-03-30 14:55:51 +07:00
Simon L
2811532e83
Merge pull request #37378 from nextcloud/enh/noid/fix-avatar-generation
...
fix the avatar generation on Alpine Linux
2023-03-30 14:20:55 +07:00
Julius Härtl
5e7e3eb665
Merge pull request #37425 from nextcloud/fix/fix-since-version-number-for-app-loading
2023-03-30 13:20:11 +07:00
jld3103
02f9c3a06f
Use implementations instead of interfaces for accessing private methods
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-03-30 12:33:46 +07:00
Arthur Schiwon
488dde12cd
Merge pull request #37448 from nextcloud/fix/12281/hide-deleted-shared-groupfolder-files
...
hide shared files located in group folder's trash bin
2023-03-30 10:31:16 +07:00
Christopher Ng
4f8e916585
Add label for logo link
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-03-29 13:36:45 +07:00
Simon L
6a91d105b9
another approach to fixing the avatar generation
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-03-29 12:42:58 +07:00
Arthur Schiwon
28e7235f87
hide shared files located in group folder's trash bin
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-03-28 14:13:12 +07:00
Côme Chilliet
e94a689bca
Fix version number in phpdoc for app loading refactor
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-27 14:27:23 +07:00
Joas Schilling
6741b37356
Merge pull request #37198 from nextcloud/bugfix/noid/reference-image-log
...
fix(references): Do not log errors on 404 responses of opengraph image fetching
2023-03-27 13:56:39 +07:00
Christoph Wurst
44dc839f7b
Revert "Dark autoloader magic for ThemingDefaults"
...
This reverts commit 4e1d501696 .
2023-03-27 12:56:52 +07:00
Robin Appelman
36835b7fec
Merge pull request #36810 from nextcloud/setup-user-onetime-before-mounts
...
do onetime user setup before getting any mount from providers
2023-03-24 16:45:08 +07:00
Simon L
825f847ef1
Merge pull request #37234 from cob2p/bugfix/typo
...
Fix the typo in comments
2023-03-23 15:00:41 +07:00
Simon L
67614150b5
Merge pull request #36636 from nextcloud/fix/oc-image-getimagesize
...
fix OC_Image: Prevent E_WARNING from getimagesize*
2023-03-23 14:59:57 +07:00
Git'Fellow
c81ea3aa98
Fix RedisCluster
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-03-22 17:19:07 +07:00
Git'Fellow
fab390f884
Move from DEL to UNLINK
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-03-22 17:10:05 +07:00
Joas Schilling
014a634635
Merge pull request #37334 from nextcloud/bugfix/noid/mark-recording-servers-as-sensitive-due-to-secret
...
fix(security): Mark recording_servers key appconfig as private as it …
2023-03-22 10:27:39 +07:00
Julius Härtl
8b4d49cf50
Merge pull request #36057 from nextcloud/feat/esm-js-scripts
2023-03-22 09:17:28 +07:00
Joas Schilling
381ab5f4cb
fix(security): Mark recording_servers key appconfig as private as it contains a secret
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-22 09:14:37 +07:00
Côme Chilliet
c60182065f
Merge pull request #34773 from nextcloud/artonge/feat/dispatch_entry_removed_event_for_all_entries
...
Dispatch event for all removed entries
2023-03-21 11:42:18 +07:00
Côme Chilliet
13c71ed24a
Small cleanups for AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:21:45 +07:00
Côme Chilliet
78c1716818
Move loadApps to the AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:21:45 +07:00
Côme Chilliet
8dc5f82189
Move isType to AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:21:45 +07:00
Côme Chilliet
a224551132
Avoid calling Server::get more times than necessary in loadApp
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:21:42 +07:00
Côme Chilliet
f0bdf2a4cd
Strong type private properties and methods in AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:19:42 +07:00
Côme Chilliet
71ed968e34
Switch away from Server::get for AppManager and logger in loadApp
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:17:28 +07:00
Côme Chilliet
a7c8090dc3
Move loadApp function to the AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:01:17 +07:00
Joas Schilling
bfc37afed3
Merge pull request #36928 from nextcloud/techdebt/noid/bruteforce-protection-attribute
...
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
2023-03-16 19:33:13 +07:00
Christoph Wurst
416c824c74
perf(autoloader): Drop legacy class autoloader
...
The documentation says apps should use PSR-4 to get their classes
loaded. The legacy PSR-0 is still in place and has a negative impact on
performance.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-03-16 12:02:09 +07:00
Marcel Klehr
4a2accaa27
fix OC_Image: Prevent E_WARNING from getimagesize*
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-03-16 11:10:36 +07:00
Julius Härtl
c7c1133c15
Merge pull request #35561 from nextcloud/create-user-transaction
2023-03-15 15:13:50 +07:00
Arthur Schiwon
a30d7c51d3
Merge pull request #37227 from nextcloud/h1-dav-brute-force-protection
...
chore: use local variable for remote address
2023-03-15 15:11:53 +07:00
CRA Yoshihito Nakatani
fb9c8e3790
Fix the typo in comments
2023-03-15 23:03:24 +07:00
Thomas Citharel
f7e65b1751
Create the database user in a transaction
...
In OC\User\Manager::createUserFromBackend the newly created user is read
using getUserObject($uid, $backend) but that can cause causal read
issues (wrote in DB primary, not yet in secondary).
In OC\User\Database user backend the user cache is unset after the
insert, so it can't be used by getRealUID() (which is called by
getUserObject()).
To avoid that we make sure the user cache is repopulated in a
transaction.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-03-15 11:07:07 +07:00
Côme Chilliet
8568c11d24
Merge pull request #36033 from nextcloud/invalidateTokensWhenDeletingOAuthClientMaster
...
[master] invalidate existing tokens when deleting an oauth client
2023-03-15 11:09:51 +07:00
Côme Chilliet
9c3e06c046
Merge pull request #33061 from ibpl/master-IB#1121253
...
Paths added to messages and message cleanup
2023-03-14 17:28:22 +07:00
Artur Neumann
f634badf12
public interface to invalidate tokens of user
...
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2023-03-14 17:13:29 +07:00
Simon L
5cba7f0062
Merge pull request #37192 from n0emis/empty-password
...
Don't try to hash a nonexisting password
2023-03-14 13:14:34 +07:00
Côme Chilliet
71328107da
Merge pull request #37029 from nextcloud/fix/chunk-objectids-in-systemtagobjectmapper
...
Add chunking in SystemTagObjectMapper::getTagIdsForObjects
2023-03-13 22:10:47 +07:00
Côme Chilliet
9b1d7794a8
Add chunking in SystemTagObjectMapper::getTagIdsForObjects
...
This avoids crashing on Oracle with more than 1000 objects
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-13 17:36:10 +07:00
Julius Härtl
b6d1154260
fix(references): Do not log errors on 404 responses of opengraph image fetching
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-03-13 18:18:04 +07:00
Thomas Citharel
f1751c4428
Introduced app enable/disable/update typed events
...
OCP\App\ManagerEvent is depreciated since 22 without a replacement
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-03-13 11:52:57 +07:00
Ember 'n0emis' Keske
6881d2f2f1
Don't try to hash a nonexisting password
...
Allows to log-in via a passwordless authentication provider, eg SSO
Signed-off-by: Ember 'n0emis' Keske <git@n0emis.eu>
2023-03-13 10:32:53 +07:00
Daniel Kesselberg
f751d2d891
chore: use local variable for remote address
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-03-10 18:04:34 +07:00
Arthur Schiwon
315510df84
Merge pull request #27034 from nextcloud/enh/s3-multipart-upload-api
...
Use MultipartUpload for uploading chunks to s3
2023-03-09 13:55:57 +07:00
Simon L
0ced170567
increase imaginary timeouts as for big files the processing could take very long
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-03-09 13:15:35 +07:00
Simon L
691aa8d025
Merge pull request #37140 from nextcloud/enh/35643/fix-heic-previews
...
imaginary - fix autorotate for heic and improve the logic
2023-03-09 10:25:54 +07:00
Simon L
694f743829
Merge pull request #37070 from nextcloud/enh/noid/add-free-disk-space-check
...
add a check for disk_free_space in Config.php
2023-03-09 10:24:20 +07:00
Simon L
3dbe108568
Merge pull request #37116 from nextcloud/enh/37114/add-quotes
...
postgresql installation - add quotes around user names
2023-03-09 10:22:35 +07:00
Arthur Schiwon
61aa0978ae
Merge pull request #36609 from nextcloud/lazyuserfolder-mountpoint
...
optimize LazyUserFolder::getMountPoint
2023-03-09 09:46:34 +07:00
Simon L
b39329c21c
imaginary - fix autorotate and improve the logic
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-03-09 00:11:37 +07:00
Michiel de Jong
c0e84cb512
Add SHARE_TYPE_SCIENCEMESH
...
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
2023-03-08 16:46:55 +07:00
Julius Härtl
e23aa8883e
feat(s3): Use multipart upload for chunked uploading
...
This allows to stream file chunks directly to S3 during upload.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-03-08 14:00:04 +07:00
Joas Schilling
2b49861679
Add a debug message when throttling without defining
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-08 12:09:22 +07:00
Joas Schilling
e839eb9b5c
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-08 12:09:22 +07:00
Simon L
40edac18f5
postgresql - add quotes around user names
...
fix https://github.com/nextcloud/server/issues/37114
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-03-08 01:03:27 +07:00
Joas Schilling
6b0cef6b9a
Add transaction around mass mounts operations
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-07 19:58:55 +07:00
Git'Fellow
28231ae515
Add function_exists() check
...
Co-authored-by: Simon L. <szaimen@e.mail.de>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-03-07 17:09:24 +07:00
Simon L
e87d968c24
add a check for disk_free_space in Config.php
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-03-07 09:43:14 +07:00
Maxence Lange
e1b91fecf1
Merge pull request #36883 from nextcloud/fix/noid/gs-saml-pre-login-event
...
dispatch BeforeUserLoggedInEvent
2023-03-07 08:01:18 +07:00
Git'Fellow
9ac065fb92
Fix free space problems
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-03-07 00:13:57 +07:00
Julius Härtl
d515da502f
fix: Use proper path for quota fetching
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-03-06 22:46:07 +07:00
Julius Härtl
3287eddbbc
fix: Recalculate storage statistics on updating the quota
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-03-06 22:46:07 +07:00
Joas Schilling
c297f8ee96
feat(appframework): ⌚ Make ITimeFactory extend \PSR\Clock\ClockInterface
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-03 15:37:13 +07:00
John Molakvoæ
c5da4b8737
Merge pull request #36736 from Glandos/patch-2
2023-03-03 13:35:06 +07:00
Joas Schilling
de64c96a67
Merge pull request #36941 from nextcloud/bugfix/prevent-error-with-oracle-database
...
Split the comments ids by chunks
2023-03-03 12:37:15 +07:00
Julius Härtl
6130f1a78e
Implement file reference wiget
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-03-02 21:01:44 +07:00
blizzz
289fadfd50
Merge pull request #36803 from nextcloud/fix/sqlite-comments
...
[db]: Remove not supported column comments for SQLite
2023-03-02 12:10:19 +07:00
Maxence Lange
980e8e24f0
dispatch BeforeUserLoggedInEvent
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-03-01 15:31:31 +07:00
Vitor Mattos
e9295f739e
Split the comments ids by chunks
...
Split the comments ids by chunks to prevent error with Oracle database
that can't do a query with more than 1000 parameters.
https://github.com/nextcloud/spreed/issues/8287
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-03-01 13:08:17 +07:00
Max
95a674e238
fix: treat text app session parameters as sensitive values
...
* `PublicSessionController create` receives a share token.
* The others receive the parameters for a text session:
`document_id`, `session_id`, `session_token`.
Even though these are relatively short lived
they could be used to retrieve content from the document when leaked.
Signed-off-by: Max <max@nextcloud.com>
2023-03-01 13:03:47 +07:00
Ilya Apasov
3a11f91dee
Update Checker.php
...
Signed-off-by: Ilya Apasov <apasov@users.noreply.github.com>
2023-02-28 13:39:02 +07:00
Julius Härtl
3e63298381
feat(translations): Add translation provider API
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-27 16:52:03 +07:00
Joas Schilling
70a68e88f5
Merge pull request #36837 from nextcloud/fix/truncate-overlong-tagnames
...
fix(SystemTagManager): Truncate overlong tag names
2023-02-27 11:49:50 +07:00
Marcel Klehr
8151b1b8b0
fix(SystemTagManager): Truncate overlong tag names
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-02-24 12:55:10 +07:00
Joas Schilling
373e6325b7
Fix appconfig compatibility with Oracle DB
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-23 16:57:54 +07:00
Joas Schilling
c8c4dd637f
fix(OCC): Don't throw in the repair step for phone validation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-23 16:57:53 +07:00
Ferdinand Thiessen
a3595f73ac
fix(OC/Template): Allow `.mjs` files within custom app paths
...
If apps are installed in non standard app paths, we need
to check `$app_path/$script` instead of only doing so for translations.
Without this it would fallback to `.js` extension even if a `.mjs` file exists.
Also tried make the code more selfe explaining.
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-22 21:19:37 +07:00
Ferdinand Thiessen
b642137c65
feat(OC/Template): Add `type="module"` for ES6 scripts
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-22 21:19:37 +07:00
Ferdinand Thiessen
00e041b907
feat(template): Allow `JSResourceLocator` to find ES6 scripts
...
Enable module js (ES6) support on the `JSResourceLocator`.
This changes `JSResourceLocator` to look for `.mjs` files first
to allow applications to provide a fallback `.js` for older Nextcloud versions.
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-22 21:19:37 +07:00
Ferdinand Thiessen
dbb1fa1273
fix(OC/Template): Remove usage of deprecated functions in `JSResourceLocator`
...
Move from `\OC_App::getAppPath` to `IAppManager::getAppPath`.
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-22 21:19:37 +07:00
Robin Appelman
fb1095f0f6
do onetime user setup before getting any mount from providers
...
this fixes a race condition where wrappers weren't properly applied if when a mount provider creates the storage instance one mountpoint creation instead of lazily
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-22 18:03:38 +07:00
Ferdinand Thiessen
a9af58fd1a
fix(DB): Remove not supported column comments when using SQLite
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-22 01:07:26 +07:00
Côme Chilliet
18c4761ab0
Merge pull request #36795 from nextcloud/fix/remove-erronous-parentheses-in-in-clause
...
Avoid extra parenthesis around SQL in IN expressions
2023-02-21 17:37:45 +07:00
Julien Veyssier
a7892881a3
Merge pull request #36792 from nextcloud/enh/noid/add-before-group-changed-event
...
New BeforeGroupChangedEvent before setDisplayName on groups
2023-02-21 17:22:27 +07:00
Robin Appelman
8bc9e23de5
Merge pull request #36428 from nextcloud/disable-db-user-create
...
add option to disable db user creation trough environment variable
2023-02-21 17:11:12 +07:00
Robin Appelman
b923310580
add option to disable db user creation trough environment variable
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-21 15:13:47 +07:00
Côme Chilliet
74811813e7
Avoid extra parenthesis around SQL in IN expressions
...
The expression builder already suround the SQL with parenthesis when
using in(), so we must not add another pair, this confuses at least
sqlite.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-21 13:37:30 +07:00
Anna Larch
ed70815076
Fix calendar emails to be outlook compatible
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-02-21 14:37:11 +07:00
Julien Veyssier
d9925806eb
dispatch new BeforeGroupChangedEvent before setDisplayName on groups
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-02-21 10:42:38 +07:00
Joas Schilling
98ed72b3ed
Revert "fix(performance): Do not set up filesystem on every call"
2023-02-21 07:36:43 +07:00
Simon L
3204f97d5e
Merge pull request #36759 from sgolovan/master
...
Fix integer overflow on 32-bit systems when testing free space for wr…
2023-02-20 15:21:37 +07:00
Julius Härtl
7858b8313a
Merge pull request #36727 from nextcloud/enh/file-id-direct-editing
...
feat(directediting): Allow opening by file id
2023-02-20 14:39:35 +07:00
Julius Härtl
95eeba83b6
Merge pull request #36780 from nextcloud/bugfix/noid/console-error-share-auth
2023-02-20 12:36:06 +07:00
Julius Härtl
614981ae9a
feat(directediting): Allow opening by file id
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-20 12:16:34 +07:00
Joas Schilling
c550acae62
Merge pull request #36653 from nextcloud/bugfix/noid/more-defensive-old-token-handling
...
fix(authentication): Handle null or empty string password hash
2023-02-20 11:15:37 +07:00
Sergei Golovan
1cb50c5afa
Fix integer overflow on 32-bit systems when testing free space for writing a config file.
2023-02-20 10:05:45 +07:00
Julius Härtl
4cebfa95e6
fix: Fix loading styles from core/css/
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-20 09:28:30 +07:00
Anna Larch
5d4efb4d5f
Do not set up filesystem on every call
...
Also remove old Oc_FileChunking logis that produced GC- collectable chunks
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-02-17 19:18:37 +07:00
Julius Härtl
47bc024885
Revert the token scope to not end up with storing the user used in the session
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-17 10:18:18 +07:00
Julius Härtl
90d2cb09b1
Merge pull request #36396 from nextcloud/fix/cors
2023-02-17 09:42:08 +07:00
Ferdinand Thiessen
f655f83c84
fix(CORS): CORS should only be bypassed on `PublicPage` if not logged in to prevent CSRF attack vectors
...
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-16 22:55:18 +07:00
Louis
98b998a2de
Merge pull request #36735 from nextcloud/fix/32635/fix-vcf-contacts
...
fix the contacts-menu vcf-contact avatars
2023-02-16 14:01:19 +07:00
Glandos
3bea7af7b7
fix indent 2
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-02-16 10:10:12 +07:00
Glandos
59e7ed1fad
fix indent
...
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-02-15 23:40:16 +07:00
Glandos
528e66859b
Use proc_open to avoid spawning a shell
...
The use of `exec` will spawn a shell, using `/bin/sh` on POSIX platforms. But in restricted environment, such as AppArmor, this means giving execution to `/bin/sh`, which renders the execution restriction quite useless.
Using an array with `proc_open` reduces this, and paved the way for file streaming instead of temporary file.
Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-02-15 23:37:13 +07:00
Simon L
b38d2daede
fix the contacts-menu vcf-contact avatars
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-15 23:16:43 +07:00
MichaIng
5f90b8eb11
Change X-Robots-Tag header from "none" to "noindex, nofollow"
...
While "none" is indeed equivalent to "noindex, nofollow" for Google, but seems to be not supported by Bing and probably other search engines.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/meta/name#other_metadata_names
https://developers.google.com/search/docs/crawling-indexing/robots-meta-tag?hl=de#comma-separated-list
https://www.bing.com/webmasters/help/which-robots-metatags-does-bing-support-5198d240
Signed-off-by: MichaIng <micha@dietpi.com>
2023-02-15 20:16:51 +07:00
Christoph Wurst
364e7693b9
Merge pull request #36639 from nextcloud/userbackend-local-cache
...
also cache backend for user in memory instead of always going to redis
2023-02-15 19:33:29 +07:00
Christoph Wurst
a2422c937a
Merge pull request #36698 from nextcloud/db-profile-start-time
...
log start time of queries for profiler
2023-02-15 19:29:56 +07:00
Simon L
228911cbcd
Merge pull request #36691 from nextcloud/fix/25175/fix-config-truncating
...
add a disk_free_space check before writing config
2023-02-15 18:25:37 +07:00
Simon L
3757b345bc
address review by Joas
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-15 13:43:54 +07:00
Robin Appelman
426b3429f7
log start time of queries for profiler
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-14 15:16:15 +07:00
Robin Appelman
c2cc3afd61
Merge pull request #36603 from nextcloud/imagick-cache-formats
...
cache formats supported by imagick
2023-02-14 13:30:44 +07:00
Julius Härtl
a705132c8d
Merge pull request #36656 from nextcloud/route-instrumentation
2023-02-14 10:12:19 +07:00
Robin Appelman
b911da3e1e
DI for Router
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-13 22:51:14 +07:00
Thomas Citharel
e60888d988
fix(preview-generator): Throw exception before dividing by zero when generating previews
...
If the maximum preview generated gives some kind of invalid IImage, it's dimentions and filename can be set to zero.
And then later we do a division by zero to keep the aspect ratio of the previews.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-02-13 16:47:28 +07:00
Simon L
9b6e5c6674
add a disk_free_space check before writing config
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-13 16:26:19 +07:00
Robin Appelman
d6818ba894
optimize LazyUserFolder::getMountPoint
...
no need to do a full setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-13 15:13:50 +07:00
Robin Appelman
382432d4e1
cache formats supported by imagick
...
turns out this can be quite slow
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-13 14:57:06 +07:00
Robin Appelman
936f634069
Merge pull request #36643 from nextcloud/fs-setup-instrimuntion
...
more filesystem setup performance instrumentation
2023-02-13 14:37:57 +07:00
Julius Härtl
610a203d31
Merge pull request #36525 from nextcloud/fix/noid/params-put
...
fix: Only get params from PUT content if possible
2023-02-13 10:25:52 +07:00
Côme Chilliet
8e1403a180
Merge pull request #36641 from nextcloud/instrument-app-register
...
Add more profiler instrumentation to app loading
2023-02-13 09:42:51 +07:00
Pytal
b59b8fd808
Merge pull request #36232 from nextcloud/enh/a11y-user-menu
...
Port user menu to Vue
2023-02-10 19:22:45 +07:00
Robin Appelman
853ec60f3e
also cache backend for user in memory instead of always going to redis
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-10 12:25:23 +07:00
Robin Appelman
b68be79464
more routing performance instrumentation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-10 11:12:26 +07:00
Robin Appelman
91d5f6a826
more filesystem setup performance instrumentation
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-10 11:11:13 +07:00
Joas Schilling
6417ea0265
fix(authentication): Handle null or empty string password hash
...
This can happen when the auth.storeCryptedPassword config is used,
which previously errored with:
Hasher::verify(): Argument #2 ($hash) must be of type string, null given
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-10 09:18:50 +07:00
Julius Härtl
d9cd8b1d37
Merge pull request #36610 from nextcloud/folder-lazy-submounts
2023-02-10 09:09:08 +07:00
Christopher Ng
c77998209f
Port user menu to Vue
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-02-09 17:54:59 +07:00
Joas Schilling
e47d56ac36
Merge pull request #36621 from nextcloud/perf/noid/only-check-for-token-when-it-can-actually-be
...
fix(performance): Only search for auth tokens when the provided login…
2023-02-10 01:29:30 +07:00
Joas Schilling
f0b6a6f307
Merge pull request #36637 from nextcloud/fix/noid/file-ref-provider-safer-match
2023-02-09 22:42:58 +07:00
Robin Appelman
fe78ef7a38
instrumentation for app booting
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-09 17:41:43 +07:00
Robin Appelman
08e7b20c43
add more performance instrumentation for app registering
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-09 17:41:43 +07:00
Julien Veyssier
4ef2b27a47
safer URL match in FileReferenceProvider
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-02-09 14:33:19 +07:00
Julius Härtl
580feecdbf
fix(authtoken): Store only one hash for authtokens with the current password per user
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-02-09 13:44:00 +07:00
Côme Chilliet
06f0da6d46
Merge pull request #36590 from nextcloud/enh/load-app-once
...
Make sure application are only loaded once
2023-02-09 13:09:10 +07:00
Robin Appelman
5bcf37b7ff
only fetch the data for mounts inside a folder when needed
...
for most operations we don't actually care about any mounts inside a folder, only for metadata that needs to propagate across storage boundaries (size, etag, mtime) do we need all the submount info.
By only loading this data when needed we can save a bunch of storage setup in a number of cases
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-09 11:39:00 +07:00
Joas Schilling
7a85a1596e
fix(authentication): Check minimum length when creating app tokens
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-09 09:58:35 +07:00
Joas Schilling
03a585ab4f
fix(performance): Only search for auth tokens when the provided login is long enough
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-08 22:45:23 +07:00
Julius Härtl
08802ad13f
Merge pull request #36566 from nextcloud/mount-find-by-numeric-id
2023-02-08 20:04:57 +07:00
Anna
6236235d23
Merge pull request #36546 from nextcloud/enh/36543/allow-further-previews
...
imaginary - fix generation of heif, pdf, illustrator and svg thumbnails
2023-02-08 11:18:36 +07:00
Simon L
112d516f27
imaginary - allow to generate heif, pdf and svg thumbnails
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-02-08 00:25:18 +07:00
Joas Schilling
dcfc96f0cc
Merge pull request #36417 from nextcloud/fix/psr-container
...
Make the container fully fulfill PSR container interface
2023-02-07 20:38:19 +07:00
Côme Chilliet
2a4ab201b7
Make sure application are only loaded once
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 16:06:32 +07:00
Robin Appelman
9f3dbb699a
fix tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-07 15:50:10 +07:00
Côme Chilliet
e586700982
Revert "disable upgrades to 26 for 32-bit"
...
This reverts commit faa747e445 .
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 15:14:15 +07:00
Côme Chilliet
308fcf4526
Respect OCP interface in private classes
...
Because the parameter type was moved to phpdoc it needs to be removed
from implementations
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:35 +07:00
Côme Chilliet
028c225d96
Fix psalm errors
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:32 +07:00
Côme Chilliet
b7d9e43e25
Put back string in $includeMounts as it actually does something
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:32 +07:00
Côme Chilliet
cd885b5705
Type sizes as int|float throughout the code base
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:31 +07:00
Côme Chilliet
5c1a0e0307
Allow float sizes in FileInfo for 32bits
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:31 +07:00
Côme Chilliet
5aed587e25
Fix setQuota on User on 32bits
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:30 +07:00