c019e33b99
Merge pull request #30160 from nextcloud/bugfix/noid/encryption-wrapper-fclose-check
2021-12-09 15:59:51 +07:00
8420431806
Merge pull request #30075 from nextcloud/logic-op
...
Switch logical operators
2021-12-09 21:14:37 +07:00
6f81e60bce
Check resource before closing in encryption wrapper
...
In case of error there is no guarantee that $source or $target is set or
is a resource when handling an error.
Without this fix, there's a risk that fclose will fail and the actual
exception will not be thrown, making it impossible to find out about the
root cause.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-12-09 11:28:10 +07:00
f1a6668cc2
Make psalm more happy
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-09 09:25:50 +07:00
93b77f54bd
Fix docs to make Psalm happier
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-09 09:19:32 +07:00
d5cb5a33dc
Convert strict_search to wildcard property and add psalm docs
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-08 19:24:16 +07:00
d49ad7ea47
Limit more contact searches
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-08 18:58:54 +07:00
0f1670be8a
Only limit search in the system address book
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-08 18:54:42 +07:00
84d37143b0
Only wildcard search if enumeration is allowed
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-08 18:54:42 +07:00
8504f0a59e
Avoid assignment in if clause
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-06 14:26:27 +07:00
ab3a1d5706
Fix typing problems in OC_Image
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-06 14:26:26 +07:00
d537226368
Avoid calling image* methods on boolean
...
This avoids fatal errors on PHP>=8, and warnings on older versions.
Log should also be clearer.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-12-06 14:26:09 +07:00
00549f7802
Merge pull request #30055 from nextcloud/enh/note-share-api
2021-12-06 08:59:51 +07:00
e296417ca2
Merge pull request #29527 from nextcloud/rakekniven-patch-1
2021-12-04 12:08:16 +07:00
074a9a5e88
Switch logical operators
...
Unless there is a good reason to keep actual ones 👀
2021-12-03 16:05:19 +07:00
b067ae78c5
Merge pull request #30034 from nextcloud/fix/bump-scssphp/scssphp-to-1.8.1
2021-12-03 11:55:42 +07:00
5116bf146f
Allow to pass note when creating a share and send it with directly in the share mail when set
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-12-03 10:17:02 +07:00
71a3528510
Allow scripts prioritization based on other apps
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-12-02 20:00:46 +07:00
6b3c703794
Merge pull request #29735 from nextcloud/background-scan-one-by-one
...
find users for background scan one by one
2021-12-02 17:09:43 +07:00
f5fe887b4b
background scan the source storage when a background scan on a storage jail is triggered
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-12-02 17:34:58 +07:00
7acb438e42
Merge pull request #30016 from nextcloud/techdebt/noid/remove-default-token-provider
...
Remove default token which is deprecated since Nextcloud 13
2021-12-02 16:48:03 +07:00
dfb569f097
Follow upstream security recommandation
...
See https://scssphp.github.io/scssphp/docs/#security-considerations
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-12-02 15:57:53 +07:00
91db6040c8
Merge pull request #30028 from nextcloud/bugfix/noid/fix-log_query
...
Fix log_query config flag
2021-12-02 10:32:04 +07:00
68d53988f6
Fix log_query config flag
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 23:00:51 +07:00
168c673755
Allow to log DB, redis and LDAP requests into files
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 22:33:41 +07:00
c0ba89ecc9
Remove default token which is deprecated since Nextcloud 13
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 18:41:31 +07:00
4c503db75d
Merge pull request #30013 from nextcloud/bugfix/noid/dont-count-attempts-when-we-just-deleted
2021-12-01 18:40:41 +07:00
1d550ab95e
Don't query the bruteforce attempts when we just deleted them
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 18:01:22 +07:00
660e550260
Only check the twofactor state once per request
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-01 17:56:30 +07:00
aaad09220d
Remove files_iedavclient
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2021-11-30 14:47:45 +07:00
c624c7eb5d
Merge pull request #29966 from nextcloud/feat/remove-isIE
2021-11-30 14:04:05 +07:00
d16d4d3459
Merge pull request #29958 from nextcloud/fix/translit-php8/deps-and-tests
...
Remove iconv from dependencies and tests
2021-11-30 13:07:02 +07:00
a325141545
Remove isIE and associated legacy scripts
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-11-30 13:03:08 +07:00
f6b5b1f519
Include previous execption for repair steps that don't exist
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-11-30 10:57:49 +07:00
f68ab00811
Let repair step query exceptions bubble up
...
And hide the type error caused by a constructor call with missing
arguments.
`new $repairStep();` only works for the rare case that no arguments are
required. Anything else will throw. Then we previously hid the trace of
the more important query exception.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-11-30 09:47:39 +07:00
0d749b7e9a
Remove iconv from dependencies and tests
...
which is not used anymore since: https://github.com/nextcloud/server/pull/29470
Signed-off-by: MichaIng <micha@dietpi.com>
2021-11-30 02:33:12 +07:00
a1497c742c
Merge pull request #29917 from nextcloud/fix/29768/l10n
2021-11-29 10:48:32 +07:00
311b3ffa2e
Interpolate the log message also for logged exceptions
...
According to PSR-3 the log message can have placeholders that are
replaced from the context object. Our logger implementation did that for
all PSR-3 logger methods. The only exception was our custom `logException`.
Since PsrLoggerAdapter calls logException when an exception key is
present in the context object, log messages were no longer interpolated.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-11-29 14:29:35 +07:00
998144f832
Obey col length of 255 to insert and search in accounts_data
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-11-26 16:30:14 +07:00
abecf594d6
Fix source of translations
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-11-26 02:00:40 +07:00
88129925ee
Merge pull request #29906 from nextcloud/fix/strict_comp_for_redis
...
Use strict comparison to detect usage of redis cluster
2021-11-25 19:52:30 +07:00
1a4427f238
Merge pull request #29894 from nextcloud/fix/inactive-profile-parameter
...
Fix inactive profile parameters being displayed in the Profile visibility section
2021-11-25 17:25:49 +07:00
5dbb080517
Use strict comparison to detect usage of redis cluster
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-11-25 16:19:42 +07:00
65d79bb592
Check for invalid characters before trimming
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-25 08:48:26 +07:00
ae85a16ed2
Fix inactive profile parameters being returned
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2021-11-25 05:01:18 +07:00
fd487c1a43
Merge pull request #29432 from nextcloud/fix/support-php-8.1
...
Support PHP 8.1 - First batch
2021-11-23 15:41:20 +07:00
18a91f02fa
Fix default value for $type in OC\DB\QueryBuilder\ExpressionBuilder\ExpressionBuilder::literal
...
This fixes PHP errors about passing null to PDO::quote second parameter.
We may want to change IExpressionBuilder as well?
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:29:02 +07:00
ee7ef77808
Fix warning about passing null to substr_count
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:29:00 +07:00
9d170f1269
Fix warning about passing null to rtrim
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:59 +07:00
008b79d808
Fix type errors
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2021-11-23 09:28:58 +07:00
Pytal
Christoph Wurst
Vincent Petry
Joas Schilling
Côme Chilliet
Julius Härtl
John Molakvoæ
acsfer
John Molakvoæ (skjnldsv)
Robin Appelman
Joas Schilling
Carl Schwan
MichaIng
Christoph Wurst
Arthur Schiwon
Christopher Ng
Louis Chemineau