Commit Graph

222 Commits (8a96ff0256f51930d3f545aa8522ac93d36c393d)

Author SHA1 Message Date
nfebe a873c8fdcc test(settings): Test user manager can be set and unset
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-06-03 07:32:11 +07:00
Ferdinand Thiessen 645ddc8195
test: adjust cypress tests to be less flaky
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-31 19:05:23 +07:00
nfebe 28ae3d3038 test(file_sharing): Do not open advanced settings manually
If a share note is present, the advanced settings should expand automatically,

without the user needing to click.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-05-26 18:39:29 +07:00
Jérôme Herbinet 89032afd3e ci(cypress): replace "remove group" with "delete group"
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
2025-05-24 08:00:40 +07:00
Ferdinand Thiessen 5c945560b1
fix(settings): allow to clear twitter and fediverse
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-29 10:00:58 +07:00
Ferdinand Thiessen 8e8125c610
fix(settings): group admins only can add users to their groups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-27 12:44:51 +07:00
skjnldsv 002ec2473c fix(cypress): rename select all clear
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-24 21:38:30 +07:00
Ferdinand Thiessen 8a0bc2422d
fix: ensure enabled themes are set on the template
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-04 10:10:25 +07:00
Louis e7b0f83b32
Merge pull request #51658 from nextcloud/backport/51471/stable30
[stable30] fix(files): Ensure actions never overflow filename
2025-04-03 10:15:53 +07:00
Ferdinand Thiessen a61d5616de
Merge pull request #51782 from nextcloud/backport/51336/stable30
[stable30] fix(settings): Fix infinitely loading account management page with pagination of groups
2025-04-03 08:46:38 +07:00
Ferdinand Thiessen edc0c838ea
fix(files): Ensure actions never overflow filename
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-02 19:10:51 +07:00
Ferdinand Thiessen 899faa77c1
test: add cypress tests for sharing download permission
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-02 13:14:25 +07:00
Christopher Ng 58fc803a26 test(settings): Fix group items not being found
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-04-01 10:17:33 +07:00
Christopher Ng 85dc4b44d2 test(settings): Correctly find group in select
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-04-01 10:17:33 +07:00
Christopher Ng 06af6de5cb test(settings): Wait until groups list has loaded
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-04-01 10:17:33 +07:00
Ferdinand Thiessen a140d9f261
fix(files_versions): correctly show version author also for shared files
The users endpoint is not available for other users if the current user
has no admin privileges, so instead use the displaynames endpoint.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-26 10:23:53 +07:00
Ferdinand Thiessen 72ab2275d4 fix(profile): allow to reset phone number
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-22 17:17:06 +07:00
Ferdinand Thiessen be82a4e502 fix(files_sharing): ensure share status action works also in grid view
Remove some hacks from files app about the *files_sharing* status
action, in general not sure why this hack was there instead of being in
the correct app - but it broke the grid view.

So now the sharing information is also available in grid view.

Moreover the icon is fixed in size to not overflow the actions menu.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 22:51:32 +07:00
Ferdinand Thiessen 985764152f
fix(files): also show file list headers on empty views
It is needed, e.g. for the note-to-recipient, that the headers
are also shown when there is no content (yet).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-17 19:41:41 +07:00
Louis Chemineau db9db0beec test: Remove `.only(` calls
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-06 11:12:14 +07:00
Louis Chemineau 6cbffb0b53
fix(test): Escape quotes in runOccCommand argument
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-05 15:04:44 +07:00
Louis Chemineau 2d839d767a
chore(tests): Fix using save/restore state in cypress
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-05 13:45:23 +07:00
Louis acf19f7880
Revert "Revert "[stable30] fix: Handle copy of folders containing live photos""
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-03-05 13:45:23 +07:00
Ferdinand Thiessen a4e9644410
test: fix cypress files trashbin tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-05 10:37:46 +07:00
Ferdinand Thiessen bd280f759b
fix(files_trashbin): disable bulk download for trashbin
The backend does not allow bulk download within the trashbin,
so we need to disable this also on the frontend.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-03 17:36:18 +07:00
skjnldsv 2b844498da fix(cypress): selection key event trigger
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-21 14:17:52 +07:00
skjnldsv e5c55bf562 fix(files): handle failed node properly
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-21 14:07:13 +07:00
skjnldsv e601503000 fix(cypress): opendetails tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-21 09:55:23 +07:00
skjnldsv 0394037b80 fix(cypress): action selector menu lookup
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-21 09:54:04 +07:00
skjnldsv 01ffa31328 chore(cypress): also log the current server image sha
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

[skip ci]
2025-02-21 09:54:04 +07:00
skjnldsv 05f3f2dbb7 chore(files_external): add cypress tests for user credentials action
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-21 09:54:03 +07:00
skjnldsv 145d3fd1a7 fix(files): properly show file not found error
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

[skip ci]
2025-02-19 10:13:55 +07:00
Ferdinand Thiessen 03e15b9297
fix(files): Do not download files with `openfile` query flag
Instead of downloading files, if there is no other default action,
we should just open the details tab.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-13 16:00:03 +07:00
Ferdinand Thiessen e046ce6858
fix(settings): Also sanitize fediverse and twitter handle in the frontend
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-07 12:42:23 +07:00
nfebe 23e70a574e test(files_sharing): Check that default expiration date is shown b4 create share
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-06 22:14:16 +07:00
Ferdinand Thiessen b5a3fc58fd
test(files): Make scrolling tests independent from magic values
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 00:09:23 +07:00
Ferdinand Thiessen 5251b25f4e
fix(files): Correctly scroll selected file into view
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 00:08:47 +07:00
Ferdinand Thiessen 4fd8440493
test: Add Cypress command for deleting files
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 00:07:18 +07:00
Ferdinand Thiessen 8d6139f17c
fix(files): Ensure favorites set in sidebar work
When marking a file as favorite from within the sidebar make sure it
really works, this fixes two issues:
1. The source needs to be the plain source not URL encoded, as otherwise
   the source of the node would be encoded twice (and show with encoding
   in the navigation)
2. The store should also listen for the update events as the sidebar has
   no access to the real node to update it, instead the store should -
   as long as we only have the legacy sidebar - update the node when
   added or removed as favorite.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-04 21:14:40 +07:00
nfebe e3b9135f1e test(files_sharing): add e2e tests for public link sharing
This commit introduces end-to-end tests for various public link sharing scenarios in the `files_sharing` app. It validates the behavior under multiple configurations:

- Password and expiration date enforced
- Password enforced with a default expiration date
- Expiration date enforced with optional password
- Default password and expiration date without enforcement
- Password enforced, expiration date set but not enforced
- Both password and expiration date not enforced, but defaults set
- Password not enforced, expiration date enforced
- Password not enforced, default expiration date set
- Password and expiration date not enforced with no defaults

The tests ensure proper validation and functionality of the configurations, leveraging the `setupData` and `createShare` utilities.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-03 17:21:22 +07:00
nfebe b1c5637a87 feat: Add setup-public-share.ts
This addition enhances the testing framework for public sharing by
improving the setup and management of share contexts.

Additionally, the update optimizes share permission adjustments and
improves state management, making public share setups more efficient and maintainable.

Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-02-03 17:19:36 +07:00
Ferdinand Thiessen 910495de1f
fix(files): File type filter UI sync with filter state
When changing the folder the filter will be re-mounted by the file list,
so we need to pass the current state of the filter to the filter UI.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 20:25:55 +07:00
Ferdinand Thiessen ab39152951 fix(theming): Ensure to only send valid URLs to backend
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-27 17:58:56 +07:00
Richard Steinmetz 3efb46ca56
fix(files): sort not working after changing views
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-26 14:09:13 +07:00
Maksim Sukharev 21f0e61477 test(e2e): hide move dialog action if destination has no CREATE permission
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
(cherry picked from commit 868517f6d2)
2025-01-17 14:55:15 +07:00
Ferdinand Thiessen d787ae9da5
Merge pull request #49940 from nextcloud/backport/49208/stable30
[stable30] fix: Redirect user to login if session is terminated
2025-01-16 23:44:04 +07:00
Ferdinand Thiessen d0dbe21f4c
test(dashboard): Add regression test for loading unneeded data
Prevent a regression of https://github.com/nextcloud/server/issues/48403

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-16 11:40:02 +07:00
Ferdinand Thiessen 21805299dc
test: Add end-to-end test for share expiration date
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-16 09:07:59 +07:00
Ferdinand Thiessen f5f3ae2c19 fix: Redirect user to login if session is terminated
If a session timed out or was closed in another tab,
then currently the user gets random error messages.
This intercepts 401 responses (should only happen if logged out, or the
users does something wrong).

If we get a 401, we make sure its because of the session,
by checking if the user can access the files app.
If that is also the case we forward the user to the login page
and set the redirect URL to the last used URL.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-09 09:48:44 +07:00
skjnldsv 0d5cda8aa4 fix(files): cancel renaming on enter if no file name changes
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-12 18:25:03 +07:00