`isDefaultExpireDateEnforced` and its corresponding `defaultExpirationDate`
is currently treated as the enforcement fallback when share type enforcements are not
set.
However, `isDefaultExpireDateEnforced` and `defaultExpirationDate` are actually more like
`isDefaultPublicExpireDateEnforced` and `defaultPublicExpirationDate` and therefore only applies
to public shares.
It might be ideal to rename this variables all the way from the backend config to the way we use
them in the frontend code.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Current expiration date errorneously assumes that `defaultExpirationDate`
applies to all kinds of shares. But it only really applies to public shares despite
its name.
This commit, fixes that by paring expiration dates with the correct share types during
new share initialization and simplifying the `hasExpirationDate` (check) property.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
We should check that a maximum expiry date has been enforced for
all shares and NOT JUST FOR internal shares before enforcing a UI max date,
like in commit 9757e680e2
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
1. grid: typo? The icon size is 160 - 44 + (44 / 2) = 138px
2. non-grid: border is already included in height because the tr
is a border-box (made this explicit to be safe)
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Labeling with `<label>` doesn't work in some screen readers.
`<label>` also doesn't work as a clickable link here.
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
When pressing a button for changing the app order that button should keep the focus after reordering the list.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
- Remove non-existing `button-class` from `NcAppNavigationNew`
- Type: use `input-id` instead of `id` on `NcSelect` to be labeled
- Encode uniqueId with user's ID, because user.id may contain space
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
If was replaced with universal `savePrimaryAccountPropertyScope`.
`<HeaderBar>` has no `handle-scope-change` prop.
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
There was a typo, it must have been disable-menu, not disableD-menu.
But it is not required, because the menu is disabled for the current user anyway.
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
`autocorrect` was actual for Safari long time ago when Safari didn't fully supported HTML 5 spellcheck.
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
* Also add API for setting the value using ajax.
* Add cypress tests for app order and defaul apps
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Pytal
Julius Härtl
Simon L
Côme Chilliet
Ferdinand Thiessen
julia.kirschenheuter
Grigorii K. Shartsev
Côme Chilliet
jld3103
Nextcloud bot
fenn-cs
John Molakvoæ
Varun Patil
Julia Kirschenheuter
John Molakvoæ