75505747bb
fix: Properly fetch version from shared files by accessing the owner storage version
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-12-06 16:01:53 +07:00
4173dfe05b
fix(files_versions): Explicitly check for user or owner before call getUserFolder
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Fix typo
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Fix
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Fix
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Fix
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Optimize DI
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Switch to DI
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
userSession does not contain null
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Restore phpdoc annots
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-11-27 15:17:13 +07:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +07:00
652317e3e2
Don't call getUid() on null
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-11-16 01:28:42 +07:00
ffeef99abc
fix: Delete ghost versions of non-existing files
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-10-28 14:47:19 +07:00
39d4c8759b
Merge pull request #39695 from fsamapoor/refactor_files_version_app_commands
...
Refactors files version app commands.
2023-09-21 15:23:36 +07:00
0273b96eef
Apply suggestions from code review
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-09-21 11:40:18 +07:00
cec0b310a5
Move module versions management logic out of main logic
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-09-07 15:47:59 +07:00
bbb7172220
fix: Also cleanup version metadata if expiring
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-08-14 19:31:41 +07:00
90652fd30f
Uses early returns.
...
To improve code readability.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-08-03 16:42:56 +07:00
ab79706253
Refactors files_version app commands.
...
To improve code readability.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-08-03 16:35:09 +07:00
3dff41786d
files_versions: Add OpenAPI spec
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-13 10:20:09 +07:00
eb71ee950d
Enable all files versions features when groupfolders is enabled
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-07-05 15:52:13 +07:00
95145ee0c9
feat(ocp): More specific type for ICapabilities::getCapabilities
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-07-03 10:03:45 +07:00
05acd916b5
Base versions' has-preview on mimetype
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-06-29 12:08:59 +07:00
36c3846475
Provide hasPreview in files_versions DAV API
...
This allow to no request non existing previews
I also set some properties to the img element to reduce preview loading to what the browser think is necessary
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-06-28 16:46:48 +07:00
7fec07196d
Do not create a new version if previousNode has the same mtime
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-06-22 17:49:49 +07:00
b94145f6bd
fix: Add logging statement for cases when updating the version fails
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-06-21 10:35:12 +07:00
ecdcc72e4d
Handle previousNode size === 0 on version creation
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-06-21 09:56:20 +07:00
e76c96be5c
fix: Avoid failing to update the current version entry if there is none
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-06-13 22:10:13 +07:00
75e04614c1
Enable version features again with S3 versioning
...
Signed-off-by: Benjamin Somers <bsomers@resel.fr>
2023-06-13 15:06:36 +07:00
c3475f4dbb
Fix initialisation of versions in the DB
...
Broken after https://github.com/nextcloud/server/pull/36690
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-05-25 23:43:40 +07:00
d6eb48c436
Check if version has entity before trying to access it
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-05-12 16:00:16 +07:00
7cd5cbe6e9
Check if version entity is not null before delete
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-05-08 14:24:58 +07:00
337fc110ec
fix: catch ManuallyLockedException and use app context
...
The files_lock app may throw ManuallyLockedExceptions
when attempting to revert a file that is currently opened.
This would prevent the user from rolling back a opened file.
Text and Richdocuments handle changes of the file while editing.
Allow reverting files even when they are locked by these apps
and let the apps handle the conflict.
Signed-off-by: Max <max@nextcloud.com>
2023-05-03 09:52:36 +07:00
60b7d2117e
Merge pull request #37428 from nextcloud/enh/ignore-non-numeric-versions
...
Ignore and log non integer versions
2023-04-20 13:33:58 +07:00
cca46f18eb
Really disable versions features when S3 versioning is enabled
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-17 11:16:20 +07:00
2e1a560867
Merge pull request #36690 from nextcloud/bugfix/noid/rollback-hook
2023-04-14 17:09:17 +07:00
a6b1d990a4
Check for non-numeric versions, not non-integer
...
All versions are string
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 17:50:45 +07:00
8cc8765089
Ignore and log non integer versions
...
This avoids being stuck when there is one buggy file version with a
non-integer version. It allows the expiration process to not crash and
continue with the other ones.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 17:44:14 +07:00
ea05544213
Fix return type of methods returning false on error
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:34 +07:00
f00f4244d4
fix: Check return type on rollback
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-03-13 10:59:33 +07:00
62e6a32899
don't re-get fileinfo for versioned file if it's not shared
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-03-13 10:52:37 +07:00
c22d51c1ad
tests(files_versions): Tear down fs to clear mount cache before testing
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-03-13 10:52:37 +07:00
cf46bd6915
fix: Make sure that rollback hook is triggered on all version backends
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-03-13 10:52:35 +07:00
21cd3b0e0d
Handle empty DB while expiring versions
...
Version on the FS can have no equivalent in the DB if they were created before the version naming feature. This makes sure that we catch the resulting exception and proceed as usual.
Fix https://github.com/nextcloud/server/issues/36541
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-02-08 13:56:49 +07:00
1765908c03
Document that size may be a float in new class VersionEntity
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:34 +07:00
88abb2d97c
Fix versions restoring with S3
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
3da63f4148
Use node's owner if no user is connected
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
84e5b9c5f7
Prevent storing versions with the same mtime
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
6dcfb29cfc
Fix renaming files_versions
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
c88328e68e
Handle empty files in version creation logic
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
d8b479752d
Fix hookconnector tests
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
53d736207c
Adapt files_versions tests to modernized hooks
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
2ce4ac4aa4
User rootFolder instead of userFolder in FileEventsListener
...
Requesting userFolder fails during NC installation phase.
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
8f23cc8259
Rename Hooks.php to FileEventsListener.php
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
ad469969bf
Prevent expiration of named versions
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
1adc9d2aab
Delete file versions entries in DB when node is deleted
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
6a2f8bc599
Allow to delete a version through DAV
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
629de6c8c9
Support getting and patching version-label
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
Julius Härtl
Git'Fellow
Joas Schilling
Côme Chilliet
Faraz Samapoor
Louis Chemineau
Faraz Samapoor
jld3103
Christoph Wurst
Benjamin Somers
Max
Côme Chilliet
Robin Appelman