Commit Graph

15122 Commits (878ccc406b411b137d1663456be2ed34269b2e51)

Author SHA1 Message Date
Benjamin Gaussorgues 49bd1754d4 fix(sharding): typo in addOrderBy
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 07:53:10 +07:00
Benjamin Gaussorgues 79db082fe6 fix(users): improve recently active search
- Remove DISTINCT clause to fix PgSQL
- Join user table only if necessary
- Don't show people who never connected in active list
- Add test

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 07:53:10 +07:00
John Molakvoæ 2d5060d1e3
Merge pull request #46151 from nextcloud/enh/do-not-enforce-cache-for-cli 2024-10-29 15:28:47 +07:00
John Molakvoæ e3e22e28c0
Merge pull request #47847 from nextcloud/fix-copying-or-moving-from-shared-groupfolders 2024-10-29 11:33:12 +07:00
skjnldsv f536c86049 fix(systemtags): translations and etag method casing
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-10-29 09:08:31 +07:00
skjnldsv d51cf4536c feat(systemtags): add cypress tests and fix a few logic issues
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-10-29 09:08:31 +07:00
skjnldsv 14e2a8d3f9 feat(systemtags): add etag support and handle proppatch
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-10-29 09:08:31 +07:00
skjnldsv 0893d4b4d2 feat(core): add index to systemtag objecttype
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-10-29 09:08:30 +07:00
Joas Schilling 1e5cb82cc1
fix(config): Mark more configs as sensitive
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-28 14:56:19 +07:00
Kate d25a0a2896
Merge pull request #48915 from nextcloud/fix/encrypt-decrypt-password 2024-10-28 13:26:55 +07:00
yemkareems 34b07ace95
fix: crypto made inline for constructor and decrypt error handled in exception
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 16:43:24 +07:00
yemkareems 3fd16de636
fix: crypto made inline for constructor and decrypt error handled in exception
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 16:32:57 +07:00
Ferdinand Thiessen 86006368bf
Merge pull request #48912 from nextcloud/bugfix/exception-appscreenshot-notstring
fix(apps-store): Fix exception on generating preview url for installed app screenshot
2024-10-28 11:32:15 +07:00
yemkareems 79b1122749
fix: use Icrypto in place of Cypto
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 15:49:05 +07:00
yemkareems a74ef8237d
fix: crypto type made not nullable and tests run using ICrypto
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 15:04:11 +07:00
Kate 5efb175665
Merge pull request #48614 from nextcloud/refactor/storage/constructors 2024-10-28 10:19:41 +07:00
Joas Schilling 220bd3422f
fix(appinfo): Make sure screenshot, author and category are always arrays
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-28 08:46:31 +07:00
yemkareems 505dfd65fd
fix: encrypt and store password, decrypt and retrieve the same
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 11:22:36 +07:00
Joas Schilling 6854af0cc4
feat(bruteforce): Allow forcing the database throttler
Using the database is most likely worse for performance, but makes investigating
issues a lot easier as it's possible to look directly at the table to see all
logged remote addresses and actions.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-24 22:04:41 +07:00
Julien Veyssier 5362486ca9
feat(textprocessing): factorize taskProcessingCompatibleTaskTypes
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-10-24 12:34:33 +07:00
Julien Veyssier 54cebc2136
fix(textprocessing): also list types that are available in task processing
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-10-24 11:28:16 +07:00
provokateurin 0de4843b73 refactor(Storage): Align all Storage constructors
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-23 13:24:18 +07:00
Louis 5f69d8d891
fix: $uid type in Encryption stream
As explained by the comment.

Signed-off-by: Louis <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-10-23 13:20:40 +07:00
dependabot[bot] bb598c8451
chore(deps): Bump nextcloud/coding-standard in /vendor-bin/cs-fixer
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v1.3.1...v1.3.2)

---
updated-dependencies:
- dependency-name: nextcloud/coding-standard
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-19 07:57:35 +07:00
Ferdinand Thiessen 2ef74b9860
Merge pull request #47329 from nextcloud/feat/add-datetime-qbmapper-support
feat(AppFramework): Add full support for date / time / datetime columns
2024-10-18 19:05:08 +07:00
Kate d0625645fb
Merge pull request #48765 from nextcloud/dbQueriesExecStmt2 2024-10-18 11:45:09 +07:00
Git'Fellow a1681b0756 chore(db): Apply query prepared statements
Fix: psalm

fix: bad file

fix: bug

chore: add batch

chore: add batch

chore: add batch

fix: psalm
2024-10-17 20:30:47 +07:00
Ferdinand Thiessen 0e54c2bd43
fix: Adjust Entity types
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 18:31:44 +07:00
Ferdinand Thiessen db94e10af0
fix: Prevent breaking change in IQueryBuilder
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 18:31:44 +07:00
Ferdinand Thiessen e314d52118
fix: Adjust parameter type usage and add SQLite support
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 18:31:44 +07:00
Ferdinand Thiessen ee02e3246d
feat(AppFramework): Add full support for date / time / datetime columns
This adds support for all Doctrine supported types, for the column types only the immutable variants needed to be added.
But especially those types are the important ones, as our **Entity** class works by detecting changes through setters.
Meaning if it is mutable, changes like `$entity->date->modfiy()` can not be detected, so the immutable types make more sense here.

Similar the parameter types needed to be added.

`Enity` and `QBMapper` needed to be adjusted so they support (auto map) those types, required when insert or update an entity.

Also added more tests, especially to make sure the mapper really serializes the values correctly.

Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 18:31:42 +07:00
Joas Schilling b61a8cfeba
fix(comments): Document supported types and provide psalm typing
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-17 14:27:42 +07:00
Joas Schilling 9d6c0afad6
feat(comments): Support mentioning emails
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-17 14:27:42 +07:00
Git'Fellow c254855222 chore(db): Correctly apply query types
fix: psalm

fix: error

fix: add batch

fix: fatal error

fix: add batch

chore: add batch

chore: add batch

fix: psalm

fix: typo

fix: psalm

fix: return bool

fix: revert Manager
2024-10-17 09:21:07 +07:00
Ferdinand Thiessen f3aa004b1c
refactor(encryption): Migrate away from Hooks to typed events
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Louis <louis@chmn.me>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-15 18:33:06 +07:00
Kate cbcbe8a83c
Merge pull request #48682 from nextcloud/fix/appconfig/sensitive-keys-external-jwt-private-key 2024-10-15 10:38:16 +07:00
John Molakvoæ 832695d565
Merge pull request #48206 from nextcloud/feat/systemtags-public 2024-10-15 09:15:16 +07:00
Ferdinand Thiessen b964e05312
Merge pull request #48673 from nextcloud/fix/null-label
fix(share): Return empty string if no label is set
2024-10-14 19:10:12 +07:00
Ferdinand Thiessen 3d2039f041
Merge pull request #48687 from nextcloud/chore/gender-neutral-language
chore: Use more gender neutral language
2024-10-14 18:13:30 +07:00
Ferdinand Thiessen 262ed0ffeb
Merge pull request #48650 from nextcloud/fix/shipped-app-version
fix: Shipped apps should include the Nextcloud version in the cache buster
2024-10-14 17:22:24 +07:00
Joas Schilling f07993173a
Merge pull request #48604 from nextcloud/bugfix/noid/fix-tainted-file-appinfo
fix(appmanager): Fix tainted file path when loading appinfos
2024-10-14 17:03:09 +07:00
Ferdinand Thiessen 980ab1f56b
fix: Shipped apps should include the Nextcloud version in the cache buster
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-14 16:04:13 +07:00
Ferdinand Thiessen 2e4d3e4e75
fix(share): Return empty string if no label is set
* Resolves: https://github.com/nextcloud/server/issues/48629

While the database supports NULL, the typing has always said it only returns *string*.
So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-14 15:15:51 +07:00
Joas Schilling 07449847e1
fix(appmanager): Fix tainted file path when loading appinfos
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-14 14:33:19 +07:00
provokateurin 51d9d63a01
chore: Use more gender neutral language
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-14 13:59:24 +07:00
Git'Fellow 8f7784bdf9
fix(locking): Accept mixed as value on setTTL
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-10-14 12:17:27 +07:00
provokateurin 7edb70a63e
fix(AppConfig): Add external JWT private key to sensitive keys
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-14 10:42:06 +07:00
John Molakvoæ (skjnldsv) abd0cddd38 feat: make systemtags public visible
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-10-11 16:06:44 +07:00
Thomas Citharel dcd27fd986
feat(http-client): expose default request timeout constant to be used instead of magic number 30
Will be used to set default where we are able to override the default timeout.

See https://github.com/nextcloud/server/pull/48418

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-10-11 10:57:02 +07:00
Daniel Calviño Sánchez 3017951d1d fix: Fix copying or moving from shared groupfolders
When copying or moving between two local storages the source path (on
disk) to copy or move from is got from the unjailed path of the source
storage. However, if the source storage has more than one jail getting
the unjailed path resolves the most external jail, but the source path
needs to be got from the most internal jail instead (the one closer to
the local storage).

This can happen, for example, with a shared groupfolder: in that case
there is an external jail for the shared storage, and one internal jail
for the groupfolder storage wrapped by the shared storage.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-10-10 15:16:12 +07:00