Commit Graph

6655 Commits (837622cb87aedaf0a6b753d92b00a2fe3475ea2c)

Author SHA1 Message Date
Joas Schilling a81d8ecef5
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-09 16:15:47 +07:00
Julius Härtl 08802ad13f
Merge pull request #36566 from nextcloud/mount-find-by-numeric-id 2023-02-08 20:04:57 +07:00
Joas Schilling dcfc96f0cc
Merge pull request #36417 from nextcloud/fix/psr-container
Make the container fully fulfill PSR container interface
2023-02-07 20:38:19 +07:00
Robin Appelman 9f3dbb699a fix tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-02-07 15:50:10 +07:00
Côme Chilliet 892e6c642a
Skip buggy tests for 32bits CI
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:33 +07:00
Côme Chilliet 77c8c9c805
Improve error output on failed Router test
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:31 +07:00
Côme Chilliet 94ecae4ade
Add helper to cast to int|float, fix MemoryInfo on 32bits
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
Côme Chilliet 0f8c34cdc6
Fix filesize return type error in ViewTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
Côme Chilliet 5cfab229db
Improve test failure output for RouterTest.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:29 +07:00
Côme Chilliet 2d8e696c24
Add apcu and ffmpeg to have less skipped tests
Also exclude test groups which rely on a service

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:28 +07:00
Joas Schilling 59578817f5
Merge pull request #36489 from nextcloud/bugfix/noid/brute-force-protection-password-reset
Add bruteforce protection to password reset page
2023-02-06 22:12:25 +07:00
Ferdinand Thiessen ba8a50c059 fix: Throw `NotFoundExceptionInterface` to fulfill PSR container interface if class not found
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-02-06 14:16:35 +07:00
Joas Schilling 875e6cf7e6
fix(CI): Adjust expected result
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-06 11:26:38 +07:00
Christoph Wurst 88d116ba84
fix(client-login-flow): Handle missing stateToken gracefully
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-02-06 09:42:15 +07:00
Joas Schilling 47880b143d
Remove failing test that works with mocks only anyway
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-02 18:06:31 +07:00
Côme Chilliet dde5c46a3e
Migrate to Symfony Mailer
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-02 10:30:06 +07:00
Maxence Lange 1a655e88d9 use php8.0 images
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-01-31 15:44:12 +07:00
Julius Härtl c246edece6
tests(oci): Test where statement on longtext column
Signed-off-by: Julius Härtl <jus@bitgrid.net>

test: try with just passing the type to eq which should also cast

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-01-31 11:57:54 +07:00
Louis 2f3007205d
Merge pull request #35160 from nextcloud/artonge/feat/version_naming_backend
Allow to name a version
2023-01-30 10:40:49 +07:00
Joas Schilling 959e2aaa17
fix(tests): Fix method name in unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-30 09:12:50 +07:00
Christoph Wurst 20e00cdf17
feat(app-framework): Add UseSession attribute to replace annotation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-27 09:40:35 +07:00
Christoph Wurst 8d9af3e262
feat(app-framework): Add support for global middlewares
This allows apps to register middlewares that always register, not just
for the app's own requests

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-26 11:54:28 +07:00
Louis Chemineau d8b479752d Fix hookconnector tests
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-01-26 10:12:23 +07:00
Christoph Wurst 907ff68bfc
perf(app-framework): Make the app middleware registration lazy
Before this patch, app middlewares were registered on the dispatcher for
every app loaded in a Nextcloud process. With the patch, only
middlewares belonging to the same app of a dispatcher instance are
loaded.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-25 09:27:24 +07:00
Christopher Ng 0236c9e8cd Port files sharing selector
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-24 17:40:17 +07:00
Côme Chilliet 003cc2b45a
Fix tests failures (number of calls differed with last rebase)
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-24 09:38:20 +07:00
Carl Schwan a23cd7b961
Fix a bunch of deprecation in the phpunit for core
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-01-24 09:34:09 +07:00
Joas Schilling 1c099c7f17
Fix broken user:setting command unit test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-23 07:01:22 +07:00
Côme Chilliet f5c361cf44
composer run cs:fix
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +07:00
Joas Schilling 89dbc629ff
Fix integrity check
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-20 11:22:11 +07:00
Côme Chilliet de68fc6347
Update test file for mimetypes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:11 +07:00
Côme Chilliet b22b6431d2
Fix gzip mimetype mapping
PHP now detects it as application/gzip and not application/x-gzip anymore

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:11 +07:00
Côme Chilliet 7ebbb6b2ca
Remove workarounds specific to 7.4
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:08 +07:00
Joas Schilling 1e2441ff6b
Disable unreliable acceptance tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-19 09:21:33 +07:00
Christoph Wurst 20fcfb5739
feat(app framework)!: Inject services into controller methods
Usually Nextcloud DI goes through constructor injection. This has the
implication that each instance of a class builds the full DI tree. That
is the injected services, their services, etc. Occasionally there is a
service that is only needed for one controller method. Then the DI tree
is build regardless if used or not.

If services are injected into the method, we only build the DI tree if
that method gets executed.

This is also how Laravel allows injection.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-18 14:00:38 +07:00
Christoph Wurst f22101d421
Fix login loop if login CSRF fails and user is not logged in
If CSRF fails but the user is logged in that they probably logged in in
another tab. This is fine. We can just redirect.
If CSRF fails and the user is also not logged in then something is
fishy. E.g. because Nextcloud contantly regenrates the session and the
CSRF token and the user is stuck in an endless login loop.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-18 09:39:17 +07:00
blizzz dbfe7b1816
Merge pull request #36073 from nextcloud/fix/fix-background-job-list
Use a Generator for job list to fix background-job:list command
2023-01-16 11:10:10 +07:00
Christopher Ng f6aa5224c4 Focus trap contacts menu with NcHeaderMenu port
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-13 23:19:28 +07:00
Joas Schilling 238e9cf3a8
feat(CI): Enforce colored output for acceptance tests on drone CI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-13 11:31:13 +07:00
Côme Chilliet d74044f634
Fix API breakage by using a new method instead
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-12 17:18:59 +07:00
Côme Chilliet 75fca38e66
Fix BackgroundJob list tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-12 11:40:18 +07:00
Simon L 7271ec7acf spaces are allowed in userids
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-01-10 13:25:27 +07:00
Vincent Petry 42d9e087fb
Remove unused legacy ajax/list.php in files app
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2023-01-09 15:18:37 +07:00
Julius Härtl 18164ae516
Merge pull request #33898 from nextcloud/fix/authtoken-password-update
PublickKeyTokenProvider: Fix password update routine with password hash
2023-01-05 08:01:47 +07:00
Joas Schilling 97e33c2bd4
Fix unit tests of the ActionProviderStore
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-04 16:17:43 +07:00
Joas Schilling 8eca26012f
Show local time in avatar menu
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-01-04 11:09:58 +07:00
Marcel Klehr adfe367106
PublickKeyTokenProvider: Fix password update routine with password hash
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-01-04 08:30:53 +07:00
Bennet Becker 4dc0957164
refactor AutoSubmittedValue to Headers\AutoSubmitted and adding
header name to constants

Signed-off-by: Bennet Becker <dev@bennet.cc>
2023-01-03 15:15:35 +07:00
Bennet Becker 411467af57
fix static-analysis error and formatting code
Signed-off-by: Bennet Becker <dev@bennet.cc>
2022-12-23 21:48:52 +07:00
Bennet Becker c1c6d215c7
fix getAutoSubmitted return type and adding unit tests
Signed-off-by: Bennet Becker <bbecker@pks.mpg.de>
2022-12-23 19:26:49 +07:00
Simon L bfb3b2af9f increase preview_max_memory and make it easier to debug
Signed-off-by: Simon L <szaimen@e.mail.de>
2022-12-22 09:52:46 +07:00
Daniel Kesselberg e2285acd04 Update behat and friends
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-12-21 15:27:59 +07:00
Stanimir Bozhilov 7dcd6eb561
Merge branch 'master' into add-scim-json-support
Signed-off-by: Stanimir Bozhilov <stanimir.bozhilov.1998@gmail.com>
2022-12-19 09:07:38 +07:00
Vincent Petry ae6fe874ed
Merge pull request #35780 from nextcloud/fix/http-dispatcher-double-parameter-cast
Fix missing cast of double controller parameters
2022-12-16 16:18:35 +07:00
Vincent Petry 6737deabbf
Merge pull request #35784 from nextcloud/chore/strict-login-controller
Make the LoginController strict
2022-12-16 16:16:31 +07:00
Christoph Wurst 138deec333
chore: Make the LoginController strict
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-15 10:52:28 +07:00
Christoph Wurst b6dd1a1d7b
fix(app framework): Fix missing cast of double controller parameters
``settype`` allows 'double' as alias of 'float'.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-12-15 09:33:52 +07:00
Artur Neumann 81f2857f34
check if params given to API are really an array
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2022-12-15 13:45:22 +07:00
Christopher Ng fb2fb0d2d5 Revert "Copy to clipboard with button instead of link"
This reverts commit 4ffc022c8b.

Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-12-14 00:57:57 +07:00
Joas Schilling 2f7a1fca5f
Merge pull request #34477 from nextcloud/bugfix/noid/sharee-recommendations-show-group-id
Show group name instead of group id as recommendation
2022-12-09 22:39:28 +07:00
Julius Härtl 4bcaeb6c2c
Drop 3rdparty root since it is unused and adjust tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 23:55:32 +07:00
Julius Härtl 306d7829b5
Cache available languages locally
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 22:32:06 +07:00
Julius Härtl 87e638b1f8
Merge pull request #35649 from nextcloud/bugfix/object-storage-master-key-enc
Update the unencrypted file size when closing streams
2022-12-07 22:03:13 +07:00
Julius Härtl 3c8fb59fa4
Merge pull request #35620 from nextcloud/fix/fix-calendar-imip-tests 2022-12-07 20:39:41 +07:00
Julius Härtl 59ae6e9dd6
Also update the unencrypted size of files when creating them with empty content
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-12-07 19:12:06 +07:00
Julien Veyssier 4a3f3beb0b
use bruteforce protection on all methods wrapped by PublicShareMiddleware
if an invalid token is provided or when share password is wrong

Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2022-12-07 13:24:50 +07:00
Côme Chilliet 7cf1dec842
Fix errors in calendar tests saying function handleIMipMessage does not exists on ICreateFromString
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-06 13:52:13 +07:00
Côme Chilliet 1821712615
Merge pull request #35596 from nextcloud/fix/move-to-ocp-timedjob
Use TimedJob from OCP instead of OC
2022-12-06 12:14:43 +07:00
Côme Chilliet ee06261b82
Fix codestyle in modified files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-05 16:08:40 +07:00
Côme Chilliet 30560d3165
Merge branch 'master' into tests/fix-phpunit-warnings
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2022-12-05 12:03:39 +07:00
Côme Chilliet 578648a062
Adapt tests to new job constructors
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-05 10:41:13 +07:00
J0WI a4d0700bf2 Fix test image default quality
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2022-12-04 14:51:33 +07:00
John Molakvoæ a869259e41
More theming cypress tests and some fixes
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2022-11-29 11:26:27 +07:00
Anna Larch 7c4ceb444c Add group display name cache
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-11-28 11:52:55 +07:00
Christopher Ng 4ffc022c8b Copy to clipboard with button instead of link
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-24 23:50:54 +07:00
Christopher Ng 20da3d081e Add label to sharing search field
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-11-23 02:04:18 +07:00
Carl Schwan e35bcc9381 Fix tests
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-22 10:06:19 +07:00
Joas Schilling d1f2e5e967
Increase the fair-use push limit to 1.000 users
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-11-18 15:39:23 +07:00
John Molakvoæ d27a39271e
getAppValue expects string
Co-authored-by: Pytal <24800714+Pytal@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2022-11-17 08:03:05 +07:00
Git'Fellow 0f3150cff7
Tests adjustement
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2022-11-16 11:01:32 +07:00
Côme Chilliet 68363f6944
Fix some more problems with tests under PHP 8.2
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 16:02:24 +07:00
Côme Chilliet 324126888e
Add Union types for properties in tests/lib/Encryption/Keys/StorageTest.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 09:29:35 +07:00
Côme Chilliet 0f7e56b3b3
Fix syntax in VerificationTokenTest.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 09:25:56 +07:00
Côme Chilliet c79a6b3f62
Fix errors from PHP 8.2 testing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 17:08:21 +07:00
Côme Chilliet 70e2217d1c
Fix dynamic properties and other problems in tests for PHP 8.2
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 16:14:35 +07:00
Simon L 4bf1f4e484
Merge pull request #35093 from nextcloud/nickvergessen-patch-1
Run integration tests on 3rdparty bump
2022-11-14 09:45:55 +07:00
Joas Schilling 9dd0d0ba57
Run integration tests on 3rdparty bump
Signed-off-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
2022-11-11 07:54:26 +07:00
Christoph Wurst 9d0e79f10d
Fix PublicKeyTokenProviderTest import and mock
* IDBConnection import missing
* Atomic doesn't need a mock

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-10 15:40:35 +07:00
Julius Härtl 908b7aa70a
Attempt to fix CalendarImpl tests
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-09 16:37:34 +07:00
Julius Härtl 2a684f6741
Fix some phpunit test warnings
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-09 16:37:34 +07:00
szaimen f9e9cd270d
Limit-number-of-concurrent-preview-generations
Signed-off-by: Bowen Ding <dbw9580@live.com>
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-11-05 16:03:01 +07:00
Julius Härtl 5c4a66f0c1
Merge pull request #34775 from nextcloud/bugfix/noid/mailer-set-to
Do not throw errors when invalid setTo email is provided
2022-11-04 18:24:55 +07:00
Julius Härtl fd036f774f
Do not throw errors when invalid setTo email is provided
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-11-03 16:59:12 +07:00
Côme Chilliet 2e83a21cd2
Merge pull request #34678 from pulsejet/patch-jpeg
Interlace all output JPEG
2022-11-03 16:11:03 +07:00
Côme Chilliet 8a2e52e7f8
Merge pull request #34330 from nextcloud/fix/fix-contacts-test-php8
Fix ContactsStoreTests under PHP 8.2
2022-11-03 14:55:06 +07:00
Christoph Wurst ac92d00da8
Merge pull request #32565 from nextcloud/chore/modernize-error-handler
Modernize the error handler
2022-11-03 14:42:51 +07:00
Christoph Wurst 052dcdebe8
Refactor the ErrorHandler into a dynamic class
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-02 09:49:37 +07:00
Christoph Wurst 8aea25b5b9
Add remote host validation API
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-10-31 16:13:28 +07:00
Christopher Ng 4a2bbc7af9 Rewrite admin theming in Vue
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2022-10-28 00:18:47 +07:00
Joas Schilling d007088cf5
Merge pull request #34847 from nextcloud/refactor/local-address-checker-method-capitalization
Rename LocalAddressChecker methods to lower case
2022-10-27 15:57:58 +07:00