e553cd1bb9
Fix comments and dav tests with Notifications and Activity changes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-19 09:57:32 +07:00
6ad600ea8a
Fix jsunit tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-09-01 14:15:42 +07:00
ae67eba84b
Use user displayname cache for comment mentions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-19 10:23:16 +07:00
bb2557c389
Replace files app ids to classes
...
Replaced ids to classes for the following:
- #filestable -> .files-filestable
- #fileList -> .files-fileList
- #controls -> .files-controls
- #emptycontent -> .emptyfilelist.emptycontent
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-26 10:19:19 +07:00
fa266165d6
Modernize comments app
...
* Use php 7.4 typed properties
* More typed methods (and replace existing php doc in some cases)
* query -> get for Container
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-03-16 13:14:15 +07:00
14e57bf70a
Replace license information to SPDX expression
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-01-11 17:26:40 +07:00
85444605d3
One more test fix
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-01-05 19:00:28 +07:00
8382e5ebb3
Fix test
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-01-05 18:02:14 +07:00
ee60736d33
Fix test
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-01-05 17:58:16 +07:00
a8ebf37b08
fix jsunit tests for comments
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2021-07-27 12:57:44 +07:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
3e624dc399
Bump js licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-31 12:17:18 +07:00
8988406789
Move comments to initial state
...
* Do not extend the jssettings
* Just use the proper intial state
* Use it in the js code as well
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 20:31:56 +07:00
6cd7549509
Bump @nextcloud/vue to 3.0.0
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
2020-10-20 18:02:45 +07:00
afa7376522
Cleanup old comments tab
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2020-10-20 13:58:07 +07:00
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +07:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +07:00
234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-12 13:55:19 +07:00
91e7f12088
Adjust apps' code to use the ContainerInterface
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-07-21 20:43:18 +07:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +07:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +07:00
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +07:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +07:00
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +07:00
2ee65f177e
Use the shorter phpunit syntax for mocked return values
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:21:27 +07:00
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:08:08 +07:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +07:00
3a7cf40aaa
Mode to modern phpunit
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 15:27:18 +07:00
c007ca624f
Make phpunit8 compatible
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:41 +07:00
68748d4f85
Some php-cs fixes
...
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +07:00
a48359ac02
Adjust unit tests to new OCA.Sidebar
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-10-29 13:20:08 +07:00
565838da9c
Update unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2019-07-16 13:32:44 +07:00
e9351ef779
Add strict type on Notifications tests
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2019-06-13 14:58:38 +07:00
1b4f1b9a63
Populate the mention-notification with the actual message
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-11-08 12:10:09 +07:00
e375107aa4
Redirect guests to login if they follow the link of a comment mention-notification
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2018-10-02 08:40:34 +07:00
c9ce96ff05
Show avatar using "span" instead of "div"
...
Visually it makes no difference, but as the ".avatar" element is inside
a "span" element it can not be a block element to be compliant with the
HTML specification.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2018-09-05 18:33:10 +07:00
16bf9326cb
Fixing failing test cases due to change in functionality.
...
Also fixes scrutinizer warnings.
Signed-off-by: Abijeet <abijeetpatro@gmail.com>
2018-03-27 01:34:00 +07:00
a5a0a938f2
test creating comments with numeric user ids
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2018-02-14 14:39:10 +07:00
4c0c3c0bef
Show max warning comment lenth again
...
Fixes #7414
Since we no longer use an input field we have to use text instead of
val.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2018-01-02 10:28:09 +07:00
5724e75827
Merge pull request #7252 from nextcloud/send-comment-on-enter
...
Submit comments with Enter and use Shift+Enter for new lines
2017-12-08 15:31:10 +07:00
9b1f3b969e
Fix Enter sending comment instead of adding autocomplete item to message
...
When the autocomplete popover is shown the At.js plugin listens on the
message input field for key down events, and when Enter is pressed it
adds the selected item to the message. However, as "_onTypeComment" also
handles key down events for the message input field, when Enter was
pressed the comment was submitted and At.js had no chance to add the
item before that happened. Now when Enter is pressed and the
autocomplete popover is shown the comment is not submitted, and thus
At.js adds the selected item to the message as expected.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-12-07 15:38:46 +07:00
c43f64d56b
Add unit tests for posting comments with enter key
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-30 19:30:27 +07:00
d03fcbca77
Set text only in the message div of the new comment form
...
When finding ".message" elements on "view.$el" the message area for the
new comment form and all the comments were matched. Now the selector was
restricted to match only the message area for the new comment form.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2017-11-30 19:29:19 +07:00
4af12dcab1
Fix unit tests
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-27 08:50:44 +07:00
0eebff152a
Update license headers
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-11-06 16:56:19 +07:00
e2805f02aa
Merge branch 'master' into autocomplete-gui
2017-11-01 15:37:29 +07:00
2b4b3b1986
adjust jsunit tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-11-01 11:44:01 +07:00
d5f1cef642
fix comment sorter
...
background: we have a flat hierarchy of comments, not a tree. therefore we
can also remove again the unnecessary additions.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-30 15:59:43 +07:00
ca72c0150b
configurable amount of autocomplete results in comments
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2017-10-27 13:50:38 +07:00
43e498844e
Use ::class in test mocks
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2017-10-24 17:45:32 +07:00
Côme Chilliet
Julius Härtl
Joas Schilling
Vincent Petry
Carl Schwan
Louis Chemineau
Valdnet
Julien Veyssier
John Molakvoæ (skjnldsv)
Roeland Jago Douma
Christoph Wurst
Morris Jobke
Christoph Wurst
Daniel Calviño Sánchez
Abijeet
Arthur Schiwon