The inputs of the sharing settings are generated in a template in the
server, but the listeners to react to changes in the elements and save
the values in the server are loaded in the client once the DOM finishes
loading. If the DOM takes long to load the user can start to interact
with the settings before the listeners were set up and, therefore, the
changes would not be saved in the server. However, as the inputs are
modified the user would think that the changes were already saved.
To address that now when the sharing settings are open a loading spinner
is shown instead of the contents of the sharing settings, and only once
the listeners to save the changes were set up the spinner is removed and
the contents shown.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
And refactor how the grid works (now it's automatically using the
correct size instead of harcoding it)
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
- Make it possible to add the new property whiout chaning foundamentally
how the layout work each time
- Use only one grid instead of multiple nested grid
- Better mobile reponsiveness
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
- Port away from jquery inside vue
- Use modern vue components when possible
- Fix some readability isssues particularly on dark theme
- Use IInitialState
- Use php7.4
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Input fields require a 44x44 pixels target size, this makes all the
input fields and button use that size.
Bonus is that now the input fields and buttons now have the same size as
the new vue button and this looks less weird than the previous state
with controls of different sizes.
See https://www.w3.org/WAI/WCAG21/Understanding/target-size.html
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
- Add visible-focus effect on each header entry
- Show focus outline when using focus-visible (keyboard navigation)
- Add polyfy for focus-visible since it's only very recently available
on webkit
- Change text for link to home button to describe the destination and
not the current page
- Improve focus effect in app sidebar navigation
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
julia.kirschenheuter
Christopher Ng
Ferdinand Thiessen
Jonas
Silke Suck
Jérôme Herbinet
Simon L
Christoph Wurst
Daniel Calviño Sánchez
Carl Schwan
dependabot[bot]
John Molakvoæ
Julius Härtl
John Molakvoæ