2018c72eaa
Merge pull request #39895 from nextcloud/fix/noid/revoke-admin-overwrite
2023-09-05 14:52:09 +07:00
e55087b6b1
admin have no special rights on users' entries
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-09-01 20:14:52 +07:00
8d1a3daa3f
Allow ext storage Local to go unavailable
...
Whenever an external storage of type Local points at a non-existing
directory, process this as a StorageNotAvailable instead of returning
404.
This makes desktop clients ignore the folder instead of deleting it when
it becomes unavailable.
The code change was limited to external storages to avoid issues during
setup and with the default home storage.
Signed-off-by: Vincent Petry <pvince81@yahoo.fr>
2023-08-29 11:04:31 +07:00
fb647e29b1
use fresh builders when deleting storages
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-08-14 18:03:20 +07:00
a7808f0115
files_external: Fix OpenAPI
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-08-07 08:42:19 +07:00
44b4c16a09
Merge pull request #39605 from nextcloud/bugfix/noid/final-events-cleanup
...
fix!: Final round of moving to IEventDispatcher
2023-08-04 10:39:57 +07:00
38480fda3c
feat(files_external): migrate to vue
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-01 16:38:06 +07:00
9b03dc52a4
Migrate files external to PSR LoggerInterface
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-08-01 09:44:57 +07:00
3962cd0aa8
fix!: Move getEventDispatcher usage to IEventDispatcher
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:22 +07:00
31f1ff87d0
Merge pull request #39367 from nextcloud/s3-fopen-exception
...
handle more exceptions in AmazonS3::fopen
2023-07-20 19:32:03 +07:00
c3c58b66f2
Merge pull request #39321 from nextcloud/feature/openapi/files_external
...
files_external: Add OpenAPI spec
2023-07-13 16:01:58 +07:00
7c9edbff32
handle more exceptions in AmazonS3::fopen
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-07-13 15:37:42 +07:00
b99020a6f7
getStorage before remove
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-07-11 17:36:17 +07:00
bb1e73de97
files_external: Add OpenAPI spec
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-11 17:22:35 +07:00
83faba5e61
Merge pull request #38591 from nextcloud/fix/caching/avoid-haskey-get
...
fix(caching): Avoid checking existence before fetching
2023-06-12 13:53:37 +07:00
b8c61b3515
fix(caching): Avoid checking existence before fetching
...
The cache might expire between checking for key existence and fetching
the value. In this rare case the code continues with a null value when
it doesn't expect one.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-12 09:44:48 +07:00
94f2f57519
Update apps/files_external/lib/Lib/Storage/SMB.php
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-05 16:21:14 +07:00
cfb921b26c
Refactors "strpos" calls in /apps/files_external to improve code readability.
...
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-06-02 19:54:49 +07:00
fa4d153610
Merge pull request #38115 from DerGenaue/patch-1
...
Rename `numericStorageId` to `numericExternalStorageId` in PersonalMount.php
2023-05-16 19:08:39 +07:00
2466724b01
check the username when doing external storage session auth
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-11 17:47:56 +07:00
55d7add92f
Rename `numericStorageId` to `numericExternalStorageId` in PersonalMount.php
...
so that it doesn't override `numericStorageId` in the `MountPoint` baseclass
fixes https://github.com/nextcloud/server/issues/37473
fixes https://github.com/nextcloud/server/issues/37414
Signed-off-by: Daniel <7558512+DerGenaue@users.noreply.github.com>
2023-05-07 04:47:44 +07:00
c0076d9cc0
Merge pull request #37717 from nextcloud/artonge/fix/dont_override_stored_credentials_with_saml
...
Do not override stored credentials when login in with SAML
2023-04-24 11:30:43 +07:00
60cf0c8f5f
add command for getting fileinfo for debugging
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-17 16:23:52 +07:00
140c2541ed
Merge pull request #37611 from ZE3kr/patch-1
...
Unquote S3 ETag stored in oc_filecache
2023-04-14 16:20:44 +07:00
fec8ad8441
Do not override stored credentials when login in with SAML
...
When login in with SAML, the password from `$event->getPassword()` is `null`.
This PR makes sure that this `null` value won't be used to override the stored password even though it is different.
This PR also allow for the password and user to be updated even though they were not set before.
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-13 18:05:37 +07:00
570b64aafc
handle not being able to write file for notify self-test
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-06 11:52:22 +07:00
bb173e092b
Update AmazonS3.php
...
Signed-off-by: James Guo <i@ze3kr.com>
2023-04-06 14:34:08 +07:00
b1f352c614
improve handling of files we can't access in the scanner
...
instead of erroring, remove the items from the cache.
this situation can be triggered if a user has access to a file but looses it afterwards
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-05 14:44:55 +07:00
fd0ef588b4
fix ftp external storage with filezilla server
...
- filezilla doesn't like "" as parameter for `mdtm` (all others seem fine)
- filezilla sends fractional modified date
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-03-30 17:44:47 +07:00
308fcf4526
Respect OCP interface in private classes
...
Because the parameter type was moved to phpdoc it needs to be removed
from implementations
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:35 +07:00
ff776a90b1
Strong type filesize related methods to ease 32bits problem findings
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-02-07 11:23:28 +07:00
0c466b7ff5
Attempt at reducing psalm errors
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:09 +07:00
f0b9b6ebaa
Merge pull request #36089 from nextcloud/enh/noid/ext-storage-default-values
...
Ext storage configs default value support + enable SSL by default
2023-01-16 14:22:16 +07:00
4e179e0e07
Enable SSL by default in ext storage configs
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2023-01-13 10:27:17 +07:00
a0f70988f4
Extend ext storage params to contain default value
...
Extend the external storage configuration parameters definition to allow
to specify a default value
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2023-01-13 10:27:17 +07:00
710f3fd405
Support of s3 storage class in External Storage application
...
Signed-off-by: François Ménabé <francois.menabe@gmail.com>
2023-01-12 14:59:13 +07:00
9430899f16
Fix psalm issues related to signature changes from PHP 8.0
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-12-29 12:36:34 +07:00
5e31ed4f52
Add comments
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-12-05 15:26:36 +07:00
754cb58b12
Fix migration to non-empty secret
...
Add a fallback for empty keys
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-12-05 11:28:52 +07:00
ed8fedc685
fix s3 directory copy
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-15 17:17:59 +07:00
9ba9f9a7dc
Make sure to not pass null to DateTime::createFromFormat
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 16:23:50 +07:00
a5ea677370
Rename file1 and file2 to source and target in Storage abstraction
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-18 17:21:47 +07:00
732badf552
Additional type hinting found by psalm
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-18 12:28:34 +07:00
94a0b27000
Specify type to internal storage class
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 11:53:11 +07:00
7da806d6eb
Fix returning null when getMessage return null
...
Don't overwrite $message but instead create another temporary variable
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 11:53:11 +07:00
9319bbb00c
More type safety
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 11:53:11 +07:00
5b3509dc05
Fix type of getVisibilityType
...
This is a int not a string
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 10:58:27 +07:00
c2c63a551f
Fix usage of streams
...
always return a bool and type the handle as a string
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 10:58:27 +07:00
74e6976779
Use argument name from parent class
...
This will be an issue with php 8, so best to fix it now
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 10:58:27 +07:00
c94f9f5e5f
Add corresponding interface to trait
...
Since we can't specify that we want a class implementing a trait yet in
PHP
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 10:58:27 +07:00
John Molakvoæ
Maxence Lange
Vincent Petry
Robin Appelman
jld3103
Joas Schilling
John Molakvoæ
Benjamin Gaussorgues
Joas Schilling
Simon L
Christoph Wurst
Faraz Samapoor
Daniel
Louis
Julius Härtl
Louis Chemineau
James Guo
Côme Chilliet
Vincent Petry
François Ménabé
Carl Schwan