Anna Larch
7051f1b577
fix(CardDAV): allow disabling of the system address book via config option
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-09-01 17:38:20 +07:00
Anna Larch
6bd78917d3
fix(CardDAV): set owner-principal, displayname properties for SAB
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-08-16 09:11:01 +07:00
Daniel
aa5dcb0952
Merge pull request #38397 from nextcloud/enh/contacts/hide-adressbook-option
...
enh(contacts): show/hide addressbooks for all
2023-07-18 17:05:12 +07:00
Anna
49b6541498
Merge branch 'master' into fix/correct-exceptions-for-SAB
2023-07-14 14:08:57 +07:00
Richard Steinmetz
9206c0f473
fix(dav): close cursor when fetching max id
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2023-07-11 08:05:34 +07:00
Johannes Merkel
bb802956a2
enh(contacts): show/hide addressbooks for all
...
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2023-07-10 13:39:15 +07:00
Anna Larch
558e386e46
fix(CardDAV): catch right exception when checking for federated app classes
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-07-06 13:07:14 +07:00
Johannes Merkel
eda3824d91
enh(sab): Add profileUrl to SAB
...
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2023-07-03 17:55:18 +07:00
Johannes
199b9788e6
Merge pull request #38856 from nextcloud/fix/contacts/3404/put-location-in-proper-place
...
fix(sab): put location in proper address field
2023-06-22 11:51:33 +07:00
Simon L
56c16b306f
Merge pull request #38639 from charno/bugfix/36644-pruneOutdatedSyncTokens-deletes-all-entries
...
Bugfix/36644 pruneOutdatedSyncTokens deletes all entries
2023-06-20 16:36:28 +07:00
Johannes Merkel
3cb8968808
fix(sab): put location in proper address field
...
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2023-06-20 16:18:09 +07:00
Christoph Wurst
62c41967e8
fix(carddav): Make SystemAddressBook::__construct $groupManager argument nullable
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-12 18:44:25 +07:00
Christof Arnosti
73fb2997f4
Issue #36644 : Fix pruneOutdatedSyncTokens for CalDAV
...
pruneOutdatedSyncTokens accidentally deletes all entries of the calendarchanges table
instead of leaving $limit elements in the table
Signed-off-by: Christof Arnosti <charno@charno.ch>
2023-06-12 08:35:35 +07:00
Joas Schilling
ef93bb926c
fix(dav): Fix avatar size in system address book
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-26 10:03:58 +07:00
Arthur Schiwon
cd5bd11771
Merge pull request #38448 from nextcloud/fix/carddav/no-sab-guest-users
...
fix(carddav): Don't show system address book cards to guests
2023-05-25 17:26:46 +07:00
Christoph Wurst
9780472a02
Merge pull request #38454 from nextcloud/fix/capitalization-other-tel
...
fix(carddav): Make system contact phone number RFC compliant
2023-05-25 15:56:08 +07:00
Christoph Wurst
e524631ce3
fix(carddav): Don't show system address book cards to guests
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-25 12:26:26 +07:00
greta
50b61c8b7b
fix(carddav): Make system contact phone number RFC compliant
...
Signed-off-by: greta <gretadoci@gmail.com>
2023-05-25 11:10:25 +07:00
Christoph Wurst
5cfbd4c535
fix(carddav): Check enumeration settings for all SAB methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-25 09:11:26 +07:00
Johannes
7ec1ceb79a
Merge pull request #38413 from nextcloud/fix/38412/save-avatar-SAB
...
fix(SAB): Save avatar to SAB
2023-05-23 15:55:26 +07:00
Johannes Merkel
5983ef001d
fix(SAB): Save avatar to SAB
...
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2023-05-23 11:15:34 +07:00
Anna Larch
3c93ce9c25
fix(carddav): Check if SERVER variables are set before accessing them
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-05-23 10:58:29 +07:00
Thomas Citharel
13a3ebd4cc
feat(CardDAV): Add Sabre\DAV\IMoveTarget support to OCA\DAV\CardDAV\AddressBook
...
This allows to just UPDATE the card row instead of deleting it and reinsert it. It's very similar to https://github.com/nextcloud/server/pull/30120 for calendars.
As we need the addressbookid exposed, this introduces OCA\DAV\CardDAV\Card that extends Sabre's.
I chose specifically NOT to auto-inject LoggerInterface in Addressbook like in #30120 because the chain of DI is huge just for ONE simple call and it would break an existing dirty call (OCA\Contacts calling OCA\DAV) of ContactsManager in Contacts: https://github.com/nextcloud/contacts/pull/1722 (in SocialApiService), but this is debatable.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-05-16 11:38:57 +07:00
Simon L
25dd264965
Merge pull request #37965 from nextcloud/fix/transactional-system-addressbook-sync
...
fix(dav): Run system address book create-if-not-exists in transaction
2023-05-16 11:33:09 +07:00
Christoph Wurst
5d038a2dc1
fix(carddav): Mark system address book as read-only
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-15 10:27:53 +07:00
Christoph Wurst
2cc672d26b
fix(dav): Run system address book create-if-not-exists in transaction
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-12 14:15:02 +07:00
Christoph Wurst
1381c4c157
feat(users): Store and load a user's manager
...
Co-Authored-By: hamza221 <hamzamahjoubi221@gmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-12 13:56:48 +07:00
Anna Larch
5c2eb732f1
fix(carddav): expose system address book
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-05-11 18:59:30 +07:00
Anna Larch
bd80a1b2dd
feat(dav): store scopes for properties and filter locally scoped properties for federated address book sync
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-05-09 19:17:39 +07:00
Christoph Wurst
8c727f2285
feat(carddav): Map user's additional emails into the SAB card
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-04 15:03:01 +07:00
Johannes Merkel
ab76b086aa
enh(contacts): write profile prop and backend prop to system addressbook
...
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2023-05-02 16:31:11 +07:00
Thomas Citharel
ff3b69b21d
refactor(dav): Since we're in a transaction, use QB properly when incrementing synctoken
...
Now that we're in a transaction, we can reuse the sync token's previous value without trouble, and rewrite the increment UPDATE query without dirty direct SQL.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-04-17 16:08:44 +07:00
Thomas Citharel
c9a3129cb4
fix(CalDAV/CardDAV): put every method from Cal/CardDAV backends that does multiple DB calls in transactions
...
In a lot of methods we're doing read-after-writes (for instance calling
updateProperties after touching calendar objects).
There's also a lot of deleting methods that do stuff sequentially which
could cause trouble.
This should avoid this kind of issues.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-04-17 16:08:44 +07:00
jld3103
7e58aa1a05
Fix DAV types
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-05 07:06:50 +07:00
jld3103
02f9c3a06f
Use implementations instead of interfaces for accessing private methods
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-03-30 12:33:46 +07:00
Joas Schilling
1a31ddb56d
Do not reuse query builder objects in DAV account deletion
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-01 21:49:34 +07:00
Christopher Ng
e6f4705920
Revert "Fix sync errors for duplicate cards with the same UID for different backends"
...
This reverts commit ddcee3dbab .
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-01-13 02:11:09 +07:00
Anna Larch
ddcee3dbab
Fix sync errors for duplicate cards with the same UID for different backends
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2023-01-05 12:19:51 +07:00
Côme Chilliet
cbbb0712db
Merge pull request #34807 from nextcloud/fix/compute-notification-parsed-subject
...
Compute notification parsed subject from rich subject when possible
2022-12-19 10:46:39 +07:00
Côme Chilliet
d9151ff35c
Get rid of all useless calls to setParsedSubject now that setRichSubject is able to do it
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-29 14:36:29 +07:00
Carl Schwan
6828a3b28d
Cleanup contactsinteraction
...
- Add more typing and use PHP 7.4 typed properties
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-11-25 11:46:18 +07:00
Anna Larch
9dd51601c6
Switch to DisplayNameCache for CardDAV
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2022-11-03 10:26:34 +07:00
Thomas Citharel
6f15873321
Add a background job to prune outdated sync tokens
...
We remove all outdated sync tokens, based on their auto-incremented ID.
By default we only keep the last 10 000, but this can be configurable.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2022-10-27 20:12:13 +07:00
Christoph Wurst
19b7dad3dc
Wrap address book creation write-read in a transaction
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-10-03 17:48:52 +07:00
blizzz
e714524267
Merge pull request #33104 from nextcloud/enhancement/add-logging-federation
...
Federation - add logging, update the server status if sync fails
2022-10-01 21:53:55 +07:00
blizzz
132f842f80
Merge pull request #33450 from sazanof/bug/base64-card-dav-search
...
Fix photo url generation (add URI type to VCard2Array)
2022-10-01 21:50:14 +07:00
Joas Schilling
d41841b4a7
Check address book URI length before creation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-26 13:58:18 +07:00
Joas Schilling
71065f5fd5
Merge pull request #33615 from nextcloud/perf/noid/user-displayname-cache-for-activity-providers
...
Use user name cache in activity providers
2022-08-19 12:28:44 +07:00
Joas Schilling
eab5189abb
Fix carddav activities
...
The settings where combined last minute but at the same time the activities
where not adjusted to map an existing setting so the filter was not possible
to even limit it to the types that the activities had.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-19 10:50:45 +07:00
Joas Schilling
7e11778190
Use user name cache in activity providers
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-08-19 10:48:32 +07:00