Commit Graph

1301 Commits (7db90efe3bb5383dcbce99e84c3b84ca4a33fcc0)

Author SHA1 Message Date
Robin Appelman 1871296041 fix: don't believe sftp when it tells us the mtime is less than we know it is
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 20:50:19 +07:00
Christian Becker c25c5bbc00
feat(S3): add SSE-C support in S3 External Storage
Just need to add the parameter and fix two calls. All other logic is already implemented and implicitly called through the S3ConnectionTrait

fixes #33283

Signed-off-by: Christian Becker <christian@dabecka.de>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-28 22:57:59 +07:00
Robin Appelman 4179abdb81
fix: detect deleted items as updated for smb storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-21 17:56:46 +07:00
Benjamin Gaussorgues 12452f7f22
fix(files_external): wrong type for external mount id
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-12-13 10:27:50 +07:00
Robin Appelman 0e10bb59a1
Merge pull request #49288 from nextcloud/smb-acl-fail-soft
fix: smb: don't fail hard if we can't load acls for a file
2024-12-04 18:22:09 +07:00
provokateurin 86eec60ebb
feat(files_external): Enable ownerless shares
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-12-04 09:38:05 +07:00
Alexander Piskun 1022c47d27
Merge branch 'master' into fix/external-storage-service-cast-id 2024-12-03 15:36:02 +07:00
Oleksander Piskun c284e49134 fix(external_storage): Cast id to int 2024-12-02 15:43:29 +07:00
Louis Chemineau a2f2f7ce93
feat: Use inline password confirmation in external storage settings
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-11-28 11:01:54 +07:00
Marcel Klehr 9c7fd29262 fix(external_storage): Cast id to int
follow up to #49218

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-11-25 09:42:53 +07:00
Robin Appelman cc39714fb5
fix: smb: don't fail hard if we can't load acls for a file
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-14 16:01:36 +07:00
skjnldsv 8b8e4763ed fix(files_external): cast storage id int
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-12 10:28:01 +07:00
John Molakvoæ d53fde8eef
Merge pull request #49015 from nextcloud/fix/openapi/array-syntax 2024-11-06 08:56:30 +07:00
provokateurin 77114fb327
fix(OpenAPI): Adjust array syntax to avoid ambiguities
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-05 09:58:11 +07:00
Maxence Lange 8360c57189 fix(files-external): set password as sensitive
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-10-31 09:41:20 +07:00
yemkareems 3b6a36fae6
fix: add PasswordConfirmationRequired to saveGlobalCredentials
Co-authored-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-30 10:54:49 +07:00
John Molakvoæ ed14f5fee2
Merge pull request #48788 from nextcloud/fix/788/add-password-required-to-external-storages 2024-10-29 11:33:47 +07:00
provokateurin 0de4843b73 refactor(Storage): Align all Storage constructors
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-23 13:24:18 +07:00
provokateurin e8426996f5
fix(psalm): Fix some newly detected issues
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +07:00
provokateurin 381077028a
refactor(apps): Use constructor property promotion when possible
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +07:00
yemkareems 08f3e44d4a
fix: cs fix namespace
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-18 14:34:39 +07:00
yemkareems 18c0c28bce
fix: add PasswordConfirmationRequired to the eternal storages mentioned in review
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-18 14:04:34 +07:00
Git'Fellow c254855222 chore(db): Correctly apply query types
fix: psalm

fix: error

fix: add batch

fix: fatal error

fix: add batch

chore: add batch

chore: add batch

fix: psalm

fix: typo

fix: psalm

fix: return bool

fix: revert Manager
2024-10-17 09:21:07 +07:00
yemkareems b86dc076b5
fix: add PasswordConfirmationRequired to update and delete method
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-16 16:49:13 +07:00
yemkareems d3f1b76ebb
fix: add PasswordConfirmationRequired to create user storages endpoint
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-16 16:49:06 +07:00
Côme Chilliet 1580c8612b
chore(apps): Apply new rector configuration to autouse classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 10:40:25 +07:00
Kate 614d8c23a0
Merge pull request #48494 from nextcloud/refactor/storage/strong-param-types 2024-10-08 15:20:17 +07:00
provokateurin 54ec472d9a
fix(BackgroundJobs): Adjust intervals and time sensitivities
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-08 11:26:53 +07:00
provokateurin 14e6734547
refactor(files_external): Add Storage parameter strong types
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-07 15:00:07 +07:00
Joas Schilling 4219969c96
fix: Ensure we only pass string to writeln()
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 12:11:38 +07:00
Joas Schilling c109ae9437
ci: Fix psalm by typing the QuestionHelper
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 12:11:27 +07:00
Robin Appelman 103b464eea fix: use nc's binary finding logic for smb
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-04 15:56:31 +07:00
Joas Schilling 96f77d7b99
fix(filesexternal): Remove unneeded 3rdparty library use
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-02 23:27:44 +07:00
Côme Chilliet 6ef05bafeb
fix: Fix test of IConstructableStorage implentation by storage classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-30 11:21:42 +07:00
provokateurin 1302b48ca2
fix(files_external): Fix all IStorage return types
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 17:29:48 +07:00
Louis c45ed55f95
Merge pull request #48359 from nextcloud/artonge/feat/compare_hashed_password_when_updating_global_cred_in_files_external
fix: Use placeholder for external storage password
2024-09-26 14:56:37 +07:00
Marcel Klehr c8a90e941a fix(files_external): Catch correct exception
SMB#getFileInfo used to throw an icewind/smb exception, but nowadays throws \OCP\Files\ForbiddenException. This fixes downstream methods to catch the new exception.

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-09-26 09:03:08 +07:00
Louis Chemineau 20eb464835
fix: Use hashed password in files_external settings
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-25 17:50:17 +07:00
Côme Chilliet 40b404c566
Merge pull request #48111 from nextcloud/fix/move-storage-constructor-to-specific-interface
fix: Move storage constructor to specific interface
2024-09-23 15:57:38 +07:00
Côme Chilliet 94b0a0e863 fix: Move storage constructor to specific interface
That allows Wrappers to use DI and not care about the constructor

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-23 09:46:44 +07:00
Côme Chilliet 1a4978c4ea
chore: Apply rector configuration to apps folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-20 17:51:00 +07:00
provokateurin 9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +07:00
Côme Chilliet 801733e523
fix: Remove OCP\Files\Storage interface deprecated since version 9
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:10:48 +07:00
Christoph Wurst 614f9ec0a2
refactor: Use the elvis operator
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 21:01:34 +07:00
Git'Fellow 07a6fd11d0
fix(files_external): Check key exists before accessing it
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-14 11:21:17 +07:00
John Molakvoæ (skjnldsv) 0f519f4856 fix(files_external): broken credentials dialog
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-13 14:32:07 +07:00
Josh 2480567005
Merge pull request #47526 from nextcloud/jtr/fix-ftp-custom-port-ui
fix(files_external): Handling in FTP UI for custom ports
2024-09-12 09:34:47 +07:00
Josh 56c744d263
Merge pull request #47527 from nextcloud/fix-sftp-custom-port-ui
fix(files_external): Handling in SFTP UI for custom ports
2024-09-12 09:34:32 +07:00
Daniel Calviño Sánchez bd4de5208d fix: Fix unmodified placeholder replacing the actual value when updating
When updating global storages and user storages a property is not
updated by "StoragesService::updateStorage()" if the value matches the
unmodified placeholder. However, userglobal storages are not updated
through the "StoragesService"; as only the authentication mechanism is
updated it is directly done with "saveBackendOptions()" in
"IUserProvided" or "UserGlobalAuth". Due to this the unmodified
placeholder value needs to be explicitly checked in those cases and
replaced by the actual value (note that in this case it is not possible
to just skip updating a specific property).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 09:46:17 +07:00
Josh Richards 2e73932c8e fix: custom port handling in UI for SFTP
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-08-27 09:01:12 +07:00