Commit Graph

32478 Commits (76d1b11bc97dc03300aeb6fe817e686e06328e48)

Author SHA1 Message Date
rakekniven e6bfd8f213 fix: Update AdminAI.vue
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-09-09 09:53:39 +07:00
rakekniven 784fc4aa3f chore(i18n): adapted lowercase
Reported at Transifex

Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-09-09 09:50:59 +07:00
Nextcloud bot a2cfcf3ca7
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-09 00:23:27 +07:00
Nextcloud bot 926bd29617
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-08 00:36:35 +07:00
Ferdinand Thiessen 46472d3f4c
Merge pull request #43281 from nextcloud/feature/minSupportDesktopVerMsg
enh: update desktop client unsupported version (403) error message
2024-09-07 16:24:27 +07:00
Ferdinand Thiessen fb28ba1b64
Merge pull request #47806 from nextcloud/chore/cleanup-public-share
chore(files_sharing): Do not use files source files but directly the library
2024-09-07 13:56:14 +07:00
Nextcloud bot 7a6191ebb9
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-07 00:36:58 +07:00
Ferdinand Thiessen 5fc715a9e2
fix: Adjust unit tests and protect against XSS
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 17:16:10 +07:00
Camila 0a72756d96
fix(dav): Update 403 error message
* The user should get a more friendly warning when their desktop client version is not supported anymore by the server.
  See #nextcloud/desktop/issues/6273
* Update BlockLegacyClientPluginTest to reflect the new 403 error message.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 17:15:45 +07:00
Ferdinand Thiessen f06fdb04a3
chore(files_sharing): Do not use files source files but directly the library
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 16:53:42 +07:00
Ferdinand Thiessen b7e2d5032f
fix(files): Fallback icons should fill the container
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 14:08:51 +07:00
Ferdinand Thiessen 4a90d5328c
test: Add end-to-end tests for new public share Vue UI
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +07:00
Ferdinand Thiessen be884eeaec
fix(files): "Edit locally" action should not be shown on public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +07:00
Ferdinand Thiessen 018af2a2fe
fix(files): Do not add click listener if there is no default action on public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +07:00
Ferdinand Thiessen cb4c569486
fix(files_sharing): Ensure sidebar share entry lists are labelled
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +07:00
Ferdinand Thiessen c9dc0afcb1
fix(files): "New folder" menu entry requires read permission
This will disable "New folder" menu entry for file-drop shares.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:48 +07:00
Ferdinand Thiessen 11fdf4e2a7
chore(files_sharing): Remove now unused legacy scripts
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
Ferdinand Thiessen 80033bde88
fix(files): Disable internal views on public shares
This is needed because some views have side effects, like `favorites` doing requests on registration time.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
Ferdinand Thiessen 1dafdce3e7
fix(files_sharing): Set file-request header for nextcloud/upload
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
Ferdinand Thiessen 3134053497
fix(files_sharing): Disable sharing status action for public shares
This is disabled to not leak personal information into the public

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
Ferdinand Thiessen 1d16bc47ff
fix(files_sharing): Handle download permission the same way for public and internal shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
Ferdinand Thiessen e93ceea804
fix(files): Do not allow copy action on public shares without `create` permission
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
Ferdinand Thiessen a84de3c755
feat(files): Allow to download files on public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
Ferdinand Thiessen ada6a61688
fix(files): Do not allow rename action on single-file-shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
Ferdinand Thiessen 563f8e7c5d
refactor(files_sharing): Make file structure more clear
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
Ferdinand Thiessen f0a765ee46
fix(files): Disable copy-move-action of single file shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
Ferdinand Thiessen f109c1a044
refactor(files): Make `RouterService` provide a protected getter for the router to allow injecting the `files_sharing` router
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
Ferdinand Thiessen 82a7a3971d
fix(files): Adjust files list for sharing permissions on public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
Ferdinand Thiessen 819f5cea9b
fix(files): Fix file previews for public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
Ferdinand Thiessen 767e87a466
fix(files): Do not use `favorite`, `sidebar` and `view-in-folder` action for public shares
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:47 +07:00
Ferdinand Thiessen 96c8275586
feat(files_sharing): Migrate public share to use Vue files list
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 03:38:42 +07:00
Nextcloud bot e4fa996701
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-06 00:25:10 +07:00
Anna Larch 8af7ecb257 chore: adjust code to adhere to coding standard
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-05 21:23:38 +07:00
Louis 4566cf791d
Merge pull request #47770 from nextcloud/artonge/fix/always_respond_custom_error_page_on_exceptions
fix(dav): Always respond custom error page on exceptions
2024-09-05 20:13:45 +07:00
Stephan Orbaugh 3f79566974
Merge pull request #47519 from nextcloud/fix/transfer-ownership-encrypted-files
feat(transfer-ownership): Correctly react to encrypted files
2024-09-05 17:58:44 +07:00
Louis Chemineau 9992e7d439
fix(dav): Always respond custom error page on exceptions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-05 16:17:32 +07:00
Côme Chilliet 0555900134 fix(transfer-ownership): Improve comments according to code review
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 14:44:50 +07:00
Côme Chilliet d92bf388b1 feat(transfer-ownership): Correctly react to encrypted files
For E2EE encrypted files, we abort the transfer.
For SSE encrypted files, we abort only if not using master key.
Also fixed the check for when the path to a single file is used.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 14:44:50 +07:00
Côme Chilliet c224b8ced4
fix(setupchecks): Test overwrite.cli url first, then generated one, and
trusted domains as last fallback.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 11:54:45 +07:00
Daniel Kesselberg 4ce4d7b9b3
fix: add option to remove the webroot for setup checks and don't check trusted_domains.
1) The checks for well-known urls should always run against the root domain and therefore the option to remove the webroot.

2) For trusted domains, the available protocol is unknown, and thus some guesswork would be needed to make that work. I've decided for now to not consider them anymore to reduce false-positives.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-05 10:30:36 +07:00
Nextcloud bot 8cded1e320
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2024-09-05 00:23:50 +07:00
skjnldsv 1ece5b975d fix(files): undefined displayname for outdated `@nextcloud/files`<3.6.0 apps
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-04 18:12:34 +07:00
skjnldsv 62878c5ece fix(files): undefined sidebar
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-09-04 14:10:37 +07:00
Daniel Calviño Sánchez fa0862c656 fix: Hide status tooltip in row to add a new mount point
The row to add a new mount point is cloned when a new mountpoint is
added, so it is expected that it includes a status span. However, it
should not be displayed in that row, only in the cloned row when its
status is updated.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 09:46:17 +07:00
Daniel Calviño Sánchez bd4de5208d fix: Fix unmodified placeholder replacing the actual value when updating
When updating global storages and user storages a property is not
updated by "StoragesService::updateStorage()" if the value matches the
unmodified placeholder. However, userglobal storages are not updated
through the "StoragesService"; as only the authentication mechanism is
updated it is directly done with "saveBackendOptions()" in
"IUserProvided" or "UserGlobalAuth". Due to this the unmodified
placeholder value needs to be explicitly checked in those cases and
replaced by the actual value (note that in this case it is not possible
to just skip updating a specific property).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 09:46:17 +07:00
Daniel Calviño Sánchez 8e5dba2be0 fix: Reset selected backend when adding a new storage
As a new storage is added by selecting a backend the selected backend
needs to be reset. Otherwise it is not possible to add another storage
with the same backend.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 09:46:17 +07:00
Daniel Calviño Sánchez baaed7f191 fix: Add missing translation for UI string
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 09:46:17 +07:00
Daniel Calviño Sánchez 26919835e7 fix: Restore default status tooltip when no status message is provided
If the status is updated but no explicit message is provided (for
example, if the status check succeeded) the default tooltip (from the
template) is now set to prevent a mismatch between the status and the
tooltip (for example, if the configuration is fixed after a failed
status check).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 09:46:17 +07:00
Daniel Calviño Sánchez ac1c8c4237 fix: Set status tooltip to error message on failed actions
When saving, updating and rechecking an storage fails (which is
different to the soft-fail when the action itself succeeds but the
status check does not) further details are provided in the error message
of the response, which is now set as the tooltip.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 09:46:17 +07:00
Daniel Calviño Sánchez 9eeb3cf423 fix: Set status tooltip to status message when saving an storage
When a storage is saved the status check can fail even if saving the
storage succeeds. In those cases further details are provided in the
status message of the storage, which is now set as the tooltip,
similarly to how it is done when rechecking the storage.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 09:46:17 +07:00