Christoph Wurst
614f9ec0a2
refactor: Use the elvis operator
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 21:01:34 +07:00
Kate
3fe3f8d1f6
Merge pull request #48016 from nextcloud/fix/s3configtrait/proxy-false
2024-09-15 19:16:04 +07:00
Kate
101891280b
Merge pull request #48013 from nextcloud/fix/baseresponse/xml-element-value-string-cast
2024-09-15 19:15:46 +07:00
Kate
77de180faa
Merge pull request #48014 from nextcloud/fix/tags/boolean-user-has-tags
2024-09-15 17:48:27 +07:00
Kate
a643cb22b2
Merge pull request #48017 from nextcloud/fix/comment/children-count-integer
2024-09-15 17:48:11 +07:00
provokateurin
9a63494fe4
fix(Comment): Initialize childrenCount as integer
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 15:44:37 +07:00
provokateurin
7c1c02d6a5
fix(S3ConfigTrait): Allow proxy field to take false
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 15:41:58 +07:00
provokateurin
5bbe535c27
fix(Storage\Local): Do not call getSourcePath() on SplFileInfo
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 15:39:09 +07:00
provokateurin
3d9b49815b
fix(BaseResponse): Cast XML element values to string
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 15:37:27 +07:00
provokateurin
9b82bfd3c3
fix(Tags): Return boolean for userHasTags()
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 15:33:46 +07:00
Côme Chilliet
6c46c43429
Merge pull request #47971 from nextcloud/fix/do-not-try-to-change-response-code-too-late
...
fix: Do not try to set HTTP response code on already closed connection
2024-09-14 21:18:47 +07:00
Ferdinand Thiessen
81df2d2c12
feat(PsrLoggerAdapter): Allow to use `Psr\Log\LogLevel` for `log` method
...
There is the `Psr\Log\LogLevel` class defining loglevel constants,
to be fully compatible we should at least support those logging levels.
Moreover this is the last part that was still required from `ILogger` interface,
as we did not have alternatives for the loglevel constants.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-14 17:35:11 +07:00
Côme Chilliet
e54eef5ae3
fix: Do not try to set HTTP response code on already closed connection
...
This avoids a PHP warning in the logs about trying to set the response
code while the output already started. It’s useless to try to print an
error page anyway in this situation because the connection was closed
already.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-14 14:20:49 +07:00
provokateurin
714671a8a6
fix(files): Adjust Cache::searchQuery() parameter name to match interface
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-13 18:13:44 +07:00
Côme Chilliet
bcb4e781a4
Merge pull request #47927 from nextcloud/fix/migrate-away-from-oc_app
...
Migrate away from OC_App to IAppManager
2024-09-13 17:44:38 +07:00
Côme Chilliet
dfa994ef28
Merge pull request #47865 from nextcloud/admin_audit/enh/move-to-event-listeners-v2
...
Move admin_audit to proper event listeners v2
2024-09-13 16:21:44 +07:00
Ferdinand Thiessen
a90f0a6b36
Merge pull request #47883 from nextcloud/fix/setup-checks
...
fix(setup-checks): Ensure URL with webroot works
2024-09-13 13:42:41 +07:00
Joas Schilling
df155fa3df
Merge pull request #47933 from nextcloud/bugfix/noid/throw-precondition-failure-when-not-matching
...
fix(config): Throw PreconditionException always when it didn't match
2024-09-13 13:39:21 +07:00
Ferdinand Thiessen
9e979d42b4
fix(setup-checks): Ensure URL with webroot works
...
We basically mock the way `URLGenerator::getAbsoluteURL` works,
so we must make sure that the URL might already contain the webroot.
Because `baseURL` and `cliURL` also contain the webroot we need to remove
the webroot from the URL first.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-13 13:06:24 +07:00
Git'Fellow
413ba1a718
Merge pull request #47854 from nextcloud/validAppsFromAppStore
...
fix(appstore): Ensure returned apps from AppStore are valid
2024-09-13 10:55:33 +07:00
Côme Chilliet
76f2bc0bfc
fix: Replace OC_App::getAllApps with a method in AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:08:44 +07:00
Côme Chilliet
7ed583cb8e
chore: Migrate cleanAppId and getAppPath calls to IAppManager from OC_App
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:08:43 +07:00
Git'Fellow
dccfb6d68a
fix: check if key is set
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-13 09:49:09 +07:00
Joas Schilling
dcd97e1234
fix(config): Throw PreconditionException always when it didn't match
...
Previously even when the precondition did not match, the call "passed"
when the after value was the expected one. This however can lead to
race conditions, duplicate code excutions and other things.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-13 09:20:08 +07:00
Côme Chilliet
b6c286640f
Merge pull request #47685 from nextcloud/fix/move-apihelper-to-oc-namespace
...
fix: Move OC_API into \OC\ApiHelper in standard namespace
2024-09-12 14:34:07 +07:00
Julius Knorr
38e0a89972
fix: Add whiteboard to education and public sector bundle
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-12 09:13:42 +07:00
Ferdinand Thiessen
5fc514877b
Merge pull request #47586 from nextcloud/fix/color
...
fix(theming): Add migration to restore primary color after separating primary and background
2024-09-11 15:10:09 +07:00
Git'Fellow
8585b05357
fix(appstore): Ensure returned apps from AppStore are valid
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: lint
chore: remove space
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: check if response array is null
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
chore: Add log
2024-09-11 11:12:59 +07:00
Ferdinand Thiessen
027fc052e7
fix: Adjust types of IQueryBuilder to properly allow joining with sub-query
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-10 17:51:27 +07:00
Ferdinand Thiessen
c7d9068be9
chore: Use `IAppConfig` instead of `IConfig->getAppValue`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-10 17:51:26 +07:00
Kate
979cc8712c
Merge pull request #47662 from nextcloud/fix/notification/validate-rich-object-key-value-types
2024-09-10 17:40:46 +07:00
Robin Appelman
a7eaed721c
Merge pull request #47853 from nextcloud/clearify-swift-exception
...
fix: make swift connect exception message more informative
2024-09-10 16:45:19 +07:00
provokateurin
a3da7456a7
fix(Activity): Restrict IEvent rich object parameters type
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-10 16:37:54 +07:00
provokateurin
d0a827a684
fix(RichObjectStrings/Validator): Validate key value types of rich object parameters
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-10 16:36:33 +07:00
John Molakvoæ
0858ff7a07
Merge pull request #47834 from nextcloud/retAppsManDis
2024-09-10 16:31:17 +07:00
John Molakvoæ
4d3168fb24
fix(appstore): disabled appstore log level bump from debug to info
...
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-09-10 16:00:56 +07:00
Thomas Citharel
82ba7d763b
chore: Code cleanup in lib/private/Console/Application
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-09-10 14:05:59 +07:00
Thomas Citharel
c2150bd079
feat: Add mimetype into BeforePreviewFetchedEvent event
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-09-10 14:05:06 +07:00
Richard Steinmetz
12ea0eb24a
Merge pull request #47858 from nextcloud/fix/preview/handle-no-local-file
...
fix(preview): gracefully handle file not being opened in ProviderV2
2024-09-10 13:24:44 +07:00
Julius Knorr
46a4a16eb6
fix: Only write once to template instead of create/copy
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-10 09:43:42 +07:00
Richard Steinmetz
bcf9f91893
fix(preview): gracefully handle file not being opened in ProviderV2
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-09-10 08:49:43 +07:00
Robin Appelman
508d8e7c01
fix: make swift connect exception message more informative
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-09 17:15:01 +07:00
provokateurin
d5e98cd190
fix(NavigationManager): Skip invalid default navigation entries
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +07:00
provokateurin
669641142b
fix(TemplateLayout): Use NavigationManager to get default app name
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +07:00
provokateurin
01ec6762a2
fix(URLGenerator): Use NavigationManager to generate default page URL
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +07:00
provokateurin
70ed08daf1
refactor(AppManager): Deprecated default apps handling
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +07:00
provokateurin
b0baaaed9d
feat(NavigationManager): Add default entries handling
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +07:00
Côme Chilliet
90a948506b
chore: Make parameter name more explicit
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 10:46:29 +07:00
Côme Chilliet
42c5a60c29
fix: Force 503 HTTP status code for maintenance mode on v1
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 10:46:29 +07:00
Côme Chilliet
76d1b11bc9
chore: Deleted now unused classes from \OC\OCS
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 10:46:29 +07:00