6336eac6a5
chore: setting test metadata in annotations is deprecated (use attributes)
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-11-05 15:42:40 +07:00
d6d6747a73
refactor: apply rector rules for PHPUnit 10
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-10-27 21:56:04 +07:00
4275825177
chore(tests): make "execute" method in Add command public
...
to simplify test execution
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
2025-10-20 12:55:17 +07:00
b0413be681
chore(tests): add unit tests for AdminDelegation command and AuthorizedGroupService
...
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
2025-10-20 12:55:17 +07:00
62fd3576c9
test(settings): Add tests for TaskProcessingSuccessRate setup check
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-10-13 14:42:51 +07:00
ac61839d1e
fix(tests): Fix PHPUnit deprecation warnings in tests
...
Turn data providers into static methods, mostly.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-09-27 13:05:32 +07:00
79184f3aed
feat(settings): migrate setup checks to Vue to prevent visual issues
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-08-26 18:35:55 +07:00
6076b67696
feat(preset): share link expiration date
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-08-14 16:07:32 +07:00
cb84ccc57d
feat(preset): share password protection
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-08-12 14:37:32 +07:00
aa227f1c55
feat: add bluesky to accounts, show the same in profile edit and visibility option, in view profile and also in sharing tab
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2025-08-08 08:06:45 +07:00
8b7aad82c7
fix: Fix button alignment for email templates in Outlook
...
The button group generated in email templates is expected to show the
two buttons side by side in a single row, but in Outlook both buttons
took the full width of the wrapper row and each button was shown in
its own row. To solve that the buttons are wrapped in an additional
table that shows each button in its own cell, limiting their width and
showing them in a single row; this is done conditionally and only
applied in Outlook, so it should not affect other clients.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2025-08-06 15:18:01 +07:00
a18e61a1e5
feat(files_sharing): add config option for extending link-share permissions
...
This allows the admin to control the behavior whether link shares with
READ permissions should be extended to also gain SHARE permissions,
allowing users (public share receivers) to add the share to their cloud.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-07-17 16:59:36 +07:00
9913bdda90
chore: Cleanup DIContainer class
...
Also removed deprecated tag from the class as this class will not be
removed, only the interface IAppContainer and associated methods should
be removed.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-08 13:32:12 +07:00
aa15f9d16d
chore: run rector
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-07-01 22:45:52 +07:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +07:00
2b58f74cc8
Fix: Remove X-XSS-Protection use, check and recommendation
...
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: invario <67800603+invario@users.noreply.github.com>
2025-06-13 16:12:27 +07:00
f8f26952d1
feat(SetupChecks): Add check for TaskProcessing pickup speed
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-05-22 12:50:00 +07:00
460d3e8ba9
test: Migrate settings and provisioning_api to PHPUnit10
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-16 23:10:14 +07:00
8f8c11ad4e
fix(mail): use matching text color for primary elements
...
when we use the default primary as background color we have to use the
default primary text color as well.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-17 11:51:46 +07:00
4c0c88a0d5
fix(systemtags): prevent tag edition if restricted
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-06 11:57:22 +07:00
f91db181af
feat(setupcheck): check logging level for validity
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-22 14:08:19 +07:00
082e85f6da
Merge pull request #50779 from nextcloud/chore/mailer-tests
...
test(Mailer): Align tests for mailer with stable30
2025-02-18 17:52:12 +07:00
17fffdbbcb
fix(settings): Inject subadmin manager and adapt tests, resolve a FIXME comment
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 12:48:12 +07:00
64863c9d46
chore: Apply new rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:46:42 +07:00
ed5b7ae161
chore: re-apply current rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 11:45:33 +07:00
84293441e8
test(Mailer): Align tests for mailer with stable30
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-12 13:29:58 +07:00
fbef47a5d7
fix(AccountManager): Sanitize social media handles
...
Ensure to only accept valid X and fediverse handles.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 11:58:24 +07:00
b4e3eff078
feat(systemtags): add setting to block non admin to create system tags
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-01-22 20:07:24 +07:00
98275fb806
refactor(settings): Use parameters explicitly when setting mail settings
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-06 08:40:52 +07:00
9e327a5890
fix(apps-store): Remove apps from force-enabled state when uninstalled
...
If an app is force-enabled and then uninstalled the force-enabled state was kept.
This is now removed, so when the app should be re-installed the compatibility should be reevaluated.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-18 14:09:54 +07:00
6d2c63ecff
fix(settings): Do not use `null` on `string` parameter for sharing disclaimer
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 20:12:32 +07:00
bb598c8451
chore(deps): Bump nextcloud/coding-standard in /vendor-bin/cs-fixer
...
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard ) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/nextcloud/coding-standard/releases )
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/coding-standard/compare/v1.3.1...v1.3.2 )
---
updated-dependencies:
- dependency-name: nextcloud/coding-standard
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-19 07:57:35 +07:00
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 10:40:25 +07:00
b5256181a4
fix(settings): Sort all settings - incl declarative settings - by priority
...
Previously declarative settings were sorted by priority but behind the "native" settings,
this is now fixed, meaning a declarative setting with higher priority than an `ISetting` will
be correctly rendered before that `ISetting` in the settings list.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 14:08:26 +07:00
096f893d46
fix(activity): Update more activity providers to use new exceptions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-23 12:31:59 +07:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +07:00
8fb64b886a
fix(settings): pronouns UsersControllerTest
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-18 13:30:33 +07:00
ede0c26b78
Merge pull request #46480 from nextcloud/fix/mailer-binaryfinder-fallback
...
fix(Mailer): Fix sendmail binary fallback
2024-09-16 18:18:14 +07:00
87aa1267a8
fix(Mailer): Fix sendmail binary fallback
...
feat: add debug logging to sendmail binary finder
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-09-16 15:20:29 +07:00
7fbd518452
feat: Make `CheckServerResponseTrait` public and provide as `OCP\SetupCheck\CheckServerResponseTrait`
...
This trait is used by other apps for creating setup checks,
so we should provide it instead apps using private API.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-16 14:58:21 +07:00
49dd79eabb
refactor: Add void return type to PHPUnit test methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 22:32:31 +07:00
be1cd7a308
refactor(settings): `CheckServerResponseTrait` always expect absolute path
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-13 13:09:40 +07:00
9e979d42b4
fix(setup-checks): Ensure URL with webroot works
...
We basically mock the way `URLGenerator::getAbsoluteURL` works,
so we must make sure that the URL might already contain the webroot.
Because `baseURL` and `cliURL` also contain the webroot we need to remove
the webroot from the URL first.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-13 13:06:24 +07:00
c88ae37844
fix(settings): Fix sharing exclude groups from password requirement option not working
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-03 14:28:44 +07:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +07:00
0563757ea4
fix(SetupCheck): Properly check public access to data directory
...
When checking for public (web) access to the data directory the status is not enough
as you might have a webserver that forwards to e.g. a login page.
So instead check that the content of the file matches.
For this the `.ncdata` file (renamed from `.ocdata`¹) has minimal text content
to allow checking.
¹The file was renamed from the legacy `.ocdata`, there is a repair step to remove the old one.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 22:08:42 +07:00
879d248c55
fix: emails tests after new design fixes
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-06 09:42:19 +07:00
26beedef36
test(users): Adapt tests to new admin delegation checks
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-22 19:58:44 +07:00
829f2b9bc7
fix(db): Promote the use of `getDatabaseProvider` to reduce the impage of removed upstream platforms
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:14 +07:00
693a81bfa3
fix(mail): Fix big logos in mail templates for Outlook
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-17 09:24:55 +07:00
Ferdinand Thiessen
Misha M.-Kupriyanov
Marcel Klehr
Côme Chilliet
Maxence Lange
yemkareems
Daniel Calviño Sánchez
Robin Appelman
invario
Joas Schilling
skjnldsv
Josh
Benjamin Gaussorgues
provokateurin
dependabot[bot]
Christoph Wurst
Daniel Kesselberg
Louis Chemineau