Commit Graph

5348 Commits (5bf34979feb5b1f5b8bd4e2c0d002f8aaf8794e1)

Author SHA1 Message Date
Daniel Kesselberg 06248cda0a chore: update expected timezone from GMT+0 to UTC
Punic 3.2.0 added support for timezone translations and returns UTC instead of GMT+0 now.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-07-27 13:57:02 +07:00
Joas Schilling c67c067ee7
fix: Move Sharing events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:53 +07:00
Joas Schilling 44a0a62107
fix: Move Node HookConnecter events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:53 +07:00
Joas Schilling 6953e14580
fix: Move SystemTags events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +07:00
Joas Schilling dac31ad101
fix!: Remove legacy event dispatching Symfony's GenericEvent from 2FA Manager
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +07:00
Joas Schilling 1b387bb341
fix!: Remove legacy event dispatching Symfony's GenericEvent from AdditionalScripts
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:52 +07:00
Joas Schilling 5bb6a7804f
fix: Move AppManager events to IEventDispatcher
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:51 +07:00
Joas Schilling 4f7de8ed60
fix!: Remove legacy event dispatching Symfony's GenericEvent
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-27 09:57:51 +07:00
Joas Schilling 7548e62181
Merge pull request #39506 from nextcloud/techdebt/39488/ensure-index-name-uniqueness
feat(db): Ensure that index names are unique across the database
2023-07-24 14:44:37 +07:00
Joas Schilling b80692d323
fix(tests): Adjust unit tests to outline the schema is checked twice now
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-21 12:17:36 +07:00
Marcel Klehr 7c80d66ee5
Merge pull request #38854 from nextcloud/enh/llm-api 2023-07-21 11:20:31 +07:00
Benjamin Gaussorgues e9b8a34cce
Merge pull request #39264 from nextcloud/feat/add-instance-category
Add instance category while checking new updates
2023-07-21 11:04:32 +07:00
Benjamin Gaussorgues 31f1354777
Add instance category while checking new updates
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-07-18 15:39:23 +07:00
Ferdinand Thiessen 3b057600d0 fix: Correctly add `module` content type to script tags when scripts with versions are used
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-07-18 13:10:37 +07:00
Marcel Klehr ffe27ce14c Massive refactoring: Turn LanguageModel OCP API into TextProcessing API
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-14 16:00:31 +07:00
Joas Schilling 2c6f32cb28
feat(request): Allow to match the client version with the IRequest::USER_AGENT_* regex
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-11 07:35:50 +07:00
Marcel Klehr bf2dcd67f3 LLM OCP API: Change Tests to use EventDispatcher mock
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr d56286b8ac LLM OCP API: s/getAvailableTasks/getAvailableTaskClasses/
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr c568c4a464 Add test for task cleanup
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr 20cb9935ca Fix tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Marcel Klehr ebc7631544 Add preliminary tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-07-07 13:39:10 +07:00
Joas Schilling 05aa39d777
Fix event names of 2FA related typed events
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-03 14:25:01 +07:00
jld3103 b0001c6010
Add template types to responses
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-06-30 09:33:29 +07:00
Joas Schilling ec6728d710
feat(HTTPClient): Provide wrapped access to Guzzle's asyncRequest()
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-27 15:53:57 +07:00
Daniel 9751303182
Merge pull request #38679 from nextcloud/feat/add-spec-to-preview-fetched-event
feat: add width, height, crop and mode to BeforePreviewFetchedEvent
2023-06-26 13:53:27 +07:00
Simon L f7183c9dcf
Merge pull request #38958 from nextcloud/enh/noid/use-getsystemvalue-mailer
use getsystemvalue-functions in Mailer.php
2023-06-26 10:23:29 +07:00
Arthur Schiwon 17515995fa
Merge pull request #38625 from nextcloud/fix/noid/querysearchehelper-narrow-type
fix: expect interface, not a specific implementation
2023-06-24 00:13:43 +07:00
Simon L 1cb81ae625 try to fix tests
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-06-23 17:12:45 +07:00
Daniel Kesselberg 440f882322
feat: add width, height, crop and mode to BeforePreviewFetchedEvent
user_usage_report keeps a counter for files read.

The app uses

- OC_Filesystem::read hook
- Event listener (the legacy one) for IPreview::EVENT

Request for previews do not trigger the hook, hence the additional event listener.
The thumbnails for a list or grid view should not count, so we need the width and height.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-23 16:27:35 +07:00
Arthur Schiwon f6ac874dbf
chore: ugly type juggling
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-06-21 16:53:20 +07:00
Joas Schilling ab8205fd35
fix(l10n): Fix plural issue with different locale and language
We need to use the language code here instead of the locale,
because Symfony does not distinguish between the two and would
otherwise e.g. with locale "Czech" and language "German" try to
pick a non-existing plural rule, because Czech has 4 plural forms
and German only 2.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-21 07:14:56 +07:00
jld3103 7f4651637a
Allow stdClass in XML responses
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-06-13 11:44:47 +07:00
Christoph Wurst 08a3f37695
chore(appframework)!: Drop \OCP\AppFramework\Http\EmptyContentSecurityPolicy::allowInlineScript
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-12 10:03:59 +07:00
Arthur Schiwon ffa30ce89b
Merge pull request #38524 from nextcloud/chore/app/clear-unused-cache-key
chore(app): Do not clear unused cache key
2023-06-05 17:48:44 +07:00
Daniel Kesselberg a2afc7b6a9
refactor: migrate OC_EventSource to dependency injection
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-03 21:42:51 +07:00
Joas Schilling 6d076c1ee9
fix(dispatcher): Migrate to OCP event dispatcher before symfony/event-dispatcher upgrade
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-06-02 08:08:24 +07:00
Christoph Wurst e76d525a43
chore: Drop \OC_App::getAppInfo
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:27 +07:00
Christoph Wurst cf6e2fa1b7
chore: Drop \OC_App::getAppVersion
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-06-01 11:31:26 +07:00
Christoph Wurst 3d1acca1f3
chore(app): Do not clear unused cache key
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-05-30 17:48:20 +07:00
Simon L 3d2d1c171e
Merge pull request #37758 from nextcloud/redis-atomic
redis: use atomic operations everywhere
2023-05-19 23:29:24 +07:00
Simon L 48521d67e1
Merge pull request #38143 from nextcloud/fix/generated-avatars-cache
Fix generated avatars cache
2023-05-16 11:37:49 +07:00
jld3103 2a19753cf7
Clear generated avatar caches
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-05-15 18:18:21 +07:00
Joas Schilling 3a6bc7aba2
fix(middleware): Also abort the request when reaching max delay in afterController
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:20:19 +07:00
Ferdinand Thiessen 31c01fa3da fix(JSResourceLocator): Handle missing translations silently
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2023-05-11 18:22:24 +07:00
John Molakvoæ db02684008
Merge pull request #37691 from nextcloud/object-store-background-scan 2023-05-11 08:15:41 +07:00
Varun Patil c6cee282b3 redis: move lua scripts to class and add type hints
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-05-10 17:37:02 +07:00
Robin Appelman 2ea41dab93
repair -1 folder sizes for object store background scan
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-10 19:33:26 +07:00
Robin Appelman 904fdf3aa3
Merge pull request #37838 from nextcloud/event-logger-http
log performance events for http requests
2023-05-09 17:15:27 +07:00
Joas Schilling b91957e3df
fix(dav): Abort requests with 429 instead of waiting
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-03 22:43:36 +07:00
Arthur Schiwon 7fcf42ad3f
Merge pull request #38024 from nextcloud/fix/fix-32bits-ci
Fix 32bits ci
2023-05-03 10:34:04 +07:00
Arthur Schiwon ef87dfc478
Merge pull request #33106 from nextcloud/feature/update-expire-date
Update expire_date column of table comments
2023-05-03 10:26:28 +07:00
Côme Chilliet e252182d80
Put back file cleanups, and remove dead code in tests/lib/Template/JSResourceLocatorTest.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-02 16:24:28 +07:00
Côme Chilliet adf743b141
Remove the array_pop failing tests on 32bit CI
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-02 16:09:37 +07:00
Côme Chilliet 10296ba7e5
Fix tests, and fix Group::searchUsers to avoid duplicates
Also went back to searchUsers indexing the array by uid as it was the
 previous behavior and the IGroup phpdoc does not say anything about the
 keys.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-05-02 11:35:41 +07:00
Robin Appelman e7ab30f5d8
log performance events for http requests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-28 15:37:57 +07:00
Côme Chilliet b6c17c6ce7
Clear up return types
usersInGroup index by int for BC, searchInGroup index by uid (string).

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-27 12:00:45 +07:00
Carl Schwan 35dc223500
Optimize retrieving display name when searching for users in a group
This is recurrent scenario that we are searching for users and then for
each users we fetch the displayName. This is inefficient, so instead try
to do one query to fetch everything (e.g. Database backend) or use the
already existing DisplayNameCache helper.

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2023-04-27 11:57:45 +07:00
Vitor Mattos 5ed6722dd2 Cover expire_date with unit tests
Signed-off-by: Vitor Mattos <vitor@php.rio>
2023-04-26 13:21:08 +07:00
Joas Schilling 75f17b6094
Merge pull request #37905 from nextcloud/techdebt/noid/add-attributes-for-remaining-security-annotations
feat(security): Add PHP \Attribute for remaining security annotations
2023-04-25 17:13:53 +07:00
Joas Schilling ecb8b55c5c
feat(security): Add PHP \Attribute for remaining security annotations
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-25 14:50:32 +07:00
Côme Chilliet 7250f54ca3
Merge pull request #37835 from nextcloud/feat/background-allow-parallel-runs
feat(BackgroundJobs): Allow preventing parallel runs for a job class
2023-04-25 12:10:43 +07:00
Marcel Klehr 06d6cf4ebc JobListTest: Fix JobList constructor call
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-24 19:07:13 +07:00
Marcel Klehr 6148c5e0a1
Update tests/lib/BackgroundJob/DummyJobList.php
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-24 12:35:52 +07:00
Joas Schilling 89c3c31402
feat(ratelimit): Add Attributes support to rate limit middleware
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-24 12:24:48 +07:00
Marcel Klehr a0c722ad69 Run cs:Fix
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Marcel Klehr 5608b50778 Fix BackgroundJob tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Marcel Klehr 281c8047b6 JobListTest: clearJobsList before testHasReservedJobs
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Marcel Klehr 56cb5d1d13 fix(tests): Remove duplicated method
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Marcel Klehr 1296f3612e test(BackgroundJobs): Add tests for allowParallelRuns and hasReservedJobs
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2023-04-23 12:36:12 +07:00
Côme Chilliet b294edad80
Merge branch 'master' into enh/type-iconfig-getter-calls
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2023-04-20 16:52:38 +07:00
Christoph Wurst 2c0cfd3772
feat(app-framework): Add native argument types for middleware
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-04-18 17:15:05 +07:00
Simon L 8fe22ebf60
Merge pull request #36617 from nextcloud/update/psr-container
chore: Update PSR container to 2.0.2
2023-04-18 11:40:12 +07:00
Julius Härtl d9c81f56ad tests: Adapt node related unit tests mocks to required root view
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-17 23:46:52 +07:00
Julius Härtl 160bd75d0a fix: Use proper path when creating node instances
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-04-17 23:46:52 +07:00
Ferdinand Thiessen dc9d8c42bb fix: Adjust console formatter code to match with Symfony type hints
Symfony has added type hints on the `OutputFormatterInterface`,
so we must adjust our type hints to match with Symfony.

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-04-17 18:35:10 +07:00
Glandos 384a1d34a8 adapt test to new workflow
getDirectoryListing should return all files
getFile is not called anymore

Signed-off-by: Glandos <bugs-github@antipoul.fr>
2023-04-17 16:29:13 +07:00
Robin Appelman 0375c9866c
add test to verify redis lua script hashes
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-04-17 16:18:48 +07:00
jld3103 b153340b62
Add type hints for mappers
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-07 09:49:42 +07:00
Côme Chilliet 8d5165e8dc
Adapt tests to config value typing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-05 17:42:14 +07:00
Côme Chilliet 8f550398c4
Merge pull request #36836 from nextcloud/fix/view-type-cleanup
Tidy up typing in OC\Files\View
2023-04-05 10:14:55 +07:00
jld3103 d9f8522003
Fix types for reading and writing config values
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-04-05 09:08:56 +07:00
Joas Schilling 131f481a67
fix(initial-state): Log an error when initial-state can not be JSON encoded
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-04 10:54:12 +07:00
Louis 7ab44b2d28
Merge pull request #37146 from nextcloud/artonge/feat/migrate_metadata_to_value
Migrate metadata JSON column to new value TEXT column
2023-04-04 10:23:54 +07:00
Joas Schilling c5339fa336
Merge pull request #37542 from nextcloud/bugfix/noid/allow-to-opt-out-of-ratelimit-for-testing
feat(security): Allow to opt-out of ratelimit protection, e.g. for te…
2023-04-03 14:19:41 +07:00
Louis Chemineau 1a6709cf43 Migrate metadata as JSON to value as STRING
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-04-03 14:06:28 +07:00
Côme Chilliet 4393b96542
Remove unused method getLocalFolder
It’s not used and not in any OCP interface/class.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:34 +07:00
Côme Chilliet 966a3e6963
Tidy up typing in OC\Files\View
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-04-03 10:52:33 +07:00
Joas Schilling 454281af03
feat(security): Allow to opt-out of ratelimit protection, e.g. for testing on CI
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-04-03 09:06:45 +07:00
Arthur Schiwon 997c2a2a79
fix DBAL exception handling in setValues
This seems to be a left over after abstracting DBAL. Nowadays,
IQueryBuilder::executeStatement() only throws a \OCP\DB\Exception, where
previously original DBAL exceptions where thrown. These are now wrapped,
the orignal classes are now mapped to a reason.

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2023-03-31 17:01:17 +07:00
Christopher Ng 4f8e916585 Add label for logo link
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2023-03-29 13:36:45 +07:00
Julius Härtl 8b4d49cf50
Merge pull request #36057 from nextcloud/feat/esm-js-scripts 2023-03-22 09:17:28 +07:00
Côme Chilliet 633ea018af
Fix BackgroundCleanupJobTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-20 10:21:44 +07:00
Joas Schilling bfc37afed3
Merge pull request #36928 from nextcloud/techdebt/noid/bruteforce-protection-attribute
feat(middleware): Migrate BruteForceProtection annotation to PHP Attribute and allow multiple
2023-03-16 19:33:13 +07:00
Arthur Schiwon a30d7c51d3
Merge pull request #37227 from nextcloud/h1-dav-brute-force-protection
chore: use local variable for remote address
2023-03-15 15:11:53 +07:00
Artur Neumann 37cfccabc1
unit tests for Manager::invalidateTokensOfUser
Signed-off-by: Artur Neumann <artur@jankaritech.com>
2023-03-14 17:13:30 +07:00
Côme Chilliet 71328107da
Merge pull request #37029 from nextcloud/fix/chunk-objectids-in-systemtagobjectmapper
Add chunking in SystemTagObjectMapper::getTagIdsForObjects
2023-03-13 22:10:47 +07:00
Côme Chilliet 9b1d7794a8 Add chunking in SystemTagObjectMapper::getTagIdsForObjects
This avoids crashing on Oracle with more than 1000 objects

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-03-13 17:36:10 +07:00
Thomas Citharel f1751c4428
Introduced app enable/disable/update typed events
OCP\App\ManagerEvent is depreciated since 22 without a replacement

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2023-03-13 11:52:57 +07:00
Daniel Kesselberg 39c1b6f49f
chore(tests): add tests for handleLoginFailed
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-03-10 18:04:39 +07:00
Joas Schilling 2b49861679
Add a debug message when throttling without defining
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-03-08 12:09:22 +07:00