03390ee791
Fix interned strings buffer check if 0 free bytes
...
With #32902 it was meant to be avoided to recommend raising the interned strings buffer size above a quarter of the total OPcache size. This works as long as there is at least 1 byte free, but does not apply if the buffer is filled completely.
This commit switches the conditions so that the interned strings buffer size must be smaller than a quarter of the total OPcache size for the warning to be shown. That the buffer must be either filled completely or by more than 90% remains untouched.
Signed-off-by: MichaIng <micha@dietpi.com>
2023-01-23 08:55:35 +07:00
7ebbb6b2ca
Remove workarounds specific to 7.4
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:22:08 +07:00
73c5591f68
Merge pull request #35024 from nextcloud/deprecate/php74
...
Deprecate PHP7.4
2022-11-14 20:35:54 +07:00
abaa3ef61b
Merge pull request #34485 from michaelkuhn/hasBigIntConversionPendingColumns-files_trash
...
Fix hasBigIntConversionPendingColumns missing files_trash
2022-11-11 17:09:26 +07:00
75a1721d7d
Deprecate PHP7.4
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2022-11-10 09:56:32 +07:00
f9e9cd270d
Limit-number-of-concurrent-preview-generations
...
Signed-off-by: Bowen Ding <dbw9580@live.com>
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-11-05 16:03:01 +07:00
9a205bdc84
Fix hasBigIntConversionPendingColumns missing files_trash
...
The two tables seem to have gone out of sync, causing the web interface
to miss `files_trash.auto_id` not being a bigint.
Signed-off-by: Michael Kuhn <github@ikkoku.de>
2022-10-09 13:37:05 +07:00
4207b80141
Harden some PHP functions
...
To avoid things like https://github.com/nextcloud/server/issues/26034
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-10-04 13:22:03 +07:00
0c407b58db
Update CheckSetupController.php
...
file_metadata.id needs to be bigint(20).
Signed-off-by: timm2k <timm2k@gmx.de>
2022-09-14 10:10:12 +07:00
cf9b1082ed
add a setup check for 64 bit
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-07-13 09:33:33 +07:00
f8bebb62ca
do not display the buffer_size info if the size is already set to a certain threshold
...
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
2022-06-17 22:15:28 +07:00
1bc6fb2c58
l10n: Change to a capital letter
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-06-03 09:34:15 +07:00
d2830612d0
l10n: Improve grammar
...
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2022-04-27 08:19:19 +07:00
31606c9861
Add OPcache recommendations to Transifex
...
Fixes: https://github.com/nextcloud/server/issues/30941
Signed-off-by: MichaIng <micha@dietpi.com>
2022-03-22 10:42:51 +07:00
3a0b934f84
Merge pull request #31430 from nextcloud/enh/31429/improve-overwrite-cli-url-check
...
Validate `overwrite.cli.url` to be a url in setup check
2022-03-10 12:40:59 +07:00
4191a178dd
improve overwrite cli url setup check
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-03-09 22:26:00 +07:00
23e8ae15aa
Merge pull request #31470 from nextcloud/enh/13099/allow-disable-imagick-warning
2022-03-08 08:53:12 +07:00
7dca146b58
allow to disable the imagick warning
...
Signed-off-by: szaimen <szaimen@e.mail.de>
Co-Authored-By: MichaIng <micha@dietpi.com>
2022-03-07 17:35:12 +07:00
d5574cf189
allow adding protocol to domains in 'connectivity_check_domains' config
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
2022-03-07 14:13:11 +07:00
3980322621
Merge pull request #31267 from nextcloud/enh/docs-link-for-opcache-recommends
...
Add Nextcloud docs link to OPcache recommends
2022-03-04 01:24:10 +07:00
5ac91f1cb8
Add Nextcloud docs link to OPcache recommends
...
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list.
Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend.
Signed-off-by: MichaIng <micha@dietpi.com>
2022-03-03 23:00:07 +07:00
f63eb4261f
Fix permittedPath comparison
...
Signed-off-by: Mickey Knox <mickey@netfreaks.org>
2022-03-02 22:38:11 +07:00
b28aa52b28
Setup warning for invalid LDAP user or group UUIDs.
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-10 10:15:01 +07:00
84cf39f582
show if the mail server settings are not set or verified
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-02-03 20:16:35 +07:00
79cdb565dc
Avoid zero division in setup checks
...
Fixes: https://github.com/nextcloud/server/issues/30532
Signed-off-by: MichaIng <micha@dietpi.com>
2022-01-11 10:26:57 +07:00
82c1beaacb
Enhance and complement OPcache setup checks
...
The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage.
With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used.
The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded.
A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks.
OPcache usage based checks are skipped when Nextcloud is not permitted to use the API.
Signed-off-by: MichaIng <micha@dietpi.com>
2021-12-19 23:38:21 +07:00
19d070850b
Make sure trusted_proxies is an array
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +07:00
e55ceb2bb1
Show warning on admin settings page
...
Signed-off-by: Vitor Mattos <vitor@php.rio>
2021-10-23 00:54:50 +07:00
4b8f8c5203
Deprecate PHP7.3 for Nextcloud 23
...
* 7.3 reaches EOL shortly after the release of 23.0.0
* Nextcloud 24 will require PHP7.4
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-10-18 09:15:54 +07:00
6958d8005a
Add admin privilege delegation for admin settings
...
This makes it possible for selected groups to access some settings
pages.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-09-29 21:43:31 +07:00
eb46011680
Issue 16719: CheckSetupController.php: now injecting reference to ITempManager, rather than obtaining using it manually
...
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +07:00
8758b36ebb
Issue 16719: CheckSetupController.php now checks configured temporary directory for existence and if it's writable
...
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +07:00
07ccccecad
Only recommand for php-sodium on >= PHP 7.4
...
This is because php-sodium will solve the missing PASSWORD_ARGON2I
constant problem only on >= php 7.4, previously argon2 wasn't part of
the standard extension and was disabled on Centos/RHEL.
So installing php-sodium on php 7.2 for example wouldn't hide the
message. Tested on Fedora with php 7.4, Centos 7 with php 7.2,
Centos 8 with php 7.2 and openSUSE with php 7.4.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-08-06 14:22:09 +07:00
8e51a5feda
Check that php was compiled with argon2 support or that the php-sodium
...
extensions is installed
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-07-30 15:11:55 +07:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
9c6b01abeb
l10n: Spelling unification
...
Spelling unification in Transifex.
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-06-02 17:49:32 +07:00
bd2e6309b5
Merge pull request #25605 from nextcloud/trusted-proxy-warning-localhost
...
dont show trusted proxy warning when the proxy and remote are both localhost
2021-04-01 13:27:26 +07:00
2afa1c5739
Merge pull request #25862 from nextcloud/techdept/psalm/some_loggers
...
Move away some ILoggers
2021-03-02 15:01:44 +07:00
38f761f25f
Move away some ILoggers
...
Makes psalm happier
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 10:47:25 +07:00
3d0dff0d2b
Fix lying docblocks
...
* typed the return
* removed unneeded temp variable
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-01 16:48:04 +07:00
7d8e9baa77
Revert "use the configured forwarded headers for the setup check"
2021-02-13 18:03:32 +07:00
01118a2218
use the configured forwarded headers for the setup check
...
instead of always checking against the same header
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-12 14:22:27 +07:00
cc0cc68c8d
dont show trusted proxy warning when the proxy and remote are both localhost
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-12 13:32:51 +07:00
c1d4f8161b
Migrate internal classes to the OCP db col types
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-12 14:09:13 +07:00
6c8f2dc7bc
Merge pull request #25016 from nextcloud/enh/noid/add-check-for-unsupported-db
...
Add setup check to verify that the used DB version is still supported…
2021-01-11 14:21:42 +07:00
24d436cb60
Remove unneeded casts that were found by Psalm
...
In preparation of the update of Psalm from 4.2.1 to 4.3.1+ (see https://github.com/nextcloud/server/pull/24521 )
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-11 13:14:41 +07:00
bffa61fc32
Add setup check to verify that the used DB version is still supported in the next major release
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-08 13:38:32 +07:00
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-08 11:45:19 +07:00
9ce3ea3368
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-30 14:07:05 +07:00
adc4f1a811
Merge pull request #22916 from J0WI/unifiy-links-to-php.net
...
Unify links to php.net
2020-12-22 09:53:31 +07:00
MichaIng
Côme Chilliet
Simon L
Robin Appelman
Christoph Wurst
Michael Kuhn
acsfer
timm2k
Valdnet
rakekniven
John Molakvoæ
Julien Veyssier
Mickey Knox
Arthur Schiwon
Joas Schilling
Vitor Mattos
Carl Schwan
Stefan
John Molakvoæ (skjnldsv)
Roeland Jago Douma
Roeland Jago Douma
Morris Jobke