490f545006
fix(sharing): Don't change the type of the controller argument
...
[EA] New value type (\DateTime) is not matching the resolved parameter type and might introduce types-related false-positives.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-18 14:31:45 +07:00
ec8a0a6267
fix(shareApiController): avoid duplicated expiryDate operations
...
`expireDate` can be set once and used anywhere needed, the current implementation,
duplicates this behavior which leads to `parseDate` receiving an a date object it
parsed and returend earlier in the createShare method.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-04-18 02:01:13 +07:00
9a0913afdc
refactor(shareApiController): use contrusctor property promotion & DI logger
...
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-04-18 02:01:08 +07:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
85b5dd0a43
fix: add extra check to ensure wrapped shared storage is set
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-20 14:48:55 +07:00
6a82042d73
fix(sharing): Align wording for declining a share
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-03-19 11:15:18 +07:00
2be421785f
fix(files_sharing): ShareesAPI - Return empty response when user is not allowed to share
...
Resolves: https://github.com/nextcloud/server/issues/20950
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-15 15:51:15 +07:00
f46209a34e
chore: improve typing for SharedStorage::$storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-14 11:22:17 +07:00
0ace9a4efa
fix: don't return null for SharedStorage::getWrapperStorage with share recursion
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-14 11:21:05 +07:00
ea8a774a0a
fix: add some recrusive detection/prevention
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-08 14:20:14 +07:00
a598de627c
chore: remove long depricated share code
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-06 15:24:48 +07:00
5c20f5b9a2
fix(sharing): Avoid (dead)locking during orphan deletion
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-05 20:19:30 +07:00
e7a7b4a401
perf: switch places that always use the first getById result to getFirstNodeById
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-04 13:57:31 +07:00
3f269782aa
Merge pull request #43428 from nextcloud/feat/share-expiration-with-time
2024-02-26 10:07:41 +07:00
0eba9570eb
Merge branch 'master' into share-external-watcher
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-02-23 21:51:44 +07:00
d541a7d178
Merge pull request #43605 from nextcloud/orphan-share-daily
2024-02-23 19:43:07 +07:00
311d1d2306
fix truncated circleId returned from Share API
2024-02-23 14:43:31 +07:00
01983d50d4
feat(share): save date and time for expiration
...
Because of timezones, not saving time can lead to unexpected behaviour
when sharing an item sooner than timezone offset
Example: sharing a file before 9am when in UTC+9
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-02-22 11:26:01 +07:00
0b8f0d0a0b
fix: only cleanup orphaned shared daly
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-15 17:53:31 +07:00
3fb1674251
Merge pull request #43461 from nextcloud/fix/get-rid-of-getlogger
...
chore: Migrate away from OC::$server->getLogger
2024-02-14 10:47:22 +07:00
839ddaa354
feat: rename users to account or person
...
Replace translated text in most locations
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +07:00
c0ce272e9c
chore: Migrate away from OC::$server->getLogger
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-13 17:32:30 +07:00
e50c176428
also improe cache ci for shared cache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-02-09 14:00:26 +07:00
d1ec85d1c7
Use `@nextcloud/capabilities` to obtain share api defaults
...
- Remove redundant initial state added
- Call `getCapabilities()` in share config file.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-02-01 17:53:36 +07:00
d9a2a78392
Consider admin defaults when creating shares
...
The current share logic always uses the default `BUNDLED_PERMISSIONS.ALL`
which includes everything.
This commit updates share creation logic to use `defaultPermissions` if set
by admin for the creation of new shares.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-02-01 17:53:36 +07:00
220296b216
fix: Fix template parameter for some listeners
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 10:57:15 +07:00
8bcc2d352e
chore: Fix missing template parameter for IEventListener
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 10:57:15 +07:00
b64ab5fba8
refactor: Migrate IgnoreOpenAPI attributes to OpenAPI
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-01-18 16:14:17 +07:00
cc3a2c351a
fix(share): use user timezone to parse share expiration date
...
If an user in UTC+1 try to create a share at 00:00, it's day D for him, but
D-1 for the server (UTC).
This fix aims to apply the correct offset
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-01-09 17:28:11 +07:00
82b5a19a35
fix: public dav and files_sharing testing fixes
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-09 10:56:14 +07:00
7b6a650b6e
feat: public dav endpoint v2
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-09 10:56:06 +07:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +07:00
9677ca062e
fix: Also cleanup orphaned shares user cannot be found anymore
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-11-20 14:26:12 +07:00
dec880b285
optimize builtin storage wrappers
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-11-08 15:26:10 +07:00
755de1e0b5
refactor: Rename OpenAPI type aliases to their namespaces
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-11-02 11:37:15 +07:00
efe68d012c
Merge pull request #39044 from nextcloud/more-empty-mount-checking
...
Fix root mounts not being setup in some cases
2023-10-24 16:54:05 +07:00
be373fca3c
fix(sharing): set name to target name in sharing cache
...
Fixes #39879 .
Signed-off-by: Max <max@nextcloud.com>
2023-10-18 14:31:27 +07:00
91ebbe8003
fix(federation): Use `sharing.federation.allowSelfSignedCertificates` config for all OCM requests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-11 11:52:10 +07:00
d64bbc8bd3
Convert isset ternary to null coalescing operator
...
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-09-28 12:18:41 +07:00
c2d45cb172
Add single status code descriptions for OpenAPI
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-09-27 08:05:21 +07:00
4954c9f4ba
Merge pull request #39574 from nextcloud/fix/noid/ocm-controller
...
OCM Services
2023-09-20 20:16:10 +07:00
fac5197486
feat(files): add files_sharing indicator
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2023-09-20 13:58:31 +07:00
b5dcd048ae
small fixes
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-09-20 08:23:45 +07:00
c6c06d517c
set authType to basic
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-09-20 08:23:45 +07:00
8b9e7e235d
ocm controller
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-09-20 08:23:45 +07:00
766806c35d
Enfore allowPublicShares admin setting
...
Use the the modern intial-state library to pass data about
`allowPublicUploads` to the sharing frontend.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2023-09-12 20:50:49 +07:00
5685d68bd3
add more checks to ensure mounts aren't empty
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-12 16:50:24 +07:00
d6eb127f76
improve logic for getting the watcher for a shared external storage
...
with the new-ish lazy mount loading the underlying mount might not be loaded yet, so ask the mount cache instead
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-09-11 15:00:32 +07:00
daac5c9a95
fix(cache): Remove displayname cache entry on delete
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-28 14:59:54 +07:00
d4e67afed7
Merge pull request #39944 from nextcloud/share-cache-share
...
pass the share to the cache instead of having to ask the storage
2023-08-28 13:44:03 +07:00
Joas Schilling
fenn-cs
Côme Chilliet
Robin Appelman
Ferdinand Thiessen
Christoph Wurst
Benjamin Gaussorgues
John Molakvoæ
Aragon Gouveia
Vincent Petry
provokateurin
John Molakvoæ
Julius Härtl
jld3103
Max
Hamid Dehnavi
Arthur Schiwon
Maxence Lange