8bbd30693c
refactor(share-manager): Make return type more precise
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-12-04 21:39:25 +07:00
5bf67fd206
Merge pull request #56745 from nextcloud/artonge/feat/files_sharing/support_priority_in_template_providers
...
feat(files_sharing): Support priority in public template providers
2025-12-04 12:58:44 +07:00
10b82c8bf8
feat(files_sharing): Support priority in public template providers
...
Signed-off-by: Louis Chmn <louis@chmn.me>
2025-12-04 10:59:58 +07:00
6bccaf778a
fix(sharing): Allow public share access for everyone
...
When a logged-in user accesses a public share link in the same browser,
the system was incorrectly checking if that user's groups were excluded
from creating link shares. This caused share not found errors for users
in excluded groups, even though public shares should be accessible to anyone
with the link.
The group exclusion setting (`shareapi_allow_links_exclude_groups`) is
intended to restrict share creation, not share access. Public shares
are meant to be anonymous and accessible regardless of the viewer identity
or group membership.
We now check the exclusion for the share creator and not the viewer.
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-12-02 09:45:18 +07:00
774aad3ab1
feat(Share\IManager): add `matchUserId` method and update docs
...
Add missing `matchUserId` method for full-match-autocomplete options
and update docs to make it clearer what each options exactly means.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-09-26 18:26:37 +07:00
746e5917c7
fix(IShare): Add missing getParent and setParent methods
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-29 11:27:04 +07:00
665a38573c
fix(IShareProvider): Add missing getChildren method to the interface
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-07-29 10:26:33 +07:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +07:00
20a50ea877
fix: invalid bool return
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2025-06-26 11:47:53 +07:00
9806a9830c
feat(files_sharing): allow viewing files with download disabled
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-06-26 11:47:53 +07:00
998062d342
fix: Cleanup share ProviderFactory to correctly use DI instead of deprecated getters
...
Ideally circles and talk should migrate to calling registerProvider and
core would not need to use their OCA classes like currently.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-16 10:48:03 +07:00
ae16a28758
perf(Share20): Add interface to query all shares in a folder without filtering by user
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-08 15:29:40 +07:00
6a0d92dedf
fix(files_sharing): expireDate null tests
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-04-14 22:46:52 +07:00
59edcdc537
fix: Fix types for sharingDisabledForUser
...
and use the non-deprecated version whenever possible
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-07 17:36:24 +07:00
b2100484c0
fix: Remove some call and references to deprecated OC_Util class
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-04-07 17:05:54 +07:00
8b26383d00
feat(sharing): Add `shareapi_allow_custom_tokens` config
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:50:43 +07:00
beffb26266
feat(sharing): Fetch a unique generated token
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:49:19 +07:00
715e7143f0
fix(files_sharing,files): Do not validate shares before adjusting the owner
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +07:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +07:00
5e4a166365
feat(files_sharing): reminder for link shares with expiration date
...
Signed-off-by: Stefan Cherniakov <luka-sama@pm.me>
2024-09-03 13:37:17 +07:00
3d136e4466
fix: Add `acceptShare` as an interface
...
It was commented out because at that time no other share provider
supported the `acceptShare` method. Today it is the same no other provider
supports it, but we should make it discoverable by adding it to the public API
as an additional interface.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-30 15:25:51 +07:00
9b84831c8d
fix(files_sharing): adjust IAttributes API and files_versions
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +07:00
967b3848e0
fix(files_sharing): phpunit & openapi fixes
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +07:00
30f9ef414e
fix: psalm, cs, autoloader and lint
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +07:00
75ca4944c9
feat(files_sharing): allow mixed values in share attributes and allow storing email arrays
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +07:00
d388370c3b
feat(files_sharing): implement IShareProviderWithNotification and refactor sendMailNotification
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-12 20:14:30 +07:00
dae7c159f7
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-24 13:11:22 +07:00
59a5b4e0bd
fix(shareManager): Respect empty `expireDate` in server
...
If `expireDate` is an empty string and not `null` then the server should not set a default.
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
2024-05-23 14:11:33 +07:00
af728c5ff6
fix: Fix tiny phpdoc errors related to Share
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 09:24:01 +07:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
9c528d412c
ShareByMailProvider: getAccessList: add token to returned array
...
This allows the share URI to be regenerated.
Signed-off-by: Adam Serbinski <adam@serbinski.com>
2024-03-21 18:25:31 +07:00
26ae5e6dfb
ShareByMailProvider: getAccessList: return full list of recipients
...
Previously was returning only boolean true if the Node was shared
by email, or false if not. Now provides an array containing the
list of email share recipients.
Signed-off-by: Adam Serbinski <adam@serbinski.com>
2024-03-21 18:25:31 +07:00
e7a7b4a401
perf: switch places that always use the first getById result to getFirstNodeById
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-04 13:57:31 +07:00
9af96d9f9a
feat(php,vue): Create a new parameter
...
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
2024-01-31 10:44:40 +07:00
7b6a650b6e
feat: public dav endpoint v2
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-01-09 10:56:06 +07:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +07:00
c008464a2a
Fix return type of IShare::getExpirationDate
...
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
2023-10-18 23:23:41 +07:00
22e033b628
feat!: Migrate Share accepted event to typed event
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
8ad94cbfda
feat!: Migrate unShare events to typed events
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:20 +07:00
44b810bfbd
feat!: Migrate Sharing events to typed events
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-28 14:11:19 +07:00
c0e84cb512
Add SHARE_TYPE_SCIENCEMESH
...
Signed-off-by: Michiel de Jong <michiel@unhosted.org>
2023-03-08 16:46:55 +07:00
4ab3c16403
Pluggable share provider
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-02-02 15:41:26 +07:00
f5c361cf44
composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +07:00
60313683e2
Fix checkpassword undocummented null parameter
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-10-17 12:38:21 +07:00
2ee659e547
Fix view-only code after code review comments
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:24 +07:00
03b1791cca
Fix share attribute related tests + code style
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
a95c19e14b
Add share attributes + prevent download permission
...
Makes it possible to store download permission
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
f525067930
Add argument to getSharesInFolder enable deep share lookup
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-26 12:17:46 +07:00
0fb4ecadae
Recursively fetch subshares
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-26 12:17:46 +07:00
e8ab298d2c
Use email settings in DAV search
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-04-19 16:23:08 +07:00
Carl Schwan
Louis
nfebe
Ferdinand Thiessen
provokateurin
John Molakvoæ
skjnldsv
Côme Chilliet
Christopher Ng
Stefan Cherniakov
Andy Scherzinger
Adam Serbinski
Robin Appelman
Baptiste Fotia
Joas Schilling
Varun Patil
Michiel de Jong
Carl Schwan
Vincent Petry