c84c256261
fix: Adjust preview for view-only shares
...
Previously there was a different behavior for public shares (link-shares) and internal shares,
if the user disabled the view permission.
The legacy UI for public shares simply "disabled" the context menu and hided all download actions.
With Nextcloud 31 all share types use the consistent permissions attributes,
which simplifies code, but caused a regression: Images can no longer been viewed.
Because on 30 and before the attribute was not set, previews for view-only files
were still allowed. Now with 31 we need a new way to allow "viewing" shares.
So this is allowing previews for those files, but only for internal usage.
This is done by settin a special header, which only works with custom requests,
and not by opening the URL directly.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-28 15:52:27 +07:00
10d1c3c29f
Merge pull request #48537 from nextcloud/add-command-to-cleanup-preview
2024-10-14 08:57:00 +07:00
315e4658dd
test(settings): Correctly only return bool for Symfony Input::hasParameterOption calls
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 12:11:39 +07:00
843f638315
test: Fix mock creation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 12:11:30 +07:00
fe0f89c237
feat(preview): add command to cleanup preview folder
...
When changing preview parameters (size, format, …), one can simply delete the preview folder and run
files:scan-app-data in order to retrigger updated preview recreation because files are absent.
However, that's not possible when using ObjectStorage as primary storage, as there's no concept of
"preview folder".
This command allows to simply delete and recreate the preview folder properly from
Nextcloud, so that the abstraction levels handle all the subfolder & file deleting part.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-10-03 13:41:32 +07:00
606241caeb
chore(legacy): Introduce public version ct plass and drop version methods from OC_Util
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-20 14:53:34 +07:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +07:00
49dd79eabb
refactor: Add void return type to PHPUnit test methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 22:32:31 +07:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +07:00
e4fa36e231
fix: Fix failing test for group listing
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-06 21:06:44 +07:00
1e2155993d
chore(tests): Adapt tests to the group:list change
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-06 14:43:44 +07:00
6c1e896a03
fix: Ignore preview requests for invalid file ids
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-07-22 22:32:34 +07:00
e5275dbada
feat: don't count failed CSRF as failed login attempt
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-11 09:27:33 +07:00
e5a6698ec0
Merge pull request #45811 from nextcloud/add-test-for-profile-page-controller
...
test: add tests for ProfilePageController
2024-06-12 14:49:03 +07:00
98eb190e04
test: add tests for ProfilePageController
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-12 11:46:12 +07:00
8bed23288b
fix(files_sharing): dark avatar support
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 10:27:29 +07:00
1f7e2ba599
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-13 17:41:36 +07:00
22dc27810e
fix(auth): Keep redirect URL during 2FA setup and challenge
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-04-19 10:24:26 +07:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
3fede00732
feat(login): Clear login form (password) after IDLE timeout
...
For security reasons it is recommended to stop the login process at a defined time,
this could prevent password leaks by e.g. user forgetting that they entered their password on public devices.
Enforced e.g. by the BSI ORP.4.A13 rule.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-25 12:22:53 +07:00
685145714a
chore: update logincontroller tests
...
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
2024-03-10 11:36:42 +07:00
72f7b80153
Revert change in TwoFactorAuth CleanupTest.php
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-03-06 16:46:35 +07:00
fcdc8b47f2
fix(files_versions): Improve files version listing
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-03-06 10:15:31 +07:00
ce24923f4c
add generate-password option and flow fixes
...
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
2024-02-24 04:56:52 +07:00
a92c507cb6
new user password email option, improved on #29368
...
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
2024-02-24 04:56:52 +07:00
b587ec39f4
Enable adding E-Mail addresses to new user accounts using the CLI
...
Signed-off-by: Philip Gatzka <philip.gatzka@mailbox.org>
2024-02-24 04:56:52 +07:00
6243a9471d
feat(core): Add OCS endpoint for confirming the user password
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-02-20 14:28:00 +07:00
4a509dfe8e
fix: phpunit
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:06:31 +07:00
f7d0c74b10
lazy AppConfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-01-15 15:45:13 +07:00
2ee5c7a8f9
fix(tests): Fix remaining tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-01-09 15:58:02 +07:00
db11313152
Fix tests after slow logout fix
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-01-08 19:09:48 +07:00
85911cbab2
Cancel PR #37405 , remove regression code
...
Signed-off-by: Gaspard d'Hautefeuille <github@dhautefeuille.eu>
2024-01-05 04:20:26 +07:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +07:00
154a9989a7
Merge pull request #39852 from nextcloud/pragmaHeader
...
Stop sending deprecated Pragma header
2023-10-18 03:30:21 +07:00
ee39a47e84
Fix Dynamic property timeFactory in ClientFlowLoginControllerTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-10-09 10:30:54 +07:00
807f173dec
make oauth2 authorization code expire after 10 minutes
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2023-10-05 14:24:02 +07:00
0c421975bd
Remove last calls to deprecated at matcher in tests/Core
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-09-18 10:21:21 +07:00
6f520f2304
Merge pull request #40026 from lhsazevedo/auth-token-commands
...
feat: Add auth token list and delete commands
2023-08-29 08:57:07 +07:00
25309bcb45
techdebt(DI): Use public IThrottler interface which exists since Nextcloud 25
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-28 15:50:45 +07:00
066f6ef16c
Stop sending deprecated Pragma header
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-08-28 15:11:22 +07:00
771a7b92cc
Add tests for occ user:auth-tokens:delete
...
Signed-off-by: Lucas Azevedo <lhs_azevedo@hotmail.com>
2023-08-25 02:27:41 +07:00
266fb31180
fix(tests): preview phpunit
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-08-17 18:58:21 +07:00
1be836273d
core: Add OpenAPI spec
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-13 07:24:15 +07:00
fd0e2f711a
Fixes testcase error.
...
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-24 23:14:23 +07:00
33385d7ecb
fix(tests): Adjust unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-05-15 16:12:14 +07:00
dc9d8c42bb
fix: Adjust console formatter code to match with Symfony type hints
...
Symfony has added type hints on the `OutputFormatterInterface`,
so we must adjust our type hints to match with Symfony.
Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
2023-04-17 18:35:10 +07:00
a4032a3800
Add some tests for input trimming in LostController.php
...
Signed-off-by: Joshua Trees <me@jtrees.io>
2023-04-05 12:15:38 +07:00
346054f854
Fix tests
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2023-03-28 09:41:04 +07:00
59578817f5
Merge pull request #36489 from nextcloud/bugfix/noid/brute-force-protection-password-reset
...
Add bruteforce protection to password reset page
2023-02-06 22:12:25 +07:00
875e6cf7e6
fix(CI): Adjust expected result
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-06 11:26:38 +07:00
Ferdinand Thiessen
Kate
Joas Schilling
Thomas Citharel
Julius Knorr
provokateurin
Christoph Wurst
Daniel Kesselberg
Côme Chilliet
Benjamin Gaussorgues
skjnldsv
Andy Scherzinger
Eduardo Morales
Louis Chemineau
Anupam Kumar
Philip Gatzka
Maxence Lange
Gaspard d'Hautefeuille
Julien Veyssier
Joas Schilling
Git'Fellow
Lucas Azevedo
jld3103
Faraz Samapoor
Ferdinand Thiessen
Joshua Trees