0563757ea4
fix(SetupCheck): Properly check public access to data directory
...
When checking for public (web) access to the data directory the status is not enough
as you might have a webserver that forwards to e.g. a login page.
So instead check that the content of the file matches.
For this the `.ncdata` file (renamed from `.ocdata`¹) has minimal text content
to allow checking.
¹The file was renamed from the legacy `.ocdata`, there is a repair step to remove the old one.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 22:08:42 +07:00
879d248c55
fix: emails tests after new design fixes
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-06 09:42:19 +07:00
26beedef36
test(users): Adapt tests to new admin delegation checks
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-22 19:58:44 +07:00
829f2b9bc7
fix(db): Promote the use of `getDatabaseProvider` to reduce the impage of removed upstream platforms
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:14 +07:00
693a81bfa3
fix(mail): Fix big logos in mail templates for Outlook
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-17 09:24:55 +07:00
8fc498fb82
fix(IntegrityCheck): Ensure the check is run if no results are available
...
If there are no cached results the current implementation was also returning an empty array,
but this was the same as when there was a successful run.
So to distinguish this we return `null` if there are *no* results.
In this case we need to rerun the integrity checker.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-03 11:37:49 +07:00
682faad0b3
Merge pull request #46009 from nextcloud/refactor/ajax-cron
...
refactor(cron): Use `IAppConfig` for cron settings and migrate ajax cron away from jQuery
2024-06-29 16:29:34 +07:00
14778811b4
refactor: Use `IAppConfig` for setting cron type
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-28 18:00:39 +07:00
6e48ca1cf8
fix(settings): Adjust SetupCheck for supported database versions
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 16:15:16 +07:00
bd46a00def
test(settings): fix AccountMigratorTest when using PNG avatars
...
PNG is lossless so we test the imported file for equality with the exported file,
but the changed asset was never imported into Nextcloud so it was never initially scaled.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-14 15:52:21 +07:00
1d451d44a2
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-13 14:15:32 +07:00
98b5cdc43d
Merge pull request #43942 from nextcloud/fix/43612/avoid-pwd-confirm-sso
...
fix(Session): avoid password confirmation on SSO
2024-06-07 11:25:36 +07:00
f6d6efef3a
refactor(Token): introduce scope constants
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-05 19:01:14 +07:00
ec5b60af28
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-03 20:33:31 +07:00
f863290572
feat(ldap): sync additional properties to profile and SAB
...
Synced from LDAP to profile:
- Date of birth
Synced from LDAP to SAB (via the profile):
- Biography
- Date of birth
Original code by Jake Nabasny (GitHub: @slapcat)
Co-authored-by: Jake Nabasny <jake@nabasny.com>
Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-05-30 12:01:13 +07:00
0fa9f3049f
feat(files_sharing): allow to specify allowed groups to share instead of excluded groups
...
Relates to #3387
Signed-off-by: Corentin Damman <c.damman@intopix.com>
2024-03-15 16:52:59 +07:00
df502c114d
feat(settings): Cache app discover images to ensure privacy of users
...
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-14 20:45:25 +07:00
6278cf181e
fix: Improve HSTS warning wording as suggested by reviewer
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-14 11:49:47 +07:00
9f819f311f
feat: Migrate HSTS check to Security headers SetupCheck
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +07:00
d7193ef65e
fix: Migrate security headers check tests and fix the SetupCheck implementation
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +07:00
1fffdf4763
fix: Fix ocm-provider setup check failure detection
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +07:00
519e434573
fix(updatenotification): spread the use of new appconfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-13 02:22:11 +07:00
4ac2375ca2
feat: Add declarative settings
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-03-12 13:56:54 +07:00
1ea88a73f6
feat(settings): Migrate .well-known URL setup check to new API
...
Co-authored-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-07 14:06:08 +07:00
5794e1c9d6
Merge pull request #43906 from nextcloud/enh/migrate-ssl-url-setupcheck
...
feat(settings): Migrate SSL access and URL generation check to SetupCheck API
2024-03-04 15:54:47 +07:00
ef2c312b18
feat(settings): Migrate data directory protection check to `SetupCheck`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-29 13:54:01 +07:00
ca246dc35c
feat(settings): Migrate SSL access and URL generation check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-29 12:21:36 +07:00
ad747ab62b
feat(settings): Migrate OCM / OCS provider tests to SetupCheck
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-27 14:52:10 +07:00
a72706f1e6
Merge branch 'master' into fix/pages-titles-apps
...
Signed-off-by: Andrii Rublov <github.a@rublov.me>
2024-02-25 13:48:38 +07:00
b080113fdd
Merge branch 'master' into fix/42480/user-admin-not-admin
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-02-24 19:31:22 +07:00
00386a5407
fix(settings): Use initial state instead of custom state for server data
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-23 21:59:02 +07:00
dd7fba2c95
fix(settings): Only use `id` in categories - drop duplicated `ident` property
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-23 21:59:02 +07:00
8d22d341c8
[Bugfix]: Titles of pages (dashboard, apps-settings, users-settings) #43327
...
Signed-off-by: Andrii Rublov <airublev@outlook.com>
2024-02-23 18:39:23 +07:00
c98b0462e3
fix(admin role): fix old and wrong way to determine whether user is admin
...
- fixes Settings knowing who is an admin of non-local group backend groups
- obsoletes and removes a little old, deprecated code
- double checks proper parameter type on Group\Manager::isAdmin
- also fixes legacy OC_User code to check whether user is an admin
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-02-19 18:57:22 +07:00
524ed97d62
fix: replace `Account name` by `Login`
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:08:10 +07:00
839ddaa354
feat: rename users to account or person
...
Replace translated text in most locations
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +07:00
449d28e610
test(php): Fix the unit tests
...
I added our context in the unit tests following the advice of Louis.
Link : https://github.com/nextcloud/server/pull/43186#issuecomment-1916571027
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
2024-01-31 10:44:40 +07:00
9af96d9f9a
feat(php,vue): Create a new parameter
...
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
2024-01-31 10:44:40 +07:00
67541f21f6
Migrate fair use of free push service check to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 13:05:59 +07:00
9add64f30e
Merge writable temporary space check with the s3 one, and improve
...
It will now show available space and path of both PHP and Nextcloud
temporary directories if they differ.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 11:47:30 +07:00
ccbc5fc273
Remove old version of temporary space setup check and fix tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 11:47:29 +07:00
10664e9529
Migrate MySQL utf8mb4 check to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-23 17:34:04 +07:00
ca3e1a531a
Merge gmp and bcmath module checks with the existing PHP modules setup check
...
Also add description for why each module is recommended
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:07:21 +07:00
a77bab2f95
Migrate set_time_limit setup check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-18 12:36:53 +07:00
5ad549a72f
Migrate memcached PHP module setup check to new API
...
Merged it with the other existing memcache setup check as it fits
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-18 09:40:43 +07:00
0e889da4a8
Remove obsolete check of curl SSL version
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 16:14:40 +07:00
9bdad442f8
Remove references to removed functions in tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 10:49:19 +07:00
b27455b922
Fix Cron setup check tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 10:49:19 +07:00
7017b3e675
Fix CheckSetupControllerTest following overwrite.cli.url migration
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 09:29:12 +07:00
0483064f07
Migrate overwrite.cli.url setup check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 09:05:40 +07:00
Ferdinand Thiessen
skjnldsv
Louis Chemineau
Joas Schilling
Andy Scherzinger
Arthur Schiwon
Jake Nabasny
Corentin Damman
Côme Chilliet
Maxence Lange
jld3103
Côme Chilliet
Andrii Rublov
John Molakvoæ
Andrii Rublov
Vincent Petry
Baptiste Fotia