Commit Graph

24993 Commits (45b0a0379e5c763a3eec766ee75f3de112f56227)

Author SHA1 Message Date
Joas Schilling fed74d78ca
Merge pull request #50452 from nextcloud/chore/update-stub
chore: update php intl stub and fix type issues
2025-02-28 08:37:18 +07:00
Nextcloud bot e1c8c2099a
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-28 00:23:18 +07:00
Ferdinand Thiessen 6900ac99e0
Merge pull request #50908 from nextcloud/chore/server-annotations
chore: Adjust `OCP\Server::get` annotation to work with phpstan
2025-02-27 22:23:20 +07:00
Ferdinand Thiessen c82337f3b9
fix: incorrect types detected by updated stubs
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 19:07:39 +07:00
Côme Chilliet 001b12c482
Merge pull request #50999 from nextcloud/fix/move-away-from-oc-app
fix: Replace OC_App calls by IAppManager
2025-02-27 18:33:47 +07:00
Louis c7900de4f2
Merge pull request #51051 from nextcloud/artonge/fix/login_flow_v2_sessions_2
feat: Close sessions created for login flow v2
2025-02-27 08:52:00 +07:00
Nextcloud bot 7ef9ffa078
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-27 00:22:16 +07:00
Louis 2afb6ed50a
Merge pull request #51050 from nextcloud/artonge/fix/extra_files_integrity_check
fix: Report duplicated extra files in integrity check
2025-02-26 14:22:00 +07:00
Louis Chemineau c6293204a2
feat: Close sessions created for login flow v2
Sessions created during the login flow v2 should be short lived to not leave an unexpected opened session in the browser.

This commit add a property to the session object to track its origin, and will close it as soon as possible, i.e., on the first non public page request.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-26 13:42:18 +07:00
Louis Chemineau cdd00bf803
fix: Report duplicated extra files in integrity check
The `array_diff` is not comparing the array keys. This means that an extra key with an expected hash will not be reported. Using `array_diff_assoc` will report such files.

For example, copying `status.php` to `status 2.php`, will only be reported with the new version.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-26 10:28:39 +07:00
Joas Schilling 095ab4419e
fix(l10n): Improve english source strings
- No leading/trailing whitespace
- Use asci single quote

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-26 09:54:32 +07:00
Nextcloud bot abf294c383
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-26 00:21:46 +07:00
Andy Scherzinger 48d69c727a
fix(lint): correct comment identation
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2025-02-25 22:35:50 +07:00
Andy Scherzinger 388301275b
Merge pull request #50764 from p1gp1g/patch-1
Update doc comment for prefixTableName
2025-02-25 22:16:04 +07:00
Robin Appelman 0a77ba99a2
feat: support migrating an instance to sharding
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-25 17:52:40 +07:00
Julius Knorr 0427d5d207
Merge pull request #50874 from nextcloud/artonge/fix/login_flow_v2_sessions
fix: Initialize lastConnectionCheck after first connection
2025-02-25 08:34:35 +07:00
Nextcloud bot 5d4be44748
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-24 20:39:08 +07:00
Côme Chilliet d189ed3dd9 fix: Remove incorrect `@throws` annotations and move away from OC_App
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-24 17:48:34 +07:00
Côme Chilliet 34139987d6 fix: Replace OC_App calls by IAppManager
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-24 17:48:34 +07:00
Ferdinand Thiessen e3af27b280
refactor: convert sanitize account properties repair step to background job
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:16:28 +07:00
Ferdinand Thiessen 575222b5af
fix: Optimize repair step performance
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:16:28 +07:00
Ferdinand Thiessen 08d33a9f57
fix: validate account properties as a repair step
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:16:27 +07:00
Nextcloud bot c1204c0670
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-24 00:21:56 +07:00
Nextcloud bot 6b2c5b8aa6
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-23 00:22:00 +07:00
Nextcloud bot 698b654a18
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-22 00:21:54 +07:00
Stephan Orbaugh 33a12eb3af
Merge pull request #50053 from nextcloud/fix/noid/thudnerbird-addon-useragent
fix: Change UserAgent to *cloud
2025-02-21 10:27:57 +07:00
Marcel Klehr a70071541e feat(SystemTag): Make MapperEvent webhook compatible
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-02-20 12:46:52 +07:00
Nextcloud bot 3b45ba2630
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-20 00:22:09 +07:00
Johannes Endres ae2cc23658 fix: Change UserAgent to *cloud
Co-authored-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Johannes Endres <je@johannes-endres.de>
2025-02-19 18:51:08 +07:00
Ferdinand Thiessen 28ce57d0f4
chore: Adjust `OCP\Server::get` annotation to work with phpstan
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-19 16:50:16 +07:00
Louis Chemineau 066c92f7b0 fix: Initialize lastConnectionCheck after first connection
We are checking whether the DB connection is alive once every 30 seconds. But when we are lacking the last check time, we are skipping the check and reconnect logic. This is causing the reconnect logic to never fire in those cases.

It seems to me that "those cases", are actually always the case, as upon initialization, we are not using the proper connection name to store the time.

In the `connect()` logic, when `$this->_conn` is null, `$this->getConnectionName()` is returning `replica`, so `$this->lastConnectionCheck` will be equal to `['replica' => time()];`

60711ea4cf/lib/private/DB/Connection.php (L215-L221)

60711ea4cf/lib/private/DB/Connection.php (L891-L893)

2b6d7bf65f/doctrine/dbal/src/Connections/PrimaryReadReplicaConnection.php (L136-L139)

Then, if the connection name ends up as being 'primary', the reconnect logic is skipped:

60711ea4cf/lib/private/DB/Connection.php (L874-L880)

Follow-up of https://github.com/nextcloud/server/pull/41819

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-19 12:25:12 +07:00
Joas Schilling 73d94353d1
fix(cron): Keep job class limitation when searching for the next job
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-19 08:44:33 +07:00
Nextcloud bot 0d49af4f27
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-19 00:21:45 +07:00
Joas Schilling a80d7ce11d
Merge pull request #50864 from nextcloud/fix/fix-psalm-taint-errors-2
fix: Fix psalm taint false-positives by small refactorings
2025-02-18 13:59:30 +07:00
skjnldsv 2e50a39265 fix(files): properly forward open params from short urls
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-18 10:53:23 +07:00
Nextcloud bot 8886f367e4
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-18 00:21:58 +07:00
Côme Chilliet e757b649b7
fix: Fix psalm taint false-positives by small refactorings
Mostly make it clear that we trust admin input or that we correctly
 escape strings.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 18:08:23 +07:00
Côme Chilliet c1c59f9a6c
chore: Add missing star in phpdoc comment
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:23 +07:00
Côme Chilliet 640dbd0b5e
fix: Fix false-positive psalm taint errors when outputting plain text
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:23 +07:00
Côme Chilliet 7c907223d2
fix: Fix psalm taint false-positive by escaping trusted input
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:22 +07:00
Côme Chilliet fa108d5b54
fix: Correctly tag json encoding in BaseResponse to fix false-positive
…in psalm taint analysis

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:22 +07:00
Côme Chilliet aac79bad9b
fix: Move config.php taint trust upstream directly in OC\Config class
This solves some false-positive psalm taint errors

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:20 +07:00
Côme Chilliet 85fbd3eb0a
fix: Work around psalm taint false-positive by not using var_export
var_export is listed as a taint sink because it may output stuff
 depending on the parameters. It was not the case here, but we can
 simply json_encode the result by passing it as context to the logger
 method rather than using var_export.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:24:08 +07:00
Côme Chilliet fec865cc29
chore: Correctly flag json encoding methods as escaping html and quotes
Especially with JSON_HEX_TAG it’s perfectly fine to echo JSON, and we
 only use it in JSON output anyway.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:24:07 +07:00
Côme Chilliet 579a337750
fix: Fix psalm taint error in L10N factory
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:24:07 +07:00
Kate 5b507561d3
Merge pull request #50791 from nextcloud/perf/remove-filecache-index
chore(filecache): remove index fs_id_storage_size
2025-02-17 11:31:12 +07:00
Git'Fellow b9f8539c63
Merge pull request #50809 from nextcloud/fixPhp83Deprecation
fix(repair): PHP8.3 deprecation warning
2025-02-15 12:06:28 +07:00
Nextcloud bot ba3868a403
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-15 00:21:54 +07:00
Git'Fellow 885175772b fix(repair): PHP8.3 deprecation warning
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-02-14 11:55:19 +07:00
Nextcloud bot 20cedce95f
Fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-14 00:22:05 +07:00