Commit Graph

7307 Commits (44dd42870e2fae52e24f9c74481694d644cec763)

Author SHA1 Message Date
Louis Chemineau 79a0cdade4
test: add test that object store folder copy preserves folder size
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-06-02 12:00:59 +07:00
Stephan Orbaugh 0d394fc9e9
Merge pull request #52988 from nextcloud/backport/50157/stable30
[stable30] feat(UserMountCache): Emit events for added, removed and updated mounts
2025-05-27 13:24:15 +07:00
provokateurin a8b96fd4f8
feat(UserMountCache): Emit events for added, removed and updated mounts
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-26 08:34:45 +07:00
Joas Schilling cfa2eddd90
test: Speed up comments test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-21 08:31:25 +07:00
Côme Chilliet 383ed0089d chore: Add an autoload.php file for tests relying on core class
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-19 15:44:05 +07:00
Daniel 4f583f073c
Merge pull request #52881 from nextcloud/backport/50234/stable30
[stable30] fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist
2025-05-16 13:17:22 +07:00
Daniel 327ce31c66
Merge pull request #52814 from nextcloud/backport/52798/stable30
[stable30] fix: log requests exceeding the rate limiting
2025-05-16 13:11:52 +07:00
Joas Schilling b6a8287ce1 fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-15 17:52:02 +07:00
Robin Appelman e5aabded60 test: add test for nested cache jail unjailedroot
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-14 20:06:56 +07:00
Daniel Kesselberg 0edd50647e fix: log requests exceeding the rate limiting
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-14 12:55:05 +07:00
Louis Chemineau a7dcc5ce33
fix(blurhash): Use preview API to generate the previews
This allows to benefit from all the checks done by the preview API.

This also use the newly introduced `cacheResult` argument to limit disk usage.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-05-06 14:58:12 +07:00
Joas Schilling e12b2d4b4a
fix(loginflow): Fix type error when password could not be decrypted
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-05 09:46:31 +07:00
Ferdinand Thiessen 832f79ac93
chore: apply code style
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-30 19:04:59 +07:00
Joas Schilling f0927e1356
fix(occ): Fix autocompletion of config:app:* commands
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-25 15:01:54 +07:00
Benjamin Gaussorgues b6b9c3d211
Merge pull request #52232 from nextcloud/backport/52223/stable30 2025-04-24 14:23:20 +07:00
Benjamin Gaussorgues db71a2b2c9
feat(ip): add configurable IPv6 subnet for BFP and throttling
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-04-24 09:41:32 +07:00
Maxence Lange c3f431d4fe fix(federation): allows equal signs in federation id
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-04-23 19:23:40 +07:00
Louis Chemineau 9bed21a8d7 fix: Transfer ownership with S3 as primary
When using S3 as primary storage, transferring ownership with the `--move` option fail with the following error:

`SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '8-45b963397aa40d4a0063e0d85e4fe7a1' for key 'fs_storage_path_hash'`

The `--move` option moves the entire home folder from one account to another.
The error means that the move failed because the destination folder already exist in `oc_filecache`.

- With S3 as primary storage, folders only exists as entries in `oc_filecache`.
- With S3 as primary storage, `moveFromStorage(...)` only moves the cache entry, as nothing needs to be moved on disk. This cache move does not delete potentially pre-existing destination folder.
- With Local storage, `moveFromStorage(...)` calls `rename(...)` which delete pre-existing folder.

- `transfer(...)`: 687a4d9ac7/apps/files/lib/Service/OwnershipTransferService.php (L112)
- `oneTimeUserSetup(...)`: 687a4d9ac7/lib/private/Files/SetupManager.php (L261-L262)
- `mkdir(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L91-L135)
- `moveFromStorage(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L635-L636)

Delete pre-existing folder in `moveFromStorage(...)`

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-04-16 16:18:42 +07:00
John Molakvoæ 6f5fc70df4
Merge pull request #52077 from nextcloud/backport/52075/stable30 2025-04-11 13:40:32 +07:00
Joas Schilling 32d30f8f67
fix(federation): Fix returning "no display name" after cache result
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-10 12:37:59 +07:00
skjnldsv 71dfb43f8f fix(files_sharing): fix share creation error handling
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>

[skip ci]
2025-04-09 15:22:18 +07:00
Joas Schilling 2593702243
fix(federation): Don't load the addressbook when resolving a cloud ID
Instead we delay the lookup of the display name until it is actually used

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-09 13:57:24 +07:00
Benjamin Gaussorgues bad8f54232
feat(ip): use larger IPv6 range by default
Some providers assign `/48` IPv6 blocks instead of `/64` so it sounds safer
to use this mask by default.

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-04-08 11:30:15 +07:00
Christoph Wurst 181561771b
fix(session): Only mark sessions of permanent tokens as app passwords
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2025-04-03 10:15:11 +07:00
Richard Steinmetz 550d8d9fce
fix(oauth2): retain support for legacy ownCloud clients
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-04-02 12:23:45 +07:00
Julius Knorr 6d5b5a2cc1 test: Adapt tests to properly use valid email addresses
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-30 01:35:25 +07:00
Julius Knorr ebe943207d fix: Do not build encrypted password if there is none
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-28 15:18:03 +07:00
Christoph Wurst cf130f43d7
Merge pull request #51538 from nextcloud/backport/51380/stable30
[stable30] fix(cardav): only show users from enabled addressBooks in contacts menu
2025-03-26 14:54:36 +07:00
Ferdinand Thiessen d0402dee06 fix(IFilenameValidator): correctly handle case insensitivity
- forbidden names and forbidden base names are case **insensitive**
  so we need to check all lowercase here.
- add test that config value is also read case insensitive.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-24 11:46:43 +07:00
Hamza Mahjoubi e55a375ae3 fix(cardav): only show useres from enabled addressBooks in contacts menu
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2025-03-21 15:14:46 +07:00
Ferdinand Thiessen 4d9e4d8bcf
test: fix CI when running Karma tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-17 20:33:46 +07:00
Ferdinand Thiessen 86d2c5cbc8
fix(mime-types): adjust compiled mime types and sign
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-12 15:29:25 +07:00
Ferdinand Thiessen c0003fbd9c
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:52:07 +07:00
Ferdinand Thiessen 7d3047f5cb
fix(lookup-server): do not query data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:46:55 +07:00
provokateurin 552eb2678f
refactor(TempManager): Simplify and unify implementations and remove legacy behavior
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-04 07:49:20 +07:00
Ferdinand Thiessen d3dbe3ab2c
refactor: convert sanitize account properties repair step to background job
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 16:44:49 +07:00
Ferdinand Thiessen bb73628ebe
fix: Optimize repair step performance
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 16:42:45 +07:00
Ferdinand Thiessen 9fdd48dd2d
fix: validate account properties as a repair step
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 16:42:44 +07:00
Johannes Endres b61ae01c52 fix: Change UserAgent to *cloud
Co-authored-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Johannes Endres <je@johannes-endres.de>
2025-02-21 09:29:26 +07:00
Louis Chemineau b1cbeff17c test(View): Copy preserves content
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-13 23:35:59 +07:00
Louis Chemineau a663b3e0cd fix(files): Correctly copy the cache information on copy operations
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-13 23:35:59 +07:00
Robin Appelman b9ac12466e test: re-add object store primary storage phpunit tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-13 17:31:51 +07:00
Andy Scherzinger 6964531134
Merge pull request #50704 from nextcloud/backport/50660/stable30
[stable30] fix: make sure we process mime extensions as string
2025-02-13 16:42:50 +07:00
Josh 431c6d0609
fix(Mailer): Fix sendmail binary fallback
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-02-12 13:23:11 +07:00
Ferdinand Thiessen 96384cd950
fix(FediverseAction): Ensure valid fediverse links are generated
Harden also for existing values of the profile.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-07 12:41:49 +07:00
Ferdinand Thiessen 57fc8f1182
fix(AccountManager): Sanitize social media handles
Ensure to only accept valid X and fediverse handles.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-07 12:41:49 +07:00
skjnldsv 80a4cb586f fix: make sure we process mime extensions as string
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-06 15:15:41 +07:00
Robin Appelman 68829ad47c
fix: improve checks for moving shares/storages into other mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:08:58 +07:00
Ferdinand Thiessen dd5ce9eaa4
fix(sharing): Move permission validation to share manager
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-31 18:21:26 +07:00
Louis Chemineau 9e6cc5737f
fix: Exclude non accepted shares when computing access list
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-30 11:07:23 +07:00