Commit Graph

2507 Commits (42f45030ff282504d7c6d6321e46ce118d5e4087)

Author SHA1 Message Date
Miguel Sánchez de León Peque f307ed8597
feat: Allow WebP content type in PhotoCache
Signed-off-by: Miguel Sánchez de León Peque <peque@ieco.io>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-10-28 13:43:01 +07:00
Kate 5efb175665
Merge pull request #48614 from nextcloud/refactor/storage/constructors 2024-10-28 10:19:41 +07:00
provokateurin bb7841998b
fix(dav): Cleanup view-only check
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-28 08:02:42 +07:00
provokateurin 0de4843b73 refactor(Storage): Align all Storage constructors
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-23 13:24:18 +07:00
Kate 070adc1131
Merge pull request #48790 from nextcloud/refactor/apps/constructor-property-promotion 2024-10-22 12:47:45 +07:00
SebastianKrupinski 3f4210e737 fix: override iTip Broker to fix several issues
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-10-21 14:21:28 +07:00
SebastianKrupinski de22119775 fix: RDATE and EXDATE property instances
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-10-21 14:08:43 +07:00
provokateurin e8426996f5
fix(psalm): Fix some newly detected issues
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +07:00
provokateurin 381077028a
refactor(apps): Use constructor property promotion when possible
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +07:00
dependabot[bot] bb598c8451
chore(deps): Bump nextcloud/coding-standard in /vendor-bin/cs-fixer
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/nextcloud/coding-standard/releases)
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md)
- [Commits](https://github.com/nextcloud/coding-standard/compare/v1.3.1...v1.3.2)

---
updated-dependencies:
- dependency-name: nextcloud/coding-standard
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-19 07:57:35 +07:00
Ferdinand Thiessen 2ef74b9860
Merge pull request #47329 from nextcloud/feat/add-datetime-qbmapper-support
feat(AppFramework): Add full support for date / time / datetime columns
2024-10-18 19:05:08 +07:00
Kate d0625645fb
Merge pull request #48765 from nextcloud/dbQueriesExecStmt2 2024-10-18 11:45:09 +07:00
Pablo Zmdl 742764bd4e chore: Use constant for default value
Co-authored-by: Thomas Citharel <nextcloud@tcit.fr>
Signed-off-by: Pablo Zmdl <57864086+pabzm@users.noreply.github.com>
2024-10-17 22:27:10 +07:00
Pablo Zmdl 280adb3e94 feat: configurable request timeout for carddav sync
Big federated setups may need a longer timeout, which they now can
configure.

Signed-off-by: Pablo Zmdl <pablo@nextcloud.com>
Co-authored-by: Josh <josh.t.richards@gmail.com>
2024-10-17 22:27:10 +07:00
Git'Fellow a1681b0756 chore(db): Apply query prepared statements
Fix: psalm

fix: bad file

fix: bug

chore: add batch

chore: add batch

chore: add batch

fix: psalm
2024-10-17 20:30:47 +07:00
Ferdinand Thiessen 0e54c2bd43
fix: Adjust Entity types
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 18:31:44 +07:00
Git'Fellow c254855222 chore(db): Correctly apply query types
fix: psalm

fix: error

fix: add batch

fix: fatal error

fix: add batch

chore: add batch

chore: add batch

fix: psalm

fix: typo

fix: psalm

fix: return bool

fix: revert Manager
2024-10-17 09:21:07 +07:00
Anna Larch cafe5ec539 fix(caldav): broken activity rich objects
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-10-16 17:18:45 +07:00
Richard Steinmetz cbcc8fc1a9
fix(caldav): duration handling in the event reader class
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-10-16 09:55:30 +07:00
Côme Chilliet 1580c8612b
chore(apps): Apply new rector configuration to autouse classes
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 10:40:25 +07:00
John Molakvoæ 832695d565
Merge pull request #48206 from nextcloud/feat/systemtags-public 2024-10-15 09:15:16 +07:00
provokateurin 51d9d63a01
chore: Use more gender neutral language
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-14 13:59:24 +07:00
John Molakvoæ (skjnldsv) abd0cddd38 feat: make systemtags public visible
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-10-11 16:06:44 +07:00
Kate 614d8c23a0
Merge pull request #48494 from nextcloud/refactor/storage/strong-param-types 2024-10-08 15:20:17 +07:00
provokateurin 54ec472d9a
fix(BackgroundJobs): Adjust intervals and time sensitivities
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-08 11:26:53 +07:00
provokateurin 2489608a72
refactor(dav): Add Storage parameter strong types
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-07 15:00:07 +07:00
Ferdinand Thiessen 02f3c88d73
Merge pull request #48438 from nextcloud/fix/bring-back-zip-event
fix(dav): Emit `BeforeZipCreatedEvent` when creating folder zip archive
2024-10-07 11:58:34 +07:00
Anna 004d7dac91
Merge pull request #48508 from nextcloud/fix/webcal-subscription-jobs-middleware
fix(caldav): add missing handlers
2024-10-02 15:12:26 +07:00
escoand a5eb38f277
fix(dav): don't crash subscription on invalid calendar object
Signed-off-by: escoand <escoand@users.noreply.github.com>
2024-10-02 11:33:18 +07:00
Anna e333bc3c8f
Merge pull request #47788 from nextcloud/feat/add-addressbook-list-command
feat(carddav): add command to list address books
2024-10-02 10:35:44 +07:00
Anna Larch d30c0669a6 fix(caldav): add missing handlers
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-10-01 22:12:37 +07:00
Daniel Kesselberg 870816466f
fix: make federation address book sync work with allow_local_remote_servers = false
Client.preventLocalAddress expects an absolute URL, which means the base_uri option cannot be used.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-10-01 18:00:46 +07:00
Anna Larch 6468ec5716 feat(carddav): add command to list address books
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-30 11:53:02 +07:00
Ferdinand Thiessen e0c00af3bf
fix(dav): Emit `BeforeZipCreatedEvent` when creating folder zip archive
This is required to not break behavior on zip download (apps should be able to react to zip download especially for shares).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-29 13:29:04 +07:00
Ferdinand Thiessen d66e16b07e
feat(dav): New `ZipFolderPlugin` which allows to download folders using GET requests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 13:18:23 +07:00
Côme Chilliet 1a4978c4ea
chore: Apply rector configuration to apps folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-20 17:51:00 +07:00
Hamza 34445ea9d1
Merge pull request #47399 from nextcloud/fix/47275/driverException
fix: expand select and group by for calendar reminder backend
2024-09-19 16:57:17 +07:00
Hamza Mahjoubi ab3a239853 fix: expand select and group by for calandar reminder backend
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-09-19 15:25:16 +07:00
provokateurin 9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +07:00
Louis Chemineau e202896a74 fix: Override start method of \Sabre\DAV\Server to remove exception output
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-18 17:53:43 +07:00
Louis Chemineau d2bf3613f6
fix: Drop unnecessary exit
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-17 17:32:33 +07:00
Anna Larch 1ce46c1fca refactor: move to new activity exception
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-17 12:06:24 +07:00
provokateurin dc13f9cc1e
fix(Files): Handle getOwner() returning false
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 10:10:50 +07:00
provokateurin 8ca6fcace7
fix(Storage): Document getOwner() can return false
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 10:10:50 +07:00
Côme Chilliet 801733e523
fix: Remove OCP\Files\Storage interface deprecated since version 9
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:10:48 +07:00
Joas Schilling cc9c61d580
Merge pull request #47947 from nextcloud/feat/make-setup-check-trait-public
feat: Make `CheckServerResponseTrait` public and provide as `OCP\SetupCheck\CheckServerResponseTrait`
2024-09-16 15:33:48 +07:00
Joas Schilling cfed24cb02
Merge pull request #47924 from ldidry/catch-MaxInstancesExceededException
🥅 — Catch MaxInstancesExceededException on calendar events
2024-09-16 15:04:49 +07:00
Ferdinand Thiessen 7fbd518452
feat: Make `CheckServerResponseTrait` public and provide as `OCP\SetupCheck\CheckServerResponseTrait`
This trait is used by other apps for creating setup checks,
so we should provide it instead apps using private API.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-16 14:58:21 +07:00
Luc Didry 615f0b2c0e
fix(dav): catch `MaxInstancesExceededException` on calendar events
Signed-off-by: Luc Didry <luc@didry.org>
2024-09-16 12:57:22 +07:00
Anna 1a972d0f47
Merge pull request #48029 from nextcloud/fix/dav-cast-content-lenght-to-int
fix(dav): cast content length to interger
2024-09-16 11:07:40 +07:00
John Molakvoæ 388618bd44
Merge pull request #48030 from nextcloud/fix/dav-cast-params-to-string 2024-09-16 11:07:31 +07:00
Anna 04997dfc53
Merge pull request #48031 from nextcloud/fix/filesreport-cast-fileId-to-int
fix(filesreport): cast fileId to integer
2024-09-16 11:07:22 +07:00
Christoph Wurst 0a7b4b597e
Merge pull request #48042 from nextcloud/refactor/elvis
refactor: Use the elvis operator + fix: Handle null checks with the ?? operator
2024-09-16 10:04:37 +07:00
Anna Larch 92d1bdb965 fix(dav): cast content length to interger
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-15 22:46:46 +07:00
Kate 876631435e
Merge pull request #48045 from nextcloud/fix/add-function-type-for-mimetype-sanitizer 2024-09-15 22:42:01 +07:00
Anna Larch 160866c52d fix(dav): set string type for sanitizeMtime
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-15 21:32:55 +07:00
Christoph Wurst 614f9ec0a2
refactor: Use the elvis operator
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 21:01:34 +07:00
Anna Larch 35969bfaaa fix(filesreport): cast fileId to integer
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-15 19:19:41 +07:00
Anna Larch 1f00cef13a feat(caldav): create subscriptions via occ
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-15 19:11:26 +07:00
Anna Larch 9479ac8376 fix(dav): cast parameters to string
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-15 18:47:59 +07:00
Richard Steinmetz 5afe212103
Merge pull request #47737 from nextcloud/fix/also-allow-unsharing-for-circles
fix(caldav, carddav): also allow unsharing of circle shares
2024-09-10 07:42:17 +07:00
Ferdinand Thiessen 5fc715a9e2
fix: Adjust unit tests and protect against XSS
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-06 17:16:10 +07:00
Camila 0a72756d96
fix(dav): Update 403 error message
* The user should get a more friendly warning when their desktop client version is not supported anymore by the server.
  See #nextcloud/desktop/issues/6273
* Update BlockLegacyClientPluginTest to reflect the new 403 error message.

Signed-off-by: Camila Ayres <hello@camilasan.com>
2024-09-06 17:15:45 +07:00
Anna Larch 17ef20c5f3 fix(dav): also allow unsharing of circle shares
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-05 21:34:20 +07:00
Anna Larch 8af7ecb257 chore: adjust code to adhere to coding standard
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-05 21:23:38 +07:00
Louis Chemineau 9992e7d439
fix(dav): Always respond custom error page on exceptions
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-05 16:17:32 +07:00
Ferdinand Thiessen 08836696e2 fix: Allow read-only filename validation to allow reading files
Needed to read files with the "Windows compatibility" feature.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 17:22:20 +07:00
Ferdinand Thiessen 030c209d22 fix: Renaming does not need update but delete permissions
Renaming is basically copy + delete (a move), so no need to update permissions.
Especially if the node is in a invalid directory the node should be moveable but not editable.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 17:22:20 +07:00
Ferdinand Thiessen 0d41c49918 fix(dav): Pre-check if node can be copied or moved in DAV files plugin
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 17:22:20 +07:00
Robin Appelman 1363e142d8
fix: make preload custom proterties sharding compatible
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:27:14 +07:00
Louis d2c372639c
Merge pull request #47495 from nextcloud/artonge/dept/delegat_is_encrypted_to_e2ee
feat: Delegate is-encrypted handling to the e2ee app
2024-08-27 12:32:40 +07:00
Louis Chemineau ac1d8cdbef
feat: Delegate is-encrypted handling to the e2ee app
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-26 19:45:30 +07:00
Joas Schilling 7a1a0eb7a2
fix(dav): Allow apps to get unshares for DAV resources
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-08-26 18:58:32 +07:00
Daniel Kesselberg af6de04e9e
style: update codestyle for coding-standard 1.2.3
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +07:00
Anna Larch 3ff7d64fda fix(caldav): limit property length
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-08-22 12:15:51 +07:00
Anna Larch 5bbc23a261 fix(caldav): allow renaming of birthday calendars
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-08-20 10:16:57 +07:00
Richard Steinmetz b8ec68d212
Merge pull request #46723 from nextcloud/feat/add-delta-sync-to-subscription-calendars
feat(webcal): only update modified and deleted events from webcal calendars
2024-08-14 08:57:03 +07:00
Christoph Wurst 7641e768b3
Merge pull request #45435 from nextcloud/feat/dav/upcoming-events-api
feat(dav): Add an API for upcoming events
2024-08-14 06:54:43 +07:00
Christoph Wurst 370a9d77ea
feat(dav): Add an API for upcoming events
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-08-13 20:03:31 +07:00
Sebastian Krupinski 4e95ec033d
Merge pull request #47200 from nextcloud/fix/issue-47193
fix: test variables before returning
2024-08-13 13:25:14 +07:00
SebastianKrupinski f807d68511 fix: test variables before returning
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-08-13 09:54:38 +07:00
Richard Steinmetz 82615ce868
fix(caldav): allow VJOURNAL if no supported component set is specified
This is mandated by the RFCs.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-08-13 15:26:17 +07:00
Anna Larch fb94db1cd9 feat(webcal): only update modified and deleted events from webcal calendars
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-08-13 13:05:58 +07:00
hamza221 67957e98b9 fix: handle-duplicate-reminder
Signed-off-by: hamza221 <hamzamahjoubi221@gmail.com>
2024-08-13 11:47:03 +07:00
Ferdinand Thiessen 4bbcbc5206
feat: Make `ISharedStorage` public API and reuse where possible
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-12 11:42:10 +07:00
Ferdinand Thiessen cb1b366baf
fix(dav): Ensure share properties are also set on public remote endpoint
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-12 11:28:03 +07:00
SebastianKrupinski 19ec5985b5 fix(caldav): test for null and blank value
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-08-07 18:56:34 +07:00
John Molakvoæ 07d302d007
Merge pull request #45841 from Vivida1/add-regex-to-match-Gnome-and-KDE-calendar-user-agents 2024-08-07 16:10:18 +07:00
Sebastian Krupinski 4c4e414036
Merge pull request #46623 from nextcloud/fix/issue-44127
fix(caldav): fixed initial sync and double processing
2024-08-07 08:49:34 +07:00
SebastianKrupinski 0df30363a4 fix(caldav): Add sharee to address list when calendar is shared
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-08-06 08:39:24 +07:00
Stephan Orbaugh 5c54a3caa7
Merge pull request #46974 from nextcloud/fix/noid/add-metadata-to-migrationsteps
feat(migrations): add metadata to existing migrations
2024-08-06 13:27:04 +07:00
Richard Steinmetz c283683a08
Merge pull request #46919 from nextcloud/fix/caldav/allow-rooms-resources-principals-listing
fix(caldav): allow listing of room and resource principals
2024-08-05 08:08:41 +07:00
Maxence Lange 726b7a6995 fix(metadata): revert wrongly renamed column
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-08-02 18:37:37 +07:00
Maxence Lange 5e1196095c feat(migrations): add metadata to existing migrations
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-08-02 18:26:12 +07:00
SebastianKrupinski a56d0dbf4b fix(caldav): fixed initial sync and double processing
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-08-01 13:20:47 +07:00
Anna Larch 3776eb4e01 fix(userstatus): add missing parenthesis
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-08-01 15:53:33 +07:00
Richard Steinmetz 74eeff7fbb
fix(caldav): allow listing of room and resource principals
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-07-31 15:47:02 +07:00
provokateurin 9d6221e098
refactor(dav): Replace security annotations with respective attributes
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-28 10:53:14 +07:00
tobiasKaminsky 63d5c2b0e0 fix: https://github.com/nextcloud/calendar/issues/6079 and https://github.com/nextcloud/contacts/issues/3997
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
2024-07-25 15:42:09 +07:00
Robin Appelman 6953be7a01
Merge pull request #46685 from nextcloud/sabre-directory-exception-previous
fix: keep previous exception when wrapping dav exceptions
2024-07-25 14:39:50 +07:00
SebastianKrupinski fc0b694d37 feat: mail provider backend
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-23 16:20:36 +07:00
Robin Appelman d5a2a4aa87
fix: keep previous exception when wrapping dav exceptions
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-23 14:23:26 +07:00
Richard Steinmetz e54d39b076
Merge pull request #45667 from nextcloud/fix/caldav/strict-default-calendar-checks
fix(caldav): stricter default calendar checks
2024-07-23 08:40:50 +07:00
Christoph Wurst f5e9be96ae
fix(dav): Call Sabre server start
exec is deprecated and calls start.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-07-22 19:35:45 +07:00
Richard Steinmetz cbea787233
fix(caldav): stricter default calendar checks
Reject calendars that
- are subscriptions
- are not writable
- are shared with a user
- are deleted
- don't support VEVENTs

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-07-22 15:24:39 +07:00
SebastianKrupinski f00354a276 fix(caldav): added localization hits for translators
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-20 13:42:27 +07:00
Andy Scherzinger 2e273e477a
Merge pull request #46225 from nextcloud/fix/issue-11633
fix(dav): Thrown forbidden error for authenticated user instead of no…
2024-07-19 18:59:58 +07:00
Joas Schilling eeb6ddb176
fix(db): Deprecate `IExpressionBuilder::or()` and `IExpressionBuilder::and()` without parameters
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:16 +07:00
Joas Schilling 829f2b9bc7
fix(db): Promote the use of `getDatabaseProvider` to reduce the impage of removed upstream platforms
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:14 +07:00
Joas Schilling e9bfaf31b8
fix(db): Don't use deprecated 3rdparty constant: `Doctrine\DBAL\Connection::PARAM_STR_ARRAY`
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:13 +07:00
skjnldsv 725736a754 chore(integration): add file request tests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-19 07:35:51 +07:00
skjnldsv f28d933acc feat(files_sharing): add public name prompt for files requests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-18 20:15:39 +07:00
skjnldsv f45d6135d7 feat(files_sharing): allow uploading to subfolders in File requests
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-07-18 19:47:11 +07:00
Anna 5c20c9e4b2
Merge pull request #46594 from nextcloud/fix/issue-28162-2
fix(caldav): decode values before returning
2024-07-18 16:00:05 +07:00
Sebastian Krupinski 31d051ae74
Merge pull request #45547 from nextcloud/feature/recurrence-invitations2
feature: Improved Recurrence Invitations Messages
2024-07-18 06:57:26 +07:00
SebastianKrupinski 43ee948890 feat: Improve recurrence invitations messages
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-17 19:10:32 +07:00
SebastianKrupinski 0f3d05afea fix(caldav): Throw 403 Forbidden Error instead of 500 Internal Server Error
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-17 17:42:35 +07:00
SebastianKrupinski 79c97e7f09 fix(caldav): decode values before returning
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-17 17:34:50 +07:00
Richard Steinmetz 718ef5dea5
Merge pull request #46510 from nextcloud/feat/info-xml-backends
feat: hide caldav server settings if no app uses the caldav backend
2024-07-17 18:57:08 +07:00
Ferdinand Thiessen 322b3946d9
fix(dav): Verify target path in `setName` instead of source path
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-16 12:57:11 +07:00
Richard Steinmetz e42bceac9f
feat: hide caldav server settings if no app uses the caldav backend
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-07-16 09:18:33 +07:00
SebastianKrupinski f5fcfb4670 fix(dav): Thrown forbidden error for authenticated user instead of not found
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-10 17:58:02 +07:00
Sebastian Krupinski fe90956aa4
Merge pull request #46315 from nextcloud/fix/limit-vevent-size
fix(caldav): limit vevent size
2024-07-08 09:10:09 +07:00
Richard Steinmetz 5d2d582a2b
Merge pull request #46295 from nextcloud/chore/remove-obsolete-function-generateVCalendar
chore(caldav): remove obsolete function
2024-07-05 07:52:32 +07:00
SebastianKrupinski 247fbb5538 fix(caldav): limit vevent size
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-04 18:56:27 +07:00
Richard Steinmetz a8e581ca94
Merge pull request #46193 from nextcloud/fix/limit-vcard-size
fix(carddav): limit vcard size
2024-07-05 00:08:14 +07:00
SebastianKrupinski cb6c091e08 fix(carddav): limit vcard size
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-04 16:42:09 +07:00
SebastianKrupinski 65e4d46e2c chore(caldav): remove obsolete function
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-04 03:39:49 +07:00
Hamza Mahjoubi 85a3b27cf9 Fix: Make out of office replacement nullable
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-07-03 12:31:53 +07:00
Daniel 92acbb0d39
Merge pull request #45766 from nextcloud/feat/ooo-replacement
Feat: Allow users to select another user as their out-of-office replacement
2024-07-01 23:25:43 +07:00
Hamza Mahjoubi a9774741e8 Feat: Allow users to select another user as their out-of-office replacement
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-07-01 15:10:16 +07:00
Arthur Schiwon 1d3ff4337e
fix(BuildSocialSearchIndexBackgroundJob): offset not applied
with more than 100 results, this job may never finish

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-07-01 14:31:27 +07:00
Julius Härtl 4d6b4b71c7 fix: Authorization header can be an empty string
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-06-28 14:42:36 +07:00
John Molakvoæ 3e06931408 fix(dav): WebcalCaching-Plugin lint
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-06-27 09:46:40 +07:00
Vivida 58cf14da87 feat(dav): add regex to match Gnome and KDE calendar user-agents
Signed-off-by: Vivida <57828684+Vivida1@users.noreply.github.com>
2024-06-27 09:46:40 +07:00
Sebastian Krupinski 380a253aab
Merge pull request #46036 from nextcloud/fix/issue-46015
fix(dav): add missing database index for dav_shares
2024-06-26 15:03:02 +07:00
SebastianKrupinski ff7e2c1837 fix(dav): add missing database index for dav_shares resourceid, type and access
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com>

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>

Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com>

Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com>

Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com>

Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Sebastian Krupinski <165827823+SebastianKrupinski@users.noreply.github.com>

Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-06-26 14:20:36 +07:00
SebastianKrupinski d7eb509b26 fix(caldav): when message is a reply compare the message sender not the recipient
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-25 16:43:51 +07:00
Daniel 952271929d
Merge pull request #46002 from nextcloud/debt/noid/use-new-http-client
Use guzzle for addressbook federation
2024-06-25 21:10:12 +07:00
Richard Steinmetz 6121325310
Merge pull request #45532 from nextcloud/feat/publish-resources-room-update
feat: implement public OCP api to update resources and rooms
2024-06-25 16:48:30 +07:00
Joas Schilling ad2fa3724d
Merge pull request #46095 from nextcloud/techdebt/44770/migrate-server-notifier-to-new-exceptions
feat(notifications): Migrate server INotifiers to new exceptions
2024-06-25 16:09:38 +07:00
Daniel Kesselberg f73c5c4aa9 chore: don't pass null to createElement
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-25 12:24:47 +07:00
Daniel Kesselberg 1fa37ed2dc refactor(dav): migrate to new http client
The request method is available since 29 and thus we can finally use the modern http client to send the report request for the addressbook sync.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-25 12:24:47 +07:00
Joas Schilling 8130968a35
feat(notifications): Migrate server INotifiers to new exceptions
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-06-25 11:56:24 +07:00
Joas Schilling 2c977d2b6e
fix(userstatus): Fix user status automation in real-life scenario
Order of applying:
- Out-of-office
- Availability
- Call
- Meeting
- User status

Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-06-25 09:29:35 +07:00
Julius Härtl 637a91e767
Merge pull request #45973 from nextcloud/remove-chunking-v1
chore: remove chunking-v1
2024-06-24 09:52:18 +07:00
Richard Steinmetz efe3244acf
Merge pull request #45999 from nextcloud/fix/caldav/shared-calendars-activity-umlauts
fix(caldav): encode calendar URIs with umlauts for activities
2024-06-20 15:44:34 +07:00
Ferdinand Thiessen c251e8f2aa
Merge pull request #45207 from nextcloud/fix/webdav-aja
fix(dav): Try basic auth for ajax WebDAV requests
2024-06-20 12:28:31 +07:00
Richard Steinmetz df28c04a8f
fix(caldav): encode calendar URIs with umlauts for activities
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-06-20 10:56:27 +07:00
Robin Appelman 957a00b9de chore: remove chunking-v1
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-19 16:57:42 +07:00
Christoph Wurst 169eedabf9
fix(dav): Limit number of UPDATES for sync token created_at
Address book and calendar sync tokens have a created_at column in 26+
and we need to assign a current timestamp to the existing data at
upgrade so the data isn't cleaned up immediately. Updating the full
table is expensive and fails on clustered setups that limit transaction
size. We don't need a timestamp for the oldest rows so we can skip
updating them.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-06-19 15:38:36 +07:00
Ferdinand Thiessen 67a0e01382
fix(dav): Try basic auth for ajax WebDAV requests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-18 10:47:11 +07:00
skjnldsv 4a77fe3530 fix(dav): also return shared-with-me shares data
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-06-12 10:27:29 +07:00
Richard Steinmetz 3a975d0a89
fix(caldav): event links in shared calendar notifications
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-06-11 20:08:57 +07:00
Ferdinand Thiessen 9d0200ca6b
Merge pull request #45120 from nextcloud/bugfix/noid/sensitive-dav-forbidden-logging
fix(dav): Don't log access control as error
2024-06-10 11:56:33 +07:00
Anna Larch ad78f7e48e fix(caldav): automatically delete outdated scheduling objects
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-05-31 13:14:01 +07:00
Andrew Summers 7a887b4513 Refactor `OC\Server::getAvatarManager` in dav app
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
2024-05-30 14:14:58 +07:00
Jake Nabasny f863290572
feat(ldap): sync additional properties to profile and SAB
Synced from LDAP to profile:
- Date of birth

Synced from LDAP to SAB (via the profile):
- Biography
- Date of birth

Original code by Jake Nabasny (GitHub: @slapcat)

Co-authored-by: Jake Nabasny <jake@nabasny.com>
Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-05-30 12:01:13 +07:00
Daniel 7f44b9d9d0
Merge pull request #45222 from nextcloud/bug/noid/caldav-search-limit-and-timerange
CalDAV fix search with limit and time range
2024-05-29 16:30:11 +07:00
Andy Scherzinger 5b7dcc1427
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-29 08:58:16 +07:00
Daniel Kesselberg b769dc4304 feat(caldav): order the calendar objects by start date for search
Sorting the events by the start date leads to more predictable results for the search API consumers.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-05-28 19:56:36 +07:00
Daniel Kesselberg 4718a7e4e0 fix(caldav): event search with limit and timerange
Event recurrences are evaluated at runtime because the database only knows the first and last occurrence.

Given, a user created 8 events with a yearly reoccurrence and two for events tomorrow.
The upcoming event widget asks the CalDAV backend for 7 events within the next 14 days.

If limit 7 is applied to the SQL query, we find the 7 events with a yearly reoccurrence and discard the events after evaluating the reoccurrence rules because they are not due within the next 14 days and end up with an empty result even if there are two events to show.

The workaround for search requests with a limit and time range is asking for more row than requested and retrying if we have not reached the limit.

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-05-28 19:56:36 +07:00
Hamza 236c9494c8
Merge pull request #44664 from nextcloud/fix/dav/rate-limit-create-adress-book
fix(dav): Rate limit address book creation
2024-05-28 16:46:05 +07:00
Andy Scherzinger 9d4b944098
chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-27 20:11:22 +07:00
Richard Steinmetz 69e0158030
feat: implement public OCP api to update resources and rooms
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-05-27 18:45:52 +07:00
Hamza Mahjoubi fe780945e2 fix(dav): Rate limit address book creation
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-05-27 14:55:07 +07:00
Jérôme Herbinet 1ffdebd20d fix(dav): Replaces "Time:" with "Date and time:" in calendar invite email
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
2024-05-23 15:37:11 +07:00
Anna Larch de49514fb4 fix(caldav): loop through all events for busy events
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-05-14 14:32:58 +07:00
Daniel Kesselberg e210043ee9
feat(caldav): expose calendar subscriptions
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-05-07 16:03:33 +07:00
Anna Larch e43811d395 fix(userstatus): catch unique constrain violation on revert
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-05-06 17:08:25 +07:00
Sebastian Krupinski c17fcc4881
Merge pull request #45098 from nextcloud/fix/issue-45081
Do not load IMipPlugin before user session is initialized also use userSession instead of userId in constructor.
2024-05-04 09:36:37 +07:00
SebastianKrupinski 51d338b9cc fix(caldav): Fixed formatting to comply with php-cs
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-05-03 09:01:07 +07:00
SebastianKrupinski d25039ec1a fix(caldav): Test if user object is not null and trim senderName
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-05-01 19:51:45 +07:00
SebastianKrupinski f44b73e2db fix(caldav): Use userSession instead of userId
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-04-30 10:30:12 +07:00
Joas Schilling 89bce5c76e
fix(dav): Don't log access control as error
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-30 13:46:50 +07:00
Côme Chilliet d2de3e9981
fix: Fix incorrect phpdoc typing in dav app
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 09:24:00 +07:00
SebastianKrupinski 9859a44908 fix(caldav): Do not load IMipPlugin before user auth and session is created
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-04-29 14:29:17 +07:00
Anna 10af08736e
Merge pull request #44938 from nextcloud/fix/remove-unknown-from-imip-service
fix(CalDAV): remove UNKNOWN from room / resource consideration
2024-04-26 13:16:29 +07:00
Joas Schilling d2c9cf4b5f
fix(DAV): Migrate known exceptions to Sabre exceptions when copying
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-04-24 07:18:47 +07:00
Anna Larch a28f264783 fix(CalDAV): remove UNKNOWN from room / resource consideration
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-04-19 21:22:17 +07:00
Louis Chemineau ac0acfbbd5
feat(dav): Support multiple scopes in DAV search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-04-17 12:33:49 +07:00
Côme Chilliet ab6afe0111 fix: Fix new psalm errors from update
Not sure about the SimpleContainer modification, let’s see what CI says
 about that.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-08 11:29:09 +07:00
Daniel c0d21b4443
Merge pull request #44511 from nextcloud/perf/noid/skip-tree-lookup-for-non-calendar-requests
perf(dav): skip non-calendar requests in webcal caching plugin
2024-04-03 07:44:33 +07:00
Côme Chilliet 9aa7225ed3
Merge pull request #44332 from nextcloud/fix/fix-chunkupload-quota-check
fix(dav): Fix quota check for chunk upload
2024-04-02 17:44:21 +07:00
Côme Chilliet 81319e78bf chore: Improve phpdoc typing to silence psalm errors
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
Côme Chilliet ec5133b739 fix: Apply new coding standard to all files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
Côme Chilliet 516fb702c9 fix(dav): Fix quota check for chunk upload
Do not ignore OC-Total-Length when Content-Length and
 X-Expected-Entity-Length are missing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:13 +07:00
Daniel Kesselberg 4bdb473aae
perf(dav): skip non-calendar requests in webcal caching plugin
The webcal caching plugin is active when the X-NC-CalDAV-Webcal-Caching header is there.

findPrincipalByUrl sends a request for /remote.php/dav/principals/users/admin/ using the caldavService which sets the header by default.[^1]

As X-NC-CalDAV-Webcal-Caching only impacts calendar requests, we can skip non-calendar requests.

[^1]: b3670f1805/src/services/caldavService.js (L43)

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-03-27 20:04:23 +07:00
Robert C. Schaller fa6e6131ee fix(dav): wrong comparison method between two events
Old comparison implementation compares each element of the array against each other with no respect for the associated array label, which leads to wrongful removals because one value is accidentally present in a completely different label. New comparison works 'by-label' individually.

Partly fixes #41084 because changes between 'SEQUENCE' not present, 'SEQUENCE:0' and 'SEQUENCE:1' were not detected in the old implementation and thus no email update sent.

Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com>
Signed-off-by: Robert C. Schaller <gtbc_robert.schaller@rsxc.de>
2024-03-25 13:18:58 +07:00
Christoph Wurst 3dea99f42b
fix(dav): Add retention time to sync token cleanup
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-21 18:37:21 +07:00
Anna bdd4ac2c17
Merge pull request #44360 from nextcloud/fix/add-exdate-exrule-to-confidential-object
fix(caldav): add EXDATE and EXRULE to confidential object
2024-03-21 14:34:08 +07:00
Hamza 007b54afed
Merge pull request #44376 from nextcloud/fix/dav/acls-shared-addressbook
fix(dav): ACLs for shared addressbooks
2024-03-21 14:33:43 +07:00
Christoph Wurst b6e1685683
fix(dav): ACLs for shared addressbooks
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-21 11:50:35 +07:00
Anna Larch a96f8f7fee fix(caldav): add EXDATE and EXRULE to confidential object
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-03-21 10:01:33 +07:00
Côme Chilliet c1b451ea86
chore: Break closure call on two lines to make it readable
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 16:01:25 +07:00
Côme Chilliet fa8efd5df8
fix(systemtags): Forbid tagging of readonly files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-19 16:01:12 +07:00
Côme Chilliet 443b26761d
fix: Migrate WebDAV endpoint check to SetupCheck API
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-14 16:20:17 +07:00
Christoph Wurst f40f962c2e
fix(dav): Add occ command to fix missing caldav sync tokens
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-03-12 12:44:00 +07:00
Maxence Lange f4beb95cdc
Merge pull request #42707 from nextcloud/enh/noid/store-file-etag-at-metadata-creation
enh(metadata): store current file etag
2024-03-11 12:46:29 +07:00
Julius Härtl ca453f5b84
fix: Use proper path when trying to check if a file needs to get copied
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-08 10:02:45 +07:00