Louis
a48bc55e2a
Merge pull request #52810 from nextcloud/artonge/feat/do_not_require_samesite_strict_cookie_on_public.php
2025-05-22 10:30:16 +07:00
Nextcloud bot
f71791bb25
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-05-22 00:22:42 +07:00
Louis Chemineau
009d0c550c
fix: Move CSRF check from base to PublicAuth for public.php
...
This currently prevent directly accessing a ressource when clicking on a link on a third party site. Example, clicking on `https://example.com/public.php/dav/files/pqLWcA269zfzXez/?accept=zip ` in a GitHub comment.
Skipping the check is an issue with password protected shares, as it allows third party sites to request the ressource when the user already entered the password, aka CSRF. So after removing the check from `base.php`, we need to add the it again in the `PublicAuth` plugin.
We also add a redirect to be helpful to the user.
**Warning**: this adds the limitation that clicking on a direct download link for password protected shares will redirect you to the password form, and then to the main share view.
Fix #52482
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-05-21 16:01:36 +07:00
Joas Schilling
ad7a050f96
fix: Revert "fix(db): Store last insert id before reconnect"
...
This reverts commit df94cceb7b .
There were records of some old IDs being read which is much worse
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-21 07:55:42 +07:00
Nextcloud bot
21d79e2308
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-05-21 00:24:39 +07:00
Kate
68b2a6261d
Merge pull request #52943 from nextcloud/feat/http/request-header-attribute
2025-05-20 14:41:34 +07:00
Kate
08b9ecafe5
Merge pull request #52972 from nextcloud/fix/setupmanager/home-root-providers-register-mounts
2025-05-20 14:17:16 +07:00
Kate
95b961c6ad
Merge pull request #52982 from nextcloud/chore/user-mount-events-since
2025-05-20 14:13:43 +07:00
Stephan Orbaugh
edf21d9242
Merge pull request #52859 from Murena-SAS/dev/external-storage-previews
...
fix: Throw exception in PreviewManager when preview is not available
2025-05-20 13:32:45 +07:00
provokateurin
40973ddde0
chore: Set correct version for new UserMount events
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-20 13:13:49 +07:00
provokateurin
ad031188bc
feat(Http): Add RequestHeader attribute
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-20 13:10:34 +07:00
Akhil
e537500c8e
fix: Throw exception in PreviewManager when preview is not available
...
Signed-off-by: Akhil <akhil@e.email>
2025-05-20 13:17:40 +07:00
provokateurin
ecfa58d3d7
fix(SetupManager): Include home and root providers when registering mounts
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-20 09:46:53 +07:00
Joas Schilling
1d8556ecc3
fix(throttler): Don't query bruteforce attempts twice
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-20 08:37:23 +07:00
Nextcloud bot
cc22d74887
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-05-20 00:22:25 +07:00
Elizabeth Danzberger
5c7216f3fd
feat: only load template fields when requested
...
Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
2025-05-19 17:51:25 +07:00
Christoph Wurst
80b21cdc6e
Merge pull request #52879 from nextcloud/bug/noid/clear-dav-photo-cache
...
Add command to clear dav's photo cache
2025-05-19 18:10:07 +07:00
Kate
06ce2ccebe
Merge pull request #50157 from nextcloud/feat/mountmanager/emit-events
2025-05-19 17:47:31 +07:00
Kate
5ba9bc2dd6
Merge pull request #52930 from nextcloud/chore/depreate-oc-helper-ro
2025-05-19 16:36:31 +07:00
provokateurin
6818aa9b12
feat(UserMountCache): Emit events for added, removed and updated mounts
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-19 13:54:51 +07:00
Kate
6b4f5c567c
Merge pull request #52848 from nextcloud/fix/cleanup-servercontainer
2025-05-19 07:02:11 +07:00
Nextcloud bot
b9983cbd42
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-05-18 00:22:42 +07:00
Ferdinand Thiessen
22889d4f1d
chore: deprecate `OC_Helper::isReadOnlyConfigEnabled`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-17 13:18:49 +07:00
Ferdinand Thiessen
e2a331f53d
Merge pull request #52890 from nextcloud/chore/move-stream-copy-implementation
...
chore: move streamCopy implementation from `OC_Helper` to `OCP\Files`
2025-05-17 12:01:44 +07:00
Ferdinand Thiessen
f47c15f61e
Merge pull request #52912 from nextcloud/chore/remove-deprecated-oc-helper
...
chore!: remove legacy functions from `OC_Helper` deprecated before v10
2025-05-17 10:55:09 +07:00
Nextcloud bot
e4e71c073d
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-05-17 00:23:16 +07:00
Ferdinand Thiessen
3d33091d2c
chore!: remove legacy functions from `OC_Helper` deprecated before v10
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 22:57:50 +07:00
Ferdinand Thiessen
bd91db8e20
chore: deprecate OC_Helper::copyr
...
Inline it into Installer as needed.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 17:32:45 +07:00
Ferdinand Thiessen
01db539d0a
chore: move streamCopy implementation from `OC_Helper` to `OCP\Files`
...
The function was already there but called the legacy version.
So moved the implementation and migrated all usages of it.
Sadly the interface was slightly different so adjusted it to be
compatible with both legacy and the OCP one.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 13:03:05 +07:00
Kate
fc9310feef
Merge pull request #52885 from nextcloud/fix/docblock-color
...
fix(OCP\Color): use correct doc block type
2025-05-16 12:41:51 +07:00
Ferdinand Thiessen
802def31f2
chore: move implementation to non-deprecated OCP\Util from OC_Helper
...
Only moves the implementation where it was already existing and adds
more helpful deprecation messages.
This way we can in the future just remove the OC_Helper variants.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-16 10:56:58 +07:00
Côme Chilliet
2406677b40
fix: Do not use circle provider class constant
...
This is to avoid issues if the circles app is disabled but you still
have circles shares in your DB
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-16 10:50:41 +07:00
Côme Chilliet
2419f4bebb
fix: Count on the circles application to register its share provider
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-16 10:49:04 +07:00
Côme Chilliet
369900e5a5
fix: Remove deprecated getters from Server that were previously removed from public interface
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-16 10:49:01 +07:00
Côme Chilliet
eccc727f4e
fix: Remove more unused deprecated getters from IServerContainer
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-16 10:48:05 +07:00
Côme Chilliet
998062d342
fix: Cleanup share ProviderFactory to correctly use DI instead of deprecated getters
...
Ideally circles and talk should migrate to calling registerProvider and
core would not need to use their OCA classes like currently.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-16 10:48:03 +07:00
Côme Chilliet
c3edaeebba
fix: Remove deprecated getters in IServerContainer which are not used anymore
...
For now I left the ones which are called from lib/
Next step is to fix all calls and remove those as well.
Also the getters should be removed from the implementation.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-05-16 10:47:32 +07:00
Christoph Wurst
47c0786a3f
Merge pull request #52871 from AndyXheli/patch-2
...
fix(previews): lower log level when cached preview isn't found
2025-05-16 10:42:51 +07:00
Nextcloud bot
b9480f44dc
fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-05-16 00:22:51 +07:00
Ferdinand Thiessen
aabb4e547a
fix(OCP\Color): use correct doc block type
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 18:35:14 +07:00
Robin Appelman
48e94baeeb
Merge pull request #52873 from nextcloud/cache-rename-source-error
...
fix: improve error message when cache rename source can't be found
2025-05-15 18:34:07 +07:00
Daniel Kesselberg
3d1de793b1
refactor(dav): replace IAppData with IAppDataFactory for PhotoCache
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-15 18:28:45 +07:00
Ferdinand Thiessen
74bded74a3
refactor: migrate from OC to OCP in public interfaces
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 16:17:47 +07:00
Ferdinand Thiessen
b6515f9402
refactor: add missing template implements where needed
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 16:15:13 +07:00
Kate
4aa4972550
Merge pull request #52870 from nextcloud/chore/remove-get-storage
2025-05-15 16:04:45 +07:00
Robin Appelman
5329c373cc
fix: improve error message when cache rename source can't be found
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-15 15:06:55 +07:00
AndyXheli
ecd1d5dde2
fix(previews): lower log level when cached preview isn't found
...
Since this PR #52221 was implemented, the log file has been flooded with warnings stating, "Cached preview not found for file; generating a new preview." This appears to be more of an informational message rather than a warning. This PR will change it from warning to debug
Original PR
#52221
Signed-off-by: AndyXheli <andyxheli@gmail.com>
2025-05-15 07:34:40 +07:00
Ferdinand Thiessen
54eaad76c0
chore!(\OCP\Files): remove deprecated static `getStorage` method
...
Was deprecated since Nextcloud 14 and is not used anymore.
Removing allows us to clean the OCP psalm baseline.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 14:18:28 +07:00
Ferdinand Thiessen
e4ed062d68
fix(RouteParser): bail out if method name contains hashtag
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 13:57:14 +07:00
provokateurin
63ba61487b
chore(AppFramework): Remove unused RouteConfig class and migrate tests to RouteParser
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 13:57:14 +07:00