a3e80e4195
feat: Update supported PostgreSQL versions
...
12 is now EOL but 17 was released and should be supported and tested.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-11-13 02:50:13 +07:00
3e870695bc
feat: mail provider settings
...
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-11-12 13:19:35 +07:00
46abfc6d50
Merge pull request #48792 from nextcloud/chore/update_mysql_setup_check_i18n
2024-11-05 10:06:29 +07:00
25d1628e30
chore(i18n): Fix grammar
...
Reported at Transifex
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-11-03 16:34:57 +07:00
a40f21b4db
chore(setupchecks): update translation for MySQL row format check
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 09:56:02 +07:00
34ade098bd
fix(users): use correct active user count
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 07:53:10 +07:00
a12b4da6af
fix(ci): psalm, suppress undefined for viewApps
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-29 20:54:08 +07:00
e4d586697c
WIP: address review comments, small fixes
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-29 20:54:08 +07:00
3a840c102a
fix(ci): suppress UndefinedClass for AppAPI related classes since it's bundled
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-10-29 20:54:07 +07:00
95b06309f3
feat(app_api): add initial state data for AppAPI UI part
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
# Conflicts:
# apps/settings/lib/Controller/AppSettingsController.php
# Conflicts:
# apps/settings/lib/Controller/AppSettingsController.php
2024-10-29 20:54:05 +07:00
e8dbf022c9
Merge pull request #48919 from nextcloud/fix/settings/userid-dependency-injection
2024-10-28 11:44:16 +07:00
5969b4bea8
fix(appsmanagement): Fix exception on generating preview url for screenshots
...
Some installed apps meant for older server versions might unexpectedly
offer up screenshot values in a non-string format (e.g. health). Avoid
an exception by checking first if the first app screenshot is indeed a
string and otherwise we take the value of the parameter
Signed-off-by: Claudio Cambra <developer@claudiocambra.com>
2024-10-28 08:29:16 +07:00
35d614057c
fix(settings): Fix dependency injection
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-28 08:14:17 +07:00
4c9877c082
fix(settings): Change "setup warnings" -> "setup checks" in Overview
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-10-23 17:31:59 +07:00
6d2c63ecff
fix(settings): Do not use `null` on `string` parameter for sharing disclaimer
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 20:12:32 +07:00
b5ac989ecd
Merge pull request #48854 from nextcloud/fix/proxy-app-screenshot
2024-10-23 17:18:13 +07:00
3b6915e96d
fix(app-store): Also proxy images of locally installed apps
...
Before this only app store apps got their screenshots proxied,
but this will cause locally installed apps to not be correctly shown on the app-store.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 13:36:27 +07:00
9955b13564
fix(app-store): Ensure the `groups` property is always an array
...
If the value was a string, like a single group, then `json_decode` will also yield only a string.
So in this case we ensure the property is always an array with that value.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-23 13:32:36 +07:00
381077028a
refactor(apps): Use constructor property promotion when possible
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-21 12:37:59 +07:00
7e99fd31ea
Merge pull request #48547 from nextcloud/feat/row_format_check
2024-10-18 11:59:58 +07:00
74d179edf3
fix(appstore): Hide last modified information for shipped apps
...
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2024-10-16 23:51:56 +07:00
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-15 10:40:25 +07:00
40823775d9
fix: Fix empty sections appearing in search results
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-10-08 10:57:20 +07:00
f70f70e0db
feat(setupchecks): add row format setup check for MySQL databases
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-08 17:13:30 +07:00
0d6acbf9e4
fix: do not reduce count for subadmins if they are members of group
...
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-10-02 18:32:53 +07:00
54cdd42ba9
Merge pull request #48437 from nextcloud/fix/noid/count-disabled-correct
2024-09-30 11:59:06 +07:00
2b2b4e9e96
fix: correctly count disabled users for subadmins
...
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
2024-09-28 18:46:16 +07:00
b5256181a4
fix(settings): Sort all settings - incl declarative settings - by priority
...
Previously declarative settings were sorted by priority but behind the "native" settings,
this is now fixed, meaning a declarative setting with higher priority than an `ISetting` will
be correctly rendered before that `ISetting` in the settings list.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 14:08:26 +07:00
9bc0aa03b2
fix: Ensure app discover section is returned as list
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-24 12:34:22 +07:00
096f893d46
fix(activity): Update more activity providers to use new exceptions
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-23 12:31:59 +07:00
606241caeb
chore(legacy): Introduce public version ct plass and drop version methods from OC_Util
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-20 14:53:34 +07:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +07:00
e019eae347
fix(setupChecks): Having transactional file locking disabled is not supported
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-09-19 12:50:59 +07:00
26abc86eca
feat: add profile pronouns
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-17 22:20:36 +07:00
f5b73d2c77
fix: Remove legacy settings forms
...
`OC_App::getForms` was always returning an empty array,
because there were no setter for `adminForms` or `personalForms` anymore.
So removed all that legacy settings forms logic.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-17 14:54:39 +07:00
1ce46c1fca
refactor: move to new activity exception
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-17 12:06:24 +07:00
ede0c26b78
Merge pull request #46480 from nextcloud/fix/mailer-binaryfinder-fallback
...
fix(Mailer): Fix sendmail binary fallback
2024-09-16 18:18:14 +07:00
87aa1267a8
fix(Mailer): Fix sendmail binary fallback
...
feat: add debug logging to sendmail binary finder
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-09-16 15:20:29 +07:00
7fbd518452
feat: Make `CheckServerResponseTrait` public and provide as `OCP\SetupCheck\CheckServerResponseTrait`
...
This trait is used by other apps for creating setup checks,
so we should provide it instead apps using private API.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-16 14:58:21 +07:00
c7c031dbd2
fix(a11y): Add OTF font loading check
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-16 09:59:21 +07:00
bcb4e781a4
Merge pull request #47927 from nextcloud/fix/migrate-away-from-oc_app
...
Migrate away from OC_App to IAppManager
2024-09-13 17:44:38 +07:00
be1cd7a308
refactor(settings): `CheckServerResponseTrait` always expect absolute path
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-13 13:09:40 +07:00
9e979d42b4
fix(setup-checks): Ensure URL with webroot works
...
We basically mock the way `URLGenerator::getAbsoluteURL` works,
so we must make sure that the URL might already contain the webroot.
Because `baseURL` and `cliURL` also contain the webroot we need to remove
the webroot from the URL first.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-13 13:06:24 +07:00
7ed583cb8e
chore: Migrate cleanAppId and getAppPath calls to IAppManager from OC_App
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:08:43 +07:00
8af7ecb257
chore: adjust code to adhere to coding standard
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-05 21:23:38 +07:00
c224b8ced4
fix(setupchecks): Test overwrite.cli url first, then generated one, and
...
trusted domains as last fallback.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-05 11:54:45 +07:00
4ce4d7b9b3
fix: add option to remove the webroot for setup checks and don't check trusted_domains.
...
1) The checks for well-known urls should always run against the root domain and therefore the option to remove the webroot.
2) For trusted domains, the available protocol is unknown, and thus some guesswork would be needed to make that work. I've decided for now to not consider them anymore to reduce false-positives.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-09-05 10:30:36 +07:00
c88ae37844
fix(settings): Fix sharing exclude groups from password requirement option not working
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-03 14:28:44 +07:00
f3419c5f57
feat(settings): Add setup check for apcu cache expunge
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-27 10:45:32 +07:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +07:00
04944aaa23
fix(security): Update expiration date in security.txt
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-08-14 09:58:02 +07:00
4673e1a391
Merge pull request #46816 from nextcloud/refactor/settings/security-attributes
2024-08-14 09:38:08 +07:00
0563757ea4
fix(SetupCheck): Properly check public access to data directory
...
When checking for public (web) access to the data directory the status is not enough
as you might have a webserver that forwards to e.g. a login page.
So instead check that the content of the file matches.
For this the `.ncdata` file (renamed from `.ocdata`¹) has minimal text content
to allow checking.
¹The file was renamed from the legacy `.ocdata`, there is a repair step to remove the old one.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 22:08:42 +07:00
4488714148
Merge pull request #46353 from nextcloud/skipOPcacheCLI
...
fix(setupchecks): Skip checking for OPcache settings if running checks from CLI
2024-08-01 20:02:25 +07:00
cf4326539e
fix(AdminSettings/AI): show pref list of only the enabled translation providers
...
Signed-off-by: Anupam Kumar <kyteinsky@gmail.com>
2024-08-01 13:36:37 +07:00
f012c996ee
refactor(settings): Replace security annotations with respective attributes
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-27 22:49:43 +07:00
2ddfbf3e79
Merge pull request #45092 from nextcloud/fix/user-provider-search-shown
2024-07-24 16:38:13 +07:00
7266a9ef33
Merge pull request #46418 from nextcloud/artonge/feat/user_admin_delegation
...
feat(users): Add users and group management to admin delegation
2024-07-24 11:15:54 +07:00
b37fb43a32
feat: let users configure their first day of week
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-07-22 22:35:46 +07:00
3574d7eec8
feat(users): Enable features for delegated user admins
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-22 19:58:44 +07:00
dff8815449
feat(users): Add support for admin delegation for users and groups management
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-22 17:17:35 +07:00
047479ccf9
feat(security): Add public API to allow validating IP Ranges and checking for "in range"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +07:00
202e5b1e95
feat(security): restrict admin actions to IP ranges
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +07:00
7cb67c67c7
Merge pull request #46509 from nextcloud/feat/settings/taskprocessing
...
feat(settings/admin/ai): Add Task Processing API settings
2024-07-17 18:24:11 +07:00
9dca5ae0e0
feat(settings/admin/ai): Add Task Processing API settings
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-17 15:24:19 +07:00
2201bce7d3
fix(caldav): lower scheduling table size warning
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-07-17 11:20:49 +07:00
e8cacc50a2
chore(settings): Rename user groups
...
- "Active accounts" -> "All accounts"
- "Recent accounts" -> "Recently active"
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-11 11:19:09 +07:00
51e9651436
chore(l10n): Translate group names
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-11 11:19:09 +07:00
07319a118b
feat: Add Recent accounts section
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-07-11 11:19:09 +07:00
fa84f52c3f
fix: typo
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 15:11:35 +07:00
372c9d2ee6
fix: check both CLI and value
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 15:09:29 +07:00
39f052407a
fix(setupchecks): Skip checking for OPcache if running from CLI
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-07-08 10:43:20 +07:00
8fc498fb82
fix(IntegrityCheck): Ensure the check is run if no results are available
...
If there are no cached results the current implementation was also returning an empty array,
but this was the same as when there was a successful run.
So to distinguish this we return `null` if there are *no* results.
In this case we need to rerun the integrity checker.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-03 11:37:49 +07:00
682faad0b3
Merge pull request #46009 from nextcloud/refactor/ajax-cron
...
refactor(cron): Use `IAppConfig` for cron settings and migrate ajax cron away from jQuery
2024-06-29 16:29:34 +07:00
02983f3317
Merge pull request #46190 from nextcloud/bug/45047/skip-check-when-disk-free-space-disabled
...
fix(setupchecks): skip check when disk_free_space is disabled
2024-06-29 15:59:17 +07:00
14778811b4
refactor: Use `IAppConfig` for setting cron type
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-28 18:00:39 +07:00
fd9fd1b6fb
fix(setupchecks): skip check when disk_free_space is disabled
...
Make it easier to discover that the check failed because disk_free_space is disabled.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-06-28 13:06:49 +07:00
6601adcd6d
refactor(SetupCheck): Make mariadb and mysql version variables
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 16:22:42 +07:00
6e48ca1cf8
fix(settings): Adjust SetupCheck for supported database versions
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-06-27 16:15:16 +07:00
ea994fe8fb
fix(settings): make trailing slash for caldav/carddav redirects optional
...
#43939 moved the CalDAV/CardDAV redirect checks from the frontend to a new backend API.
Since the backend does not send an authentication header, checking for the expected response code 207 of the DAV endpoint does not work anymore, hence the URL of the last redirect is checked instead.
This URL is expected to contain a trailing slash, which was not required before, since the DAV endpoint works properly without it (when authenticated).
While a trailing slash in the redirect does no harm, it causes many setups to throw an admin panel warning, while in fact the redirects work properly. Furthermore, the proposed "/.well-known/carddav" => "/remote.php/dav/" redirect leads to double slashes, when doing a request to "/.well-known/carddav/", which seems more wrong then right.
This change makes the trailing slash optional, hence old and adjusted setups won't throw the warning anymore, and the DAV endpoint works well in both cases.
Signed-off-by: MichaIng <micha@dietpi.com>
2024-06-24 17:52:22 +07:00
e74f71b32e
feat: add setup check for needed mimetype migrations
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-06-18 14:46:19 +07:00
98b5cdc43d
Merge pull request #43942 from nextcloud/fix/43612/avoid-pwd-confirm-sso
...
fix(Session): avoid password confirmation on SSO
2024-06-07 11:25:36 +07:00
f6d6efef3a
refactor(Token): introduce scope constants
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-06-05 19:01:14 +07:00
ec5b60af28
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-03 20:33:31 +07:00
ad78f7e48e
fix(caldav): automatically delete outdated scheduling objects
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-05-31 13:14:01 +07:00
f863290572
feat(ldap): sync additional properties to profile and SAB
...
Synced from LDAP to profile:
- Date of birth
Synced from LDAP to SAB (via the profile):
- Biography
- Date of birth
Original code by Jake Nabasny (GitHub: @slapcat)
Co-authored-by: Jake Nabasny <jake@nabasny.com>
Co-authored-by: Richard Steinmetz <richard@steinmetz.cloud>
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-05-30 12:01:13 +07:00
e1331d9edc
fix:Ensure security.txt file ends with a newline character
...
Signed-off-by: Archisman Das <archisman.officials@gmail.com>
2024-05-27 09:36:39 +07:00
c31d6b1fdc
Merge pull request #45262 from nextcloud/check-HttpsUrlGeneration
...
fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check
2024-05-13 12:06:21 +07:00
99f89bb3de
Merge pull request #45242 from nextcloud/check-memcache-memcached
...
fix(setupCheck): Only warn when memcache present w/o memcached
2024-05-13 11:53:27 +07:00
ef320200b9
fix: Move hint about firewall issues to common helper string
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-05-13 09:27:19 +07:00
a5fc9b1563
Merge pull request #45272 from nextcloud/check-db-missing-indices
...
feat(SetupChecks): Refactor DatabaseHasMissingIndices
2024-05-13 07:55:39 +07:00
5b5178abe7
fix(SetupChecks): Detect CLI mode in HTTPS / URL generator check
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-12 18:09:36 +07:00
229e5444c9
feat(SetupChecks): Refactor DatabaseHasMissingIndices
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-11 10:29:42 +07:00
29157149c8
fix: oops vendor string embedded in version
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 +07:00
2e94ec8832
fix: only compare major version of pgsql
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 +07:00
3ce8c6d0db
fix: refactor postgresql check to match mariadb/mysql
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 +07:00
f486be8da1
fix: only compare minor mariadb version differences
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 +07:00
2abd67cc02
fix(setupChecks): update db version checks
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-10 16:41:29 +07:00
c0e395cc0d
fix(setupCheck): Only warn when memcache present w/o memcached
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-05-09 11:45:16 +07:00
37262c860a
fix(setupchecks): Fix opcache buffer check
...
This was broken by last codestyle update, maybe even before because of
operator precedence. Now using vars to make it readable and correct at
the same time.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 09:23:59 +07:00
efea956c64
fix(search): show user search provider for deactivated and admin pages
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-04-29 11:47:48 +07:00
2b04a80f90
feat: Add legal notice and privacy policy links to help page
...
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2024-04-22 15:19:59 +07:00
733a818139
fix: Migrate a few more classes away from OC_App::getAppPath
...
Also fixed AppTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-22 12:19:01 +07:00
9ef70f0c4e
feat: drop support for php 8.0
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-04-08 11:28:54 +07:00
f63c0cf921
Merge pull request #44306 from nextcloud/settings/show-indextoreplace-warning
...
fix(settings): show warning for indexToReplace as part of missing indices
2024-04-05 13:14:43 +07:00
66fad4ae93
fix(SetupChecks): Add hint about dns/firewall if `mjs` check can't run
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-04-02 18:10:22 +07:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
b08563df32
fix(security): Update expiration date in security.txt
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-03-28 11:20:58 +07:00
5453c1d7fa
feat(settings): Allow to sort groups in the account management alphabetically
...
We can do this purly in the frontend - but when enforced from the backend using the existing system config,
we need to follow the requirement. We then show a warning about the configuration.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-27 12:04:03 +07:00
14addf3fdb
fix(settings): Also verify that `trusted_proxies` only contains IP addresses (with range)
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-26 14:50:57 +07:00
33a0aa6994
fix(settings): show warning for indexToReplace as part of missing indices
...
Signed-off-by: Johannes Merkel <mail@johannesgge.de>
2024-03-19 11:44:00 +07:00
bae133bf4f
fix(AppDiscoverFetcher): Do not remove entries as expired that have no expiry date
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-19 09:36:06 +07:00
0fa9f3049f
feat(files_sharing): allow to specify allowed groups to share instead of excluded groups
...
Relates to #3387
Signed-off-by: Corentin Damman <c.damman@intopix.com>
2024-03-15 16:52:59 +07:00
ba94de2510
fix: when no AI setting has been set, make sure the selected text processing provider is the same as the one that will be used
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-03-15 13:17:29 +07:00
df502c114d
feat(settings): Cache app discover images to ensure privacy of users
...
Co-authored-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-14 20:45:25 +07:00
f4efb762ec
feat: Allow to fetch app discover json and provide frontend API route
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-14 20:45:24 +07:00
d435f0c3d3
Merge pull request #44067 from nextcloud/fix/migrate-header-check-to-setupcheck
...
Migrate header check to setupcheck API
2024-03-14 14:39:35 +07:00
6278cf181e
fix: Improve HSTS warning wording as suggested by reviewer
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-14 11:49:47 +07:00
002fda62f1
fix(settings): `posix_getpwuid` can return `false` which should not be accessed using array operation
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-13 16:13:03 +07:00
9f819f311f
feat: Migrate HSTS check to Security headers SetupCheck
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +07:00
d7193ef65e
fix: Migrate security headers check tests and fix the SetupCheck implementation
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +07:00
310377e496
fix: Fix Security headers setup check behavior
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +07:00
1fffdf4763
fix: Fix ocm-provider setup check failure detection
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +07:00
a47a1e6249
feat: Migrate header check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-03-13 12:49:52 +07:00
519e434573
fix(updatenotification): spread the use of new appconfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-03-13 02:22:11 +07:00
865fd3ba08
fix: add missing copyrights and strict types
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-03-12 18:14:40 +07:00
4ac2375ca2
feat: Add declarative settings
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-03-12 13:56:54 +07:00
58f57fd13f
fix(settings): Adjust order of parameters for `runRequest`
...
Fixing invalid request to host `HEAD`.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-08 11:21:51 +07:00
1ea88a73f6
feat(settings): Migrate .well-known URL setup check to new API
...
Co-authored-by: Côme Chilliet <come.chilliet@nextcloud.com>
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-03-07 14:06:08 +07:00
a6a962d5a2
fix(settings): adjust source maps setup check wording and log level
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-03-06 15:11:32 +07:00
f0494e2b5a
feat(settings): add JavaScript Source Maps support `.js.map` setup check
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-03-06 11:16:10 +07:00
5794e1c9d6
Merge pull request #43906 from nextcloud/enh/migrate-ssl-url-setupcheck
...
feat(settings): Migrate SSL access and URL generation check to SetupCheck API
2024-03-04 15:54:47 +07:00
ef2c312b18
feat(settings): Migrate data directory protection check to `SetupCheck`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-29 13:54:01 +07:00
ca246dc35c
feat(settings): Migrate SSL access and URL generation check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-29 12:21:36 +07:00
ad747ab62b
feat(settings): Migrate OCM / OCS provider tests to SetupCheck
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-27 14:52:10 +07:00
a72706f1e6
Merge branch 'master' into fix/pages-titles-apps
...
Signed-off-by: Andrii Rublov <github.a@rublov.me>
2024-02-25 13:48:38 +07:00
b080113fdd
Merge branch 'master' into fix/42480/user-admin-not-admin
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-02-24 19:31:22 +07:00
00386a5407
fix(settings): Use initial state instead of custom state for server data
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-23 21:59:02 +07:00
dd7fba2c95
fix(settings): Only use `id` in categories - drop duplicated `ident` property
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-23 21:59:02 +07:00
8d22d341c8
[Bugfix]: Titles of pages (dashboard, apps-settings, users-settings) #43327
...
Signed-off-by: Andrii Rublov <airublev@outlook.com>
2024-02-23 18:39:23 +07:00
c98b0462e3
fix(admin role): fix old and wrong way to determine whether user is admin
...
- fixes Settings knowing who is an admin of non-local group backend groups
- obsoletes and removes a little old, deprecated code
- double checks proper parameter type on Group\Manager::isAdmin
- also fixes legacy OC_User code to check whether user is an admin
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-02-19 18:57:22 +07:00
398b042af7
enh(settings): Migrate WOFF2 loading check to a SetupCheck
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-15 02:17:20 +07:00
096d66edc8
enh(settings): Add trait for setup checks that need to access the webserver using HTTP requests
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-02-15 02:17:16 +07:00
524ed97d62
fix: replace `Account name` by `Login`
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:08:10 +07:00
839ddaa354
feat: rename users to account or person
...
Replace translated text in most locations
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +07:00
9228adba73
do not break personal settings page is viewer is not there
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2024-02-09 12:28:06 +07:00
303e2febc7
Merge pull request #43387 from nextcloud/fix/migrate-away-from-ilogger-in-jobs
2024-02-08 18:27:44 +07:00
898df41de9
Revert "Merge branch 'master' of github.com:nextcloud/server"
...
This reverts commit d9d60238c7ba3fdb0cdc
2024-02-08 15:31:19 +07:00
ca5f7adebc
Merge pull request #43435 from nextcloud/enh/noid/do-not-break-personal-settings-without-viewer
...
do not break personal settings page is viewer is not there
2024-02-08 14:39:18 +07:00
686e2683ed
fix psalm
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2024-02-08 14:12:28 +07:00
166773879b
fix!: Migrate jobs away from deprecated interfaces
...
BREAKING CHANGE: Removed ILogFactory::getCustomLogger deprecated method
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-08 10:28:29 +07:00
b0c57ed65f
do not break personal settings page is viewer is not there
...
Signed-off-by: Simon L <szaimen@e.mail.de>
2024-02-07 14:29:22 +07:00
618fae7759
Merge pull request #43215 from nextcloud/rakekniven-patch-3
...
fix(i18n): Adapted spelling of Unicode
2024-02-01 11:07:46 +07:00
9af96d9f9a
feat(php,vue): Create a new parameter
...
Signed-off-by: Baptiste Fotia <fotia.baptiste@hotmail.com>
2024-01-31 10:44:40 +07:00
8663da1e50
fix(i18n): Adapted spelling of Unicode
...
Reported at Transifex
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-01-30 16:54:21 +07:00
8bcc2d352e
chore: Fix missing template parameter for IEventListener
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 10:57:15 +07:00
cff36b7156
Merge pull request #42331 from nextcloud/fix/auth-token-settings
...
fix(settings): Disable renaming for tokens marked to be wiped
2024-01-29 18:47:19 +07:00
d49b70773b
fix(settings): Disable renaming for tokens marked to be wiped
...
This otherwise a WipeException will be thrown when trying to rename
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-29 13:53:45 +07:00
936c6a2928
Migrate debug mode check to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-29 10:11:03 +07:00
3be505f9c2
Rename to "Push service" and enable on all instances to avoid trouble
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 15:23:54 +07:00
67541f21f6
Migrate fair use of free push service check to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 13:05:59 +07:00
9add64f30e
Merge writable temporary space check with the s3 one, and improve
...
It will now show available space and path of both PHP and Nextcloud
temporary directories if they differ.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 11:47:30 +07:00
ccbc5fc273
Remove old version of temporary space setup check and fix tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 11:47:29 +07:00
058f7d5664
Migrate available temp space check to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-25 11:47:29 +07:00
10664e9529
Migrate MySQL utf8mb4 check to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-23 17:34:04 +07:00
4dc224fa2c
Merge pull request #42999 from nextcloud/fix/mjs-setup-check-local
2024-01-23 15:13:24 +07:00
c43144fc7d
Remove bz2 leftover description
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:56:40 +07:00
f13b2fb103
Add missing recommended modules gmp and bcmath
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:08:59 +07:00
4c34216305
Fix description for exif PHP module
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:07:37 +07:00
ca3e1a531a
Merge gmp and bcmath module checks with the existing PHP modules setup check
...
Also add description for why each module is recommended
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-22 15:07:21 +07:00
d51522750e
Merge pull request #42821 from J0WI/rm-bz2-check
...
Remove disputed bz2 check
2024-01-22 11:11:36 +07:00
d2cb90bda2
fix(settings): Allow to connect to local address when checking for `.mjs` support
...
Also reduce the severity in case of a failed check to warning.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-21 20:20:53 +07:00
b64ab5fba8
refactor: Migrate IgnoreOpenAPI attributes to OpenAPI
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-01-18 16:14:17 +07:00
a77bab2f95
Migrate set_time_limit setup check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-18 12:36:53 +07:00
1334055ab8
Merge pull request #42812 from nextcloud/enh/migrate-memcached-setupcheck
...
Migrate memcached PHP module setup check to new API
2024-01-18 12:23:02 +07:00
5ad549a72f
Migrate memcached PHP module setup check to new API
...
Merged it with the other existing memcache setup check as it fits
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-18 09:40:43 +07:00
b09fa57c16
fix(i18n): Change cli to uppercase
...
Like all other occurences.
Reported at Transifex.
Signed-off-by: rakekniven <2069590+rakekniven@users.noreply.github.com>
2024-01-18 09:18:05 +07:00
0e889da4a8
Remove obsolete check of curl SSL version
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 16:14:40 +07:00
46ebe16c83
Migrate Cron checks to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 10:49:19 +07:00
0483064f07
Migrate overwrite.cli.url setup check to new API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-16 09:05:40 +07:00
80d58f0162
Merge pull request #41312 from nextcloud/feat/migrate-code-integrity-check
2024-01-16 09:04:24 +07:00
1cb7ccfb45
Remove disputed bz2 check
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2024-01-15 23:45:47 +07:00
265e9060f8
Merge pull request #42436 from nextcloud/enh/add-mjs-setup-check
...
enh(settings): Add SetupCheck to ensure webserver correctly serves `.mjs` files
2024-01-15 18:21:42 +07:00
24f8b04908
Remove CSRF check from code integrity rescan
...
Did not find a way to get a valid token from SetupCheck
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:48 +07:00
1c4d43923a
Use highlight rich objecttype to render links in CodeIntegrity setup check
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:48 +07:00
f06b8da249
Migrate code integrity to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-15 11:50:38 +07:00
09ee265353
Add missing ProviderWithId check
...
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2024-01-14 17:58:00 +07:00
2df26608ef
Merge pull request #42649 from nextcloud/enh/machine-translation-provider-with-id
2024-01-11 21:50:50 +07:00
f789732922
Merge pull request #42640 from nextcloud/fix/fix-authentication-exceptions-2
...
Always catch OCP versions of authentication exceptions
2024-01-11 18:51:43 +07:00
8fc39aeb1c
Use IToken from OCP instead of OC
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +07:00
95ea6188dc
Suppress or fix psalm errors related to InvalidTokenException
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +07:00
eee9f1eec4
Always catch OCP versions of authentication exceptions
...
And always throw OC versions for BC
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 14:02:15 +07:00
d1f2add10c
Migrate PHP imagick module check to new SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-11 11:28:59 +07:00
c5fbd969dd
Update apps/settings/lib/SetupChecks/JavaScriptModules.php
...
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-10 11:58:51 +07:00
995b23e818
enh(settings): Add SetupCheck to ensure webserver correctly serves `.mjs` files
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-01-10 11:58:51 +07:00
1fd0c2979e
enh(OCP\Translation): Add ITranslationProviderWithId
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-01-10 11:16:14 +07:00
2c815256f2
Merge pull request #42590 from nextcloud/add-settings-section-type-attribute
...
Add settings section type attribute on settings app-content section
2024-01-10 09:23:26 +07:00
3d4c4f19b4
Migrate app dir owner check to SetupCheck API
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 17:37:14 +07:00
94d0399229
Improve PHP opcache setup check and reduce level in some cases
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 16:03:53 +07:00
c92fbca6e6
Fix small psalm issue
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-08 15:09:09 +07:00
Ferdinand Thiessen
SebastianKrupinski
Benjamin Gaussorgues
rakekniven
Andrey Borysenko
Kate
Claudio Cambra
provokateurin
Josh
Marcel Müller
Côme Chilliet
Christopher Ng
Maksim Sukharev
Joas Schilling
Julius Knorr
John Molakvoæ (skjnldsv)
Anna Larch
Robin Appelman
Côme Chilliet
Daniel Kesselberg
Git'Fellow
Anupam Kumar
Louis
Richard Steinmetz
Marcel Klehr
MichaIng
Arthur Schiwon
Andy Scherzinger
Jake Nabasny
Archisman Das
Johannes Merkel
Corentin Damman
Julien Veyssier
Maxence Lange
jld3103
John Molakvoæ
Andrii Rublov
Andrii Rublov
Vincent Petry
Simon L
Baptiste Fotia
J0WI
Joas Schilling