Commit Graph

5929 Commits (315c0ea59c8fe73bc413e5a915d41b768f67e26f)

Author SHA1 Message Date
Côme Chilliet 315c0ea59c
fix: Allow hyphen in appid
It’s rare but exists for some apps not in the appstore.
Also added unit tests for cleanAppId and fixed small issues with it.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-09-22 10:03:08 +07:00
Marcel Klehr 62e63730df fix(TaskProcessing): Cache task types by user language
fixes https://github.com/nextcloud/assistant/issues/357

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-09-18 09:36:19 +07:00
SebastianKrupinski e25d0dbf2d fix: aliases and capitalization of emails
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-09-16 22:05:47 +07:00
Andy Scherzinger 26f455b178
Merge pull request #55126 from nextcloud/backport/55122/stable31
[stable31] fix: Dispatch favorite event with an actual path
2025-09-15 18:46:43 +07:00
Louis Chemineau 939e08895f
fix(TagsTest): Declare `rootFolder` property
It was not caught by the CI on master, but is blocking in the backports.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-09-15 17:09:11 +07:00
Louis Chemineau d7775cba6a
fix: Dispatch favorite event with an actual path
The `$path` argument was added in https://github.com/nextcloud/server/pull/48612, but was never actually used by the callers. The path was therefore missing in the favorite/unfavorite events, which lead to a broken activity information.

I also added a fallback to handle `addToFavorites` and `removeFromFavorites`, which are part of a public API, and are calling `tagAs` and `untag` without `$path`.

Fix https://github.com/nextcloud/activity/issues/2134

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-09-15 16:52:28 +07:00
Carl Schwan 47ce9c4c7b fix(auth): Fix invalid unique constraint violation catch
UniqueConstraintViolationException is no longer throw but instead a
OCP\DB\Exception is.

Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-09-15 13:37:35 +07:00
Côme Chilliet ae080bf8d8 fix(tests): Fix fopen in mock returning null which is not a valid return
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-08-26 08:42:58 +07:00
Joas Schilling 953a55c1db ci: Update testing certificates that expired after 10 years
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-08-25 11:18:59 +07:00
Misha M.-Kupriyanov 815003676e test(SearchComposerTest): add unit test for getProviders with mixed order values
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
2025-08-14 13:03:12 +07:00
Misha M.-Kupriyanov 407f7a1c74 test(SearchComposerTest): add unit tests for getProviders with allowed providers restriction and empty configuration
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
2025-08-14 13:03:12 +07:00
Misha M.-Kupriyanov 291c35cc47 test(SearchComposerTest): add test for provider icon generation
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
2025-08-14 13:03:12 +07:00
Misha M.-Kupriyanov dae4cfbd21 test(SearchComposerTest): add unit test for getProviders with multiple providers
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
2025-08-14 13:03:12 +07:00
Misha M.-Kupriyanov 09172cfe69 test(SearchComposerTest): add test for handling unknown search provider
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
2025-08-14 13:03:12 +07:00
Misha M.-Kupriyanov 5339e6115a test(SearchComposerTest): add unit tests for SearchComposer
Signed-off-by: Misha M.-Kupriyanov <kupriyanov@strato.de>
2025-08-14 13:03:12 +07:00
Stephan Orbaugh b09dfb03b7
Merge pull request #54252 from nextcloud/backport/54203/stable31
[stable31] fix: fix oci string length with empty strings
2025-08-07 15:21:33 +07:00
Marcel Müller 5e6532d467 feat: Cache user keys
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de>
2025-08-05 19:05:14 +07:00
John Molakvoæ 2792cd8c60
Merge pull request #54130 from nextcloud/backport/51602/stable31 2025-08-05 15:05:17 +07:00
Robin Appelman 4560a512b8 fix: fix oci string length with empty strings
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-08-05 10:19:00 +07:00
Côme Chilliet 8de6b95152 chore(tests): Adapt DefaultShareProviderTest to new constructor parameter
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-07-29 09:16:20 +07:00
Daniel Kesselberg 9f8064aae2 fix(imip): group messages by logging principal and uri as context
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-07-23 09:21:29 +07:00
Maxence Lange 4348217b47 feat(appconfig): add searchKeys()
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-07-21 10:27:50 +07:00
Kate 20b41645e6
Merge pull request #53843 from nextcloud/backport/53109/stable31 2025-07-11 09:08:52 +07:00
skjnldsv 13253f5ede fix(systemtags): case-insensitive search & prevent duplicates
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-07-10 08:50:23 +07:00
諏訪子 df78886ae7 fix(settings): fix test
Signed-off-by: 諏訪子 <suwako@076.moe>
2025-07-07 10:02:19 +07:00
諏訪子 8f0f6e6aac fix(settings): change Mastodon only URI to webfinger
Signed-off-by: 諏訪子 <suwako@076.moe>
2025-07-07 10:02:19 +07:00
Jana Peper 3f176632b2
test: fix tests
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2025-07-03 11:37:48 +07:00
Richard Steinmetz a402a84544
fix: revive always storing lowercased email addresses
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-06-24 14:24:48 +07:00
Arthur Schiwon 6e9bccddf4
fix: unbloc ffmpeg on some broken videos
Co-authored-by: Joas Schilling <coding@schilljs.com>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2025-06-12 11:58:47 +07:00
Robin Appelman 5f45b4f5fc test: add test that object store folder copy preserves folder size
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-06-02 09:56:30 +07:00
provokateurin 29d69826b6 feat(UserMountCache): Emit events for added, removed and updated mounts
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-25 16:46:53 +07:00
Joas Schilling 9d471877ae
test: Speed up comments test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-05-21 08:30:28 +07:00
Daniel Kesselberg b422189843 fix: log requests exceeding the rate limiting
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-05-16 17:54:27 +07:00
Kate 3f2fee08ca
Merge pull request #52823 from nextcloud/backport/52775/stable31 2025-05-16 10:01:43 +07:00
SebastianKrupinski 5efb381f9e fix: check if properties exist before using them
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2025-05-15 09:35:06 +07:00
Robin Appelman 66362e6b51 test: add test for nested cache jail unjailedroot
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-05-15 14:57:05 +07:00
provokateurin 8c4b6b9748
perf(Share20): Add interface to query all shares in a folder without filtering by user
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-12 14:55:39 +07:00
Louis Chemineau bea982dfd5 fix(blurhash): Use preview API to generate the previews
This allows to benefit from all the checks done by the preview API.
This also use the newly introduced `cacheResult` argument to limit disk usage.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-05-06 12:19:35 +07:00
Joas Schilling cf4e784818 fix(navigation): Fix default app entry registered as closure
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-28 14:54:35 +07:00
nfebe 73c447027e refactor: Thumbnail Generator logging and tests
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-04-24 08:49:16 +07:00
Maxence Lange e82cdba53f fix(federation): allows equal signs in federation id
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-04-23 19:23:52 +07:00
Ferdinand Thiessen 1be7c65047
Merge pull request #52233 from nextcloud/backport/52223/stable31
[stable31] feat(security): add configurable IPv6 subnet for BFP and throttling
2025-04-23 13:54:15 +07:00
nfebe 84469a42af feat: add logging to preview generation
Signed-off-by: nfebe <fenn25.fn@gmail.com>
2025-04-22 23:43:58 +07:00
Joas Schilling 9821d3d20a
Merge pull request #52256 from nextcloud/backport/52224/stable31
[stable31] fix(usermanager): Don't throw when checking if a too long user id is an existing user
2025-04-21 14:20:18 +07:00
Joas Schilling c34a5d2f6e fix(usermanager): Don't throw when checking if a too long user id is an existing user
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-04-17 14:55:12 +07:00
Ferdinand Thiessen dada9b5c1c fix(mail): use matching text color for primary elements
when we use the default primary as background color we have to use the
default primary text color as well.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-17 10:43:58 +07:00
Benjamin Gaussorgues a8bcff1388 feat(ip): add configurable IPv6 subnet for BFP and throttling
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-04-17 07:03:46 +07:00
Louis Chemineau 27ed921ad5 fix: Transfer ownership with S3 as primary
When using S3 as primary storage, transferring ownership with the `--move` option fail with the following error:

`SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '8-45b963397aa40d4a0063e0d85e4fe7a1' for key 'fs_storage_path_hash'`

The `--move` option moves the entire home folder from one account to another.
The error means that the move failed because the destination folder already exist in `oc_filecache`.

- With S3 as primary storage, folders only exists as entries in `oc_filecache`.
- With S3 as primary storage, `moveFromStorage(...)` only moves the cache entry, as nothing needs to be moved on disk. This cache move does not delete potentially pre-existing destination folder.
- With Local storage, `moveFromStorage(...)` calls `rename(...)` which delete pre-existing folder.

- `transfer(...)`: 687a4d9ac7/apps/files/lib/Service/OwnershipTransferService.php (L112)
- `oneTimeUserSetup(...)`: 687a4d9ac7/lib/private/Files/SetupManager.php (L261-L262)
- `mkdir(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L91-L135)
- `moveFromStorage(...)`: 687a4d9ac7/lib/private/Files/ObjectStore/ObjectStoreStorage.php (L635-L636)

Delete pre-existing folder in `moveFromStorage(...)`

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-04-16 10:19:17 +07:00
Joas Schilling 0c3c61c4be
Merge pull request #52068 from nextcloud/backport/52066/stable31
[stable31] fix(federation): Don't load the addressbook when resolving a cloud ID
2025-04-11 13:44:22 +07:00
John Molakvoæ e75f3df9a1
Merge pull request #52078 from nextcloud/backport/52075/stable31 2025-04-11 13:29:53 +07:00