425e0c3660
test(View): Copy preserves content
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-03 18:29:32 +07:00
199b0bd4d9
fix(files): Correctly copy the cache information on copy operations
...
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-03 17:04:44 +07:00
dd101dd0f7
Merge pull request #49515 from nextcloud/bugfix/noid/boolean-false-in-multipart-form-data
...
fix(controller): Fix false booleans in multipart/form-data
2024-11-28 14:46:16 +07:00
1909b981a4
fix(controller): Fix false booleans in multipart/form-data
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-28 12:18:30 +07:00
379f575c25
Merge pull request #49493 from nextcloud/artonge/feat/pwd_confirmation_allow_set_period
2024-11-28 11:58:02 +07:00
512f3caf57
test:(PasswordConfirmationMiddleware): Fix constructor call
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-11-28 11:05:10 +07:00
1323e5bcb1
fix(migration): Decrypt ownCloud secrets v2
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-11-28 09:00:33 +07:00
c2ca99e2f6
fix(Share20\Manager): Ensure node is still accessible when checking share
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +07:00
c378e74017
feat(Share20\Manager): Return all shares on IShareOwnerlessMount
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +07:00
a978e0a806
fix(Share20\DefaultShareProvider): Return link shares in getSharesByPath()
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +07:00
f9cda54cbf
fix: Wrap partial cache entry in CacheEntry
...
Because it is returned here: 7b7d07c575/lib/private/Files/Cache/Cache.php (L136-L137)df95bf6ba8/lib/Mount/RootEntryCache.php (L23-L28)
2024-11-21 17:13:24 +07:00
e4c013d86d
feat(Mailer): add "null" SMTP transport mode
...
== Goal
Allow disabling mail delivery altogether.
== Usecase
If mails ought to be send by other means than rendering messages from
templates and sending them via SMTP-like protocols.
Example: listening to specific Nextcloud events and pass parameters to
a centralized (i.e. REST-based) API that sends e-mails.
Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
2024-11-19 11:32:39 +07:00
46d8a7333b
feat(Mailer): implement caching
...
Currently $this->instance is never set, so the code is no-op. This
brings back caching of the instance.
Caching broke with
be7db1573d
2024-11-19 11:32:39 +07:00
5b4f1904c0
feat(user-prefs): renaming to IUserConfig
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
6afc8552b7
feat(user-prefs): switching to NCU/
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
7c04818c5c
feat(user-prefs): iterator instead of array on search
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
e73513bdd1
fix(user-prefs): adding sensitive and indexed as flags
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
65e24f7def
feat(user-prefs): IUserPreferences
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
0718984bdf
Merge pull request #48675 from georglauterbach/master
...
DNS: do not query CNAME if A succeeded already
2024-11-14 11:43:32 +07:00
158299b3d7
fix(profile): make sure the app cannot be disabled as it was in core
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-14 10:25:10 +07:00
7ebeed45bd
feat: add iMip Request Handling
...
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-11-07 21:12:37 +07:00
b21c0265df
test: add some minimal testing for metadata storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-07 16:27:16 +07:00
c3c8b7e2a3
fix(richobjectstrings): Add missing placeholder validation
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-06 21:31:41 +07:00
387cd8b771
fix: do not query CNAME if A succeeded already
...
Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
2024-11-06 20:21:38 +07:00
3c4290631b
Merge pull request #49039 from nextcloud/jtr/fix-ipv6-zone-ids-link-local
2024-11-06 09:17:52 +07:00
8fab143aa4
Merge pull request #48721 from nextcloud/feat/allow-getter-setter-decl-fors
2024-11-06 08:54:40 +07:00
5ea5b2de84
fix: Handle exception when clearing previously removed two factor tokens
...
If a token was already removed from the database but not from the
configuration clearing the tokens will try to remove it again from the
database, which caused a DoesNotExistException to be thrown.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 11:14:05 +07:00
381a2aa627
fix: Clear pending two factor tokens also from configuration
...
Otherwise as the tokens were removed from the database but not from the
configuration the next time that the tokens were cleared the previous
tokens were still got from the configuration, and trying to remove them
again from the database ended in a DoesNotExistException being thrown.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 11:14:04 +07:00
e885e4f13d
fix(tests): Add IpAddressClassifier v6 zone ID test
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-11-04 09:31:48 +07:00
97421fb143
fix(tests): Add RemoteAddress v6 zone ID test
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-11-04 09:30:21 +07:00
901496276b
Merge pull request #47425 from nextcloud/fix/avoid-invalid-share-on-transfer-ownership
...
fix: promote re-shares when deleting the parent share
2024-11-04 10:09:58 +07:00
79db082fe6
fix(users): improve recently active search
...
- Remove DISTINCT clause to fix PgSQL
- Join user table only if necessary
- Don't show people who never connected in active list
- Add test
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 07:53:10 +07:00
e3e22e28c0
Merge pull request #47847 from nextcloud/fix-copying-or-moving-from-shared-groupfolders
2024-10-29 11:33:12 +07:00
d25a0a2896
Merge pull request #48915 from nextcloud/fix/encrypt-decrypt-password
2024-10-28 13:26:55 +07:00
86006368bf
Merge pull request #48912 from nextcloud/bugfix/exception-appscreenshot-notstring
...
fix(apps-store): Fix exception on generating preview url for installed app screenshot
2024-10-28 11:32:15 +07:00
a74ef8237d
fix: crypto type made not nullable and tests run using ICrypto
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 15:04:11 +07:00
5efb175665
Merge pull request #48614 from nextcloud/refactor/storage/constructors
2024-10-28 10:19:41 +07:00
220bd3422f
fix(appinfo): Make sure screenshot, author and category are always arrays
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-28 08:46:31 +07:00
505dfd65fd
fix: encrypt and store password, decrypt and retrieve the same
...
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 11:22:36 +07:00
0de4843b73
refactor(Storage): Align all Storage constructors
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-23 13:24:18 +07:00
54c3aa3f99
fix(entity): Fix mapping of old/sub-types to actually supported database types
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-23 09:22:05 +07:00
2ef74b9860
Merge pull request #47329 from nextcloud/feat/add-datetime-qbmapper-support
...
feat(AppFramework): Add full support for date / time / datetime columns
2024-10-18 19:05:08 +07:00
882f91605b
fix(comments): Add test for email mention
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-18 07:39:41 +07:00
db94e10af0
fix: Prevent breaking change in IQueryBuilder
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 18:31:44 +07:00
ee02e3246d
feat(AppFramework): Add full support for date / time / datetime columns
...
This adds support for all Doctrine supported types, for the column types only the immutable variants needed to be added.
But especially those types are the important ones, as our **Entity** class works by detecting changes through setters.
Meaning if it is mutable, changes like `$entity->date->modfiy()` can not be detected, so the immutable types make more sense here.
Similar the parameter types needed to be added.
`Enity` and `QBMapper` needed to be adjusted so they support (auto map) those types, required when insert or update an entity.
Also added more tests, especially to make sure the mapper really serializes the values correctly.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 18:31:42 +07:00
9a7e1bb227
feat(DeclarativeSettings): Allow to implement value getter and setter directly in Form
...
Instead of implementing the form class, a setter event listener and a getter event listener,
this allows to simply write a basic class that provides `getSchema`, `setValue` and `getValue` functions.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-15 20:33:45 +07:00
b964e05312
Merge pull request #48673 from nextcloud/fix/null-label
...
fix(share): Return empty string if no label is set
2024-10-14 19:10:12 +07:00
d6ba524263
fix: Use getRelativePath method to check if node is inside folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-14 17:23:29 +07:00
980ab1f56b
fix: Shipped apps should include the Nextcloud version in the cache buster
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-14 16:04:13 +07:00
2e4d3e4e75
fix(share): Return empty string if no label is set
...
* Resolves: https://github.com/nextcloud/server/issues/48629
While the database supports NULL, the typing has always said it only returns *string*.
So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-14 15:15:51 +07:00
e584e9baf7
fix: Fix promotion of reshares from subsubfolders
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-14 11:58:47 +07:00
3ee5bf6af1
fix(tests): Fix share tests to test new reshare promotion system
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-14 11:58:47 +07:00
7e9bc7c8cf
fix: Tidy up code for reshare deletion
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-14 11:58:47 +07:00
42181c2f49
fix: delete re-shares when deleting the parent share
...
Note: Removed part about fix command from original PR
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-14 11:58:47 +07:00
7cb07bf306
test: add test for nested jail cross-storage move
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-10 15:16:12 +07:00
356f3ded52
Merge pull request #48610 from nextcloud/fix/usertrait/backend-initialization
2024-10-08 16:53:26 +07:00
902fb8f9fc
fix(UserTrait): Fix backend initialization
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-08 11:12:01 +07:00
f28e74b7a8
refactor(Storage): Make all parameter types strong types
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-07 15:00:05 +07:00
4412b2b8a8
refactor(Wrapper\Encryption): Migrate to strong types
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-07 14:11:56 +07:00
d1977b8d25
refactor(Stream\Encryption): Migrate to strong types
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-07 14:02:27 +07:00
e6cd1051da
fix(message): Fix logic of Mail test
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-07 12:11:38 +07:00
3095a92551
Merge pull request #47896 from nextcloud/fix/resiliant-user-removal
...
fix: Make user removal more resilient
2024-10-07 11:33:07 +07:00
6be00432b7
chore: always execute parse_url in preventLocalAddress
...
This change should make it easier to spot wrong uses of the HTTP client on development setups where allow_local_remote_servers is usually true.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-10-01 18:00:47 +07:00
eb69e89fa5
chore: Drop unused legacy `OC_Files`
...
It is replaced with the Sabre `ZipFolderPlugin` and apps should use the `OCP\AppFramework\Http\StreamResponse`.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 13:18:40 +07:00
0f6760c810
feat(files): Make the files download action use WebDAV zip download
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-28 13:18:29 +07:00
16833aff86
fix: Make user removal more resilient
...
Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.
There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.
The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-26 20:48:37 +07:00
256a8d8903
test: Fix IStorage return types
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-26 17:29:48 +07:00
280f6df66c
Merge pull request #32018 from nextcloud/cleanup/event/trashbin
...
Port files trashbin events to IEventDispatcher/IEventListener
2024-09-24 17:15:39 +07:00
19ad13571c
fix: gracefully parse non-standard trusted certificates
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-09-24 12:36:09 +07:00
4adf5fd5b0
fix(tests): Pause trashbin for lock tests in ViewTest using rmdir and unlink
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-24 10:37:38 +07:00
af0b8fbd17
fix(tests): Fix tests now that trashbin listens to events properly
...
Hooks are cleared in test bootstrap so switching to events activates
them in tests.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-23 18:13:29 +07:00
82566c5479
fix(rtl): Make clear that the direction is based on language
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-23 17:00:07 +07:00
d94745201b
fix(rtl): Add unittest for language direction
...
Signed-off-by: Mostafa Ahangarha <ahangarha@riseup.net>
2024-09-23 16:59:21 +07:00
40b404c566
Merge pull request #48111 from nextcloud/fix/move-storage-constructor-to-specific-interface
...
fix: Move storage constructor to specific interface
2024-09-23 15:57:38 +07:00
b8ab560bdd
fix(tests): Fix test to remove call to non-existing constructor
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-23 14:50:43 +07:00
22d5d29c01
fix(users): Don't crash if disabled user is missing in the database
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-23 10:40:38 +07:00
3009da3722
Merge pull request #43968 from exi/custom-binary-search-paths
...
feat: make search path for BinaryFinder customizable.
2024-09-20 19:14:17 +07:00
2ba3f7ed5c
Merge pull request #47782 from nextcloud/reworkShareExceptions
...
fix(l10n): Rephrasing some exceptions to be translated
2024-09-20 18:53:40 +07:00
dcbe8da2a6
fix(l10n): Rephrasing some exceptions to be translated
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: Fix tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-20 18:35:11 +07:00
ef7e857881
feat: make search path for BinaryFinder customizable.
...
This feature is important for nextcloud running on
distributions like NixOS, where all the standard
search paths do not exist.
Also added tests.
This fixes issue #43922
Co-authored-by: Daniel <mail@danielkesselberg.de>
Signed-off-by: Reno Reckling <e-github@wthack.de>
2024-09-20 17:00:06 +07:00
606241caeb
chore(legacy): Introduce public version ct plass and drop version methods from OC_Util
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-20 14:53:34 +07:00
2a59f4fc95
Merge pull request #48220 from nextcloud/chore/remove-travis
...
chore: Remove old travis related stuff
2024-09-19 23:26:39 +07:00
9813cbf616
Merge pull request #48217 from nextcloud/chore/prepare-oc_repair-unit10
...
chore: Cleanup and prepare `\OC\Repair\RepairMimeTypes` tests for PHPUnit 10
2024-09-19 20:50:35 +07:00
7ae7f7fd12
chore: Remove old travis related stuff
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 20:16:29 +07:00
349a9fc5f6
chore: Cleanup and prepare `\OC\Repair\RepairMimeTypes` tests for PHPUnit 10
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 19:25:42 +07:00
4ccf62a224
chore: Cleanup and prepare some app tests for PHPUnit 10
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-19 18:19:32 +07:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-19 14:21:20 +07:00
44c7248749
refactor(Collaboration): Use non-deprecated methods
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-19 00:35:20 +07:00
989d708bd8
Merge pull request #48137 from nextcloud/enh/add-rich-object-formatter
...
feat: Add OCP interface to format richtext into string
2024-09-18 18:59:56 +07:00
1db3d94e1e
test: put parent items into cache in tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 16:10:14 +07:00
74adaebf96
test: fix incorrect ltrim usage in test
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-18 14:11:27 +07:00
8fb64b886a
fix(settings): pronouns UsersControllerTest
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-18 13:30:33 +07:00
b124f19777
fix(tests): Adapt tests to changes in RepairMimeTypes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 19:34:44 +07:00
cfca7e7911
fix(tests): Fix most obvious errors in ObjectStore tests
...
Some are still failing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 19:20:13 +07:00
2bdc97741c
fix(tests): Fix Folder tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 19:19:08 +07:00
9a9dd10c0c
fix(tests): Remove deprecated tests for ServerTest
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 17:48:01 +07:00
f25acfb799
Merge pull request #47986 from cfiehe/fix_move_on_same_bucket
...
perf(ObjectStoreStorage): Improve (slow) move on same object bucket
2024-09-17 16:35:19 +07:00
b926df4730
fix: Adapt notifications and activity tests to new DI dependency
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-17 15:28:09 +07:00
8ca6fcace7
fix(Storage): Document getOwner() can return false
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-17 10:10:50 +07:00
b9fb1db0f8
Merge pull request #48009 from nextcloud/fix/remove-references-to-deprected-storage-interface
...
fix: Remove OCP\Files\Storage interface deprecated since version 9
2024-09-16 20:50:38 +07:00
ede0c26b78
Merge pull request #46480 from nextcloud/fix/mailer-binaryfinder-fallback
...
fix(Mailer): Fix sendmail binary fallback
2024-09-16 18:18:14 +07:00
a165d8f978
chore: Fix encryption test use statement
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:38 +07:00
22822d5e9b
fix: Fix other uses of removed Storage interface
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:11:36 +07:00
801733e523
fix: Remove OCP\Files\Storage interface deprecated since version 9
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-16 18:10:48 +07:00
d9c5512878
Merge pull request #46140 from nextcloud/fix-nc-env-inclusion
...
fix(config): Add missing handling for `envCache` in `getKeys()`
2024-09-16 16:55:13 +07:00
87aa1267a8
fix(Mailer): Fix sendmail binary fallback
...
feat: add debug logging to sendmail binary finder
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-09-16 15:20:29 +07:00
13088b745a
Merge branch 'master' into fix-nc-env-inclusion
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-16 15:13:29 +07:00
9597072ada
perf(ObjectStoreStorage): Improve (slow) move on same object bucket
...
This commit fixes the issue #47856 . When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.
The behavior improves a lot with https://github.com/nextcloud/server/pull/46013 . However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
2024-09-16 15:11:09 +07:00
7fbd518452
feat: Make `CheckServerResponseTrait` public and provide as `OCP\SetupCheck\CheckServerResponseTrait`
...
This trait is used by other apps for creating setup checks,
so we should provide it instead apps using private API.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-16 14:58:21 +07:00
ff0cab5956
Merge pull request #47852 from nextcloud/sharding-code-fixes
2024-09-16 11:39:58 +07:00
8a32881633
Merge pull request #48008 from nextcloud/fix/entity/strict-types
2024-09-16 11:08:35 +07:00
d46f271b1f
Merge pull request #48049 from nextcloud/refactor/void-tests
...
refactor: Add void return type to PHPUnit test methods
2024-09-16 00:11:41 +07:00
6892500405
Merge pull request #48046 from nextcloud/refactor/self-class-reference
...
refactor: Replace __CLASS__ with ::class references
2024-09-15 23:01:22 +07:00
49dd79eabb
refactor: Add void return type to PHPUnit test methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 22:32:31 +07:00
1ee833efab
refactor: Replace __CLASS__ with ::class references
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 21:40:55 +07:00
6c36c54dc6
feat(db): switch from settype to casts
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-15 19:26:58 +07:00
247b1dd70e
fix(Entity): Fix magic setter call for custom strong typed setters
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-15 15:14:54 +07:00
81df2d2c12
feat(PsrLoggerAdapter): Allow to use `Psr\Log\LogLevel` for `log` method
...
There is the `Psr\Log\LogLevel` class defining loglevel constants,
to be fully compatible we should at least support those logging levels.
Moreover this is the last part that was still required from `ILogger` interface,
as we did not have alternatives for the loglevel constants.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-14 17:35:11 +07:00
bcb4e781a4
Merge pull request #47927 from nextcloud/fix/migrate-away-from-oc_app
...
Migrate away from OC_App to IAppManager
2024-09-13 17:44:38 +07:00
dfa994ef28
Merge pull request #47865 from nextcloud/admin_audit/enh/move-to-event-listeners-v2
...
Move admin_audit to proper event listeners v2
2024-09-13 16:21:44 +07:00
7a16d01ea7
chore(tests): Fix Router test by mocking AppManager methods correctly
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:26:36 +07:00
76f2bc0bfc
fix: Replace OC_App::getAllApps with a method in AppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:08:44 +07:00
7ed583cb8e
chore: Migrate cleanAppId and getAppPath calls to IAppManager from OC_App
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-13 10:08:43 +07:00
dcd97e1234
fix(config): Throw PreconditionException always when it didn't match
...
Previously even when the precondition did not match, the call "passed"
when the after value was the expected one. This however can lead to
race conditions, duplicate code excutions and other things.
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-13 09:20:08 +07:00
b6c286640f
Merge pull request #47685 from nextcloud/fix/move-apihelper-to-oc-namespace
...
fix: Move OC_API into \OC\ApiHelper in standard namespace
2024-09-12 14:34:07 +07:00
38e0a89972
fix: Add whiteboard to education and public sector bundle
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2024-09-12 09:13:42 +07:00
d0a827a684
fix(RichObjectStrings/Validator): Validate key value types of rich object parameters
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-10 16:36:33 +07:00
c2150bd079
feat: Add mimetype into BeforePreviewFetchedEvent event
...
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
2024-09-10 14:05:06 +07:00
da59fd4389
fix: misc code fixes around db sharding
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-09-09 16:59:59 +07:00
d5e98cd190
fix(NavigationManager): Skip invalid default navigation entries
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +07:00
70ed08daf1
refactor(AppManager): Deprecated default apps handling
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +07:00
b0baaaed9d
feat(NavigationManager): Add default entries handling
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-09 11:04:36 +07:00
359bbce3af
chore: Adapt tests to OC_API refactoring
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-09-09 10:46:29 +07:00
0308001118
fix(files): Check if the target path is a descendant of the shared folder path
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: fix tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: add tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
fix: tests
2024-09-05 23:54:01 +07:00
8af7ecb257
chore: adjust code to adhere to coding standard
...
Signed-off-by: Anna Larch <anna@nextcloud.com>
2024-09-05 21:23:38 +07:00
09fef8f0ec
Merge pull request #47417 from nextcloud/fix/files/create-mountpoint-parents
2024-09-04 20:00:24 +07:00
78e09b5a0a
fix: share manager tests translation string
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-09-04 09:03:45 +07:00
4d2556d4cf
refactor(IMenuAction): Make public menu actions use the new Vue UI
...
This removes custom rendering code an replaces it with the declarative menu actions.
Also adjust the template to allow the Vue UI to mount.
Custom entries still are possible.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-09-03 16:07:49 +07:00
92f3f7e2d2
chore: Remove unused `CsrfTokenManager` from `CSPMiddleware`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-31 00:34:41 +07:00
41e3bde40c
fix(TaskProcessing): Fix namespace of TaskProcessingTest.php
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
03b3d03b46
fix(taskprocessing): fix tests
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-08-30 10:07:01 +07:00
bfb5835750
Merge pull request #47546 from nextcloud/fix/files-view-error-messages
...
fix: Adjust filename validation messages
2024-08-29 23:28:50 +07:00
b71c539b5c
test(phpunit): skip sharding tests on 32bit
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-08-29 20:18:35 +07:00
80d7d867bd
fix(tests): Fix ImageTest test
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +07:00
e8c671fa8b
fix: Remove all references to OC_Image
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-29 17:06:32 +07:00
030c209d22
fix: Renaming does not need update but delete permissions
...
Renaming is basically copy + delete (a move), so no need to update permissions.
Especially if the node is in a invalid directory the node should be moveable but not editable.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-28 17:22:20 +07:00
2574cbfa61
chore: Apply php:cs recommendations
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-08-28 10:44:18 +07:00
b21a399d1a
fix: implement sharding compatible cleanup for various bits
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:27:14 +07:00
382d102d22
test: fix share provider tests for sharding
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:19 +07:00
ddbeb4cac9
test: mark share test cleanup as running across all shards
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:19 +07:00
62f8b6517f
feat: implement distributing partitioned queries over multiple shards
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:21:19 +07:00
f5b3486744
feat: add option to automatically partition queries by specific tables
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:18:53 +07:00
c58bdbf378
fix: delay calculating global cache prefix untill a cache is created
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-28 10:18:52 +07:00
81c6c24cd5
fix: Adjust filename validation messages
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-27 23:12:24 +07:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +07:00
8b60df1600
perf: delay getting (sub)admin status for user in the security middleware untill we need it
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-23 15:26:40 +07:00
127cacdd19
feat(Security): Allow setting password context for validation and generation
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Joas Schilling <213943+nickvergessen@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-22 19:16:50 +07:00
ebfbe99652
fix(files): Create non-existent parents of mountpoints
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-08-22 12:04:31 +07:00
c3ad469750
Merge pull request #47259 from nextcloud/memcache-ncad
...
feat: add negative compare-and-delete to imemcache
2024-08-21 17:19:04 +07:00
e1caa198e3
ci: Skip flaky test on PHP 8.3
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-08-21 13:13:12 +07:00
b9cc7bcec7
fix: `FilenameValidator::isForbidden` should only check forbidden files
...
And not forbidden basenames as this is used for different purposes.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-21 04:16:14 +07:00
20dbb6c7e8
feat: add negative compare-and-delete to imemcache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-20 19:34:28 +07:00
2ec68b1eb9
refactor(Log): Use new in initializer instead of constructor body
...
PHP 8.1 allows us to now move the `new` into the initializer,
this makes the code a bit nicer (and 3 lines shorter).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-17 18:38:28 +07:00
d35c4eb911
Merge branch 'master' into jr-readdir-false-false
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-08-16 10:53:50 +07:00
3e409fd342
Merge pull request #43573 from nextcloud/HolgerHees-fix-csp-nonce-handling
...
Fix for ignored `CSP_NONCE` in ContentSecurity Header
2024-08-13 17:53:30 +07:00
5100e3152d
feat(auth): Clean-up unused auth tokens and wipe tokens
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-08-13 12:39:11 +07:00
2916e5df7e
feat: Provide CSP nonce as `<meta>` element
...
This way we use the CSP nonce for dynamically loaded scripts.
Important to notice: The CSP nonce must NOT be injected in `content` as
this can lead to value exfiltration using e.g. side-channel attacts (CSS selectors).
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-13 10:32:44 +07:00
009761be58
test: Adjust tests for CSP nonce
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-13 10:06:32 +07:00
1cfc25d08c
fix(tests): Adapt tests to change of DefaultShareProvider constructor
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-08-12 15:20:21 +07:00
0563757ea4
fix(SetupCheck): Properly check public access to data directory
...
When checking for public (web) access to the data directory the status is not enough
as you might have a webserver that forwards to e.g. a login page.
So instead check that the content of the file matches.
For this the `.ncdata` file (renamed from `.ocdata`¹) has minimal text content
to allow checking.
¹The file was renamed from the legacy `.ocdata`, there is a repair step to remove the old one.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-08 22:08:42 +07:00
2b38d6ae7e
fix(session): Log when session_* calls are slow
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-08-07 09:02:10 +07:00
db28aa8cd1
fix(files_sharing): show proper share not found error message
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-08-06 16:25:10 +07:00
c221090c86
fix: unify bundle naming
...
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-08-06 11:14:07 +07:00
9af6184af6
chore: delete repair step for 8y old oc_mounts issue
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-02 17:21:54 +07:00
a6d421e767
chore: Remove deprecated legacy search backend
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-08-01 12:33:18 +07:00
18c0bcb2da
Merge pull request #46476 from nextcloud/enh/noid/migration-attributes
...
Migration Attributes
2024-07-30 15:54:56 +07:00
710a69b4b5
feat(log): Allow to combine log.conditions to only log (app&user)
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-30 13:18:09 +07:00
21f558b12b
Merge pull request #46379 from nextcloud/fix/folder-search-owner
...
fix: `OCP\Files\Node\Folder::search` was not setting the owner
2024-07-30 13:04:15 +07:00
ad490c963b
feat(migration-attributes): tests
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-07-29 12:44:52 +07:00
9d1705259c
fix(AppFramework): Allow requests with OCS-APIRequest header to pass CSRF checks
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-25 17:31:49 +07:00
799ee8fd51
feat(TaskProcessing): Implement enums and default values
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2024-07-25 10:10:31 +07:00
57ed738af2
Merge pull request #46644 from nextcloud/cast-bigint
...
fix: cast to bigint on postgresql
2024-07-24 20:39:04 +07:00
7266a9ef33
Merge pull request #46418 from nextcloud/artonge/feat/user_admin_delegation
...
feat(users): Add users and group management to admin delegation
2024-07-24 11:15:54 +07:00
fc0b694d37
feat: mail provider backend
...
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-07-23 16:20:36 +07:00
16c184e2cb
fix: cast to bigint on postgresql
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-23 14:41:13 +07:00
dff8815449
feat(users): Add support for admin delegation for users and groups management
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-07-22 17:17:35 +07:00
fffc784769
feat(taskprocessing): add support for webhooks (http or AppAPI) in the task processing API
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2024-07-22 11:34:29 +07:00
9ed2d3e495
Merge pull request #46571 from nextcloud/chore/migrate-to-filenamevalidator
...
refactor: Migrate some legacy and core functions to `IFilenameValidator`
2024-07-22 10:40:50 +07:00
c2a571e435
Merge pull request #46473 from nextcloud/feat/restrict_admin_to_ips
...
feat(security): restrict admin actions to IP ranges
2024-07-22 10:10:42 +07:00
9716b0d735
refactor: Migrate some legacy and core functions to `IFilenameValidator`
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-07-19 19:41:46 +07:00
7395211c1a
Merge pull request #46605 from nextcloud/bugfix/noid/test-more-oracle-versions
...
fix(deps): Deprecate functionality deprecated by doctrine and test on more oracle versions
2024-07-19 16:40:49 +07:00
047479ccf9
feat(security): Add public API to allow validating IP Ranges and checking for "in range"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +07:00
202e5b1e95
feat(security): restrict admin actions to IP ranges
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-07-19 16:28:03 +07:00
a3c3eab09c
Merge pull request #46368 from nextcloud/fix/task-processing
...
TaskProcessing follow-up
2024-07-19 12:38:30 +07:00
f6238d35bd
fix(test): Make the test less flaky
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:16 +07:00
eeb6ddb176
fix(db): Deprecate `IExpressionBuilder::or()` and `IExpressionBuilder::and()` without parameters
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:16 +07:00
829f2b9bc7
fix(db): Promote the use of `getDatabaseProvider` to reduce the impage of removed upstream platforms
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:14 +07:00
a4c1d7291f
fix(db): Use `createSchemaManager()` method as `getSchemaManager()` is deprecated
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-07-19 11:21:11 +07:00
64ca4b832d
Merge pull request #46583 from nextcloud/filecache-sharding-compat
...
Make filecache queries compatible with sharding
2024-07-19 09:49:45 +07:00
e5dcdfb9e0
feat(Security): Warn about using annotations instead of attributes
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-18 11:25:32 +07:00
Louis Chemineau
Joas Schilling
Joas Schilling
John Molakvoæ
Christoph Wurst
provokateurin
Thomas Lehmann
Maxence Lange
Côme Chilliet
skjnldsv
SebastianKrupinski
Robin Appelman
georglauterbach
Daniel Calviño Sánchez
Josh
Benjamin Gaussorgues
Kate
Ferdinand Thiessen
yemkareems
Côme Chilliet
Luka Trovic
Daniel Kesselberg
Richard Steinmetz
Mostafa Ahangarha
Andy Scherzinger
Git'Fellow
Reno Reckling
Julius Knorr
Stephan Orbaugh
Christoph Fiehe
Anna
Thomas Citharel
Marcel Klehr
Julien Veyssier
Arthur Schiwon
Jérôme Herbinet