b6f8b8da60
directly build the search filter for shared storage instead of setting up the source cache
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-17 11:58:57 +07:00
8004aa7721
Make DisplayNameCache return null if user doesn't exists
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-16 14:10:05 +07:00
8367b99c59
fix external share scanner not propagating locking-opt-out
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-08-03 17:12:30 +07:00
6ba9a4a752
Disable locking on federated shares
...
The old inneficiant code didn't do locking and adding locking is
creating issues
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-03 15:17:55 +07:00
fa48430feb
Revert "Revert "Remove inefficient fed share scanner""
...
This reverts commit 6667007bf2
2022-08-03 15:17:51 +07:00
7b723813ce
Multiple fixes
...
- Fix tests
- Use non deprecated event stuff
- Add a bit of type hinting to the new stuff
- More safe handling of instanceOfStorage (share might not be the first
wrapper)
- Fix resharing
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-31 19:37:59 +07:00
ab1a20522b
Enforcing permission during resharing
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-28 16:54:13 +07:00
bbb5043c07
Inherit hide download from share attributes
...
When resharing by link, if the download permission was removed through
share attributes, convert it to the hide download flag.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:54:13 +07:00
3cfb4cbf94
Block download when needed on direct download endpoint
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:54:13 +07:00
2ee659e547
Fix view-only code after code review comments
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:24 +07:00
54a0d8fe64
Don't reset share attributes when not specified
...
When not specified in the OCS call, don't reset the share attributes.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:23 +07:00
03b1791cca
Fix share attribute related tests + code style
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
9493f86de3
Fix share controller to accept share attributes alone
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
a95c19e14b
Add share attributes + prevent download permission
...
Makes it possible to store download permission
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-28 16:53:22 +07:00
f525067930
Add argument to getSharesInFolder enable deep share lookup
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-26 12:17:46 +07:00
0fb4ecadae
Recursively fetch subshares
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-26 12:17:46 +07:00
13e7ebbe4b
Change share owner when moving share out of share
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-26 12:17:46 +07:00
8ca910976d
Update owner of subdir on move into/out of share
...
When moving a directory into or out of a received share, make sure to
also update the share owner column for shares that exist insie the
directory.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-07-26 12:17:46 +07:00
d5c23dbb9f
Move CappedMemoryCache to OCP
...
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-07-14 15:54:31 +07:00
85cc867143
Merge pull request #31771 from nextcloud/fix/hook-encryption-cron
...
Fix hook encryption with cron job
2022-06-10 16:27:59 +07:00
148498bba5
Merge pull request #32741 from nextcloud/Valdnet-patch-2
...
l10n: Delete apostrophe
2022-06-10 15:54:14 +07:00
6ee4e0b94c
Merge pull request #32806 from nextcloud/fix-federated-sharing
...
Revert "Remove inefficient fed share scanner"
2022-06-10 15:47:13 +07:00
6667007bf2
Revert "Remove inefficient fed share scanner"
...
This reverts commit ce31914314
2022-06-10 10:29:42 +07:00
50badb3fb6
Various improvements related to the recent implementation of temporary passwords
...
for mail shares:
1- Changes style of "forgot password?" and "Back" button
2- Adds information about share password's expiration time in the emails sent.
3- Shows password expiration time in the Share menu
4- Fixes an issue when the message "Password expires..." would be shown for non email share types (which don't have temporary passswords)
5- At share's creation, password should only be sent when it's a permanent one
See also https://github.com/nextcloud/server/issues/31952
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-06-08 11:29:19 +07:00
50c697dbd4
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-06-07 20:40:55 +07:00
5907bba3fd
Fix hook encryption with cron job
...
Make sure the setup fs is set before using the Update service
Fix #29674
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-06-07 15:38:45 +07:00
dfe7243338
l10n: Delete apostrophe
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-06-07 16:41:38 +07:00
e4378fd18c
Merge pull request #32349 from nextcloud/enh/projects-event
...
Add event to load additional scripts for projects
2022-05-27 18:36:40 +07:00
ec6b83cc18
Add stricter psalm type for CappedMemoryCache
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-12 15:06:18 +07:00
ae0e9ff083
Move files_sharing over to new event for projects
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2022-05-12 10:50:13 +07:00
102d119297
Merge pull request #32053 from nextcloud/cache-verify-share-mountpoint
...
cache the verification of the share mountpoint
2022-04-22 14:36:49 +07:00
ed4c1e584f
Update cache when display name change
...
This improve the correctness of the data
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-22 10:29:18 +07:00
4333c215cb
Cache display name
...
This should saves some query in the share backend when displaying the
owner and it's not important if the display name is 10 minutes outdated
as it is very rare that this gets changed.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-22 10:22:15 +07:00
54532b2df3
Merge pull request #32050 from nextcloud/share-cache-owner-name
2022-04-22 08:13:38 +07:00
bda8601648
cache the verification of the share mountpoint
...
after the initial verification this can only really be invalidated by a system mount (external/group/etc) being created at the share target since any normal file/folder creation will already conflict with the share
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-21 18:08:35 +07:00
1f1b2a32cb
cache the share owner name for formating cache entries
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-21 17:33:18 +07:00
e3ade5507d
also apply the fix for the other storage types
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-21 15:00:42 +07:00
f6d5eb9a75
improve optimization for SharedStorage::instanceOfStorage(Common)
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-21 14:51:09 +07:00
f5c8fa4f11
Properly reset pw expiration
...
When requesting a new password for share by mail link, now we correctly
reset the expiration date.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-13 15:46:30 +07:00
483741ff36
Merge pull request #31220 from nextcloud/enhancement/31005/temporary-passwords
...
Temporary passwords for public non-anonymous protected shares (ie: files shared with an email recipient).
2022-04-12 09:46:31 +07:00
c6a5c07041
Adds a "Request password" button to the public share authentication page for shares
...
of type TYPE_EMAIL, when the "video verification" checkbox isn't checked. Users accessing
non-anonymous public shares (TYPE_EMAIL shares) can now request a temporary password themselves.
- Creates a migration step for the files_sharing app to add the 'password_expiration_time'
attribute to the oc_shares table.
- Makes share temporary passwords' expiration time configurable via a system value.
- Adds a system config value to allow permanent share passwords
-Fixes a typo in a comment in apps/files_sharing/src/components/SharingEntryLink.vue
See https://github.com/nextcloud/server/issues/31005
Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
2022-04-11 21:58:24 +07:00
9834350ac3
Merge pull request #31713 from nextcloud/fed-performance
...
Federated share performance improvements
2022-04-07 18:53:36 +07:00
d7e094836b
Merge pull request #31845 from nextcloud/querybuilder-shareexternal
...
Use querybuilder for share external mountpoint
2022-04-07 17:53:58 +07:00
579c6b1e5a
Use querybuilder for share external mountpoint
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-04-06 10:18:36 +07:00
1ceb6cdb38
Merge pull request #31684 from nextcloud/user-share-permissions-merge
...
take permissions from multiple paths into account for share permissions
2022-04-05 17:37:46 +07:00
0cdf03b733
Merge pull request #31773 from nextcloud/share-limited-owner-setup
...
Perform a limited filesystem setup when getting share source
2022-04-05 17:05:57 +07:00
5e2dd29aaf
only request free space once for external shares
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-04 16:48:27 +07:00
802e59243b
use all possible permissions dav properties
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-04 16:48:24 +07:00
89d3cd1447
don't overwrite the etag from storage backends that already provide "good" etags
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-04 16:48:18 +07:00
ef5ca766e9
Set oc_share_external.name column length to 4000 to remove arbitrary limitation
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-04-04 16:28:06 +07:00
74c97e2571
use UserFolder to get the share source node
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-04-04 14:57:53 +07:00
278b13155a
take permissions from multiple paths into account for share permissions
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-31 16:47:35 +07:00
47f1ba6ea6
Merge pull request #31240 from nextcloud/Valdnet-patch-3
...
l10n: Add a dot
2022-03-31 14:57:25 +07:00
de5af8efbf
invalidate mount cache after accepting or renaming federated share
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-25 14:18:36 +07:00
db2418be85
invalidate mount cache after share rename
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-24 17:36:56 +07:00
1e487c2a09
l10n: Spelling unification in Transifex.
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-03-18 10:14:34 +07:00
e8872f01ae
Merge pull request #31431 from nextcloud/fs-setup-manager
...
Unify/cleanup filesystem setup
2022-03-08 14:50:25 +07:00
ccd08877e8
Fix too many file download notifications when watching a video
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-03-07 19:50:15 +07:00
917c74e214
type fixes
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:30:16 +07:00
1c468129af
adjust tests to new fs setup
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-03-04 16:29:59 +07:00
cfb7923e08
store mountprovider for each mount in the mounts table
...
this enabled more fine grained filesystem setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-23 18:02:33 +07:00
b8752c59cd
improve errors for external share availability check
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-02-21 14:21:28 +07:00
522d9c1d1f
l10n: Delete dot
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-02-17 15:03:53 +07:00
c72718c61b
l10n: Add a dot
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2022-02-17 14:07:51 +07:00
da435b1e67
Support CRUD share permissions
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-02-15 11:54:17 +07:00
f0424378f6
Revert "Add non-breaking space in the file size"
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-02-10 10:35:19 +07:00
b8e0a3dbdd
Use the new option to signaling insensitivity
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-02-07 13:54:54 +07:00
46c0ceb59c
Add non-breaking space in the file size
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-14 09:19:15 +07:00
ce31914314
Remove inefficient fed share scanner
...
Remove scanAll which relies on the "shareinfo" endpoint that returns the
full cache tree.
The latter can become big for big shares and result in timeouts.
Furthermode, the full tree would be retrieved again for each and every
detected change which can become expensive quickly.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-01-10 11:33:28 +07:00
91c7efaeb6
Merge pull request #30020 from nextcloud/feat/webpack-vendors-bundles
...
Feat/webpack vendors bundles
2022-01-10 09:41:18 +07:00
b664aad7ab
Move bundles to /dist
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2022-01-08 10:11:58 +07:00
0b15da3c25
Handle LocalServerException when scanning external shares
...
When remoteIsOwnCloud trows LocalServerException, the storage is
unavailable and instead of crashing the scanner, ignore the specific
storage.
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-06 18:03:21 +07:00
66b1963b6e
Fix passing on the parameter
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2022-01-05 09:30:20 +07:00
33051667ce
Improve api documentation for file sharing external storage
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-03 10:41:40 +07:00
325be6627b
Handle external share with invalid host
...
remoteIsOwnCloud might throw an exception when the host is localhost.
Handle this case instead of aborting completely. The behavior is the
same as that is done 10 lines under it
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2021-12-20 15:28:14 +07:00
4559a46c8d
Discard share notification for non-existing groups
...
Group shares might exist even after a group got deleted.
This fix catches the situation and discards the notification for the
obsolete group.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Co-authored-by: Joas Schilling <coding@schilljs.com>
2021-12-15 14:55:27 +07:00
d49ad7ea47
Limit more contact searches
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-12-08 18:58:54 +07:00
00549f7802
Merge pull request #30055 from nextcloud/enh/note-share-api
2021-12-06 08:59:51 +07:00
5116bf146f
Allow to pass note when creating a share and send it with directly in the share mail when set
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-12-03 10:17:02 +07:00
71a3528510
Allow scripts prioritization based on other apps
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-12-02 20:00:46 +07:00
db2dcbfe13
code checker fixes for instanceOfStorage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-12-02 17:35:10 +07:00
f5fe887b4b
background scan the source storage when a background scan on a storage jail is triggered
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-12-02 17:34:58 +07:00
e673ec0b87
Merge branch 'master' into imountpoint-ocp-storage
2021-10-22 11:47:37 +07:00
ef93d2ea1c
update tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-19 11:31:08 +07:00
7345de78c5
use the correct navigation manager for the shares
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-19 11:31:08 +07:00
4b82d8d20c
call setupSharingMenus again
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-19 11:31:07 +07:00
ab275c5e38
move files_sharing to IBootStrap
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-10-19 11:31:07 +07:00
43fcd28ea0
Merge pull request #28377 from nextcloud/fix/shared-ext-storage-scan
...
Scan the shared external storage source on access
2021-09-10 10:12:19 +07:00
90b47ab7f0
Merge pull request #28764 from nextcloud/feat/sharing-link-event
2021-09-10 09:31:18 +07:00
719480ad9d
Return proper watcher if SharedStorage originates from ExternalMount
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-09-10 08:55:54 +07:00
c56c317d82
Emit event on link share action
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2021-09-10 08:36:45 +07:00
27865d03c0
use specific email getter where necessary
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-09-09 19:23:05 +07:00
961f8958c0
Let users choose a share_folder
2021-09-06 16:39:11 +07:00
8597d9c7d4
add event for when a share is mounted
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-08-24 15:26:50 +07:00
f6f2f63016
Fix remote share deletion when deleting user
...
When deleting a user, we should only delete the direct remote user
shares or the remote group based subshares.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-07-27 14:32:51 +07:00
dac676c14e
Replace ILogger with LoggerInterface in remote share manager
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Co-authored-by: Carl Schwan <carl@carlschwan.eu>
2021-07-27 13:04:39 +07:00
e67e90afce
Fix remote group share decline+accept code path
...
When declining a remote group share through the dialog that appears when
notifications are off, the mount point is now correctly saved when
re-accepting.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-07-27 12:20:03 +07:00
e8f4a524a2
Fix external share manager with multiple user groups
...
Use query builder with proper matching for finding the group names.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-07-27 12:19:26 +07:00
15f41a6b72
Fix remote group share API interactions
...
Accepting and declining can now be done repeatedly on both the parent
group share and sub-share with the same effects.
Added unit tests to cover these cases, and also when the same operation
is repeated.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-07-27 12:19:26 +07:00
4b5bb4d9cf
Fix re-accepting or re-rejecting remote group shares
...
When accepting a group share, a sub-share entry is created which also
has a different id.
When accepting or rejecting the sub-share, simply update the "accepted"
flag instead of trying to re-insert the entry.
Adjust getShare to also properly validate group share membership
when called on a sub-share id.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-07-27 12:19:24 +07:00
cff8ae7ded
Add logging to external shares manager
...
Instead of just returning false, also log the exception to make
debugging database issues easier.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-07-27 12:19:24 +07:00
7130a98e47
Fix received federated group shares
...
Fix pending shares endpoint to consider user-specific sub-entries
for group shares whenever a share was accepted or declined.
Added unit test for adding remote group shares.
Fixed "removeUserShares" to not send a remote request as we never send
remote requests for group shares.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-07-27 12:19:23 +07:00
5d097ddb4b
Merge pull request #27875 from goyome/goyome-patch-group-shares-limit
...
No limit in the number of group shares
2021-07-14 13:45:50 +07:00
3a5918d932
No limit in the number of group shares
...
By default, autoaccept doesn't work if the user has more than 50 group shares
Signed-off-by: Guillaume COLSON <guillaume.colson@univ-lorraine.fr>
2021-07-08 16:56:26 +07:00
0c27faf711
Update "Sending password by Nextcloud Talk failed" sentence
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-07 13:39:57 +07:00
b78f3a57d1
Migrate HintException to OCP
...
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 +07:00
2690481cba
Use DI for files_sharing Cache
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-06-17 10:22:37 +07:00
095418493e
Use proper methods for display name retrieval
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-06-17 10:19:07 +07:00
818fc95b03
Merge pull request #26571 from nextcloud/bugfix/noid/existing-link-no-reshare
...
Only allow removing existing shares that would not be allowed due to reshare restrictions
2021-06-16 15:26:12 +07:00
c0474ba364
Use product name in places where it is appropriate rather than the instance name
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-16 11:42:53 +07:00
9774fb1573
use searchoperation for storage filter instead of db expression
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:25 +07:00
e198dc1b20
rework search api to allow searching on multiple caches at once
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-06-14 16:11:22 +07:00
ebf35fb38a
Correctly check the reception of a remote feedback
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2021-06-09 15:37:18 +07:00
06bfbb4a8c
When changing the share owner, downgrade permissions where needed
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-09 10:32:36 +07:00
4a2804dae2
Drop share if moved to a parent share that does not allow resharing
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-09 10:32:36 +07:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
e4b5645883
Also make other shares listen to the "Allow sharing with groups"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-26 11:19:58 +07:00
f1dbabd910
Merge pull request #26727 from nextcloud/group-exclude-link-share
...
Add option to exclude groups from creating link shares
2021-05-21 15:35:39 +07:00
b1ad3faf14
Merge pull request #25679 from nextcloud/drop/ocp-user
...
Drop \OCP\User
2021-05-21 15:05:38 +07:00
8196420063
Drop \OCP\User
...
Inlines and remaining usages and drops the deprecated public API.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-21 15:00:34 +07:00
35d978c2fc
Rename External storages to External storage
...
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-05-20 12:13:04 +07:00
9749968308
l10n: Unify spelling
...
Spelling unification in Nextcloud applications.
2021-05-20 09:22:08 +07:00
6f31d20f3d
Merge pull request #26580 from castillo92/patch-2
...
Fix casing of exception string
2021-05-18 09:29:45 +07:00
b1dca57a1c
load share settings from the share manager in more places
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:28 +07:00
701294520a
Add bruteforce protection to the shareinfo endpoint
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-05-12 09:34:45 +07:00
505863c55e
l10n: Change to a capital letter
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-04-27 12:38:28 +07:00
dcd45427a6
Make lookup search explicit
...
Speedsup sharee lookup quite a bit.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-19 20:05:21 +07:00
12948aa217
Update ShareAPIController.php
...
Change to capital letters in an abbreviation.
Signed-off-by: castillo92 javiercizquierdo@gmail.com
2021-04-16 08:56:20 +07:00
af61486aea
Separate settings for remote share expiration
...
Added separate settings for default and enforced expiration date for
remote shares.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +07:00
b0aaafe259
Fix expire date capability for federated shares
...
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:03 +07:00
8680bafc5c
Implement expiration date for federated shares
...
Add expiration date field in UI.
Save expiration date when creating or updating federated share.
Read expiration date from DB in federated share provider.
Applies to both federated user and group shares.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:00 +07:00
74a7c2eefc
Use correct getSystemValue type
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-12 22:54:50 +07:00
278a73789e
Map old account scope properties to new names
...
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +07:00
7995c6e1dc
dont return private storage interface from public mount interface
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-23 12:25:37 +07:00
f99876997a
Remove duplicated query for email shares
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 06:50:47 +07:00
100d5d9a47
Add labels to mail shares
...
Now the email is shown on a second line if a label is set.
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:34:09 +07:00
6401d88283
Merge pull request #25331 from nextcloud/fix-valid-storages-removed-when-cleaning-remote-storages
...
Fix valid storages removed when cleaning remote storages
2021-03-18 08:57:09 +07:00
e559afb8d4
Merge pull request #25136 from nextcloud/cachejail-search-filter
...
do cachejail search filtering in sql
2021-03-15 17:45:30 +07:00
6997344931
Log exceptions when creating share
...
Because the exceptions don't always contain a useful message for the UI,
but also because in some cases we need to find out what went wrong.
In some setups, a ShareNotFoundException might happen during creation
when we try to re-read the just written share. Usually related to Galera
Cluster where node syncing wait is not enabled.
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-15 12:00:41 +07:00
988b9f49c5
Fix invalid check after constructing DateTime
...
We construct an object. Either that works on not.But the result can't be
false.
Found by psalm
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 16:32:34 +07:00
b844293536
catch notfound and forbidden exception in smb::getmetadata
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-04 21:34:54 +07:00
cdc9a1efd9
Merge pull request #25912 from nextcloud/techdept/psalm/sharedstorage_some_types
...
Add some typing to SharedStorage
2021-03-04 12:31:17 +07:00
7b9ca4f7c2
Add some typing to SharedStorage
...
Makes psalm a bit more happy.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 10:49:42 +07:00
69c2864aca
Add appconfig to always show the unique label of a sharee
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-03-04 09:25:45 +07:00
ce430c3613
Merge pull request #25892 from nextcloud/techdept/initialstate/part1
...
Move some settings over to the IInitialState
2021-03-03 11:08:42 +07:00
bc961baa40
Move some settings over to the IInitialState
...
The old one has been deprecated. Part one of many.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 21:11:56 +07:00
5c952e83fc
Pimp sharingcheckmiddleware
...
Reported by psalm
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 20:36:04 +07:00
eb502c02ff
Bump nextcloud/coding-standard from 0.3.0 to 0.5.0
...
Bumps [nextcloud/coding-standard](https://github.com/nextcloud/coding-standard ) from 0.3.0 to 0.5.0.
- [Release notes](https://github.com/nextcloud/coding-standard/releases )
- [Changelog](https://github.com/nextcloud/coding-standard/blob/master/CHANGELOG.md )
- [Commits](https://github.com/nextcloud/coding-standard/compare/v0.3.0...v0.5.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-02-18 13:31:24 +07:00
2ea3cb7c93
Drop redundant indes
...
Those indexes are already covered by others. So those can just be used.
THose extra indexes just take up space.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-02-16 11:38:43 +07:00
9ccabff6ba
Fix valid storages removed when cleaning remote storages
...
The remote URL of a share is always stored in the database with a
trailing slash. However, when a cloud ID is generated trailing slashes
are removed.
The ID of a remote storage is generated from the cloud ID, but the
"cleanup-remote-storage" command directly used the remote URL stored in
the database. Due to this, even if the remote storage was valid, its ID
did not match the ID of the remote share generated by the command and
ended being removed.
Now the command generates the ID of remote shares using the cloud ID
instead, just like done by the remote storage, so there is no longer a
mismatch.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-01-28 21:42:31 +07:00
Robin Appelman
Carl Schwan
Vincent Petry
Louis Chemineau
Joas Schilling
Cyrille Bollu
Joas Schilling
Valdnet
Julius Härtl
blizzz
John Molakvoæ
Simon L
Côme Chilliet
Louis
John Molakvoæ (skjnldsv)
Hinrich Mahler
Guillaume Colson
Gary Kim
Morris Jobke
Christoph Wurst
Roeland Jago Douma
castillo92
J0WI
Daniel Calviño Sánchez
Christoph Wurst
Roeland Jago Douma
dependabot-preview[bot]