Commit Graph

19498 Commits (1f42657bb9ea76353fbc02ee100cff5755b6384d)

Author SHA1 Message Date
blizzz 0bbb195af1
Merge pull request #27354 from nextcloud/escape-download-response
Escape filename in Content-Disposition
2021-06-02 21:15:25 +07:00
John Molakvoæ 949102c031
Merge pull request #27088 from nextcloud/fix/27074/removing-apps
Allow removing apps with app store disabled
2021-06-02 21:10:05 +07:00
blizzz aa40bdea0f
Merge pull request #24295 from nextcloud/perf/noid/router
First attempt to check against core routes before loading all app routes
2021-06-02 21:03:29 +07:00
Lukas Reschke 377514aad1 Escape filename in Content-Disposition
We should escape all occurences of ' and \ in here.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-02 19:22:17 +07:00
Julius Härtl 4b1576e978
First attempt to check against core routes before loading all app routes
Most of the time we will find a matching route in either the loaded ones
matched on the URL or in the core ones. Therfore we can attempt to try
those first and only load all app routes if no match was found by the
Symfony URLMatcher.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-06-02 17:57:04 +07:00
Valdnet 9c6b01abeb
l10n: Spelling unification
Spelling unification in Transifex.

Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2021-06-02 17:49:32 +07:00
Bernard Spil f78420702c
Coalesce RewriteCond lines in .htaccess
And escape some '.' where not yet escaped
2021-06-02 17:32:33 +07:00
John Molakvoæ d0cf20cc51
Merge pull request #26792 from nextcloud/user-delete-cleanup-files
better cleanup of user files on user deletion
2021-06-02 17:02:00 +07:00
Joas Schilling 6578a93463
Merge pull request #27053 from nextcloud/bugfix/noid/dont-throw-when-comments-is-disabled
Don't throw when comments is disabled
2021-06-02 15:40:51 +07:00
Lukas Reschke 5438e00276
Merge pull request #27329 from nextcloud/propagate-throttle-state-for-baseresponse
Propagate throttling on OCS response
2021-06-01 21:40:41 +07:00
Lukas Reschke 09503b0269
Merge pull request #27316 from nextcloud/bugfix/noid/getNumberOfUnreadCommentsForObjects
Fix populating the array and closing the cursors
2021-06-01 21:01:01 +07:00
Christoph Wurst 84584959b0
Merge pull request #27328 from nextcloud/fix/noid/UserLoggedInEvent-apache-auth
emit UserLoggedInEvent on apache auth
2021-06-01 17:38:41 +07:00
Daniel Kesselberg 2b60587a2f
Add mbstring as dependency
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-06-01 15:43:08 +07:00
Lukas Reschke 09abcfadfa Propagate throttling on OCS response
The BaseResponse converter did not take over any throttling state from the DataResponse.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-01 14:15:23 +07:00
Arthur Schiwon 6ac4eafcf9
emit UserLoggedInEvent on apache auth
- post_login OC_Hook is barely used or listened to

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-01 13:59:40 +07:00
Christoph Wurst b29c3aa03f
Merge pull request #25658 from nextcloud/dav-respect-disallow-sharing-with-groups
Dav respect disallow sharing with groups
2021-06-01 12:07:29 +07:00
Joas Schilling c0c5340f4e
Fix populating the array and closing the cursors
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-06-01 09:15:34 +07:00
Daniel Kesselberg 747325fc43
Set local domain for swiftmailer transport
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-05-31 15:04:00 +07:00
Nextcloud bot 9e596dd0cf
[tx-robot] updated from transifex 2021-05-31 02:35:25 +07:00
Nextcloud bot 719430559f
[tx-robot] updated from transifex 2021-05-30 02:24:58 +07:00
Richard de Boer 7990f95558 Check whether output buffering is active before turning it off
Before we just turned it off and @suppressed the error if ob was not active.
In PHP 8 this error is no longer suppressed, so try to not cause it at all.

Signed-off-by: Richard de Boer <git@tubul.net>
2021-05-29 14:14:52 +07:00
Richard de Boer a0d265b0b1 Fix a usort comparison function returning a boolean instead of an integer
PHP 8 shows deprecation warnings about this, see #25806

Signed-off-by: Richard de Boer <git@tubul.net>
2021-05-29 14:14:52 +07:00
Richard de Boer f23d057ad9 Fix functions taking optional parameters before required ones
PHP 8 shows deprecation warnings about this, see #25806
Removes the "default" values, as they actually are required parameters anyway.

Signed-off-by: Richard de Boer <git@tubul.net>
2021-05-29 14:14:52 +07:00
Morris Jobke 77d6611fa0
Merge pull request #27199 from nextcloud/fix/26683/use-noreply-as-share-email
Use noreply@ as email address for share emails
2021-05-28 13:40:12 +07:00
Morris Jobke fb7899135e
Merge pull request #27187 from Simounet/fix/comments-query-oracle-limit-compliance
Fix Oracle query limit compliance in Comments
2021-05-28 11:19:36 +07:00
Morris Jobke dc9bdd4f39
Use noreply@ as email address for share emails
Fixes #26683

Before it used the instance name, which a) doesn't make sense to randomly guess email addresses and b) could contain characters that are not allowed in email addresses like spaces.

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-05-28 11:13:24 +07:00
Simounet a50eba16ad
Fix Oracle query limit compliance in Comments
Signed-off-by: Simounet <contact@simounet.net>
2021-05-28 08:48:01 +07:00
blizzz 6f063c2ee9
Merge pull request #25770 from nextcloud/fix/25742/cli-cache-backend-recursion
Don't allow executing cli if cache backend is unavailable
2021-05-27 17:56:11 +07:00
kesselb 222ac93774
Merge pull request #27117 from nextcloud/fix/add-exception-doc-to-qbmapper
Add DB exception '@throws' tag to QBMapper PHPDoc
2021-05-26 17:11:49 +07:00
Anna Larch 8fcb3f33c8 Add DB exception throws tag to QBMapper PHPDoc
Signed-off-by: Anna Larch <anna@nextcloud.com>
2021-05-26 15:12:41 +07:00
Joas Schilling e4b5645883
Also make other shares listen to the "Allow sharing with groups"
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-26 11:19:58 +07:00
Richard Steinmetz 0f949eaeb1
Don't allow executing cli if cache backend is unavailable
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2021-05-26 11:02:26 +07:00
Nextcloud bot accfe5b82d
[tx-robot] updated from transifex 2021-05-26 02:28:28 +07:00
Morris Jobke 6ed728d76c
Merge pull request #27043 from nextcloud/storage-info-include-external
fix return value of getStorageInfo when 'quota_include_external_storage' is enabled
2021-05-25 21:57:23 +07:00
blizzz 1b47886abb
Merge pull request #27035 from nextcloud/techdebt/26866/userscontroller-accountmanager-api
do not use private AccountManager in UsersController
2021-05-25 21:22:37 +07:00
Morris Jobke 3d1c78647e
Merge pull request #23065 from TomG736/FixEmptyDisplayName
Fix null displayname crash as described in #21885
2021-05-25 21:13:00 +07:00
kesselb 1b21b173e6
Merge pull request #27104 from nextcloud/properly-name-execute
[Quick Review] executeUpdate is also deprecated
2021-05-25 20:44:51 +07:00
Lukas Reschke 4e7b82169c executeUpdate is also deprecated
Ref 1089ad5d9e/lib/private/DB/QueryBuilder/QueryBuilder.php (L312-L323)

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-05-25 20:25:44 +07:00
Lukas Reschke a521ed874c Remove unused constants
No calls in all of GitHub as per https://sourcegraph.com/search?q=USER_AGENT_OWNCLOUD_&patternType=literal

Deprecation has also been years ago.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-05-25 19:01:48 +07:00
Morris Jobke 726d01843e
Merge pull request #26600 from hosting-de/feature/occ-tags
Add commands to manage tags via OCC
2021-05-25 16:54:06 +07:00
Vincent Petry 0815be1ca8
Merge pull request #27062 from nextcloud/search-limit-offset-jail
properly use limit and offset for search in Jail wrapper
2021-05-25 15:47:09 +07:00
Arthur Schiwon 847ed37afc
do not use private AccountManager in UsersController
- extends IAccountProperty for verificationData getters and setters
- implementation thereof ^
- and of course adaption of UsersController

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-25 14:35:38 +07:00
Maxence Lange 65649468f3 force 'name' key in array
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2021-05-25 09:33:20 +07:00
Johannes Leuker d606799ee2 Add commands to manage tags via OCC
list, add, delete, edit

Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-05-25 11:29:32 +07:00
Morris Jobke 333665b43d
Merge pull request #27040 from nextcloud/FlorentCoppint-master
Avoid reading ~/.aws/config when using S3 provider
2021-05-25 10:19:22 +07:00
Nextcloud bot 3fa2437223
[tx-robot] updated from transifex 2021-05-25 02:27:20 +07:00
Gary Kim 92555b6014
Allow removing apps with app store disabled
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-05-24 10:35:51 +07:00
Nextcloud bot 8d80ee547b
[tx-robot] updated from transifex 2021-05-23 02:25:47 +07:00
Nextcloud bot 41f0cf4fca
[tx-robot] updated from transifex 2021-05-22 02:27:14 +07:00
kesselb 9a80052eeb
Merge pull request #27052 from nextcloud/bugfix/noid/fix-log-entry-readability
Fix log entry readability
2021-05-21 20:45:55 +07:00
Robin Appelman 7ee528fc5a
properly use limit and offset for search in Jail wrapper
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-21 15:37:38 +07:00
Morris Jobke f1dbabd910
Merge pull request #26727 from nextcloud/group-exclude-link-share
Add option to exclude groups from creating link shares
2021-05-21 15:35:39 +07:00
Morris Jobke b1ad3faf14
Merge pull request #25679 from nextcloud/drop/ocp-user
Drop \OCP\User
2021-05-21 15:05:38 +07:00
Christoph Wurst 8196420063
Drop \OCP\User
Inlines and remaining usages and drops the deprecated public API.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-21 15:00:34 +07:00
Joas Schilling 5ae5729664
Don't throw when comments is disabled
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-21 12:04:23 +07:00
blizzz 4aae71cd77
Merge pull request #27032 from nextcloud/bugfix/noid/log-rotation-error
Fix filesize error on log rotation, if file does not exist
2021-05-21 11:40:40 +07:00
Julius Härtl b900d64fd4
Merge pull request #26832 from nextcloud/object-close-stream-non-count
explicitly close source stream on object store upload even if count…
2021-05-21 11:30:43 +07:00
Morris Jobke b2c2f32968
Merge pull request #27039 from nextcloud/fix/2973/rename-external-storages
Rename External storages to External storage
2021-05-21 11:09:52 +07:00
Joas Schilling f602c9328e
Fix log entry readability
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-21 09:07:45 +07:00
Nextcloud bot a6cb2973a9
[tx-robot] updated from transifex 2021-05-21 02:27:50 +07:00
Robin Appelman 7e22487278
fix return value of getStorageInfo when 'quota_include_external_storage' is enabled
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-20 13:55:49 +07:00
Florent d4444f2472
Avoid reading ~/.aws/config when using S3 provider
When using S3 storage, we sometimes have open_basedir errors due to aws-sdk-php trying to read ~/.aws/config which is out of open_basedir restrictions.
Christoph Wurst already added csm=false config in #21406 but it wasn't enough, we also need to set use_arn_region=false, added in this commit.

Signed-off-by: Florent <florent@coppint.com>
2021-05-20 12:21:15 +07:00
szaimen 35d978c2fc Rename External storages to External storage
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-05-20 12:13:04 +07:00
Valdnet e7648c2fdd
l10n: Unify spelling
Spelling unification in Nextcloud applications.
2021-05-20 09:26:38 +07:00
Valdnet 11dc65869d
l10n: Unify spelling
Spelling unification in Nextcloud applications.
2021-05-20 09:26:37 +07:00
Valdnet 2137480a06
l10n: Unify spelling
Spelling unification in Nextcloud applications.
2021-05-20 09:22:07 +07:00
Valdnet 1abb48375a
l10n: Unify spelling
Spelling unification in Nextcloud applications.
2021-05-20 09:22:07 +07:00
Robin Appelman ed2396b045
better cleanup of filecache when deleting an external storage
this way it can delete the cache entries even with per-user credentials

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-19 17:08:20 +07:00
dartcafe 40929cba79
typo
Signed-off-by: dartcafe <github@dartcafe.de>
2021-05-19 15:46:01 +07:00
dartcafe 7c77e74314
fix #25813
Signed-off-by: dartcafe <github@dartcafe.de>
2021-05-19 13:55:29 +07:00
Morris Jobke a577768aa6
Refine version comparision for repair job for major version updates
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-05-19 10:12:57 +07:00
Joas Schilling b89f4b33f0
Merge pull request #26834 from nextcloud/enh/only_run_once
Inject the repair job only once
2021-05-19 09:51:40 +07:00
Joas Schilling 4a02726f37
Merge pull request #26852 from nextcloud/fix-noauth-cors
fix error when using CORS with no auth credentials
2021-05-19 09:51:28 +07:00
Roeland Jago Douma aa785d266d
Merge pull request #26963 from nextcloud/bugfix/noid/empty-template-error
Fix log error when creating files from an empty template
2021-05-19 08:46:18 +07:00
Julius Härtl b8d0249b0e Fix log error when creating files from an empty template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-05-18 10:24:14 +07:00
Julius Härtl 35b910cf8e
Merge pull request #26322 from nextcloud/recent-search
Use file search for recent files and optimize getting share types
2021-05-18 09:44:08 +07:00
Roeland Jago Douma ee3dc57cbd
Merge pull request #26626 from J0WI/strict-security
Make Security module strict
2021-05-18 08:43:13 +07:00
korelstar b38e8678e4 fix error when using CORS with no auth credentials 2021-05-18 07:11:10 +07:00
Nextcloud bot 5ea903d824
[tx-robot] updated from transifex 2021-05-16 02:26:44 +07:00
blizzz 0ab5b3e265
Merge pull request #26679 from nextcloud/bugfix/noid/fix-unauthorized-ocs-status-in-provisioning
Fix unauthorized OCS status in provisioning
2021-05-13 23:39:20 +07:00
Arthur Schiwon 2ee34ff76c
Repair job to use public AccoutManager API
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 22:55:28 +07:00
Robin Appelman a9eb1f6af3
update public interface with new methods
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:35 +07:00
Robin Appelman 0e6321957d
allow excluding groups from creating link shares
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:31 +07:00
Robin Appelman b1dca57a1c
load share settings from the share manager in more places
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-05-12 16:11:28 +07:00
blizzz 7e1c842d96
Merge pull request #26923 from nextcloud/techdebt/noid/provapi-no-private-accountmanager
provisioning API to use only public API of IAccountManager
2021-05-12 14:17:50 +07:00
Joas Schilling b6c6527705
Fix unauthorized OCS status in provisioning
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-12 08:16:07 +07:00
Arthur Schiwon 8413ed9475
allow to set valid scopes only in AccountProperty
the auto-fallback to v2-local is removed as well to react on wrong input

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-05-12 01:31:15 +07:00
Nextcloud bot 461a975749
[tx-robot] updated from transifex 2021-05-08 02:24:54 +07:00
Morris Jobke ed2d6eee1e
Merge pull request #26848 from nextcloud/bugfix/noid/add-datetime-support-to-qbmapper
Add datetime support to QBMapper
2021-05-07 16:02:53 +07:00
Nextcloud bot 42f0f27240
[tx-robot] updated from transifex 2021-05-06 02:25:32 +07:00
Morris Jobke 1089ad5d9e
Merge pull request #26877 from nextcloud/chore/query-builder-execute-statement
Rename IQueryBuilder::executeUpdate to IQueryBuilder::executeStatement
2021-05-05 14:19:02 +07:00
Joas Schilling 784b059a01
Don't break OCC if an app is breaking in it's Application class
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-05 10:41:18 +07:00
Christoph Wurst 865661ed75
Rename IQueryBuilder::executeUpdate to IQueryBuilder::executeStatement
Because executeUpdate wasn't a great name. And in DBAL they also use
executeStatement more consistently now.

Ref https://github.com/doctrine/dbal/issues/4607

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-05 10:31:54 +07:00
Nextcloud bot 6d3aef1849
[tx-robot] updated from transifex 2021-05-04 02:26:15 +07:00
Nextcloud bot a5faa98e6e
[tx-robot] updated from transifex 2021-05-02 02:25:23 +07:00
Joas Schilling 5c4c527245
Add datetime support to QBMapper
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-05-01 11:59:19 +07:00
Julius Härtl 1e2cf820c8
Filter mounts for file id before trying to get user information
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-30 07:55:38 +07:00
Nextcloud bot f3baab3159
[tx-robot] updated from transifex 2021-04-30 02:27:46 +07:00
Roeland Jago Douma 3b074c811a Inject the repair job only once
Since we backproted we should do a better check. Else we run the code
again for everybody upgrading to 22.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-29 20:23:12 +07:00
Robin Appelman ef6f2e68f0
explicitly close source stream on object store upload even if count wrapper isn't needed
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-29 17:01:19 +07:00
Nextcloud bot e0f700b1bd
[tx-robot] updated from transifex 2021-04-29 02:26:26 +07:00
Roeland Jago Douma 758a662b23 Do not try to contact lookup server if not needed
In some cases (for example you never send data to the lookup server)
there is no need for this job to even try.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-28 14:27:46 +07:00
Christoph Wurst 6a5d89c1ac
Merge pull request #26758 from J0WI/more-strict
Some more strict_types
2021-04-28 09:28:19 +07:00
Nextcloud bot be4f665d2d
[tx-robot] updated from transifex 2021-04-28 02:25:44 +07:00
Robin Appelman ed2d02d5f1
better cleanup of user files on user deletion
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-27 20:29:51 +07:00
Christoph Wurst 99f0b10421
Merge pull request #26591 from nextcloud/techdebt/noid/less-ilogger
Less ILogger
2021-04-27 15:38:12 +07:00
Joas Schilling 48c50277a9
Merge pull request #26718 from nextcloud/bugfix/noid/fix-ratelimit-template
Fix ratelimit template
2021-04-27 15:18:02 +07:00
Joas Schilling c52a026f55
Merge pull request #26572 from nextcloud/bugfix/noid/throw-401-when-authentication-is-provided-and-invalid
Throw "401 Unauthenticated" when authentication is provided but invalid
2021-04-27 14:37:28 +07:00
Joas Schilling 2d75868935
Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:33 +07:00
Joas Schilling 29a66a5e49
Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +07:00
Joas Schilling 167efa19d7
Fix psalm errors
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +07:00
Joas Schilling df47445c01
Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +07:00
Joas Schilling 56ae87c281
Less ILogger
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +07:00
Joas Schilling 13b37a5255
Do not allow to overwrite some variables
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:55:35 +07:00
Joas Schilling 174f4dd043
Fix ratelimit template
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 13:55:34 +07:00
Joas Schilling bf1c875425
Merge pull request #26764 from nextcloud/feature/noid/add-geo-location-as-ROS-type
Add geo location as ROS type
2021-04-27 13:54:28 +07:00
Nextcloud bot 2aad4bbed6
[tx-robot] updated from transifex 2021-04-27 02:25:33 +07:00
Joas Schilling 7d3c135146
Add geo location as ROS type
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 16:47:01 +07:00
Joas Schilling 21ed3419f3
Log deprecation only as debug
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 16:19:03 +07:00
Joas Schilling 8d9e5e0b91
Respect the error level when logging
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-26 14:18:18 +07:00
Joas Schilling aa651fd629
Merge pull request #26259 from nextcloud/feature/noid/validate-website-to-be-valid
Validate the website field input to be a valid URL
2021-04-26 13:56:01 +07:00
Lukas Reschke e1a3000cbe
Merge pull request #26747 from nextcloud/php8-libxml
Fix installer deprecation warnings for PHP 8
2021-04-26 12:44:38 +07:00
J0WI a369933084 Fix ini_set() type
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-26 12:44:05 +07:00
J0WI efc5c57a79 Some more strict_types
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-26 12:33:45 +07:00
Roeland Jago Douma bf9ed2d3cd
Merge pull request #26721 from nextcloud/fix/noid/final-private
private cannot be final
2021-04-26 09:04:18 +07:00
Nextcloud bot 4ded8a08b7
[tx-robot] updated from transifex 2021-04-26 02:24:39 +07:00
acsfer 3d900b1e58
PHP 8+ deprecates openssl_free_key 2021-04-25 13:50:23 +07:00
acsfer 5882648cac
Only use libxml_disable_entity_loader on PHP<8 2021-04-25 13:45:14 +07:00
Nextcloud bot da17db0fdc
[tx-robot] updated from transifex 2021-04-25 02:24:52 +07:00
Nextcloud bot 39764b05b1
[tx-robot] updated from transifex 2021-04-24 02:26:38 +07:00
Maxence Lange bb32880ec4 private cannot be final
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2021-04-23 11:00:10 +07:00
Daniel Calviño Sánchez 7159a70894 Guard against null phone number value
"parsePhoneNumber()" expects a string, so a TypeError would be thrown if
the phone number value is null.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2021-04-23 11:44:42 +07:00
Nextcloud bot 539c065e8e
[tx-robot] updated from transifex 2021-04-23 02:26:10 +07:00
Morris Jobke 012f791c8f
Merge pull request #26375 from nextcloud/techdebt/noid/symfony-component-translation-pluralization-rules-is-deprecated
"Symfony\Component\Translation\PluralizationRules" is deprecated
2021-04-22 21:20:16 +07:00
Joas Schilling d80cc76ee7
Validate the website field input to be a valid URL
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 16:34:13 +07:00
Arthur Schiwon e7691ef6ab
remove undefined parameter, add description
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-22 16:23:01 +07:00
Joas Schilling 521bb30541
Throw "401 Unauthenticated" when authentication is provided but invalid
E.g. with an AppToken that has been revoked

Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-22 15:28:43 +07:00
Morris Jobke 393309b98f
Merge pull request #25714 from nextcloud/fix/23197/explicitly_check_hex2bin_input
Explicitly check hex2bin input
2021-04-22 13:23:39 +07:00
Robin Appelman effb7dc8ba
set mimetype for objects uploaded to object storages
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-21 15:25:58 +07:00
Robin Appelman 0d5f4edc22
adjust tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-21 14:09:07 +07:00
Robin Appelman e8221303e9
use search query for Folder::getRecent
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-04-21 13:56:04 +07:00
Nextcloud bot e58344fb2a
[tx-robot] updated from transifex 2021-04-21 02:25:58 +07:00
Roeland Jago Douma a34085e1a2 Move 2fa backupscode to new registration
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 21:01:16 +07:00
Roeland Jago Douma 5ee9e1f784 Move 2FA registration to IBootstrap
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-20 21:01:16 +07:00
Roeland Jago Douma 46872e3921
Merge pull request #26617 from nextcloud/fix/oracle-column-check-unrelated-migrations
Do not check Oracle column constraints in unrelated migrations
2021-04-20 20:49:06 +07:00
Roeland Jago Douma f31d24dd7a
Merge pull request #26647 from nextcloud/bugfix/noid/empty-filename
Fail when creating new files with an empty path
2021-04-20 20:47:16 +07:00
Joas Schilling 3cf447ac44
Fix PHP CS
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:43 +07:00
Joas Schilling 2b8e47dcac
Correclty use plural for share exception
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:43:40 +07:00
Joas Schilling 5a514a9a41
Correctly replace all PHP placeholders with the parameters
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:05 +07:00
Joas Schilling 439457d2b4
Fix languages that miss a string in the translation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:04 +07:00
Joas Schilling a4c6749b02
Add a check for the pipe character
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:04 +07:00
Joas Schilling 157147cb8e
"Symfony\Component\Translation\PluralizationRules" is deprecated
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-20 16:42:04 +07:00
Arthur Schiwon f8d1ee5cfa
ignore mail shares of related remote share results
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-20 14:02:35 +07:00
Julius Härtl 8398762d78
Fail when creating new files with an empty path
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-20 11:20:20 +07:00
Nextcloud bot 79116e825c
[tx-robot] updated from transifex 2021-04-20 02:25:58 +07:00
J0WI ca7b37ce5a Make Security module strict
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-19 17:31:12 +07:00
Christoph Wurst 2ab8268128
Do not check Oracle column constraints in unrelated migrations
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-04-19 13:05:34 +07:00
Roeland Jago Douma fc11617222 Deprecate the old way
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 13:56:28 +07:00
Roeland Jago Douma 808e589035 Allow registering NotifierServices trough IBootstrap
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-04-16 13:56:28 +07:00
Joas Schilling 25d11b5197
Fix constraint violation detection in QB Mapper
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-16 10:12:17 +07:00
Vincent Petry af61486aea
Separate settings for remote share expiration
Added separate settings for default and enforced expiration date for
remote shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:06:09 +07:00
Vincent Petry 8680bafc5c
Implement expiration date for federated shares
Add expiration date field in UI.
Save expiration date when creating or updating federated share.
Read expiration date from DB in federated share provider.
Applies to both federated user and group shares.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-04-15 10:02:00 +07:00
Nextcloud bot 8ef920fdf9
[tx-robot] updated from transifex 2021-04-15 02:25:10 +07:00
Roeland Jago Douma f031dd61c1
Merge pull request #26551 from nextcloud/fix/noid/redis-exists-bool
ensure redis returns bool for hasKey
2021-04-14 13:37:23 +07:00
Roeland Jago Douma 644ce9e4f0
Merge pull request #26529 from J0WI/getSystemValue-type
Use correct getSystemValue type
2021-04-14 13:36:56 +07:00
Nextcloud bot 7081c63d09
[tx-robot] updated from transifex 2021-04-14 02:26:51 +07:00
Arthur Schiwon 9f5480eef4
ensure redis returns bool for hasKey
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-04-13 23:07:54 +07:00
Joas Schilling 421914b4d0
Merge pull request #26467 from nextcloud/feature/noid/allow-apps-to-log-to-audit
Allow apps to log actions into the audit_log
2021-04-13 08:52:08 +07:00
Nextcloud bot bab06b9abb
[tx-robot] updated from transifex 2021-04-13 02:24:57 +07:00
J0WI 74a7c2eefc Use correct getSystemValue type
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-12 22:54:50 +07:00
Roeland Jago Douma 789bb0d0ac
Merge pull request #26266 from nextcloud/future-proof-networking
Improve networking checks
2021-04-12 12:42:33 +07:00
Joas Schilling 6d502041e0
Fix version
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-12 10:31:10 +07:00
Joas Schilling 99e5367208
Move to another namespace and class name
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-09 12:51:57 +07:00
Joas Schilling ca939214bd
Allow apps to log actions into the audit_log
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-09 10:32:45 +07:00
Maxime Besson 547438527d fix(proxy): reaching s3 storage behind some http proxy
Signed-off-by: Maxime Besson <maxime.besson@worteks.com>
2021-04-09 10:15:57 +07:00
Samuel 03fe74b95e fix(proxy): reaching s3 storage behind some http proxy
Signed-off-by: Maxime Besson <maxime.besson@worteks.com>
2021-04-09 10:15:57 +07:00
Nextcloud bot 9de329a4c2
[tx-robot] updated from transifex 2021-04-09 02:25:11 +07:00
Roeland Jago Douma 2bedbc1793
Merge pull request #26439 from nextcloud/increase-subnet-matcher
Increase subnet matcher
2021-04-08 14:48:27 +07:00
Lukas Reschke 2befac662c Limit size of properties to 2048 characters
It is unreasonable to expect that one of these fields would be longer
than 2048 characters. Whilst some have definitely lower limits (such as
for phone numbers or domain names), a upper bound as sanity check makes
sense.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-08 11:55:51 +07:00
Lukas Reschke e5a4236e68 Increase subnet matcher
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-07 12:28:59 +07:00
Nextcloud bot c391e8692b
[tx-robot] updated from transifex 2021-04-07 02:24:14 +07:00
Lukas Reschke 4b4971ab52
Merge pull request #24966 from nextcloud/jknockaert-patch-1
avoid fread on directories and unencrypted files
2021-04-06 13:45:10 +07:00
Lukas Reschke 5fe1f134f9 Strictify null check
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-06 11:39:24 +07:00
Lukas Reschke d5c7bb2188 Generate autoload files
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-06 11:37:47 +07:00
Lukas Reschke 5f3abffe6f Improve networking checks
Whilst we currently state that SSRF is generally outside of our threat model, this is something where we should invest to improve this.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-04-06 11:37:47 +07:00
Nextcloud bot e9075b02cd
[tx-robot] updated from transifex 2021-04-06 02:25:33 +07:00
J0WI 0c9b8ad051 Return early if path is root
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-04-05 17:19:34 +07:00
Nextcloud bot bb3ba96b37
[tx-robot] updated from transifex 2021-04-05 02:24:46 +07:00
Nextcloud bot bfd926938f
[tx-robot] updated from transifex 2021-04-04 02:24:48 +07:00
Nextcloud bot 6f55d2e293
[tx-robot] updated from transifex 2021-04-03 02:25:32 +07:00
Nextcloud bot 4bea123c7a
[tx-robot] updated from transifex 2021-04-02 02:26:04 +07:00
Morris Jobke 5fb909faa5
Merge pull request #24055 from nextcloud/bugfix/noid/enfore-no-notnull-for-boolean-to-store-false
Enforce no notnull for boolean to store false
2021-04-01 18:30:26 +07:00
Julius Härtl 6fd571461c
Properly handle creating the template directory in a subfolder (fixes #25787)
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 13:48:21 +07:00
Julius Härtl 37591f05dc
Get the parent directory before creating a file from a template
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-04-01 13:48:21 +07:00
Julius Härtl bbc64cfabc
Merge pull request #26394 from nextcloud/feature/noid/updatable-account-data
Allow apps to write/update account data
2021-04-01 08:05:54 +07:00
Robin Appelman 65b78515bd
make ILDAPProviderFactory usable when there is no ldap setup
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-31 15:23:33 +07:00
Joas Schilling fcedbc85d0
Allow apps to write/update account data
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 15:18:25 +07:00
Joas Schilling f9d4fa2d38
Rename the method to match what it does
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:18 +07:00
Joas Schilling 3696ef5b96
Don't allow Notnull for boolean columns
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:17 +07:00
Joas Schilling 133a6f4fe4
Document the constraints we test against
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:17 +07:00
Joas Schilling c98cab137c
Fix exception messages spacing
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-31 10:21:10 +07:00
Nextcloud bot 855b5fc638
[tx-robot] updated from transifex 2021-03-31 02:24:50 +07:00
kesselb 2212a67fbc
Merge pull request #25961 from nextcloud/enh/events/2fa_provider
Add real events for enabled 2fa providers for users
2021-03-30 23:13:36 +07:00
Roeland Jago Douma f3738eeff7
Merge pull request #25280 from nextcloud/explicit-file-permissions
Set umask before operations that create local files
2021-03-30 21:55:50 +07:00
Roeland Jago Douma 7c30d1aa2d
Merge pull request #26219 from nextcloud/relative-path-null
getRelativePath can return null
2021-03-30 21:10:05 +07:00
Arthur Schiwon be3ae9a44b
gracefully handle deleteFromSelf when share is already gone
- handling race conditions

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-03-30 12:59:40 +07:00
Joas Schilling 602de272c0
Merge pull request #26243 from nextcloud/enh/noid/avatar-privacy-new-scope
Avatar privacy and new scope
2021-03-29 09:01:12 +07:00
Nextcloud bot be83a32411
[tx-robot] updated from transifex 2021-03-28 02:24:04 +07:00
Morris Jobke 83c7b54ba6
Merge pull request #26327 from nextcloud/fix-get-return
fix return value of Root::get
2021-03-27 22:26:32 +07:00
J0WI 5f468c0248 Cleaner removePassword regex
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-03-27 18:42:58 +07:00
Nextcloud bot aec9c8437a
[tx-robot] updated from transifex 2021-03-27 02:24:25 +07:00
Robin Appelman c8736e7a23
fix return value of Root::get
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-26 21:29:24 +07:00
Vincent Petry 5a8b7c1cb2
Update autoloader for PlaceholderAvatar
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:10 +07:00
Vincent Petry cc54f718f5
Add known user check in avatar when v2-private scope
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:10 +07:00
Vincent Petry bb008be28a
Added PlaceholderAvatar with own cached images
When avatar scope is private, the PlaceholderAvatar is used to deliver a
placeholder avatar based on the user's initials.

This was implemented as a separate class for now to avoid messing with
the existing UserAvatar implementation and its generated vs
non-generated logic.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +07:00
Vincent Petry b73df5846c
Add property scope tests for AccountManager
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:09 +07:00
Vincent Petry 266a6fb5f8
OCS allow reading and writing account property scopes
Extends the provisioning API to allow a user to get and set their own
account property scopes.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +07:00
Vincent Petry 278a73789e
Map old account scope properties to new names
Use new scope values in settings page.
Adjust all consumers to use the new constants.
Map old scope values to new ones in account property getter.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:08 +07:00
Vincent Petry b81a1c1bdb
Add new v2-private account scope
Added new v2-private account manager scope that restricts the scope
further by excluding public link access.

Avatars with v2-private account scope are now showing the guest avatar
instead of the real avatar.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-03-26 13:07:05 +07:00
Roeland Jago Douma a75f0e62fa
Merge pull request #26308 from nextcloud/enhancement/timed-job-interval-description
Document that the TimedJob interval is in seconds
2021-03-26 10:45:50 +07:00
Roeland Jago Douma 9fd29173cf
Merge pull request #26281 from hosting-de/fix/email
Change my email address
2021-03-26 09:59:35 +07:00
Christoph Wurst 389623a910
Document that the TimedJob interval is in seconds
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-03-26 09:13:05 +07:00
Morris Jobke 81fef4ddee
Log when a storage is marked as unavailable
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-25 16:19:08 +07:00
Roeland Jago Douma f97491eb8f
Merge pull request #26285 from nextcloud/techdebt/noid/cleanup-update-events
Remove event listener to udpate events that are not present anymore
2021-03-25 11:12:34 +07:00
Morris Jobke ad16b19ec7
Merge pull request #21484 from nextcloud/better-forbidden-path-errors
show better error messages when a file with a forbidden path is encountered
2021-03-25 09:15:52 +07:00
Morris Jobke 3388758d04
Remove event listener to udpate events that are not present anymore
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-25 09:01:09 +07:00
Roeland Jago Douma c15172bc4e
Merge pull request #21641 from nextcloud/techdebt/noid/bye-bye-database-xml
Bye bye database xml
2021-03-25 08:58:07 +07:00
Nextcloud bot 9af8c0b380
[tx-robot] updated from transifex 2021-03-25 02:25:39 +07:00
Morris Jobke ab48d5e8cb
Cleanup unneeded code around database.xml
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-03-24 22:15:44 +07:00
Joas Schilling bb0c50717c
Bye bye database.xml
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-24 20:04:12 +07:00
Robin Appelman aee4caed07
show better error messages when a file with a forbidden path is encountered
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 17:13:09 +07:00
Robin Appelman db0e198fe0
improve type handling of Avatar::generateAvatarFromSv
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 17:09:53 +07:00
Johannes Leuker e9ca59ef0a Change my email address
Signed-off-by: Johannes Leuker <j.leuker@hosting.de>
2021-03-24 15:13:56 +07:00
Robin Appelman 8a92229485
getStorage can also return null
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 14:56:40 +07:00
Robin Appelman e8184eaaad
proper error for search results outside user folder
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 14:33:35 +07:00
Robin Appelman f842608c95
getRelativePath can return null
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-24 14:30:29 +07:00
Joas Schilling 02c011c4f7
Make debugging easier which header is being set
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-24 13:22:44 +07:00
John Molakvoæ (skjnldsv) 2074d87d0c
Catch invalid cache source storage path
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-24 10:36:51 +07:00
Robin Appelman e5dc1a8085
Set umask before operations that create local files
this solves issues where "other php stuff" is messing with the umask

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-23 14:52:31 +07:00
Nextcloud bot a81408a8e1
[tx-robot] updated from transifex 2021-03-23 02:24:02 +07:00
Morris Jobke 1c074e7602
Merge pull request #26198 from nextcloud/unified-search-node
Handle limit offset and sorting in files search
2021-03-22 21:48:51 +07:00
Morris Jobke 1eb084cfd3
Merge pull request #25498 from Worteks/feat-federatedfilesharing-logging
feat(federatedfilesharing): log errors, as suggested by @maxbes
2021-03-22 21:21:53 +07:00
Morris Jobke 268acd301d
Merge pull request #25529 from nextcloud/fix-non-lgc-glyphs-in-avatars-and-txt-file-previews
Fix non LGC glyphs in avatars and txt file previews
2021-03-22 21:06:22 +07:00
Roeland Jago Douma 3c5cf825b3 Add real events for enabled 2fa providers for users
* Shiny new events
* Listener to still emit the old event

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-22 20:57:10 +07:00
Joas Schilling f35d7adf7d
Don't hardcode the product name to Nextcloud but use the theming value
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-03-22 16:32:35 +07:00
John Molakvoæ (skjnldsv) 15767643f2
Fix sharebymail tests
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:47 +07:00
Daniel Calviño Sánchez f99876997a
Remove duplicated query for email shares
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-03-22 06:50:47 +07:00
John Molakvoæ (skjnldsv) a100186e5e
Sharing link & mail parity
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:45 +07:00
Nextcloud bot ae19cb168f
[tx-robot] updated from transifex 2021-03-22 02:23:45 +07:00
Nextcloud bot 8c7e246d98
[tx-robot] updated from transifex 2021-03-21 02:23:12 +07:00