The MailPlugin collaborator returned results for both user and mail
collaborators, but it was registered only for mail collaborators. While
it might make sense to move the user results to the UserPlugin instead
that change would be more complex and riskier, so for now the MailPlugin
is now registered for both user and mail collaborators and the results
are limited only to the registered type.
As the plugins are registered only with their class and then resolved
when needed using dependency injection it is not possible (as far as I
know) to provide an explicit parameter in the constructor to
differentiate whether the MailPlugin should return user or mail
collaborators. To overcome this two subclasses are introduced,
MailByMailPlugin and UserByMailPlugin, which just hardcode in their
constructor the collaborator type that their parent MailPlugin must use,
and those subclasses are the ones registered instead of the MailPlugin
(which still contains all the logic).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The "sharebymail" app is enabled by default, so it needs to be enabled
once the scenario ends as other scenarios could expect that the app is
enabled. To solve that now a special step is added that records the
enabled state of the given app and restores it once the scenario ends.
This step only restores the state of already installed apps. If an app
is installed during the test it will not be neither disabled nor
uninstalled after the test ends. Therefore, at least for now, it is
necessary to explicitly call the step to record the app to be restored,
rather than automatically keeping track of the changes in the enabled
state of the apps during the scenario.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The OCS endpoint expects either an int or an array for "shareType".
However, when using "getRowsHash()" only a single key is taken into
account, so instead of:
| shareType[] | 0 |
| shareType[] | 4 |
the share types are provided in a single row like:
| shareTypes | 0 4 |
and then converted to "shareType[]=0&shareType[]=4" when sending the
request.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
- the old approach lead connection issues, as ldap_set_option was called
too late. Specifically it needs to be called before ldap_connect and set
globally!
- The old approach also connected it to the ldapTLS configuration, which
has a misleading naming. It indicates StartTLS usage only, not plain TLS
connections.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
When hitting the `/contactsmenu/contacts` endpoint with the `dav.system_addressbook_exposed` config switch set to `"no"`, the system address book content is still listed in the response.
This ensure that we do not expose unexpectedly the system address book.
Signed-off-by: Louis Chemineau <louis@chmn.me>
* Fixes the problem with MariaDB 11 and `vector` keyword, see https://github.com/nextcloud/recognize/issues/1352
| Production Changes | From | To | Compare |
|--------------------|-------|---------|----------------------------------------------------------------|
| doctrine/cache | 2.2.0 | REMOVED | |
| doctrine/dbal | 3.9.4 | 3.10.2 | [...](https://github.com/doctrine/dbal/compare/3.9.4...3.10.2) |
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
- Follow-up of #51600
The original PR introduced the possibility to continue an `ExpireTrash` job by saving the offset. This was to prevent having to start over the whole user list when the job crashed or was killed.
But on big instances, one process is not enough to go through all the users in a timely manner. Supporting parallel run allows covering more ground faster.
This PR introduced this possibility. We are now storing the offset right away to allow another parallel job to pick up the task at that point. We are arbitrarily cutting the user list in chunk of 10 to not drastically overflow the 30 minutes time limit.
Signed-off-by: Louis Chemineau <louis@chmn.me>
The files.view.index route with dir and scrollto is deprecated and
opening the actual does not work anymore.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
The files.view.index route with dir and scrollto is deprecated and
opening the actual does not work anymore.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Daniel Calviño Sánchez
Joas Schilling
nextcloud-command
Ferdinand Thiessen
Arthur Schiwon
Louis Chemineau
provokateurin
Kate
dependabot[bot]
Hamza
Côme Chilliet
Andy Scherzinger
Maxence Lange
Daniel Kesselberg
Carl Schwan
Joas Schilling
Richard Steinmetz
John Molakvoæ