When "Enforce password protection" is enabled in the sharing settings a
popover menu is shown to set a password before the share is created. On
the other hand, when "Always ask for a password" was enabled in the
sharing settings and a new link share was created the share was
immediately created with a default password; the user was not able to
specify a password (nor create the share without password).
The component template already provided the needed elements to also ask
for the password without enforcing it, but the popover menu was not
shown due to "enableLinkPasswordByDefault" being missing in "if"
conditions.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
"Enforce password protection" is a subcase of "Always ask for a
password", so it should be disabled if its parent option is unchecked.
Although other dependant options in the sharing settings are fully
hidden instead of just disabled this option is disabled but shown to
avoid confusion when updating from a previous Nextcloud version where
"Always ask for a password" was unchecked and "Enforce password
protection" was checked.
Besides that, due to their dependency the enforced password protection
is now automatically unchecked too if its parent option is unchecked.
Finally, the groups excluded from password requirements are also
disabled when "Always ask for a password" is unchecked, as they might be
still shown if "Enforce password protection" was checked due to an
update from a previous version.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
"Enforce password protection" is a subcase of "Always ask for a
password", so it should be indented to visually show the dependency.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The permitted contents of a paragraph are only phrasing contents, so
"div" elements can not be used, although "span" can. Besides being
invalid HTML it seems that the browser ends the paragraph at the div, so
the label/input that appears after it is treated as being in a new
paragraph, which is not indented by default, and thus is not aligned
with the rest of its sibling inputs.
Note that an additional div is nevertheless added once the page is
loaded to be able to select the groups, but this one does not break its
parent paragraph (maybe due to being added after the page load, but I do
not really know). Nevertheless, it needs to be explicitly indented, and
the second indentend wrapper needs to be removed, as it affects only the
label but not the div/input, and therefore the label had an extra
indentation over the input.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The rest of "<br/>" elements in the file appear immediately after their
previous "</label>" rather than in a new line.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The aria-expanded attribute was added on the expandable item rather
Than the button that triggers the expand.
Resolves : #37137
Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
This allows to just UPDATE the card row instead of deleting it and reinsert it. It's very similar to https://github.com/nextcloud/server/pull/30120 for calendars.
As we need the addressbookid exposed, this introduces OCA\DAV\CardDAV\Card that extends Sabre's.
I chose specifically NOT to auto-inject LoggerInterface in Addressbook like in #30120 because the chain of DI is huge just for ONE simple call and it would break an existing dirty call (OCA\Contacts calling OCA\DAV) of ContactsManager in Contacts: https://github.com/nextcloud/contacts/pull/1722 (in SocialApiService), but this is debatable.
Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Côme Chilliet
Joas Schilling
Daniel Calviño Sánchez
Nextcloud bot
Simon L
Christopher Ng
fenn-cs
Varun Patil
Joas Schilling
Ferdinand Thiessen
Jérôme Herbinet
John Molakvoæ
Thomas Citharel
Louis