Commit Graph

19428 Commits (154fe59eb69ecb58076792bbd3f88bb246805c1a)

Author SHA1 Message Date
Julius Härtl e1f644a2ae
Merge pull request #27631 from yan12125/php8-fix-error-reporting 2021-07-13 08:52:18 +07:00
Julius Härtl 3860dad9ea
Merge pull request #26481 from ghost/fdroid 2021-07-13 08:49:59 +07:00
Julius Härtl 0031152de1
Merge pull request #27852 from nextcloud/bugfix/noid/allow-casting-query-functions 2021-07-13 08:48:49 +07:00
Chih-Hsuan Yen 16c4991db6
Correctly skip suppressed errors in PHP 8.0
Applies the suggested transformation mentioned in
https://www.php.net/manual/en/migration80.incompatible.php,

> The @ operator will no longer silence fatal errors (E_ERROR,
> E_CORE_ERROR, E_COMPILE_ERROR, E_USER_ERROR, E_RECOVERABLE_ERROR,
> E_PARSE). Error handlers that expect error_reporting to be 0 when
> @ is used, should be adjusted to use a mask check instead

The new code still works on PHP 7, as error_reporting() already
returns 0 when diagnostics are suppressed.

This fixes https://github.com/nextcloud/server/issues/25807 in PHP 8.0.
For PHP 7.x, https://github.com/nextcloud/server/pull/22243 suppresses
the E_NOTICE message from the second session_start() call with the error
suppression operator @, and thus those E_NOTICE messages are still
logged in PHP 8.0.

See also https://github.com/nextcloud/server/issues/25806

Signed-off-by: Chih-Hsuan Yen <yan12125@gmail.com>
2021-07-13 13:23:03 +07:00
Lukas Reschke 84d9b17dc7
Check for !== false instead
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-07-12 15:06:30 +07:00
Lukas Reschke b0cef8827d Check if dns_get_record returns non-false
`dns_get_record` can return false which results in exceptions such as
the ones shown in https://github.com/nextcloud/server/issues/27870.

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-07-12 13:15:20 +07:00
Nextcloud bot bdb5d9f418
[tx-robot] updated from transifex 2021-07-10 02:31:32 +07:00
Nextcloud bot c2f62ee0b8
[tx-robot] updated from transifex 2021-07-09 02:26:17 +07:00
Nextcloud bot 726f23ffd9
[tx-robot] updated from transifex 2021-07-08 02:26:46 +07:00
Joas Schilling aae16c21e6
Allow casting query functions as well
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-07-07 14:20:24 +07:00
Sanpi 81c272a8a5 Fixes recursion count incrementation
Signed-off-by: Sanpi <sanpi@homecomputing.fr>
2021-07-07 12:00:00 +07:00
J0WI b344ff1a67 Refactor getEncryptionModule routine 2021-07-06 19:20:32 +07:00
kesselb 9f04a7c71e
Merge pull request #27801 from nextcloud/enh/noid/hardening-dns-pin-middleware
Ignore subdomain for soa queries
2021-07-06 18:55:25 +07:00
kesselb 5e7206d23a
Merge pull request #27818 from nextcloud/fix/locking-cache-check
Fix in locking cache check
2021-07-06 18:53:51 +07:00
Nextcloud bot 17e58f5056
[tx-robot] updated from transifex 2021-07-06 02:26:02 +07:00
MichaIng 0304eea58d
Fix in locking cache check
The intention obviously was to check whether $lockingCacheClass is defined, and existing class, and available. It was however checked whether the $distributedCacheClass is an existing class, which would have caused an exception already in the previous distributed cache check.

Signed-off-by: MichaIng <micha@dietpi.com>
2021-07-05 23:11:13 +07:00
Christoph Wurst 26efbe982e
Merge pull request #27794 from nextcloud/fix/clarify-lazy-event-listener-container
Clarify that lazy event listeners are built from the server container
2021-07-05 21:13:53 +07:00
Daniel Kesselberg b6530e5e82
Ignore subdomain for soa queries
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-07-05 20:29:06 +07:00
Pytal 04441d5012
Merge pull request #27767 from nextcloud/enh/20515/maintenance-mode-info
Improve maintenance mode info
2021-07-05 10:44:10 +07:00
Lukas Reschke 8037a4be57
Merge pull request #27799 from nextcloud/bug/26425/check-return-encrypt
Throw exception if encrypting the data failed.
2021-07-05 18:53:32 +07:00
John Molakvoæ b396aee333
Merge pull request #27758 from nullspoon/fix-dns-pinning 2021-07-05 17:37:51 +07:00
Christoph Wurst a6a31bb419
Clarify that lazy event listeners are built from the server container
Ref https://github.com/nextcloud/server/issues/27793

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-07-05 12:11:54 +07:00
Daniel Kesselberg 0a15043f69
Throw exception if encrypting the data failed.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-07-05 10:23:16 +07:00
Daniel Kesselberg c91bb98e5c
Check that pdo is installed
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2021-07-05 09:49:05 +07:00
HouraisanNEET 0ba0189260 Add F-Droid
Signed-off-by: HouraisanNEET <HouraisanNEET@users.noreply.github.com>
2021-07-04 21:44:55 +07:00
Aaron Ball 484913dc31
Fix DnsPinMiddleware resolve pinning bug
Libcurl expects the value of the CURLOPT_RESOLVE configurations to be an
array of strings, those strings containing a comma delimited list of
resolved IPs for each host:port combination.

The original code here does create that array with the host:port:ip
combination, but multiple ips for a single host:port result in
additional array entries, rather than adding them to the end of the
string with a comma. Per the libcurl docs, the `CURLOPT_RESOLVE` array
entries should match the syntax `host:port:address[,address]`.

This creates a function-scoped associative array which uses `host:port`
as the key (which are supposed to be unique and this ensures that), and
the value is an array containing IP strings (ipv4 or ipv6). Once the
associative array is populated, it is then set to the CURLOPT_RESOLVE
array, imploding the ip arrays using a comma delimiter so the array
syntax matches the expected by libcurl.

Note that this reorders the "foreach ip" and "foreach port" loops.
Rather than looping over ips then ports, we now loop over ports then
ips, since ports are part of the unique host:port map, and multiple ips
can exist therein.

Signed-off-by: Aaron Ball <nullspoon@oper.io>
2021-07-02 16:08:44 +07:00
Robin Appelman 9884344230
dont include folder being search in in the results
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-07-02 16:32:25 +07:00
szaimen 37ff07b9e1 Improve maintenance mode info
Signed-off-by: szaimen <szaimen@e.mail.de>
2021-07-02 13:54:33 +07:00
blizzz 7589d5a176
Merge pull request #27533 from Rid/master
Fix scanner mistaking socket files for directories
2021-07-01 17:36:06 +07:00
blizzz 62675eb5c2
Merge pull request #27586 from nextcloud/bugfi/noid/objectstore-checksum
Reset checksum when writing files to object store
2021-07-01 17:30:54 +07:00
Julius Härtl 3853307a6a
Merge pull request #26681 from nextcloud/techdebt/hint-exception-ocp
Move HintException to OCP
2021-07-01 08:34:55 +07:00
Nextcloud bot bb40e65e4e
[tx-robot] updated from transifex 2021-07-01 02:24:48 +07:00
Gary Kim b78f3a57d1
Migrate HintException to OCP
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 +07:00
Arthur Schiwon 12e4484dba
ensure that factoryClass exisits before instantiation
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 15:09:27 +07:00
blizzz f99a895047
Merge pull request #27700 from nextcloud/deprecate-remote
Deprecate OCP\Remote
2021-06-30 11:21:12 +07:00
Arthur Schiwon ad0a11b2bf
cleanup
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 01:03:44 +07:00
Arthur Schiwon 506227b509
adjust internal data handling logic to fix store and load
- format as stored previously in oc_accounts table is kept

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:48:01 +07:00
Arthur Schiwon c7bf4295cc
adjust email verification checker
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:47:36 +07:00
Arthur Schiwon d64411e9df
fix code style
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:45:49 +07:00
Arthur Schiwon 3d6ffd3da2
adjust verification state updater method
- also fixes scope of internal methods

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:42:42 +07:00
Arthur Schiwon af3fdbea7b
make AccountManager actually write multi value properties
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:12 +07:00
Arthur Schiwon 638c04d6e0
accounts event handler to use eventdispatcher, DI and Accounts API
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:11 +07:00
Arthur Schiwon d109d4f581
prov api to be able to edit multivalue properties
- adding as usual
- deleting and scope setting via additional endpoint

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:11 +07:00
Arthur Schiwon 13818005a3
prov api reports additional emails on getUser
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2021-06-30 00:41:10 +07:00
Vincent Petry 8535340d9a
Revert "First attempt to check against core routes before loading all app routes"
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2021-06-29 17:54:30 +07:00
Lukas Reschke a423aae522 Deprecate OCP\Remote
This is unused.

Fixes https://github.com/nextcloud/server/issues/25780

Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
2021-06-28 16:36:32 +07:00
Nextcloud bot ac97873a17
[tx-robot] updated from transifex 2021-06-28 02:25:09 +07:00
Nextcloud bot 67851a0262
[tx-robot] updated from transifex 2021-06-27 02:25:38 +07:00
Nextcloud bot 1cf04c8b6f
[tx-robot] updated from transifex 2021-06-26 02:25:44 +07:00
Julius Härtl 99013d4bc7
Merge pull request #27668 from nextcloud/fix/harden-context-registration-app-missing
Harden bootstrap context registrations when apps are missing
2021-06-25 18:42:46 +07:00