Commit Graph

7472 Commits (1042d1458ca37d28600767aefcbeb302ddee5159)

Author SHA1 Message Date
provokateurin 4f27d82471
fix(RichObjectStrings): Make exception messages for invalid parameters more useful for debugging
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-17 06:46:12 +07:00
Ferdinand Thiessen dfd39f21b7 fix(mime-types): adjust compiled mime types and sign
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-12 12:03:06 +07:00
Ferdinand Thiessen 324582729a
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:54:06 +07:00
Ferdinand Thiessen aa7300b53d
fix(lookup-server): do not query data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:39:33 +07:00
provokateurin b42d26b42f refactor(TempManager): Simplify and unify implementations and remove legacy behavior
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-03 15:25:00 +07:00
Robin Appelman ea678c0280 feat: support migrating an instance to sharding
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-25 21:43:54 +07:00
Andy Scherzinger 55b8a6ba13
Merge pull request #50941 from nextcloud/backport/50053/stable31
[stable31] fix: Change UserAgent to *cloud
2025-02-25 18:37:15 +07:00
Ferdinand Thiessen 06ddb7aff6 refactor: convert sanitize account properties repair step to background job
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:23:20 +07:00
Ferdinand Thiessen 29e5e8a31b fix: Optimize repair step performance
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:23:20 +07:00
Ferdinand Thiessen e9c4c59998 fix: validate account properties as a repair step
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:23:20 +07:00
Johannes Endres 76d4138736 fix: Change UserAgent to *cloud
Co-authored-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Johannes Endres <je@johannes-endres.de>
2025-02-21 09:30:10 +07:00
skjnldsv 63d9a11575 fix: make sure we process mime extensions as string
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-09 21:09:12 +07:00
Ferdinand Thiessen e550ad7bbe
fix(FediverseAction): Ensure valid fediverse links are generated
Harden also for existing values of the profile.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 15:46:15 +07:00
Ferdinand Thiessen ac1a448765
fix(AccountManager): Sanitize social media handles
Ensure to only accept valid X and fediverse handles.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-06 15:46:15 +07:00
Louis Chemineau a56cff70e1 fix: Exclude non accepted shares when computing access list
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-30 09:18:41 +07:00
Andy Scherzinger c99c135520
Merge pull request #50508 from nextcloud/backport/50436/stable31
[stable31] fix: Harden files scanner for invalid null access
2025-01-28 23:52:39 +07:00
Ferdinand Thiessen 26c93519f2 fix: Harden files scanner for invalid null access
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 19:49:03 +07:00
Ferdinand Thiessen 0f298e1db1 fix(sharing): Move permission validation to share manager
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-28 17:26:28 +07:00
Andy Scherzinger bae32be74d
Merge pull request #50468 from nextcloud/backport/50234/stable31
[stable31] fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist
2025-01-27 18:14:06 +07:00
Dario Mehlich 72a43a17f5 fix(preview): Filter for folders in cleanup old preview job
Fixes #35936.
When running `OC\Preview\BackgroundCleanupJob`, the main iteration loop
in `run()` expects a folder, however, `getOldPreviewLocations()`
currently does not filter by mimetype and therefore can yield a
non-folder entry which causes an Exception when constructing the Folder
impl.
Filtering for `httpd/unix-directory`, as `getNewPreviewLocations()`
already does, fixes this issue.

Signed-off-by: Dario Mehlich <d.mehlich@gmail.com>
2025-01-27 15:11:26 +07:00
Joas Schilling 77fddb8f23 fix(ratelimit): Allow to bypass rate-limit from bruteforce allowlist
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-27 13:21:36 +07:00
Marcel Klehr c88c2216ae fix(taskprocessing): Fix tests
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-01-25 13:08:19 +07:00
Louis Chemineau 5b2af8b4c0 fix: Metadata field search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-25 09:44:50 +07:00
Ferdinand Thiessen 99e76d7a99 fix(TemplateLayout): `core` is not an app but the server itself
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-24 18:12:18 +07:00
Ferdinand Thiessen ae3e26024e fix: Correctly return app id and app version for `core` styles and images
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-24 18:12:18 +07:00
provokateurin 9fafcb267c Revert "fix(Share20\Manager): Ensure node is still accessible when checking share"
This reverts commit c2ca99e2f6.

Signed-off-by: provokateurin <kate@provokateurin.de>
2025-01-24 09:47:35 +07:00
Benjamin Gaussorgues b4e3eff078 feat(systemtags): add setting to block non admin to create system tags
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-01-22 20:07:24 +07:00
Josh 79ca27f6a6
test: fix periodic `Test\Group\DatabaseTest::testSearchGroups` failure
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-22 10:53:03 +07:00
Ferdinand Thiessen 27ac8e0f78
Merge pull request #50214 from nextcloud/feat/show-time-diff-user
feat(contacts): Show time difference for users in different timezones
2025-01-20 14:39:00 +07:00
Ferdinand Thiessen 84f0fc88cc
feat(contacts): Show time difference for users in different timezones
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-16 18:10:04 +07:00
Côme Chilliet 626bc7220b
Merge pull request #50171 from nextcloud/enh/limit-ldap-user-count
Limit ldap user count
2025-01-16 17:25:01 +07:00
Christopher Ng 42d997bcd7 test: Update tests
Signed-off-by: Christopher Ng <chrng8@gmail.com>
2025-01-15 15:50:43 +07:00
Côme Chilliet db94aeb96e
chore(tests): Adapt tests to the countUsers refactor
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-14 16:34:15 +07:00
Maxence Lange 28acc002a2 fix(lexicon): syntax
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-01-14 10:38:15 +07:00
Maxence Lange bd4a154d64 feat(lexicon): configurable default value
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-01-14 10:36:07 +07:00
Robin Appelman 7b2cb2e3bc
test: update test for mountpoint numeric storage id
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-13 18:09:29 +07:00
Richard Steinmetz 3dbdf3266c
feat(ocp): add calendar api to retrieve availability of attendees
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-13 10:12:31 +07:00
Joas Schilling dd0f7f0bbf
Merge pull request #49888 from nextcloud/feat/ocp/meetings-api-requirements
feat(ocp): calendar event builder api
2025-01-08 11:48:53 +07:00
Joas Schilling fdfeb99b76
fix(license): Move license closer to file
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-01-08 11:12:37 +07:00
Côme Chilliet f52b4c5eb2 fix: Remove skip of grant page, only skip first step
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-07 10:34:30 +07:00
Côme Chilliet 99e0867f0a chore: Adapt tests to added constructor parameters
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-01-07 10:34:30 +07:00
Richard Steinmetz 80bc1c2d6c
feat(ocp): calendar event builder api
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2025-01-06 10:16:53 +07:00
Robin Appelman 16d0363937
fix: improve checks for moving shares/storages into other mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-01-03 15:36:32 +07:00
Stephan Orbaugh d4715c61f2
Merge pull request #49560 from nextcloud/fix/login-origin
feat(login): add origin check at login
2024-12-20 14:53:11 +07:00
Andy Scherzinger a60f71bd93
Merge pull request #49727 from nextcloud/feat/make-tasks-types-toggleable
Feat: make taskprocessing task types toggleable
2024-12-18 20:08:28 +07:00
Jana Peper 75e64e2942 fix: egt rid of unused variable
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2024-12-18 18:32:34 +07:00
Jana Peper b1d1badcf0 test: add explicitly enabled task type unit test
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2024-12-18 18:32:34 +07:00
Jana Peper 129af480ac test: add disabled task type unit test
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2024-12-18 18:32:34 +07:00
Arthur Schiwon 13fefc4612
feat(Navigation): emit dedicated event for loading additional entries
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2024-12-18 12:50:11 +07:00
Daniel fe90aa3ffe
Merge pull request #49833 from nextcloud/chore/noid/coverage
chore: ignore vendor-bin for coverage
2024-12-17 16:20:14 +07:00
Daniel Kesselberg 5b0e54e858 chore: ignore vendor-bin for coverage
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-12-16 15:47:17 +07:00
Maxence Lange 815991741d fix(lexicon): renaming and minor fixes
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-12-13 11:08:20 +07:00
Maxence Lange 96586ba709 feat(config): implementation of lexicon
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-12-13 11:08:20 +07:00
Côme Chilliet 365ff40929 fix(tests): Adapt ManagerTest to change in Exception class used
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-12 15:39:48 +07:00
Julius Knorr cba556d641
Merge pull request #48612 from nextcloud/fix/activity-log-for-favorites-in-dav
add activity logging for favorites in dav
2024-12-12 15:18:47 +07:00
John Molakvoæ 3baa91d842
Merge pull request #40394 from nextcloud/updater-change-mimetype-objectstore 2024-12-11 08:40:58 +07:00
skjnldsv 0c7e259151 feat(systemtags): allow setting color with occ
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-06 10:19:42 +07:00
skjnldsv adf8a454dd feat(systemtags): add color support backend
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-12-06 10:19:42 +07:00
Robin Appelman 37199779de
fix: fix mimetype not being updated when changing file extention on object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-05 18:05:13 +07:00
Benjamin Gaussorgues 22051a73c1
feat(login): add origin check at login
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-12-05 09:51:53 +07:00
grnd-alt 8d953aeb8d refactor(tags): move favorite event dispatching to tags.php
Signed-off-by: grnd-alt <salimbelakkaf@outlook.de>
2024-12-03 20:56:36 +07:00
Louis Chemineau 425e0c3660
test(View): Copy preserves content
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-03 18:29:32 +07:00
Louis Chemineau 199b0bd4d9
fix(files): Correctly copy the cache information on copy operations
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-12-03 17:04:44 +07:00
Joas Schilling dd101dd0f7
Merge pull request #49515 from nextcloud/bugfix/noid/boolean-false-in-multipart-form-data
fix(controller): Fix false booleans in multipart/form-data
2024-11-28 14:46:16 +07:00
Joas Schilling 1909b981a4
fix(controller): Fix false booleans in multipart/form-data
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-28 12:18:30 +07:00
John Molakvoæ 379f575c25
Merge pull request #49493 from nextcloud/artonge/feat/pwd_confirmation_allow_set_period 2024-11-28 11:58:02 +07:00
Louis Chemineau 512f3caf57
test:(PasswordConfirmationMiddleware): Fix constructor call
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-11-28 11:05:10 +07:00
Christoph Wurst 1323e5bcb1
fix(migration): Decrypt ownCloud secrets v2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-11-28 09:00:33 +07:00
Kate 235b7d7c26
Merge pull request #49073 from nextcloud/feat/files_sharing/co-owner 2024-11-25 14:41:40 +07:00
Louis aa393aa744
Merge pull request #49433 from nextcloud/artonge/feat/maintenance_warn_encrypt_all
feat: Warn about maintenance in EncryptAll command
2024-11-25 12:10:12 +07:00
Louis Chemineau 590b1e8698
feat: Warn about maintenance in EncryptAll command
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-11-25 11:42:29 +07:00
provokateurin c2ca99e2f6
fix(Share20\Manager): Ensure node is still accessible when checking share
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +07:00
provokateurin c378e74017
feat(Share20\Manager): Return all shares on IShareOwnerlessMount
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +07:00
provokateurin a978e0a806
fix(Share20\DefaultShareProvider): Return link shares in getSharesByPath()
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-11-25 10:27:31 +07:00
Louis Chemineau f9cda54cbf
fix: Wrap partial cache entry in CacheEntry
Because it is returned here: 7b7d07c575/lib/private/Files/Cache/Cache.php (L136-L137)

And some implementation got stricter: df95bf6ba8/lib/Mount/RootEntryCache.php (L23-L28)

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-11-21 17:13:24 +07:00
Thomas Lehmann e4c013d86d feat(Mailer): add "null" SMTP transport mode
== Goal

Allow disabling mail delivery altogether.

== Usecase

If mails ought to be send by other means than rendering messages from
templates and sending them via SMTP-like protocols.

Example: listening to specific Nextcloud events and pass parameters to
a centralized (i.e. REST-based) API that sends e-mails.

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
2024-11-19 11:32:39 +07:00
Thomas Lehmann 46d8a7333b feat(Mailer): implement caching
Currently $this->instance is never set, so the code is no-op. This
brings back caching of the instance.

Caching broke with

   be7db1573d

   Swift to \Swift_Mailer as abstraction

Signed-off-by: Thomas Lehmann <t.lehmann@strato.de>
2024-11-19 11:32:39 +07:00
Maxence Lange 5b4f1904c0 feat(user-prefs): renaming to IUserConfig
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
Maxence Lange 6afc8552b7 feat(user-prefs): switching to NCU/
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
Maxence Lange 7c04818c5c feat(user-prefs): iterator instead of array on search
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
Maxence Lange e73513bdd1 fix(user-prefs): adding sensitive and indexed as flags
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
Maxence Lange 65e24f7def feat(user-prefs): IUserPreferences
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-11-18 20:11:31 +07:00
Côme Chilliet 0718984bdf
Merge pull request #48675 from georglauterbach/master
DNS: do not query CNAME if A succeeded already
2024-11-14 11:43:32 +07:00
skjnldsv 158299b3d7 fix(profile): make sure the app cannot be disabled as it was in core
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-14 10:25:10 +07:00
skjnldsv b15fdfd40e chore(profile): move profile app from core to apps
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2024-11-14 10:25:02 +07:00
SebastianKrupinski 7ebeed45bd feat: add iMip Request Handling
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2024-11-07 21:12:37 +07:00
Robin Appelman b21c0265df
test: add some minimal testing for metadata storage
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-11-07 16:27:16 +07:00
Joas Schilling c3c8b7e2a3
fix(richobjectstrings): Add missing placeholder validation
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-11-06 21:31:41 +07:00
georglauterbach 387cd8b771
fix: do not query CNAME if A succeeded already
Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
2024-11-06 20:21:38 +07:00
John Molakvoæ 3c4290631b
Merge pull request #49039 from nextcloud/jtr/fix-ipv6-zone-ids-link-local 2024-11-06 09:17:52 +07:00
John Molakvoæ 8fab143aa4
Merge pull request #48721 from nextcloud/feat/allow-getter-setter-decl-fors 2024-11-06 08:54:40 +07:00
Daniel Calviño Sánchez 5ea5b2de84
fix: Handle exception when clearing previously removed two factor tokens
If a token was already removed from the database but not from the
configuration clearing the tokens will try to remove it again from the
database, which caused a DoesNotExistException to be thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 11:14:05 +07:00
Daniel Calviño Sánchez 381a2aa627
fix: Clear pending two factor tokens also from configuration
Otherwise as the tokens were removed from the database but not from the
configuration the next time that the tokens were cleared the previous
tokens were still got from the configuration, and trying to remove them
again from the database ended in a DoesNotExistException being thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 11:14:04 +07:00
Josh e885e4f13d
fix(tests): Add IpAddressClassifier v6 zone ID test
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-11-04 09:31:48 +07:00
Josh 97421fb143
fix(tests): Add RemoteAddress v6 zone ID test
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-11-04 09:30:21 +07:00
Côme Chilliet 901496276b
Merge pull request #47425 from nextcloud/fix/avoid-invalid-share-on-transfer-ownership
fix: promote re-shares when deleting the parent share
2024-11-04 10:09:58 +07:00
Benjamin Gaussorgues 79db082fe6 fix(users): improve recently active search
- Remove DISTINCT clause to fix PgSQL
- Join user table only if necessary
- Don't show people who never connected in active list
- Add test

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-10-30 07:53:10 +07:00
John Molakvoæ e3e22e28c0
Merge pull request #47847 from nextcloud/fix-copying-or-moving-from-shared-groupfolders 2024-10-29 11:33:12 +07:00
Ferdinand Thiessen c84c256261
fix: Adjust preview for view-only shares
Previously there was a different behavior for public shares (link-shares) and internal shares,
if the user disabled the view permission.
The legacy UI for public shares simply "disabled" the context menu and hided all download actions.
With Nextcloud 31 all share types use the consistent permissions attributes,
which simplifies code, but caused a regression: Images can no longer been viewed.

Because on 30 and before the attribute was not set, previews for view-only files
were still allowed. Now with 31 we need a new way to allow "viewing" shares.

So this is allowing previews for those files, but only for internal usage.
This is done by settin a special header, which only works with custom requests,
and not by opening the URL directly.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-28 15:52:27 +07:00
Kate d25a0a2896
Merge pull request #48915 from nextcloud/fix/encrypt-decrypt-password 2024-10-28 13:26:55 +07:00