614f9ec0a2
refactor: Use the elvis operator
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-09-15 21:01:34 +07:00
07a6fd11d0
fix(files_external): Check key exists before accessing it
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2024-09-14 11:21:17 +07:00
0f519f4856
fix(files_external): broken credentials dialog
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2024-09-13 14:32:07 +07:00
2480567005
Merge pull request #47526 from nextcloud/jtr/fix-ftp-custom-port-ui
...
fix(files_external): Handling in FTP UI for custom ports
2024-09-12 09:34:47 +07:00
56c744d263
Merge pull request #47527 from nextcloud/fix-sftp-custom-port-ui
...
fix(files_external): Handling in SFTP UI for custom ports
2024-09-12 09:34:32 +07:00
bd4de5208d
fix: Fix unmodified placeholder replacing the actual value when updating
...
When updating global storages and user storages a property is not
updated by "StoragesService::updateStorage()" if the value matches the
unmodified placeholder. However, userglobal storages are not updated
through the "StoragesService"; as only the authentication mechanism is
updated it is directly done with "saveBackendOptions()" in
"IUserProvided" or "UserGlobalAuth". Due to this the unmodified
placeholder value needs to be explicitly checked in those cases and
replaced by the actual value (note that in this case it is not possible
to just skip updating a specific property).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-09-04 09:46:17 +07:00
2e73932c8e
fix: custom port handling in UI for SFTP
...
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-08-27 09:01:12 +07:00
6db4099246
fix: custom port handling in UI for FTP External Storage
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-08-27 08:49:24 +07:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2024-08-25 19:34:58 +07:00
d35c4eb911
Merge branch 'master' into jr-readdir-false-false
...
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
2024-08-16 10:53:50 +07:00
c102b89cd5
refactor(files_external): Replace security annotations with respective attributes
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-08-14 09:44:57 +07:00
c2b1f079b1
feat: add a specialized writeStream implementation for s3 external storage
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-07-24 17:37:20 +07:00
369c552e41
Merge pull request #46073 from nextcloud/fix/save_global_credentials
2024-06-25 09:48:24 +07:00
e93866f904
fix: allows admin to edit global credentials
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-06-24 15:20:44 +07:00
733e3f62fd
fix: Do not log an error when connecting to SFTP without a logged in user
...
When connecting to a SFTP server from a SFTP storage the host key is
checked against the known host keys stored in a file in the data
directory of the logged in Nextcloud user. The path to the file is
(indirectly) got using "OC_App::getStorage", which logs an error if
called when there is no logged in user; this can happen, for example, if
the storage is used from a background job or a command.
Not being able to read or write the file just causes the host key check
to be skipped, but it has no other consequence. Moreover, even with
logged in users it is likely that the file can not be read either and
the check is also skipped, as the file needs to have been manually
created by an admin.
Due to all that now the path to the file is directly created using a
View rather than relying on "OC_App::getStorage" to prevent the unneeded
error from being logged.
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-06-18 07:06:30 +07:00
c1555fc33e
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-06-06 18:05:37 +07:00
4d060818d1
fix(files_external): Be extra safe with null handling to please psalm
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-30 09:24:00 +07:00
3ad4bbb096
Merge pull request #44658 from nextcloud/fix/migrate-away-from-resource-type
...
fix: Remove obsolete resource typing
2024-04-16 17:13:07 +07:00
4910e7e231
fix: Pass the mountpoint target user to storages without owner
...
Storages that do not have a dedicated owner (e.g. groupfolders, external
storages) currently always assume the current session user as the owner.
This leads to several issues when there is no user session but a node is
obtained through a user folder.
In order to have the correct user available we need to pass the user
that is used to setup a mountpoint along to the storage layer as we
generally assume that an owner is available for those.
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-04-09 09:04:24 +07:00
72a0da6d4e
fix: Fix small psalm errors in FTP and LDAP connections
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-09 10:01:47 +07:00
0f348516d2
fix: Remove obsolete resource typing
...
In PHP>=8.1, LDAP and FTP resources are always typed objects
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-09 10:01:47 +07:00
81319e78bf
chore: Improve phpdoc typing to silence psalm errors
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-02 14:16:21 +07:00
e330efe5a0
fix: Implement option to temporarily set the user session
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-19 13:48:23 +07:00
42e14cc4c7
feat: add command to scan external storages directly
...
the main use case of this over simply scanning through is the ability to provide a username and/or password for cases where login credentials are used
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-06 19:11:08 +07:00
d576b8eaf9
fix: Allow to disable multipart copy on external s3 storage
...
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-02-24 17:11:07 +07:00
2f41b9c092
mark MOUNT_TYPE_PERSONAl as deprecated
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-24 11:33:44 +07:00
1a5b545fe8
full uppercase const
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2024-02-24 11:33:44 +07:00
524ed97d62
fix: replace `Account name` by `Login`
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:08:10 +07:00
839ddaa354
feat: rename users to account or person
...
Replace translated text in most locations
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +07:00
35d0c63abc
Merge pull request #43349 from nextcloud/fix/case-sensitive-root-smb
...
SMB: allow to list root directory when using case-insensitive option
2024-02-12 11:14:07 +07:00
2e00184eb4
fix(files_external) Add sensitive S3 values redacted by list command
...
Signed-off-by: Josh <josh.t.richards@gmail.com>
2024-02-07 10:05:46 +07:00
2cb0bf5437
fix(files_external): list root when using SMB case-insensitive option
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2024-02-05 11:24:12 +07:00
b2e9e0fa0d
chore: Replace OC::$server->getL10N by OCP\Util::getL10N in lib and some apps
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-05 11:16:04 +07:00
8bcc2d352e
chore: Fix missing template parameter for IEventListener
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-01-30 10:57:15 +07:00
b64ab5fba8
refactor: Migrate IgnoreOpenAPI attributes to OpenAPI
...
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-01-18 16:14:17 +07:00
9064171b27
Correct a typo
...
Signed-off-by: Valdnet <47037905+Valdnet@users.noreply.github.com>
2023-11-28 15:48:58 +07:00
64f5faf8b5
fix(files_external): Fix "Could not find resource main.js to load"
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-27 12:35:41 +07:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +07:00
755de1e0b5
refactor: Rename OpenAPI type aliases to their namespaces
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-11-02 11:37:15 +07:00
c52d5e418a
Merge pull request #41053 from nextcloud/bug/smb/in-place-case-rename
...
fix(files_external): on case insensitive system, block case change
2023-10-31 16:07:29 +07:00
4759e7a22d
fix(external): Get storage before update it
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-26 06:46:05 +07:00
e66e8bad1a
Return correct status if touch failed
...
Signed-off-by: Louis Chemineau <louis@chmn.me>
2023-10-23 15:26:43 +07:00
a45e12abc8
fix(files_external): on case insensitive system, block case change
...
When a file/directory is renamed to the same name with only case change,
the rename fail. We block this kind of rename.
The user will have to rename to another name first.
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-10-23 10:32:28 +07:00
ae29608e46
fix(files_external): basic auth user storage trigger
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2023-10-10 12:07:48 +07:00
45cac16432
Merge pull request #39131 from fsamapoor/refactor_lib_files_external_commands
...
Refactors files_external app commands
2023-09-28 14:39:49 +07:00
d64bbc8bd3
Convert isset ternary to null coalescing operator
...
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
2023-09-28 12:18:41 +07:00
eab7818f0e
Adds parameter type hints.
...
Co-authored-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-09-28 09:02:10 +07:00
32838d8f0a
Refactors files_external app commands.
...
To improve code readability.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com>
2023-09-28 09:02:10 +07:00
c2d45cb172
Add single status code descriptions for OpenAPI
...
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-09-27 08:05:21 +07:00
Christoph Wurst
Git'Fellow
John Molakvoæ (skjnldsv)
Josh
Daniel Calviño Sánchez
Daniel Kesselberg
John Molakvoæ
provokateurin
Robin Appelman
Benjamin Gaussorgues
Andy Scherzinger
Côme Chilliet
Côme Chilliet
Julius Härtl
Maxence Lange
Vincent Petry
Arthur Schiwon
Valdnet
Joas Schilling
jld3103
Louis Chemineau
Louis
Hamid Dehnavi
Faraz Samapoor
Faraz Samapoor