095ab4419e
fix(l10n): Improve english source strings
...
- No leading/trailing whitespace
- Use asci single quote
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-26 09:54:32 +07:00
abf294c383
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-26 00:21:46 +07:00
48d69c727a
fix(lint): correct comment identation
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2025-02-25 22:35:50 +07:00
388301275b
Merge pull request #50764 from p1gp1g/patch-1
...
Update doc comment for prefixTableName
2025-02-25 22:16:04 +07:00
0a77ba99a2
feat: support migrating an instance to sharding
...
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-25 17:52:40 +07:00
0427d5d207
Merge pull request #50874 from nextcloud/artonge/fix/login_flow_v2_sessions
...
fix: Initialize lastConnectionCheck after first connection
2025-02-25 08:34:35 +07:00
5d4be44748
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-24 20:39:08 +07:00
e3af27b280
refactor: convert sanitize account properties repair step to background job
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:16:28 +07:00
575222b5af
fix: Optimize repair step performance
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:16:28 +07:00
08d33a9f57
fix: validate account properties as a repair step
...
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-24 15:16:27 +07:00
c1204c0670
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-24 00:21:56 +07:00
6b2c5b8aa6
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-23 00:22:00 +07:00
698b654a18
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-22 00:21:54 +07:00
33a12eb3af
Merge pull request #50053 from nextcloud/fix/noid/thudnerbird-addon-useragent
...
fix: Change UserAgent to *cloud
2025-02-21 10:27:57 +07:00
a70071541e
feat(SystemTag): Make MapperEvent webhook compatible
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
2025-02-20 12:46:52 +07:00
3b45ba2630
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-20 00:22:09 +07:00
ae2cc23658
fix: Change UserAgent to *cloud
...
Co-authored-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Johannes Endres <je@johannes-endres.de>
2025-02-19 18:51:08 +07:00
066c92f7b0
fix: Initialize lastConnectionCheck after first connection
...
We are checking whether the DB connection is alive once every 30 seconds. But when we are lacking the last check time, we are skipping the check and reconnect logic. This is causing the reconnect logic to never fire in those cases.
It seems to me that "those cases", are actually always the case, as upon initialization, we are not using the proper connection name to store the time.
In the `connect()` logic, when `$this->_conn` is null, `$this->getConnectionName()` is returning `replica`, so `$this->lastConnectionCheck` will be equal to `['replica' => time()];`
60711ea4cf/lib/private/DB/Connection.php (L215-L221)60711ea4cf/lib/private/DB/Connection.php (L891-L893)2b6d7bf65f/doctrine/dbal/src/Connections/PrimaryReadReplicaConnection.php (L136-L139)60711ea4cf/lib/private/DB/Connection.php (L874-L880)https://github.com/nextcloud/server/pull/41819
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-19 12:25:12 +07:00
73d94353d1
fix(cron): Keep job class limitation when searching for the next job
...
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-19 08:44:33 +07:00
0d49af4f27
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-19 00:21:45 +07:00
a80d7ce11d
Merge pull request #50864 from nextcloud/fix/fix-psalm-taint-errors-2
...
fix: Fix psalm taint false-positives by small refactorings
2025-02-18 13:59:30 +07:00
2e50a39265
fix(files): properly forward open params from short urls
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-02-18 10:53:23 +07:00
8886f367e4
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-18 00:21:58 +07:00
e757b649b7
fix: Fix psalm taint false-positives by small refactorings
...
Mostly make it clear that we trust admin input or that we correctly
escape strings.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 18:08:23 +07:00
c1c59f9a6c
chore: Add missing star in phpdoc comment
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:23 +07:00
640dbd0b5e
fix: Fix false-positive psalm taint errors when outputting plain text
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:23 +07:00
7c907223d2
fix: Fix psalm taint false-positive by escaping trusted input
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:22 +07:00
fa108d5b54
fix: Correctly tag json encoding in BaseResponse to fix false-positive
...
…in psalm taint analysis
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:22 +07:00
aac79bad9b
fix: Move config.php taint trust upstream directly in OC\Config class
...
This solves some false-positive psalm taint errors
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:26:20 +07:00
85fbd3eb0a
fix: Work around psalm taint false-positive by not using var_export
...
var_export is listed as a taint sink because it may output stuff
depending on the parameters. It was not the case here, but we can
simply json_encode the result by passing it as context to the logger
method rather than using var_export.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:24:08 +07:00
fec865cc29
chore: Correctly flag json encoding methods as escaping html and quotes
...
Especially with JSON_HEX_TAG it’s perfectly fine to echo JSON, and we
only use it in JSON output anyway.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:24:07 +07:00
579a337750
fix: Fix psalm taint error in L10N factory
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-17 15:24:07 +07:00
5b507561d3
Merge pull request #50791 from nextcloud/perf/remove-filecache-index
...
chore(filecache): remove index fs_id_storage_size
2025-02-17 11:31:12 +07:00
b9f8539c63
Merge pull request #50809 from nextcloud/fixPhp83Deprecation
...
fix(repair): PHP8.3 deprecation warning
2025-02-15 12:06:28 +07:00
ba3868a403
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-15 00:21:54 +07:00
885175772b
fix(repair): PHP8.3 deprecation warning
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
2025-02-14 11:55:19 +07:00
20cedce95f
Fix(l10n): Update translations from Transifex
...
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2025-02-14 00:22:05 +07:00
8c69bf1219
Merge pull request #48738 from nextcloud/perf/log-high-memory-requests
...
perf: Log requests using high amount of memory as warning
2025-02-13 19:50:32 +07:00
b003af2364
Merge pull request #50794 from nextcloud/fix/fix-appmanager-cleanappid
...
fix: Only keep allowed characters in appid, and flag the method as escaping
2025-02-13 17:23:44 +07:00
6e7c97ea1f
fix: Also remove digits at the start and underscore on both ends of appid
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
2025-02-13 16:22:21 +07:00
c71bc0696f
Merge pull request #50781 from nextcloud/perf/improve-incomplete-scan
...
perf(files): faster query to fetch incomplete directories
2025-02-13 15:21:25 +07:00
8f57a50767
fix: Only keep allowed characters in appid, and flag the method as escaping
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 14:21:36 +07:00
d31bc88a23
perf: Log requests using high amount of memory as warning
...
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-02-13 13:43:10 +07:00
3548bde384
chore(filecache): remove index fs_id_storage_size
...
Index is outdated by PR 50781
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-02-13 11:37:10 +07:00
f758f565d4
fix: Replace getInstalledApps calls with getEnabledApps
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:20 +07:00
a3685551f7
fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUser
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:19 +07:00
cffd2c8d09
chore: Improve naming of methods and properties in AppManager
...
Remove all references to installed apps where it’s about enabled apps
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:19 +07:00
fb917c495b
fix(ocp): Deprecate getInstalledApps and replace with clearer method name
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:19 +07:00
d2864f7d84
fix(ocp): Deprecate isInstalled and add isEnabledForAnyone instead
...
The method name was really confusing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2025-02-13 10:19:18 +07:00
9bdee76535
perf(files): faster query to fetch incomplete directories
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2025-02-13 10:11:02 +07:00
Joas Schilling
Nextcloud bot
Andy Scherzinger
Robin Appelman
Julius Knorr
Ferdinand Thiessen
Stephan Orbaugh
Marcel Klehr
Johannes Endres
Louis Chemineau
Joas Schilling
skjnldsv
Côme Chilliet
Kate
Git'Fellow
Côme Chilliet
Benjamin Gaussorgues