Commit Graph

7132 Commits (0710cfb800981b76727ba656943a58a0f49e4414)

Author SHA1 Message Date
Julius Knorr dc82454c41
Merge pull request #51710 from nextcloud/backport/51707/stable29
[stable29] fix: filter out contacts with empty email addresses in sharee completion
2025-03-28 16:22:12 +07:00
Julius Knorr a9d2ac3472 fix: Do not build encrypted password if there is none
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-28 15:16:34 +07:00
Julius Knorr fc7ac7b136
test: Adapt tests to properly use valid email addresses
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-28 14:55:10 +07:00
Hamza Mahjoubi 408c4bf680 fix(cardav): only show useres from enabled addressBooks in contacts menu
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2025-03-21 14:57:56 +07:00
Ferdinand Thiessen 888726111b
test: fix CI when running Karma tests
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-19 18:02:17 +07:00
Ferdinand Thiessen b8c34bbbb3 fix(mime-types): adjust compiled mime types and sign
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-13 21:30:14 +07:00
Ferdinand Thiessen 92c48d0394
fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:58:09 +07:00
Ferdinand Thiessen e674631f9b
fix(lookup-server): do not query data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-11 21:56:45 +07:00
skjnldsv 48a643f8c1 fix: update babel and fix karma
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-06 16:32:44 +07:00
Stephan Orbaugh d8040d7d7f
Merge pull request #51201 from nextcloud/backport/51194/stable29
[stable29] refactor(TempManager): Simplify and unify implementations and remove legacy behavior
2025-03-04 10:20:18 +07:00
skjnldsv 1672a357bd fix: make sure we process mime extensions as string
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
2025-03-04 09:29:12 +07:00
provokateurin 7e8ffd332b
refactor(TempManager): Simplify and unify implementations and remove legacy behavior
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-04 07:50:44 +07:00
Ferdinand Thiessen 8830bdbb1a refactor: convert sanitize account properties repair step to background job
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 12:59:09 +07:00
Ferdinand Thiessen fb714dfd40 fix: Optimize repair step performance
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 12:59:09 +07:00
Ferdinand Thiessen 62d122adfa fix: validate account properties as a repair step
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step,
`ValidateAccountProperties` which validates and sanitizes all account
properties.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-27 12:59:09 +07:00
Johannes Endres a49366910b fix: Change UserAgent to *cloud
Co-authored-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Johannes Endres <je@johannes-endres.de>
2025-02-21 09:28:41 +07:00
Josh 635dbdc785 fix(Mailer): Fix sendmail binary fallback
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-02-17 19:21:42 +07:00
Louis Chemineau 85417b56bf test(View): Copy preserves content
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-13 23:37:04 +07:00
Louis Chemineau ef4281ebe3 fix(files): Correctly copy the cache information on copy operations
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.

Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-13 23:37:04 +07:00
Louis Chemineau 25ec8053eb
test:(PasswordConfirmationMiddleware): Fix constructor call
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-02-11 11:56:30 +07:00
Ferdinand Thiessen c4cc3f2888
fix(FediverseAction): Ensure valid fediverse links are generated
Harden also for existing values of the profile.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-09 13:46:27 +07:00
Ferdinand Thiessen 4a7c8834d0
fix(AccountManager): Sanitize social media handles
Ensure to only accept valid X and fediverse handles.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-02-09 13:46:26 +07:00
Robin Appelman 5b4ceb0eaa fix: improve checks for moving shares/storages into other mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 09:39:28 +07:00
Ferdinand Thiessen a0d7d107f5
fix(sharing): Move permission validation to share manager
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-31 18:46:07 +07:00
Louis Chemineau 9626ff81bd
fix: Exclude non accepted shares when computing access list
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-30 11:07:28 +07:00
Ferdinand Thiessen 3f8244a841 fix(files): Do not array access null value
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-29 10:28:01 +07:00
Ferdinand Thiessen 092f1b7f34
fix: Correctly return app id and app version for `core` styles and images
fix(TemplateLayout): `core` is not an app but the server itself

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-29 10:14:51 +07:00
Louis Chemineau 840ee6d59a
fix: Metadata field search
Signed-off-by: Louis Chemineau <louis@chmn.me>
2025-01-27 13:03:49 +07:00
Josh 7516b094c0 test: fix periodic `Test\Group\DatabaseTest::testSearchGroups` failure
Signed-off-by: Josh <josh.t.richards@gmail.com>
2025-01-22 17:45:17 +07:00
Côme Chilliet 56a5350806
chore: Remove syntax incompatible with PHP 8.0
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 15:50:23 +07:00
Côme Chilliet 97800c555d fix: Use getRelativePath method to check if node is inside folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:16:48 +07:00
Côme Chilliet e1a23cf0a7 fix: Fix promotion of reshares from subsubfolders
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:16:48 +07:00
Côme Chilliet 0ee5c781f7 fix(tests): Fix share tests to test new reshare promotion system
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:16:48 +07:00
Côme Chilliet 786424ef09 fix: Tidy up code for reshare deletion
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-19 14:16:48 +07:00
Luka Trovic dfbaa103f9 fix: delete re-shares when deleting the parent share
Note: Removed part about fix command from original PR

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
(cherry picked from commit 42181c2f49)
2024-12-19 14:16:47 +07:00
Côme Chilliet a5017fc0d3 fix(tests): Adapt ManagerTest to change in Exception class used
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-12 20:15:35 +07:00
Robin Appelman f8ad3d6cc9 fix: fix mimetype not being updated when changing file extention on object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-11 09:00:37 +07:00
Christoph Wurst e6738874a7
fix(migration): Decrypt ownCloud secrets v2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-11-28 09:44:56 +07:00
georglauterbach 487d19a0b3 fix: do not query CNAME if A succeeded already
Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
2024-11-14 10:46:13 +07:00
Richard Steinmetz 4b563e0c71
Merge pull request #49097 from nextcloud/backport/48933/stable29
[stable29] Clear pending two factor tokens also from configuration
2024-11-13 11:04:35 +07:00
yemkareems 051af1a8b9
fix: conflicts resolved in apps.php loadDirectory
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-11-13 08:34:39 +07:00
Josh Richards ce3cec9681
fix: Clean-up some remaining readdir calls with undesirable false evaluation potential
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

[skip ci]
2024-11-13 08:34:23 +07:00
Daniel Calviño Sánchez 4d9cc7dd8d fix: Handle exception when clearing previously removed two factor tokens
If a token was already removed from the database but not from the
configuration clearing the tokens will try to remove it again from the
database, which caused a DoesNotExistException to be thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 10:49:31 +07:00
Daniel Calviño Sánchez 44ed719027 fix: Clear pending two factor tokens also from configuration
Otherwise as the tokens were removed from the database but not from the
configuration the next time that the tokens were cleared the previous
tokens were still got from the configuration, and trying to remove them
again from the database ended in a DoesNotExistException being thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 10:49:31 +07:00
Louis 8b42f46c3d
Merge pull request #48998 from nextcloud/backport/47986/stable29
[stable29] perf(ObjectStoreStorage): Improve (slow) move on same object bucket
2024-10-31 15:55:32 +07:00
Côme Chilliet 74438f7f96
fix(tests): Fix most obvious errors in ObjectStore tests
Some are still failing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-31 14:40:37 +07:00
Benjamin Gaussorgues 31aa1fe4f5
Merge pull request #48488 from nextcloud/backport/48235/stable29 2024-10-30 09:59:56 +07:00
Christoph Fiehe 68b9972889 perf(ObjectStoreStorage): Improve (slow) move on same object bucket
This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
2024-10-30 08:28:52 +07:00
Robin Appelman a61d2ab4c4 test: add test for nested jail cross-storage move
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-29 10:41:24 +07:00
yemkareems de14601944
fix: crypto added manually as expected
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 18:47:05 +07:00