Commit Graph

118 Commits (0710cfb800981b76727ba656943a58a0f49e4414)

Author SHA1 Message Date
Joas Schilling c63c27d8d5
fix(l10n): Improve english source strings
- No leading/trailing whitespace
- Use asci single quote

Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-02-26 15:27:20 +07:00
Côme Chilliet ebafd49bc3 fix(tests): Fix sharebymail tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-08 15:34:22 +07:00
Côme Chilliet 7f7e2a6524 fix(sharebymail): Fix share update when node id changed
This fixes transfering an email share from a user to another one when using
 objectstore as primary storage.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-08 15:34:22 +07:00
Adam Serbinski f45eb75e3d ShareByMailProvider: getAccessList: set correct value for 'public'
PDOStatement::rowCount behavior is undefined for SELECT statements
for some database types, therefore manually set the value for 'public'
based on actual results fetched.

Signed-off-by: Adam Serbinski <adam@serbinski.com>
2024-03-21 18:25:31 +07:00
Adam Serbinski 01e32340af ShareByMailProvider: getAccessList: set both array keys 'public' and 'mail'
To preserve prior behaviour where 'public' was set 'true' if there
are any mail recipients. The 'mail' key will be an array of email
recipients.

Signed-off-by: Adam Serbinski <adam@serbinski.com>
2024-03-21 18:25:31 +07:00
Adam Serbinski 34ca6bd46a ShareByMailProvider: getAccessList: recommended style changes
Signed-off-by: Adam Serbinski <adam@serbinski.com>
2024-03-21 18:25:31 +07:00
Adam Serbinski 9c528d412c ShareByMailProvider: getAccessList: add token to returned array
This allows the share URI to be regenerated.

Signed-off-by: Adam Serbinski <adam@serbinski.com>
2024-03-21 18:25:31 +07:00
Adam Serbinski 26ae5e6dfb ShareByMailProvider: getAccessList: return full list of recipients
Previously was returning only boolean true if the Node was shared
by email, or false if not. Now provides an array containing the
list of email share recipients.

Signed-off-by: Adam Serbinski <adam@serbinski.com>
2024-03-21 18:25:31 +07:00
Robin Appelman bfeb97c54a fix: also filter by storage when getting shares in folder
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-03-06 15:33:05 +07:00
John Molakvoæ 4a509dfe8e
fix: phpunit
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
2024-02-13 21:06:31 +07:00
Vincent Petry 839ddaa354
feat: rename users to account or person
Replace translated text in most locations

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2024-02-13 21:06:30 +07:00
Benjamin Gaussorgues 303dadfaa9
sharebymail: remove ILogger and upgrade to PHP 8 syntax
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-08-30 18:36:29 +07:00
Côme Chilliet 9ba9f9a7dc
Make sure to not pass null to DateTime::createFromFormat
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-14 16:23:50 +07:00
Louis Chemineau f525067930 Add argument to getSharesInFolder enable deep share lookup
Signed-off-by: Louis Chemineau <louis@chmn.me>
2022-07-26 12:17:46 +07:00
Richard Steinmetz c1f054a9e0
Fix email shares not being shown to other users
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2022-06-17 17:31:26 +07:00
Cyrille Bollu 50badb3fb6 Various improvements related to the recent implementation of temporary passwords
for mail shares:

1- Changes style of "forgot password?" and "Back" button
2- Adds information about share password's expiration time in the emails sent.
3- Shows password expiration time in the Share menu
4- Fixes an issue when the message "Password expires..." would be shown for non email share types (which don't have temporary passswords)
5- At share's creation, password should only be sent when it's a permanent one

See also https://github.com/nextcloud/server/issues/31952

Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
2022-06-08 11:29:19 +07:00
Vincent Petry 82f1344d33
Adjust settings for mail link password
Rename the settings and invert the meaning.
Increase default interval to one hour.
Changed the interval to be a number of seconds, to align with other
setting styles.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-14 14:13:47 +07:00
Vincent Petry 2c2b238008
Default to permanent link passwords
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-04-13 16:11:15 +07:00
Cyrille Bollu c6a5c07041 Adds a "Request password" button to the public share authentication page for shares
of type TYPE_EMAIL, when the "video verification" checkbox isn't checked. Users accessing
non-anonymous public shares (TYPE_EMAIL shares) can now request a temporary password themselves.

- Creates a migration step for the files_sharing app to add the 'password_expiration_time'
  attribute to the oc_shares table.
- Makes share temporary passwords' expiration time configurable via a system value.
- Adds a system config value to allow permanent share passwords

-Fixes a typo in a comment in apps/files_sharing/src/components/SharingEntryLink.vue

See https://github.com/nextcloud/server/issues/31005

Signed-off-by: Cyrille Bollu <cyrpub@bollu.be>
2022-04-11 21:58:24 +07:00
Carl Schwan fffc19f5c3
Fix types warnings from psalm
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-12 20:33:46 +07:00
Carl Schwan 7ecb65f725
Add check before sending email that email address is valid
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-01-11 20:59:44 +07:00
Julius Härtl 5116bf146f
Allow to pass note when creating a share and send it with directly in the share mail when set
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2021-12-03 10:17:02 +07:00
J0WI 3b656446af Introduce ISecureRandom::CHAR_ALPHANUMERIC
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
2021-07-08 15:11:31 +07:00
Gary Kim b78f3a57d1
Migrate HintException to OCP
Signed-off-by: Gary Kim <gary@garykim.dev>
2021-06-30 15:28:02 +07:00
John Molakvoæ (skjnldsv) 215aef3cbd
Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +07:00
Valdnet 998bcad80c
l10n: Unify spelling
Spelling unification in Nextcloud applications.

Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
2021-05-20 09:22:58 +07:00
Christoph Wurst 99f2fa73d1
Fix usage of rename executeUpdate
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-05-05 10:35:25 +07:00
robottod 0451927994
Remove some deprecated calls from ShareByMailProvider.php
This moves the execute calls to the executeQuery and executeUpdate calls
Resulting in less calls to deprecated functions

Signed-off-by: rtod <robottod@protonmail.com>
2021-04-26 21:53:56 +07:00
John Molakvoæ 6b4cfc5805
Merge pull request #26231 from nextcloud/Valdnet-patch-6
l10n: Add words user and because in ShareByMailProvider.php
2021-03-22 09:42:01 +07:00
Valdnet 1dab60a79d
l10n: Add changes to text string for user 2021-03-22 09:01:45 +07:00
John Molakvoæ (skjnldsv) a100186e5e
Sharing link & mail parity
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:50:45 +07:00
John Molakvoæ (skjnldsv) 100d5d9a47
Add labels to mail shares
Now the email is shown on a second line if a label is set.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-03-22 06:34:09 +07:00
Valdnet 4b4b1f6ff1
l10n: Add word user in ShareByMailProvider.php
Standardizing text strings with other Nextcloud applications.
2021-03-20 15:37:32 +07:00
Roeland Jago Douma 69b26c73f3 Fix some redundant casts
Happier psalm

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-08 08:51:08 +07:00
Roeland Jago Douma d247a5fb47 Sharebymail: set expiration on creation
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-04 13:49:21 +07:00
Nicolas SIMIDE 4ac636d252 ReplyTo option for sharebymail Issue #24139
Signed-off-by: Nicolas SIMIDE <2083596+dems54@users.noreply.github.com>
2021-01-28 15:57:29 +07:00
Christoph Wurst 2a054e6c04
Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +07:00
Daniel Kesselberg 4dd507675c
Generate password by password_policy app
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-08-11 21:58:51 +07:00
Joas Schilling 89ed2c37bf
Update share type constant usage
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-24 16:49:16 +07:00
Daniel Calviño Sánchez e59e283cc2 Fix creating a mail share with a password
When a mail share was created with a password the given password was not
hashed, so it was not possible to open the share with that password.
Moreover, if passwords were enforced the given password was ignored and
a new one was set (although in this case it was hashed so it worked as
expected). Now the given password is properly hashed and not overriden.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2020-05-28 21:51:22 +07:00
Christoph Wurst caff1023ea
Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +07:00
Christoph Wurst 1a9330cd69
Update the license headers for Nextcloud 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-31 14:52:54 +07:00
Christoph Wurst b80ebc9674
Use the short array syntax, everywhere
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +07:00
Robin Appelman 606f685457
properly set 'hide_download' as integer
the database field is a smallint, not a boolean.

fixes postgresql tests

Signed-off-by: Robin Appelman <robin@icewind.nl>
2020-03-13 17:38:56 +07:00
Roeland Jago Douma 84a148aac1
Properly respect hide download on sharebymail
fixes #19484

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-03-13 09:20:32 +07:00
Christoph Wurst 6127c288e8 Fix license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-01-13 14:23:49 +07:00
exner104 5c517baf98
additional fix to #18730 #18733
regarding to advice from @kesselb
2020-01-08 10:40:52 +07:00
exner104 44eba5cdc6
Wrong email sender fix #18730
Wrong email sender in app sharebymail when sending password to owner fix #18730
2020-01-08 09:47:55 +07:00
Christoph Wurst 5bf3d1bb38
Update license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +07:00
Roeland Jago Douma 68748d4f85
Some php-cs fixes
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +07:00